From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.31]) by mx.groups.io with SMTP id smtpd.web12.1839.1601513959055008725 for ; Wed, 30 Sep 2020 17:59:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=mywfphxZ; spf=pass (domain: outlook.com, ip: 40.92.41.31, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EoExBCiPbJcY6szcUazLgv+4mI/Svq/PtUiKKHmrTbyRDho5cpOLbCddxDoZweKw1E9R/EgQdBA9lEOJZ3sQVY4LVKm3PNx3S+YcAIr3oR+i6seNM9K874b3Ow6c9bcGzzTqpMe3BYRxWpwyHtfQtgY2SR5tR99zwU+LbCqgpZzthanX3JSsZZ8vQw3wTNmckmZ5Fnthefc1B2lxxMAz8eBViGwmEH2rBMYESpAvVmAzWuFr88H4ZZFU3CBYV/1fLZ2z2k2j7bEC6owxTtfigNwuQEMXgULHZsIFH+gjuhNnrU3GZTKR6Aqbmd3V+vuAc5SiSzxTankCAcFbMv6DCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Rg60/r0AOoL9StsaPO09JzwTkv/nZaH8Wyp+khOm5o=; b=GMFzzHRzFPGRT++LrF6HfjnroMOIE2xdX/ePLydjPoWj3OnsAi4KXxbi8KSXbeTTYTXc9PCIauGMgP1N0jcF0/qkmZkZTwkYSF/uel++OplYaJelxjUZRHuQ0ckE5z9WSNGNJijAOkVMRVTx/LDB2e+QNy/Ld46T1HtP4Zk5Fdc1mITf6yoTz/IU5VoOoq5JSXZHKU60MBRAaNTDunvi0Voxunwob2EC0PMzgaxsUSYE7vHgrYE7pH3tK7c7Ne5Lw8bG7kIcOios9sMGJkySbdzAX/pcFVZhw78hwXm8R/VVKoi8d+9fce5yxCpJNXqF6Xh48/vHhwkfSOjZMjP5ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Rg60/r0AOoL9StsaPO09JzwTkv/nZaH8Wyp+khOm5o=; b=mywfphxZ0cN1ZaouZYSsFtPdStpI+lGTM/xO2Q2uUp1JKWGwNrbrzP4kP5vpo61dBTkmHG7aKfz/JY9nQthmu/sp+3tLguQQQ1dG2I9C2zVi+oSr91YBIGNV7EtcwVLW4D8zwM3p6ZOBff/QuFBzI9MczVl3eAmzFcPHNMPGi0yHolmZ/ldj5UzxC8eQyV/7x6DiKtkHubAbDrencEj2+Z/o6mBNQgzmc4DdVKj1MDDwV41JL6bLwvXcCOpZlG924rYwmPJvZxT+a2oNCWsD2scy1loCOchlnn9zHPUxOjvDZv41+pVD5VRcF9+Ipzz25fXTmmF5FjE5y/6ew3D+Og== Received: from MW2NAM10FT008.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::4f) by MW2NAM10HT136.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::369) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21; Thu, 1 Oct 2020 00:59:17 +0000 Received: from BN8PR07MB6962.namprd07.prod.outlook.com (2a01:111:e400:7e87::4f) by MW2NAM10FT008.mail.protection.outlook.com (2a01:111:e400:7e87::158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34 via Frontend Transport; Thu, 1 Oct 2020 00:59:17 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8978E949115CB852559E3E59ACAA7480145AC1EFA67B0C2765EA304548612EDB;UpperCasedChecksum:4A0D184D6D82629E1FF249D98118C6B48850470B5E92B243FB2B9929583C4725;SizeAsReceived:8853;Count:48 Received: from BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3]) by BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3%6]) with mapi id 15.20.3433.035; Thu, 1 Oct 2020 00:59:17 +0000 Subject: Re: [edk2-devel] Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET) To: devel@edk2.groups.io, rebecca@nuviainc.com Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael D Kinney References: <0b04d303-655f-7f4e-88b6-d63268fe234f@nuviainc.com> From: "Sean" Message-ID: Date: Wed, 30 Sep 2020 17:59:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 In-Reply-To: <0b04d303-655f-7f4e-88b6-d63268fe234f@nuviainc.com> X-TMN: [g9xZqR4QtEVYe4IcfCKdj09K5HmeeH2X] X-ClientProxiedBy: MWHPR21CA0054.namprd21.prod.outlook.com (2603:10b6:300:db::16) To BN8PR07MB6962.namprd07.prod.outlook.com (2603:10b6:408:d6::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <7bda9779-6226-0f32-0b5f-ba3d8d939367@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR21CA0054.namprd21.prod.outlook.com (2603:10b6:300:db::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.8 via Frontend Transport; Thu, 1 Oct 2020 00:59:15 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b7b08011-2dd0-426c-f17e-08d865a53871 X-MS-TrafficTypeDiagnostic: MW2NAM10HT136: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LzUCImjQFw0bugmY4nHetpGAVxLZq2n/vlExvWBVDFmak+qVSNg4BrlwzshOZR0zNCypSQ5QP2lTVwdGgR+HHr5kLiOI/X9BpXSMlDxFl3FOoYE35kO71daWJhvwwtoATmvv+k3lBX5vBYEPiEyMexQ/4UkHw8tuVmW6JNbJHKIMhT4GkYyT7m8BuKwEZsJg9Yj3QoFUjdAiKQ6RWMxdWnBYd6o+jggvvih/u3AoDMu60sngGeNa966Zlr3EXHze X-MS-Exchange-AntiSpam-MessageData: X2Kwbh4cwZSPsNqwVftqQJb2G22gXSdUlR25vgB1exMGfB2gxjj9yrNeqPAxdKhfvH3FAPiPFj4rENtPxTZy2gkjCiz4ID/VxABWQT2LWWvvFmbvq4SUR/ID4p39mSrwwd9ZfbRU9Vmz7/JwSC2XYg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7b08011-2dd0-426c-f17e-08d865a53871 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2020 00:59:17.5027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT008.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT136 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Not sure i follow your first question but running without a "-t" specified at the command line and "-t NO-TARGET" is two different things. For edk2 ci you can see the CISettings.py file defines targets supported as a tuple of all 4 ("DEBUG", "RELEASE", "NO-TARGET", "NOOPT"). https://github.com/tianocore/edk2/blob/master/.pytool/CISettings.py#L72 and you can see that if the cli parameter for target is empty then the value is assigned to whatever is declared as supported. https://github.com/tianocore/edk2-pytool-extensions/blob/master/edk2toolext/invocables/edk2_multipkg_aware_invocable.py#L121 By creating a specific target "NO-TARGET" we could easily enable/disable their execution and thus we could control it in the matrix on the CI servers. Example here: https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L32 Most of the static code tests run for NO-TARGET. ECC is such a test so it only runs when NO-TARGET is run. Finally please be aware EccCheck runs git commands and can change your local workspace. This was something i recently learned and should probably be revisited as it means running it locally can be destructive to changes you don't yet have committed. Hope that helps. Thanks Sean On 9/30/2020 2:59 PM, Rebecca Cran wrote: > Is it expected that the EDK2 CI run without errors in NO-TARGET mode - > that is, when "-t" isn't specified? > > When I run it locally with "stuart_ci_build -c .pytool/CISettings.py > TOOL_CHAIN_TAG=GCC5 -a X64,AARCH64" I get lots of errors: one in > ArmVirtPkg/PrePi/PrePi.c about a missing comment above a function, and > then loads in DynamicTablesPkg - e.g.: > > PROGRESS - --Running ArmVirtPkg: EccCheck Test NO-TARGET -- > > ERROR - > ERROR - EFI coding style error > ERROR - *Error code: 8003 > ERROR - *The #ifndef at the start of an include file should use both > prefix and postfix underscore characters, '_' > ERROR - *file: .../edk2/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > ERROR - *Line number: 41 > ERROR - *The #ifndef name [AML_HANDLE] does not follow the rules > ERROR - > > > When I specify "-t DEBUG,RELEASE,NOOPT" it completes successfully. > >