From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.92.20.63]) by mx.groups.io with SMTP id smtpd.web11.1340.1602027947391251582 for ; Tue, 06 Oct 2020 16:45:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=uiWH7fyV; spf=pass (domain: outlook.com, ip: 40.92.20.63, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkUJYJDJ5Coq7VP4S/A3rHZAflKbeKcc6lg7NfQXL3SZUvp1LmNhom10SwspJdCplZcHWQfhhNMhHWo217w0ywMufpNLeaS84bai791onSC8m2FVWA2YNZZZmDMKueixRvgIzFA8pOI3V8NTxmX/5/9NAA1bMxMBADjEIDXgOVFBR58WRlTgeOjxSTkzbR9JJYLdxfDmtTttAdosaCVO/jKRSEJm/CpH5avdM5pd1WAigi3UgODeoVJGvzGG7fnj8+TWlPG1HrjpEI3lFxswH4rYIimGHw2dLKSVPThttx6T1+3cG43gTvnaqsTB2R6Npys51svOahBYGepc0NJCoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yetv2kgKo8RxGbDFLWYMS/4hDdUq3ZGL0Q48wV0yARs=; b=NI9frzetpciCeGflM+JoF2bZNuWe6xNc6Artwi6SzhNCnk03hfjeA3k0hSebfub8IDO14JVb2CmK99VU2wTNVEV95SKXyoWphfjqenJmYcAanuhz+RkGGVQsIBznBN0SCvrod3wCiefa9aWD9tQcJbLnEvBim9oHzhGKMgOqIWcNJYCjD6GLHTrAHiXPmsXhpKoLsT76v5EvABqZw17g/yIwx67iiQOJ6UOSdOCHjR7O1AKLGy+EJ2dawrRn6ajJ8QVXrOHV6veAg/qBRVht9mysIX9ovoMAqBOrsyJyGvq1q99Uk4vm0au4QsmYCKj8SDi6MCL9kFcNS0YeflSICA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yetv2kgKo8RxGbDFLWYMS/4hDdUq3ZGL0Q48wV0yARs=; b=uiWH7fyVFarLN8UC7Ol+O+aCv+MWdDIpmnVGqYJjSKH3O2Udfa9a8AjkCym2H9fl6UWOV2BArNkFVvfNMj4jukNvLxrhupPZ9Do1paR/QRGGFn5DjtK+lJZLjxRikw3Czx1AcXvl1HvGDvHVbbCHX7RwcwVUd7uOU+6Yl6om1iDIvkuQoo2j3CKDX43tHYTxpUXs8TgroRvuvpz8Bry1pllJDSBUZyRNh+yLCOwxzufqNAZ0qq9ix6Tj8I9iClO3tp4BKPi4bObZg+J28h+GP26fAP0jpveLKOK3vFQgQr7Do4EeehVLqaUftB/dej47nH1zvtU9RDWrEgWSHUqiYQ== Received: from BN8NAM11FT053.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::46) by BN8NAM11HT124.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35; Tue, 6 Oct 2020 23:45:46 +0000 Received: from BN8PR07MB6962.namprd07.prod.outlook.com (2a01:111:e400:fc4b::43) by BN8NAM11FT053.mail.protection.outlook.com (2a01:111:e400:fc4b::465) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35 via Frontend Transport; Tue, 6 Oct 2020 23:45:46 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:6D699B5EB7475AD0F887698905DFD401536270ED664C75132A4F47282D209A02;UpperCasedChecksum:77E1BF49BA93AC284D94A4C6079AA58B404C9B14D4BC0D488D33B72E0F0BD924;SizeAsReceived:9225;Count:48 Received: from BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3]) by BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3%5]) with mapi id 15.20.3455.022; Tue, 6 Oct 2020 23:45:46 +0000 Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , "Wang, Nickle (HPS SW)" References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-4-abner.chang@hpe.com> From: "Sean" Message-ID: Date: Tue, 6 Oct 2020 16:45:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 In-Reply-To: X-TMN: [iV5VUAPS7uOv7B1WvIq3rKXT3VH66ws9] X-ClientProxiedBy: CO2PR04CA0104.namprd04.prod.outlook.com (2603:10b6:104:6::30) To BN8PR07MB6962.namprd07.prod.outlook.com (2603:10b6:408:d6::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <893698c4-e8b0-e3e4-3ee2-1f9317a5f5a7@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by CO2PR04CA0104.namprd04.prod.outlook.com (2603:10b6:104:6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Tue, 6 Oct 2020 23:45:45 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 353b0f9d-3574-4c4a-37d5-08d86a51f1f8 X-MS-TrafficTypeDiagnostic: BN8NAM11HT124: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6wrt/WR+lI07Odfp1HmNji/mVjJij3RG80C6PUc0R9q4R5va7Hqp0zSYFfXsHjTBHsDB0ZujYziMx+Grd7WlDaamZY9jfj+zQ3d3IS9PLVu4PpTt65ZcDzX4O1lcF90TNz0Fd+8a7ajZ1jyxJdblhnDvSYhY0RfSQaW+/11xiIQOgg4iCZady0AsozyMmq/TcAd0zUVlSfRteb4rrateds0DFDfaXS1jLcI0kB7+tZGfX7E5nZRLkq4Eb4/jzp4p X-MS-Exchange-AntiSpam-MessageData: zheIYE9ePbYo4htHqeJ+2ZPIm0K+pJ8ALFtJiqC4VO+ulK+Mz8L4r+eLW1TdGRNCofP9B6jOfwNYt4z15Gv21sMEq0jDw57dRTNDabA8hBXHqdAExMit7TX0pGG+X4myEpMlBgrEHIsobxjSpveRRg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 353b0f9d-3574-4c4a-37d5-08d86a51f1f8 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2020 23:45:45.9875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT124 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable I am just suggesting that for CI you should put redfishpkg into an=20 existing matrix item rather than create a new matrix item. Each one of=20 those is a build that spins up when CI/PR is invoked. instead of this (your patch) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml=20 b/.azurepipelines/templates/pr-gate-build-job.yml index 2683687a1c..b5b09c2cca 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -45,6 +45,9 @@ jobs: TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_REDFISH: + Build.Pkgs: 'RedfishPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' TARGET_PLATFORMS: # For Platforms only check code. Leave it to Platform CI # to build them. I would just do something like below. (i hand edited the diff so might=20 not be perfect but hopefully you get the idea). @@ -45,6 +45,9 @@ jobs: - TARGET_SECURITY: + TARGET_SECURITY_REDFISH: - Build.Pkgs: 'SecurityPkg' + Build.Pkgs: 'SecurityPkg,RedfishPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' Thanks Sean On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote: >=20 >=20 >> -----Original Message----- >> From: Sean Brogan [mailto:spbrogan@outlook.com] >> Sent: Wednesday, October 7, 2020 7:05 AM >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) >> >> Cc: Sean Brogan ; Bret Barkelew >> ; Michael D Kinney >> ; Liming Gao ; >> Wang, Nickle (HPS SW) >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 >> 3/4] .azurepipelines/templates: Add RedfishPkg to target build >> >> On this change i would recommend that you add RedFishPkg to another in >> the list as i don't think the time it takes to compile and test this rel= atively >> small package makes it worth spinning up another machine, syncing source= s, >> installing tools, etc. >=20 > Sean, do you mean to add RedFishPkg to another package? Or move drivers (= currently is none) under RedFishPkg to another package? > This is the initial commit of RedFishPkg, more drivers will added to this= package later on. > https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md >=20 > That doesn't make sense to put RedFishPkg to any of another to save CI ti= me, but what we can do now is remove RedFishPkg from CI test for the time b= eing. Says don=E2=80=99t add RedfishPkg to GetPackageSupported for now. >=20 >=20 >> >> Looking at the current matrix it looks like the SecurityPkg only takes 8 >> minutes and CRYPTO only takes ~9 minutes. I also see FMP and FAT is fas= ter >> than the slowest entry. We generally try to load balance this so that C= I >> completes quickly. >> >> vs2019 >> INVALID URI REMOVED >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId- >> 3D12811-26view- >> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ul >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd- >> D4sw4IjDO8v_OJ74lDlU0M&s=3D3XIQ_TF_f0Ck_fkywiGXKd- >> 2a23G5fMyOkEFrZgBz5M&e=3D >> >> gcc >> INVALID URI REMOVED >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId- >> 3D12810-26view- >> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ul >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd- >> D4sw4IjDO8v_OJ74lDlU0M&s=3D4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6 >> XbXB9yt4&e=3D >> >> >> Thanks >> Sean >> >> >> >> On 10/6/2020 3:48 AM, Abner Chang wrote: >>> Signed-off-by: Abner Chang >>> Cc: Sean Brogan >>> Cc: Bret Barkelew >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Nickle Wang >>> Reviewed-by: Bret Barkelew >>> --- >>> .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml >>> b/.azurepipelines/templates/pr-gate-build-job.yml >>> index 2683687a1c..b5b09c2cca 100644 >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml >>> @@ -45,6 +45,9 @@ jobs: >>> TARGET_SECURITY: >>> Build.Pkgs: 'SecurityPkg' >>> Build.Targets: 'DEBUG,RELEASE,NO-TARGET' >>> + TARGET_REDFISH: >>> + Build.Pkgs: 'RedfishPkg' >>> + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' >>> TARGET_PLATFORMS: >>> # For Platforms only check code. Leave it to Platform CI >>> # to build them. >>>