From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [Patch] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE
Date: Thu, 24 Sep 2020 20:52:44 -0700 [thread overview]
Message-ID: <BN8PR07MB696236B93F0B294C2F6238ADC8360@BN8PR07MB6962.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20200925004849.15248-1-michael.d.kinney@intel.com>
I think you should add NOOPT target as well. NOOPT catches more
compiler issues than debug/release given the change in optimization
flags and it is used less by developers.
Once you run a build you should also add the badge to the readme.rst
(https://github.com/tianocore/edk2/blob/master/ReadMe.rst) so that
status is visible.
and finally the readme should be updated to include details on this
configuration.
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/ReadMe.md#supported-configuration-details
Thanks
Sean
On 9/24/2020 5:48 PM, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2979
>
> Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE
> for IA32/X64 and DEBUG/RELEASE. Label this these as
> FULL builds, so if additional build options are added
> in the future, they can be added to these FULL builds.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> .../.azurepipelines/Ubuntu-GCC5.yml | 29 +++++++++++++++++++
> .../.azurepipelines/Windows-VS2019.yml | 29 +++++++++++++++++++
> 2 files changed, 58 insertions(+)
>
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 12ef8226ff..b5f1d933f4 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -6,6 +6,7 @@
> # Toolchain: GCC5
> #
> # Copyright (c) Microsoft Corporation.
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> trigger:
> @@ -65,6 +66,34 @@ jobs:
> Build.Target: "NOOPT"
> Run.Flags: $(run_flags)
> Run: $(should_run)
> + EmulatorPkg_X64_FULL_DEBUG:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "X64"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "DEBUG"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_X64_FULL_RELEASE:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "X64"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "RELEASE"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_IA32_FULL_DEBUG:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "IA32"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "DEBUG"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_IA32_FULL_RELEASE:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "IA32"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "RELEASE"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
>
> workspace:
> clean: all
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index a5baf4b606..5d52d532aa 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -6,6 +6,7 @@
> # Toolchain: VS2019
> #
> # Copyright (c) Microsoft Corporation.
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> trigger:
> @@ -66,6 +67,34 @@ jobs:
> Build.Target: "NOOPT"
> Run.Flags: $(run_flags)
> Run: $(should_run)
> + EmulatorPkg_X64_FULL_DEBUG:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "X64"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "DEBUG"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_X64_FULL_RELEASE:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "X64"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "RELEASE"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_IA32_FULL_DEBUG:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "IA32"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "DEBUG"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
> + EmulatorPkg_IA32_FULL_RELEASE:
> + Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> + Build.Arch: "IA32"
> + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> + Build.Target: "RELEASE"
> + Run.Flags: $(run_flags)
> + Run: $(should_run)
>
> workspace:
> clean: all
>
prev parent reply other threads:[~2020-09-25 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 0:48 [Patch] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE Michael D Kinney
2020-09-25 3:52 ` Sean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR07MB696236B93F0B294C2F6238ADC8360@BN8PR07MB6962.namprd07.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox