From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.92.18.21]) by mx.groups.io with SMTP id smtpd.web10.6936.1601005969378566911 for ; Thu, 24 Sep 2020 20:52:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Sk7jKkzK; spf=pass (domain: outlook.com, ip: 40.92.18.21, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hmh/oNjH8Du7RSkjLJ574XK1KaklNq5J+CeXYqt3bgrGc+tNg1doSWKZOGJvDhhKzJFQX3SolMPjZfxWubWcFIjSygjtSHpWza0gyYgjtO9Cr/ZZqb6Nf6YY6py7zx/ekTRN1ckSxy7z5CpBE7tF81YLxvQY05uZc1vdNKU+KB+rFNH7niwghKL+vo6y/hy52I4BdXru7LKNPM0L3Uvghq7lIPERZ7qdHZ5tnhj5TxBoSk7U91TmmSUcGeiFHYmUHYHRm9OL6kWjqU1euDhtjw2BVZJQrTdY2RLc/5vmjG6ejApNj9ez12bxz+xJfK0MVFOEp7aWhYYTFx6/58xJQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIELw9MPfEhAV0tA1APV9IQyoAU3DR8ZvzoJ1tYWEJ8=; b=GNezw3LRmGOvCNjBUSaaQKCD5DBBWcY9sYOLIafZUhgl22ZJzIVAw3vDVfazTcD5QPg9we+KKoJi+Nt4qpH+WJ8pKxt/B9TkifYb8zyi3Wyk3ypZYGsS25OwWeUOeMLeUHuntNmpcXXp/bqJqeu0ODzm8Otvz0fcwDJVKFDhLoY8foViOFMAM7i5aaBccpPBTVWQkQHgS5scMu9orDi+pKp2jK594r11Y41sfRzCe9nspdhPBIwfoycTmA1Di/FI929XLyOHy+mfBzG3sEl8Vyy+mqI1dFyYOKlsQcV6K34xVAL89fAMDCmflj+xD1WqoF1ijUG3mJNOEAX8vpsh6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIELw9MPfEhAV0tA1APV9IQyoAU3DR8ZvzoJ1tYWEJ8=; b=Sk7jKkzK2wlUhSA9LnHJAfCCzw8As3mQEMjB18QdHOW2ROniGll9Rs1ZXQVFUnrlwEY2YVlrgfTRlqTjCGWC7gpuclH9f5pRFMWVPTIOLHiVXf18E37rLO02ssQvNFoHqmQuUYTh2FzM116Fw+4iJyx3MEXqRKVapr4CoGaepruMXOZotC2VaJRxgiD0upWjUnIZf6uuHNjxHXur2a3dS260Gtf8uVxSMIRjQezZoezcgPVm6k9PPv/TTkGltE/b/hbwKOa74kab7Wdp1bcglShdXelj3fNbOWyvk1yB933zsglL41CVIOwAKvWu6NljhNnUZfbwKb7Jg+4nxs5o9A== Received: from CO1NAM11FT049.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::4b) by CO1NAM11HT063.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21; Fri, 25 Sep 2020 03:52:48 +0000 Received: from BN8PR07MB6962.namprd07.prod.outlook.com (2a01:111:e400:3861::42) by CO1NAM11FT049.mail.protection.outlook.com (2a01:111:e400:3861::306) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Fri, 25 Sep 2020 03:52:48 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:D9305804C8EC3776E60AF09DB83210DB4F61BA00DDDC4BDFD81FCC7063D4E798;UpperCasedChecksum:B65EAB6924BF0DA4F1156DB24AABCB8CA43EAB009829B665CDDFDC108C430B38;SizeAsReceived:8860;Count:48 Received: from BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3]) by BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3%6]) with mapi id 15.20.3412.022; Fri, 25 Sep 2020 03:52:48 +0000 Subject: Re: [edk2-devel] [Patch] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Jordan Justen , Andrew Fish , Ray Ni , Divneil Rai Wadhawan , Sean Brogan References: <20200925004849.15248-1-michael.d.kinney@intel.com> From: "Sean" Message-ID: Date: Thu, 24 Sep 2020 20:52:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 In-Reply-To: <20200925004849.15248-1-michael.d.kinney@intel.com> X-TMN: [gIqlAYmFZZOwKK7gkN1opvUAQSRPPgq/] X-ClientProxiedBy: MWHPR22CA0061.namprd22.prod.outlook.com (2603:10b6:300:12a::23) To BN8PR07MB6962.namprd07.prod.outlook.com (2603:10b6:408:d6::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <188a83c6-909c-f026-24a5-9b4529fe1ccc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR22CA0061.namprd22.prod.outlook.com (2603:10b6:300:12a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Fri, 25 Sep 2020 03:52:46 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2935131e-0ae3-498b-696c-08d861067731 X-MS-TrafficTypeDiagnostic: CO1NAM11HT063: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLVZBOApPm06C8VBzGgzYsWslGSSLnD6k2N9Z40Ju8kmM6hR4qPeYk0LWK+5OsepOSuanI+PBZWnnCSjLB/mXYU63+BFsDfcqcovV87G6p8VNNJJOvVsVltAo8EH9wmNS0s6l9L+BP9O4ZvtOCoY1OpDXfuyAs+6leGE1Ooxph265VluhRWGYJHP8bhbLuLMwNG3ALXLmO2KfOjrEGFdU99U2mz21dGfYgm7YcFkfeChPcXJvyW5NA/6WxK5qcDN X-MS-Exchange-AntiSpam-MessageData: ToGxw4hHkcvbTVYDEHEcoNmN7EEqnHPunq7ckqsfEVxBfe6NLhFtll1munKQCpYOfV6Y/4ZlqkEuOus3n8KlwjMYdA4SdVMlcTSyINMEq6c7ycCJ0ZoC10ukesQsoREJVOYdsct0eYJNBRYqF5f7lw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2935131e-0ae3-498b-696c-08d861067731 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2020 03:52:48.1023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT063 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I think you should add NOOPT target as well. NOOPT catches more compiler issues than debug/release given the change in optimization flags and it is used less by developers. Once you run a build you should also add the badge to the readme.rst (https://github.com/tianocore/edk2/blob/master/ReadMe.rst) so that status is visible. and finally the readme should be updated to include details on this configuration. https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/ReadMe.md#supported-configuration-details Thanks Sean On 9/24/2020 5:48 PM, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2979 > > Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE > for IA32/X64 and DEBUG/RELEASE. Label this these as > FULL builds, so if additional build options are added > in the future, they can be added to these FULL builds. > > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Cc: Divneil Rai Wadhawan > Cc: Sean Brogan > Signed-off-by: Michael D Kinney > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 29 +++++++++++++++++++ > .../.azurepipelines/Windows-VS2019.yml | 29 +++++++++++++++++++ > 2 files changed, 58 insertions(+) > > diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > index 12ef8226ff..b5f1d933f4 100644 > --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > @@ -6,6 +6,7 @@ > # Toolchain: GCC5 > # > # Copyright (c) Microsoft Corporation. > +# Copyright (c) 2020, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > trigger: > @@ -65,6 +66,34 @@ jobs: > Build.Target: "NOOPT" > Run.Flags: $(run_flags) > Run: $(should_run) > + EmulatorPkg_X64_FULL_DEBUG: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "X64" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "DEBUG" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_X64_FULL_RELEASE: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "X64" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "RELEASE" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_IA32_FULL_DEBUG: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "IA32" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "DEBUG" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_IA32_FULL_RELEASE: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "IA32" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "RELEASE" > + Run.Flags: $(run_flags) > + Run: $(should_run) > > workspace: > clean: all > diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml > index a5baf4b606..5d52d532aa 100644 > --- a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml > +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml > @@ -6,6 +6,7 @@ > # Toolchain: VS2019 > # > # Copyright (c) Microsoft Corporation. > +# Copyright (c) 2020, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > trigger: > @@ -66,6 +67,34 @@ jobs: > Build.Target: "NOOPT" > Run.Flags: $(run_flags) > Run: $(should_run) > + EmulatorPkg_X64_FULL_DEBUG: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "X64" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "DEBUG" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_X64_FULL_RELEASE: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "X64" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "RELEASE" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_IA32_FULL_DEBUG: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "IA32" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "DEBUG" > + Run.Flags: $(run_flags) > + Run: $(should_run) > + EmulatorPkg_IA32_FULL_RELEASE: > + Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + Build.Arch: "IA32" > + Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE" > + Build.Target: "RELEASE" > + Run.Flags: $(run_flags) > + Run: $(should_run) > > workspace: > clean: all >