public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, bob.c.feng@intel.com
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [Patch] BaseTools: Fix PcdValueInit tool build issue with VS compiler x64
Date: Fri, 16 Oct 2020 15:17:23 -0700	[thread overview]
Message-ID: <BN8PR07MB69623D1444A3821133C56453C8030@BN8PR07MB6962.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20201015112037.26556-1-bob.c.feng@intel.com>

Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

On 10/15/2020 4:20 AM, Bob Feng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3001
> 
> When the 64-bit version of VS compiler is used, the generated
> PcdValueInit tool will be failed to compile.
> 
> This patch is going to fix that issue.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> 
> ---
>   BaseTools/Source/C/Common/PcdValueCommon.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h b/BaseTools/Source/C/Common/PcdValueCommon.h
> index cfd3bb76e1..1652bd5430 100644
> --- a/BaseTools/Source/C/Common/PcdValueCommon.h
> +++ b/BaseTools/Source/C/Common/PcdValueCommon.h
> @@ -12,11 +12,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>   #include <Common/UefiBaseTypes.h>
>   #include <Common/UefiInternalFormRepresentation.h>
>   
>   #define __FIELD_SIZE(TYPE, Field) (sizeof((TYPE *)0)->Field)
>   #define __ARRAY_ELEMENT_SIZE(TYPE, Field) (sizeof((TYPE *)0)->Field[0])
> -#define __OFFSET_OF(TYPE, Field) ((UINT32) &(((TYPE *)0)->Field))
> +#define __OFFSET_OF(TYPE, Field) ((UINT32)(size_t) &(((TYPE *)0)->Field))
>   #define __FLEXIBLE_SIZE(Size, TYPE, Field, MaxIndex)   if (__FIELD_SIZE(TYPE, Field) == 0) Size = MAX((__OFFSET_OF(TYPE, Field) + __ARRAY_ELEMENT_SIZE(TYPE, Field) * (MaxIndex)), Size)
>   #define __ARRAY_SIZE(Array) (sizeof(Array)/sizeof(Array[0]))
>   
>   #if defined(_MSC_EXTENSIONS)
>   #define __STATIC_ASSERT static_assert
> 

  reply	other threads:[~2020-10-16 22:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 11:20 [Patch] BaseTools: Fix PcdValueInit tool build issue with VS compiler x64 Bob Feng
2020-10-16 22:17 ` Sean [this message]
2020-10-19  1:03   ` 回复: [edk2-devel] " gaoliming
2020-10-19  1:56     ` Bob Feng
2020-10-22  1:04       ` 回复: " gaoliming
2020-10-26  3:21         ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR07MB69623D1444A3821133C56453C8030@BN8PR07MB6962.namprd07.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox