public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, lersek@redhat.com, michael.kubacki@outlook.com
Cc: Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Ray Ni <ray.ni@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v3 0/7] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg
Date: Tue, 28 Apr 2020 09:35:33 -0700	[thread overview]
Message-ID: <BN8PR07MB69624C408EA1E803C13E7FCCC8AC0@BN8PR07MB6962.namprd07.prod.outlook.com> (raw)
In-Reply-To: <d4cd9fdd-681d-0a33-6dd4-35266339c17c@redhat.com>

I think this was my fault.

I was under the impression that a patch needed one of developers listed 
in the (m) or (r) section of maintainers.txt to provide a reviewed-by. 
My new understanding is an ack from the (m) plus anyone providing a 
reviewed-by is enough.

Thanks
Sean



On 4/28/2020 5:59 AM, Laszlo Ersek wrote:
> On 04/24/20 23:31, michael.kubacki@outlook.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Attention: Reviewed-by is still needed from some package maintainers.
>> * 0002-ArmVirtPkg-Add-Platform-CI-and-configuration-for-Cor.patch
>>    * Laszlo Ersek <lersek@redhat.com>
>>    * Ard Biesheuvel <ard.biesheuvel@arm.com>
>>    * Leif Lindholm <leif@nuviainc.com>
> 
> I don't understand. Your posting
> 
> [edk2-devel] [PATCH v3 2/7] ArmVirtPkg: Add Platform CI and
> configuration for Core CI
> 
> already -- and, to my understanding, correctly -- includes
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> That means both Ard and myself are OK with the patch. What else is
> needed from us?
> 
>> * 0004-OvmfPkg-Add-Platform-CI-and-configuration-for-Core-C.patch
>>    * Jordan Justen <jordan.l.justen@intel.com>
>>    * Laszlo Ersek <lersek@redhat.com>
>>    * Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Same here:
> 
> [edk2-devel] [PATCH v3 4/7] OvmfPkg: Add Platform CI and configuration
> for Core CI
> 
> I think these patches are ready to be merged.
> 
> 
> Who's going to merge the series?
> 
> Thanks!
> Laszlo
> 
> 
> 
> 

  reply	other threads:[~2020-04-28 16:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 21:31 [PATCH v3 0/7] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg Michael Kubacki
2020-04-28 12:59 ` Laszlo Ersek
2020-04-28 16:35   ` Sean [this message]
2020-04-29 18:03     ` [edk2-devel] " Laszlo Ersek
2020-04-30  1:18       ` Liming Gao
2020-04-30 11:24         ` Laszlo Ersek
2020-04-30 13:40           ` Leif Lindholm
2020-04-28 19:18   ` Michael Kubacki
2020-04-28 22:18 ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR07MB69624C408EA1E803C13E7FCCC8AC0@BN8PR07MB6962.namprd07.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox