From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.102]) by mx.groups.io with SMTP id smtpd.web10.5248.1591772087101603399 for ; Tue, 09 Jun 2020 23:54:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=s3afGMKb; spf=pass (domain: outlook.com, ip: 40.92.21.102, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I988QEgPA4Vso2PgCSg6p5HoxpoiZqc2qTANCQRfYI49WzsRCDKr05HL/xgfOKDGCJJzcrhgIf3bYQvUBQABmdFuHVUCkBxhncK+piDD+9K01egYgl2g5pZH7EXIdX8SedIicfcHJt5zWFdr/Hgy9NifSJfYYwpFhuu4l35WNKt2azMWb9DLjTihMWtpK7pcmI4cGpCILY1WhxMVqJ2psudfxSIjy8b0Yc4ydhtLpqE/Tz5tSbT4CmfkPXrPLPsx1SfmSOlABy6yZ+lVgHf6PU+EON18xnfdQIhGWjST4J21Ud/09SDgIeCOddu9qMPcMAoX8ZzdJoY19amCOxHJkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8POzGmtFFVoJjTjTrdzidCL55ik4w4nnWJhLxvzPves=; b=Q4ZY8ttiWqzFSNYNG7sxW35ILg8T6WreveCqVOGnmsHGpM2N1WOKsFIAYcaS4s/fRfhzmAxdIZDchXtSDT5s6E1tdm6ejxs9nCMVER/yICct3mexRUKSNDl1ZBQdWS/WUlMv7OFDqeB5CujdZ0WaY8EQepvJvXgIX5o+FkwIMVoOk+zvi8zoCH/pxjG99po3Z4jdeiIZc2O2u3qkNRSfZlKDJvzcz9nabG12NS9YUOfO9PXceuEeMxW/ZQai9n/ddBUZCPQMWUw0UoXLuJvBKH3LB3JHoQsMbbAjwXgzLBO0ZHB2yCDcKJAQvuTtlYV3MsymWok0AGANJEJ9CJ4wPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8POzGmtFFVoJjTjTrdzidCL55ik4w4nnWJhLxvzPves=; b=s3afGMKb85eRFvaeaDK+iLKq0nbad3ZFoUslgDkDy/UyjuxPiHpuPK+f+qlPNy1D3FsECuL23JTGbmMeg/NDmv9JPut1rFFALnOFm1azY+ip0ndOf0jx1HtjBqzaq9d8FV62IjlpDXSPoeSy0bI15B51zS1rdzSVZcoYX31sGho1A5K7LEPyJfmJgke17oldYe1uMjjqFdhdfoIUwmIU9cYclJJbz+mmYko2FERS2eIy/JzJNa3B/zGUeq9bXLqvZGO2AlUMq3+ZVDr6ZnopNyg8IxdwnnZMyqjIqEGI/2CCAUPVS9Kriteolo6y8N3uT2y6hh8M8nxz3Q+/I0F+ug== Received: from BN8NAM12FT035.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::4b) by BN8NAM12HT236.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.9; Wed, 10 Jun 2020 06:54:46 +0000 Received: from BN8PR07MB6962.namprd07.prod.outlook.com (2a01:111:e400:fc66::43) by BN8NAM12FT035.mail.protection.outlook.com (2a01:111:e400:fc66::203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.9 via Frontend Transport; Wed, 10 Jun 2020 06:54:45 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8A8253004E1335EF36B3BD1618C9C1DBB674CBBB4DBC00DD134070CBC716483F;UpperCasedChecksum:8AD749B7B0184D0872D5AD37D9E2C6511B89418E6C9BF40C8CB31B151D42A1B9;SizeAsReceived:8845;Count:49 Received: from BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::edbc:7122:7dd9:1403]) by BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::edbc:7122:7dd9:1403%8]) with mapi id 15.20.3088.018; Wed, 10 Jun 2020 06:54:45 +0000 Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc. To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: Maurice Ma , Nate DeSimone , Star Zeng References: <20200610023314.8248-1-chasel.chiu@intel.com> From: "Sean" Message-ID: Date: Tue, 9 Jun 2020 23:54:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 In-Reply-To: <20200610023314.8248-1-chasel.chiu@intel.com> X-ClientProxiedBy: MWHPR22CA0063.namprd22.prod.outlook.com (2603:10b6:300:12a::25) To BN8PR07MB6962.namprd07.prod.outlook.com (2603:10b6:408:d6::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <6a8a5afc-9acf-d2c5-86f4-b9101120043b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR22CA0063.namprd22.prod.outlook.com (2603:10b6:300:12a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.19 via Frontend Transport; Wed, 10 Jun 2020 06:54:44 +0000 X-Microsoft-Original-Message-ID: <6a8a5afc-9acf-d2c5-86f4-b9101120043b@outlook.com> X-TMN: [J4rSVuq5qR8BisWqT9CGKCsonn/din3j] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 3bfe24d9-80da-4df7-9ff1-08d80d0b28d4 X-MS-TrafficTypeDiagnostic: BN8NAM12HT236: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9RXXyZ4u85Vfp0LX/RZry0EkV7P+V5O13ENxi5ac49qNmyqnbwPEZNhXVJVMi+KVyPzaqfViSrhjJnElWjtnMTGl23wMoTnHyUq/WnT+kap87iDrKt3HaoXWkSMIGlTZ1n6JoX5k7BLf0zd3HdjhsNkTujFzBaevDpnlTJR4swvKwS2sCxj83nnYvFQbfMqovWg2cUq4zlUkvzVSwR2gwwASBjqrcqhfen+oAbYRnpi98eCSuyGeNL66Idig1k3z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR07MB6962.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: aLrgkmDo8JynAQ1zM5ut+3IbsKXUKEuxgjkgqfbUV4p+CAZaZzqDKlg8x0+/8TrxgxcwJ30rL+kNjZOyrKfya5rWqbZS41AMR0rz9NN1tgMTY8/RsQWXdTH4LxVrHfM5SBhbHWhJNhUyq3pKKZ27JQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bfe24d9-80da-4df7-9ff1-08d80d0b28d4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2020 06:54:45.5940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT236 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I think your copyright year is off. 2022? After you fix that Reviewed-by: Sean Brogan Also since you are the package maintainer of this package what do you think about enabling Core CI? We do this already in Project Mu which is how this missing entry was identified. https://github.com/microsoft/mu_silicon_intel_tiano/blob/release/202002/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml Thanks Sean On 6/9/2020 7:33 PM, Chiu, Chasel wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788 > > DSC is incomplete according to the established CI policies. > Fsp22SecCoreS.inf needs to be added to the Components section > for completeness. > > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/IntelFsp2Pkg.dsc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > index 02fe9cb188..9b5e38c5d9 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # Provides driver and definitions to build fsp. > # > -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2014 - 2022, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -65,6 +65,7 @@ > IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf > + IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.inf > IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf > > [PcdsFixedAtBuild.common] >