From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.105]) by mx.groups.io with SMTP id smtpd.web12.5104.1602212565106404840 for ; Thu, 08 Oct 2020 20:02:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=a2tDjeb5; spf=pass (domain: outlook.com, ip: 40.92.19.105, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLiLohxs5tK9GuhDcI/zlpIK2DC/g5pr3Ymu9AZgz0yaWqhyLXAyArRy9Ok6JGUrkEHI2GvUsjJJQxFQtG9DOoQdt0N9ATB+wv5lqhhPaj3erKYmYGve+VopaBaGAhEJFHT2ZPw/yZj4O6YvlIr4C8ETQti7x8TtQbi3Jcc7/VomRfJNnoQymvGYlGk2HArdd+C+CT8c3N9CFTIYSTIGtZR7f23hwLfL2+XPp/YWF6l5SqEnYi/Ubyw3hc9ZhJ0OP8Hmh0/YRZKh7f39DD1reSY3lw+srXHsfnq206bwahPqVn2095KQecVBgpu57X3vnGiWDmHQEzH/1Xd1UylB1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lySH6GeF1DEx3l93Kd+PnSKmZH6lr5CQZFs5qG1HJGo=; b=BOwahZk5gVZRCW6R8+MK31U1HzYmw8CGQXM1qhAlR5IUZBhOMD/qLcbMD/naXUS1LU16KxI96JnexflxOwowlgkVOPUstn85WrrM3lGDuSdlHshqiXsrafLw+LubwupsBaFElk7l9ovtdxt9PLREBGfeLbKirZyTqVHs973Iv2bcJ4GKsU6f/zAdLEH1vjTXaFJ5jdBi+lDRX7CPtcrv8OHtvZWyvjbbK6cAYcFGxuaKqV4lMqhRaxEQeFN7D3LupaMmSdYfZe0/fmSZisYGM3TAaJS3iXYJB0IrssrFd6H7a6rJLzepCjfI6Qw67rod8R3BJX9tuFsv+bo9XfXyQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lySH6GeF1DEx3l93Kd+PnSKmZH6lr5CQZFs5qG1HJGo=; b=a2tDjeb5Bn70j69qZvm/qm63e7M0Mn6//CF/XJT7/7Cicc3iEowDphoRkJDPDGnaBZSvj5HVWH4soBSz9Z9z0jY/JQhunxOQAN9r1sKNdBBokIhpEMrjRg1/lwf0q3i7zIBi7A9geYNlZ2pddniCHHu90fAVQVnZw5xejQ8vG4lnS4u7jfSmjfSzvfZiAJRwKtH8i3bYBWeOzCieuJWXy6SXzchVWl4nZjJaijLO4hg7/XT2vV8ebFWjAGDOBQFREVpThMcMuwooeolPCWEkJM93TWgRGGtNKlbCeHA9J+WLZ9z/cZAmF4Qvd2JAu4BxvDqsZpka2V/uC0WzAdtVZg== Received: from CO1NAM11FT014.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::46) by CO1NAM11HT164.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::301) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Fri, 9 Oct 2020 03:02:43 +0000 Received: from BN8PR07MB6962.namprd07.prod.outlook.com (2a01:111:e400:3861::4e) by CO1NAM11FT014.mail.protection.outlook.com (2a01:111:e400:3861::355) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Fri, 9 Oct 2020 03:02:43 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:CD5403C849E008293ADBD0819934DCB1C0A86506085E4D01F6EEFB0659C2D9C6;UpperCasedChecksum:3BD30D7AFFD4B2C0D7E9E6D771C6791E3A9D886AA0A862A07CA48E54EC69223B;SizeAsReceived:8948;Count:48 Received: from BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3]) by BN8PR07MB6962.namprd07.prod.outlook.com ([fe80::b1be:f3e4:f6e:66c3%5]) with mapi id 15.20.3455.024; Fri, 9 Oct 2020 03:02:42 +0000 Subject: Re: [edk2-devel] [RestJsonStructureDxe PATCH 0/2] EFI REST JSON Structure Protocol To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao , Nickle Wang References: <20201008151045.16476-1-abner.chang@hpe.com> From: "Sean" Message-ID: Date: Thu, 8 Oct 2020 20:02:39 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 In-Reply-To: <20201008151045.16476-1-abner.chang@hpe.com> X-TMN: [eSWr339w/WoVCoNBup98bJruJxmz3orW] X-ClientProxiedBy: MWHPR08CA0043.namprd08.prod.outlook.com (2603:10b6:300:c0::17) To BN8PR07MB6962.namprd07.prod.outlook.com (2603:10b6:408:d6::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <892c8987-cdf1-e326-588c-3f60303d19d3@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR08CA0043.namprd08.prod.outlook.com (2603:10b6:300:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Fri, 9 Oct 2020 03:02:40 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 49bf5592-804e-4871-aff9-08d86bffc9bf X-MS-TrafficTypeDiagnostic: CO1NAM11HT164: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qoJbvJfdUG8KYpOGMdjfnKnGJ6ZO1mP1AvYTY1UJBnfJe4CaE7xM7j2/UzT6ZMMCnclKkf7cbqGusotBRC2DDjQ911GAKrzmBSZxZUR5WZCQ2yMuvqrxe6rJrRwHZlhYYc30o3A/hBaoeuDNReL9Ae+aIutG7z/OjIYBAet5dvSrv9GrQmmLjHFlDxInUk8iqEx5jKo8lrWIBVNCPr05JA== X-MS-Exchange-AntiSpam-MessageData: uet4q6eKBN43zhjJl+5vhBPS8geev6Qc28y3scXX0hKzjdRVFxYCf0qtbr0rwq7jo44+V61tkDJY1cfAkkE7RtM+bacm9CfBme0mte0J/y4A0dHscw+urfXVlHl8HxPhqENRLxavTAEWJPZsRcnUrA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49bf5592-804e-4871-aff9-08d86bffc9bf X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2020 03:02:42.2533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT164 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Abner, As you add this RedfishPkg and significant new code to edk2 have you thought about authoring unit tests. One of the goals of the unit test work that was enabled nearly 1 year ago was to make it easy for developers to write unit tests and to continually run them during PR and CI runs in the hope that as a community we might start authoring unit tests with new code. Personally i would like to see a process that new modules can not be added without unit tests and relatively high code coverage. Was there any thought to that? Has there been discussion i may have missed? Thanks Sean On 10/8/2020 8:10 AM, Abner Chang wrote: > This is the implementation of EFI_REST_JSON_STRUCTURE_PROTOCOL, > refer to UEFI spec 2.8 Section 29.7.3 EFI REST JSON Resource to C Structure > Converter. > > Signed-off-by: Abner Chang > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Nickle Wang > > Abner Chang (2): > MdePkg/Include: Definitions of EFI REST JSON Structure Protocol > RedfishPkg/RestJsonStructureDxe: EFI REST JSON Structure Protocol > > MdePkg/Include/Protocol/RestJsonStructure.h | 160 +++++ > MdePkg/MdePkg.dec | 6 + > RedfishPkg/RedfishPkg.dsc | 3 + > .../RestJsonStructureDxe.c | 583 ++++++++++++++++++ > .../RestJsonStructureDxe.inf | 40 ++ > .../RestJsonStructureInternal.h | 35 ++ > 6 files changed, 827 insertions(+) > create mode 100644 MdePkg/Include/Protocol/RestJsonStructure.h > create mode 100644 RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.c > create mode 100644 RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf > create mode 100644 RedfishPkg/RestJsonStructureDxe/RestJsonStructureInternal.h >