From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.4182.1600397252914186416 for ; Thu, 17 Sep 2020 19:47:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XLkhxBeb; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) IronPort-SDR: YTh+8vjtnxKocyaCO857KtQmiyg8Lr3cUWtWtelS25t0RjnERoM/WHsr1uvlcswR4ydj0bG7f0 6qam4OliM+Fg== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="159898187" X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="159898187" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 19:47:21 -0700 IronPort-SDR: yt2DgTzeeA2Baw3NKrrLj5p/g4gf63fIP8yQ0RwsNUFQB9ofuQEm4J0N3TFVkir99I9qqHW8/l tbbkYDylF3Ow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="344582320" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 17 Sep 2020 19:47:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 19:47:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 19:47:17 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 19:47:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGjBoQV/ALEgpPpAhuKK9S/8sfk/Hn8ae89kSIOX63mdlw27UUj3BfbJfhlS9XTVUB7niqzRFNYlHuGYTnWhQu/QYgDB5SpxchPPDbjRXXfbwzZSaRz/bt8fBotU0XJ72sh0oD23AI1FHlZUol+AYsxwWAkkp8quum+ixkDuk3j0jiULXWwzT8ATpl1rmnplUkn7bn5118mUY7F/EuPW+RKEBBHwCjCCFy1un79Wz4YEon6Lft1hEGaHu+GmW599iqdO9ZNb9/O1HpFZ2KvaEwpmGJWnwEvsXg2T32EYfnBnRj0WW2BvhyAp0GKg8TScvzTAKuH8PKi+VBAePjEivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jyaiD0TVo8tf8ggAMSAwpg3tv2Y5Yl9vS4/DbSnshKY=; b=kfkGgGlxxwyDaLH7trFt9/o1r0MVOJjdGQTransoVHXNPjGQKFK5Bfe4jeCJvZW4N/EfaE85zBLEJCqB+iPmIQSgPjhONfi+X+UrSVoME5PUsgt8zldZ87P4+oJz5zGY86+dikJ81LHNnsjAWDZgQ9eRtY2iueuRsHFHCbr+3N8XUVRw7f071WVInRSP1Jz4lmWBRWE4Y1zqjwLpFF+/WKf9rfQjslCIIrwo7JVws8Ahe0s+SDcSbDXJVuNECmXWCzlPV817zIvPsggVNVYzcHSNnerH86IwGl2xUasefOjcmxNP5MyVd84BHcwV/Nf3p7qVtA52a0T1rEOaCz4xUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jyaiD0TVo8tf8ggAMSAwpg3tv2Y5Yl9vS4/DbSnshKY=; b=XLkhxBebWKXLmicYF1A0Kk0c4Md+HJMk9nqmLMAGt+bPnmBv+jyEuNKBdg+5+IkaDXBJXHbpelJtGkT7v6c02Z5AP6OyE9ad4c/8P9EfJM0RRsZkNjbULuV7pT017jABkUtNr/9QXpgEQNJLYaPjb6mnmXmKuzhfkgpcwvhlDVs= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR1101MB2242.namprd11.prod.outlook.com (2603:10b6:405:58::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Fri, 18 Sep 2020 02:47:11 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::78b6:7108:8852:7536]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::78b6:7108:8852:7536%7]) with mapi id 15.20.3391.011; Fri, 18 Sep 2020 02:47:11 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , Jeff Brasen CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Thread-Index: AQHWiF9VOUUZ9A13wUaAUBbxQ9Wsqqlo86FwgATHk8A= Date: Fri, 18 Sep 2020 02:47:11 +0000 Message-ID: References: <3e6a774a62a4ef92fcdfb5e156e2abc4c440d35e.1599844505.git.jbrasen@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f981439-abd0-4453-ecd8-08d85b7d2485 x-ms-traffictypediagnostic: BN6PR1101MB2242: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:49; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QshFfeR2QwakZynOtmjvhBDjKWADMt0qaLiIUKPi1KrijC+I0itsqt0878Jw5CF5kuwN7DkfRnMHgd+13iAy9KIsDPkQacU1s/beABa6nyUcaoH+Ob3vPhWCT4+v2JioCgE1q4Kxfzz8bO/80a6sY6GXFnn+gDHawhKf4wRhQb3F1IpQo7vB32cVAfpxuayfIw+NZCq00hmfqUmjlzKVQqmJNTRe3+qb3VfXiGdXmeX7t5HT5T+OAflOZOg76oeLoits1ykX5NN5vCjaoO3C+aKHz2wNIlhAOSdGxTkzRW0vQg0hWY88z4RsNhc5M7vFWEQowbahTMfaTuV5hhtve9iIbLcxuSukvzN31mx+/Z/G+rnDZW5GTvcjzLJ3WySk+U8yTf9m/vy+EunJsELwUZhFnwtDQIwklzdrx7KwK8EsL4h89AZwOvkZ/JXfkPwpvMizeiNnUjE1WO5CCKuuZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(396003)(136003)(346002)(9686003)(55016002)(64756008)(66476007)(2906002)(66446008)(86362001)(66556008)(8936002)(107886003)(186003)(26005)(8676002)(33656002)(7696005)(71200400001)(6506007)(53546011)(478600001)(5660300002)(4326008)(316002)(83380400001)(76116006)(66946007)(966005)(110136005)(52536014)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: SYq4oRtAv+A0NeNrGH8wrPBHYSGVhpEOvRph9WPMGDwWaW6F1KbYyskcKaRbcgZRItllYriXgztXZwsxmgrviZDJososUX9eq+B5kvQExLvqX6wWJydvcCyML8doxUC49MA4zqNKA1rkunlotwDIS+ayfnoravw4Ymeu/ZpKPQ+bCR+cb3I2Z42PDmhLFZZCStkdUjYHlcoU+DwDfwqtKJjVpRw0HmI+09uUWequCZAl0TCrWFQ5mx5N2Y6n5PmTlB2U1M/2rM7N51f8UYqKeobwsL9fBhbPTquxujgaHPvOTXMqXGDAHcOeEl22GYjAIPZJxBE0UElyT/xMYLdQUx4Sy1wTiKg1qP2JMc0UZMAVVun+sAOaBwSpNotgbhQX2aVGrW9MjeD/iY8lzQn+GSqU+FAGu1hI8USEKEZBLMLCk7wRARaMRKneMtnpl6Ixu2uIXGcViyqxoNZ3gj4LP51Ln2GMXCF57ZldvHUC6I/yMZUAqRuCCX+P3BwhN3ZwvDAeGkJMx4+96E3WWDFgch0x5sot8+75htpX9YtKL0fZwbW0zGW5fFn2q0IOzlTGwivMY9qhil7A8TDLm5pzkatKdvkqOWgmkcvpT44H8UNtrJ5U+nPHuw2wmRSKnYn8jCFm0Rp6BVq1gHDetSFp+A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f981439-abd0-4453-ecd8-08d85b7d2485 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 02:47:11.2712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0nsgbSE1AYeGnI9d7eC6icZDijMPU2KEfYMMr09PAGTclVZrT9XpBUKPnFVyoL61k5IqUGSDmdrGEO9m1EIleA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2242 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed via commit 698d3d7726232694018d437279dd4166e462deb7. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao A > Sent: Tuesday, September 15, 2020 9:48 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [PATCH] > MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check >=20 > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Jeff Brasen > > Sent: Saturday, September 12, 2020 1:17 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Ni, Ray ; Jeff > > Brasen > > Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL > > pointer check > > > > Add check for NULL HostAddress in AllocateBuffer as required by UEFI > > specification. > > > > Signed-off-by: Jeff Brasen > > --- > > .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > index a40c1a9593..363c4a765b 100644 > > --- > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > PciDeviceIo.c > > +++ > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable > > Pc > > +++ iDeviceIo.c > > @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( > > return EFI_UNSUPPORTED; } + if (HostAddress =3D=3D NULL) {+ = return > > EFI_INVALID_PARAMETER;+ }+ if ((MemoryType !=3D EfiBootServicesData= ) > > && (MemoryType !=3D EfiRuntimeServicesData)) { return > > EFI_INVALID_PARAMETER;-- > > 2.25.1 >=20 >=20 >=20