From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.1652.1624412009030935015 for ; Tue, 22 Jun 2021 18:33:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OsyejLg/; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) IronPort-SDR: JsFq7m/e/agpStYudh483eD4PGX9y1LlBR+IJ2i6nEndIvXFe7njZRiIJDqLRPnTGGHc7Nw8af 7Enm7aakDdwQ== X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="207113137" X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="207113137" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 18:33:28 -0700 IronPort-SDR: 13Cy+E/xXih9yzYGm0yC6ZwO8GMWLPKYpmxqOFzRGr7gBz54an3SzxUHU6R8QIlFBUtDrx3qFs 4WnonSebkWdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="556805618" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 22 Jun 2021 18:33:28 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 22 Jun 2021 18:33:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 22 Jun 2021 18:33:27 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 22 Jun 2021 18:33:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S991gZArtsv3CtEMXgvZUwt9RMs+YLSzQRTjaW+2S1/DYcFUdFEVKOGsjcd7ovoAhtzCkNp+I3XQNIH2kLcF75j2GqtteBzw7keH4TbTb03xy1zHKz7HOlayo+1eAJYE7us+bn6v+AoT2aeQbT9DRr4n+PxNDEu1lD8pk5IX/TpTUthJfzf+zkr7ZHhr1oSPsXBMxAg10IJUqBpQTrwcjljzewCjLu8vSU95/WdujlbgJikfbuhEeqni2Gpyamq3xyJ4uL8Xx+0dPp2coAku0Et4MbbqgXPrl4DFziSAEk7xaiOs6roLAA1+vZJO8nvpaAcIIK8D12XRLVty7jTB/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Rr/0EqnFYQeZ8kTCWUnb/weflTdj0x1GZZsGDnhM1c=; b=a2mqx9bK74e1bjp/MtVCldxzek87l3itq+HMf7fy3DC3k/Ut4F34ZuEyeiJOcf3YzwAwCxfwLVB1eu5hf/oTYuY1xk71tPDlWwMJfw/BZ+iU5h80ak7jrS9a5irQISD0MDF9T1xYiNYLOn6WZbicNHz8ID06G5100kybXu9wHDJRBezD9ZfcEq9ZRM5ts30rOjRxLBlNKOb0TaDAD5GRiBl33CX3TM/8EqkL1OspQlg7svyBwNIZ8EC6ni031yCj4yT+Vo7z8t+XHvU5qJDyw+rrie4kqXL/qbcLD7pbjGLdkNlkMEueVJTzcuDZq0GLmhnvZxo6wu6nUhcbcfP1ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Rr/0EqnFYQeZ8kTCWUnb/weflTdj0x1GZZsGDnhM1c=; b=OsyejLg/oE96JDB9EIeHhV9i4Sa6FxTzIDE3k9W6CgzRWlJVY6eiRNuZpomkUzP/eKQDECf49gSniRZi+jWgpk6drk5f2NN9N4ACicpbH3zWAUu/+vcivOsm8atPWs50+Gwsxxnl0G12a8PfMosKYB1L/GoB9MqiM25j7ztOPQY= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.23; Wed, 23 Jun 2021 01:33:26 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d%5]) with mapi id 15.20.4242.024; Wed, 23 Jun 2021 01:33:26 +0000 From: "Wu, Hao A" To: Kun Qin , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Dong, Eric" , "Ni, Ray" Subject: Re: [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: Updated MessageLength calculation Thread-Topic: [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: Updated MessageLength calculation Thread-Index: AQHXZCDAp8g3TB4YHU6s2fAzzcVaX6sg1wuQ Date: Wed, 23 Jun 2021 01:33:26 +0000 Message-ID: References: <20210618090243.2517-1-kuqin12@gmail.com> <20210618090243.2517-6-kuqin12@gmail.com> In-Reply-To: <20210618090243.2517-6-kuqin12@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.142.16] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b33b5ee2-660b-40ef-9bf9-08d935e6e5e3 x-ms-traffictypediagnostic: BN6PR11MB1473: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VK2HwQZWpOEKcfY1xqOiWKzVl62TcJDHnXe3jStFaosq++l8n2UUZN8GtVNUr7TC86euuJor7S8D6Q/JxuEigZokg2qrbVls/4dE7X+911SdMF/iJa/2nCr1kFgGUzKgmG39uoxcvUKuc/DJUzCV1SWOxYwT+dgCfoG6DW1AmXZ6qigm81ytAkr6azpMOahgA6eeOS2R8thkcqgk9Jtj336wI88XH7Sn4WtUKtB9TFzNMzQ2Qo8miZ8QnzwdzIJxAmYftmfHrl1mnTdsP63WhTyibXTiHDK3Y/V4UHd3VeclCltZhsk20KLaBSGulWC/1xld0+FhzUJOMC+9dkQQZ26UQw6u8TEz9TAs1de0wLgyxRMrdp16J5r5jPRTjPt+XVEIzW3mUE0tg1rrWEzITxUej6XJ2h3tltXo0RK1Dm1+bJPT1B3rXVPOu882TD0WO1L4oNwf1e0ZYsRM188p225iH6LcyVZ3sFrwvjNoSAj04Id52168lQfbRk5MPZRU8yksIVdtotVCVsmRbTjQ25ASDNz1MP+ZXEzmX/PQTH5JaPhzKc09Kgp+XAxszF1WW8u4xRhxdwI6hpgEYJYhbeDNpnrmsuviWomcrSc+64wsRQQAVISEb7ZtB5NVclJm0iMhJvvOokHonvi9O2Bo4YEyOHg2eN6mrrkPC6O9wrGZ8dbINSq4p/GEyT18WgDn+qAIQjC9cXnsbX8Nr44kDkhyp+1BPIbR1e3Pn+1CjOZ/aR/sI4F/w/ptFANjeCbXJPXzOTEyxSnnBOcBdicqlFMCOOGri27XB5Ra+H5CxlGMQ7VqHfMWYGOfi/cRQNOu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(39860400002)(366004)(376002)(136003)(76116006)(15650500001)(66476007)(54906003)(5660300002)(2906002)(110136005)(8936002)(66446008)(33656002)(66946007)(316002)(66556008)(52536014)(86362001)(6506007)(966005)(478600001)(8676002)(26005)(38100700002)(186003)(4326008)(71200400001)(83380400001)(53546011)(122000001)(55016002)(107886003)(9686003)(64756008)(7696005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vD6L0jTkWJkOr6zeM0K8fogZWDTQ6JbEjwBuoY2/WWvHMa37Yg8boqDuu3yM?= =?us-ascii?Q?vAOZ8ILaDR0hqb7YO/g8cVFAba0Ab8K8WzmdQDBGq0AB9rojl2CnNv4dDCk5?= =?us-ascii?Q?zh0aNlEkHqg8KveqM8HDKjcBKg1a8PlCGYvFMCbNEURUTIGC/BMy3S20B1/v?= =?us-ascii?Q?hGPbiIDS2eLqRjseRafzQ7TiEDkXXsQdr3Esr26JO9j1fyZm8R7C0P+rfvDL?= =?us-ascii?Q?JhBzKJhpEsU8v2aMIn46/XoMImP9ZQ7Ra1tbfF5eiNEBtcp4Is81WwvjaJca?= =?us-ascii?Q?PqPKH5uh83IFEjRCrDw2ju46shymvjzwNLHIPmqXCo1a9kLebf6neUvG0unZ?= =?us-ascii?Q?/q/31NF9mbI0gHe+HtpSxMpGKTKgreFTBMofoZp6uOFt0ul9TvtZg+EtPb+a?= =?us-ascii?Q?lEjgOgDzX0XGbqMYYNZYEguS1oTDKpAlDJpkOoZyyxbDzxMkG/Lfb8cCADoA?= =?us-ascii?Q?2eYg+RV1c8Ca9whjpFqeum6OujNUqwzncMbKTYCJOHbGaJ8FF6qzNIY7LzF6?= =?us-ascii?Q?6uqfsUB7gAzcQEETOFWpfMFi28E+B4/QFfcAiB9qswG889rzDLyajM8NXat1?= =?us-ascii?Q?UDQXifhT06D30v/urlA5pnG8nq8flvycLomrv4IO3JZwgdFIUGSU5HjBmVrR?= =?us-ascii?Q?NlImJ+a8jM5AXwUC58UVIv+XBtPjZoj73mjvmcDxQt9f93v1HkBoPMztTZdt?= =?us-ascii?Q?XRGXqM+0Zly54vqPD9mCy9maMzuCq7g4Hx1mg5VPeVK+D1VCsuY22xeVBjDl?= =?us-ascii?Q?JhWxqOHptm3WkA1gn2l5Eb4J9YZsL6Oy4G7DCu/FZeDA5F69RGKzBCs3QvWv?= =?us-ascii?Q?sW1vsnbkBLfZViAWL33ewjMJgobnlWylwaFieh0nL+rGV3MiflYtdV+XeGwl?= =?us-ascii?Q?J6L3e6/wjK3h786a5V5dHPxvrD6GHoJ/sJfszr1fUtabb/aR6hq1AzmmkQhN?= =?us-ascii?Q?IK1NtJ1eONOIdEay6BgH2bA/D1v5CTwUV2cU+s608STCPfNSHZKhz57sQ2xE?= =?us-ascii?Q?eEw2jmyA9BiF2fHaOqleriYNUJSvrd0EuuiSbnPI+g3x/K3vX4FyEkKMUm7r?= =?us-ascii?Q?j+I7oYNvZtDU6ZcjPWkY2EREDG9tBCeJi4iBbXWLMvNyzpNz6wZYTOr60kVf?= =?us-ascii?Q?tos5fGeIut/BEOdkex2Lsg4xVQngji0NUzq4nUlHLRl4jTs57FR8j61FLuZo?= =?us-ascii?Q?uMG6CbhFeAv6VoKHHkUuJiDIZ1WhYhD6J+Cmb8Skug911L4MPQeIgmpdmyf+?= =?us-ascii?Q?uQ7GAC4blKbPagA0U3TJQFFEwCBR8k2GvOlfoRoQmYoDllefHfRaXAO8blBf?= =?us-ascii?Q?q5h+g2SMVK8udI4x6ccXLwFg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b33b5ee2-660b-40ef-9bf9-08d935e6e5e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 01:33:26.3626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OWRFMif7AtNuiTm3xjPk5S905mlhcXhOe8SYoJkWElLyWoqn5F0LXqzhxxIeArkJG/Hz5DUx9b54HIZ5nZtnNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1473 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Kun Qin > Sent: Friday, June 18, 2021 5:03 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Dong, Eric ; Ni, Ray > Subject: [PATCH v2 5/6] MdeModulePkg: SmmLockBoxDxeLib: Updated > MessageLength calculation >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3398 >=20 > This change replaced the calculation of communication buffer size from > explicitly adding the size of each member with the OFFSET macro function. > This will make the structure field defition change transparent to > consumers. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Eric Dong > Cc: Ray Ni >=20 > Signed-off-by: Kun Qin > --- >=20 > Notes: > v2: > - Newly added in v2 >=20 > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c | 23 > ++++++++++---------- > 1 file changed, 11 insertions(+), 12 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > index 2cbffe889e1f..66fbe4dd961c 100644 > --- a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > +++ b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > @@ -79,8 +79,7 @@ LockBoxGetSmmCommBuffer ( > return mLockBoxSmmCommBuffer; > } >=20 > - MinimalSizeNeeded =3D sizeof (EFI_GUID) + > - sizeof (UINTN) + > + MinimalSizeNeeded =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, > Data) + > MAX (sizeof (EFI_SMM_LOCK_BOX_PARAMETER_SAVE), > MAX (sizeof > (EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES), > MAX (sizeof (EFI_SMM_LOCK_BOX_PARAMETER_= UPDATE), > @@ -142,7 +141,7 @@ SaveLockBox ( > EFI_SMM_COMMUNICATION_PROTOCOL *SmmCommunication; > EFI_SMM_LOCK_BOX_PARAMETER_SAVE *LockBoxParameterSave; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > - UINT8 TempCommBuffer[sizeof(EFI_GUID) + size= of(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SAVE)]; > + UINT8 TempCommBuffer[OFFSET_OF > (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SAVE)]; > UINT8 *CommBuffer; > UINTN CommSize; >=20 > @@ -182,7 +181,7 @@ SaveLockBox ( > // > // Send command > // > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SAVE); > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SAVE); > Status =3D SmmCommunication->Communicate ( > SmmCommunication, > &CommBuffer[0], > @@ -224,7 +223,7 @@ SetLockBoxAttributes ( > EFI_SMM_COMMUNICATION_PROTOCOL *SmmCommunication; > EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES > *LockBoxParameterSetAttributes; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > - UINT8 TempCommBuffer[sizeof(EFI_GU= ID) + > sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES)]; > + UINT8 TempCommBuffer[OFFSET_OF > (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES)]; > UINT8 *CommBuffer; > UINTN CommSize; >=20 > @@ -264,7 +263,7 @@ SetLockBoxAttributes ( > // > // Send command > // > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES); > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_SET_ATTRIBUTES); > Status =3D SmmCommunication->Communicate ( > SmmCommunication, > &CommBuffer[0], > @@ -314,7 +313,7 @@ UpdateLockBox ( > EFI_SMM_COMMUNICATION_PROTOCOL *SmmCommunication; > EFI_SMM_LOCK_BOX_PARAMETER_UPDATE *LockBoxParameterUpdate; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > - UINT8 TempCommBuffer[sizeof(EFI_GUID) + si= zeof(UINTN) > + sizeof(EFI_SMM_LOCK_BOX_PARAMETER_UPDATE)]; > + UINT8 TempCommBuffer[OFFSET_OF > (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_UPDATE)]; > UINT8 *CommBuffer; > UINTN CommSize; >=20 > @@ -355,7 +354,7 @@ UpdateLockBox ( > // > // Send command > // > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_UPDATE); > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_UPDATE); > Status =3D SmmCommunication->Communicate ( > SmmCommunication, > &CommBuffer[0], > @@ -403,7 +402,7 @@ RestoreLockBox ( > EFI_SMM_COMMUNICATION_PROTOCOL *SmmCommunication; > EFI_SMM_LOCK_BOX_PARAMETER_RESTORE *LockBoxParameterRestore; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > - UINT8 TempCommBuffer[sizeof(EFI_GUID) + s= izeof(UINTN) > + sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE)]; > + UINT8 TempCommBuffer[OFFSET_OF > (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE)]; > UINT8 *CommBuffer; > UINTN CommSize; >=20 > @@ -449,7 +448,7 @@ RestoreLockBox ( > // > // Send command > // > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE); > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE); > Status =3D SmmCommunication->Communicate ( > SmmCommunication, > &CommBuffer[0], > @@ -488,7 +487,7 @@ RestoreAllLockBoxInPlace ( > EFI_SMM_COMMUNICATION_PROTOCOL *SmmCommunication; > EFI_SMM_LOCK_BOX_PARAMETER_RESTORE_ALL_IN_PLACE > *LockBoxParameterRestoreAllInPlace; > EFI_SMM_COMMUNICATE_HEADER *CommHeader; > - UINT8 TempCommBuffer[sizeof(= EFI_GUID) + > sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE_ALL_IN_PLACE)]; > + UINT8 TempCommBuffer[OFFSET_= OF > (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE_ALL_IN_PLACE)]; > UINT8 *CommBuffer; > UINTN CommSize; >=20 > @@ -518,7 +517,7 @@ RestoreAllLockBoxInPlace ( > // > // Send command > // > - CommSize =3D sizeof(EFI_GUID) + sizeof(UINTN) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE_ALL_IN_PLACE); > + CommSize =3D OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data) + > sizeof(EFI_SMM_LOCK_BOX_PARAMETER_RESTORE_ALL_IN_PLACE); Reviewed-by: Hao A Wu Best Regards, Hao Wu > Status =3D SmmCommunication->Communicate ( > SmmCommunication, > &CommBuffer[0], > -- > 2.31.1.windows.1