From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1306.1594342232314313046 for ; Thu, 09 Jul 2020 17:50:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=y4kXHLPh; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) IronPort-SDR: 2E2C/nlhPUSx+wviRLVvv8zl6W/d/xP2PEkaCc4FtKl2I2lJ4FnJOnPPoefaFFu/sCQd8RCM9T atYDCA6a/Gew== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="136337970" X-IronPort-AV: E=Sophos;i="5.75,332,1589266800"; d="scan'208";a="136337970" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 17:50:31 -0700 IronPort-SDR: dBL1+k/ZxvnoFqFnVL7e+ffgTvhilmEQJFT8ih0S+elMc33WT60DFmnrLsMCJW8GeAk25FPxDI AzxBmyU6sFXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,332,1589266800"; d="scan'208";a="358616382" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 09 Jul 2020 17:50:31 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Jul 2020 17:50:31 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Jul 2020 17:50:31 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 17:50:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZHi7sq4r+i3/I4yugGTplov7M3OCIU8HZoRogIPIAGEw2E72D6WKMybuUc/f66ieBE6e+Wqke8epVouPjRjZourdYHU2TnKw55g1YndGDx8I/eBJgIgLmVYERt/ScuRa8YQStEbGnndCkmte3XSd9e4MuW0DBt71n+GGrcfjNxIc0jscq+OYSyO7uS7ThTBmpw96I7xnWHLJFyJw2grcLQBstUJxBcL0rhhndYgPb3/Wuqkn/T5eqIOBdJ1p4jyNGFkbdXTlB9AZ2E27RmK/peeJGNxaBntmvg8qMcuQ3g9sTd+6qWa+gfq6gVPW5YjAkh2bbGczkS2HcIAh0tOPPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+/TFK231bo+ckTOPuxy+1gpz26RWFHoDKYqrGd9/NmM=; b=i9nv5A74+KMIzwD1/N9sMKaySaADP2ggQZa00PSXlVV4iycQnESCWN6fBgNswjaCadfb7j8CBSaEbVz5CSIdc/NWlN0OQ76cmXkyA83bsuH3J2mBQgXt5CBC83ThY2uE6c76PlDDu1x5p8ygKDdLwRwPK0EU5K0d49TyECHzX8+ydDxfuzP7p5k0WcT3nnytmQWw0lMVLZynt7AYiowTMWYviX73A8w1al1xpyMA7DVR1vq81hg3LNXGJndFgAl2+7AMKh4n6Xh5FL4M21zO7TzFZYIg12erwqNCXWlAH7He9wOU0JapjGAagQR4CuyE8OXMUg6ItxPsIhknXgpZzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+/TFK231bo+ckTOPuxy+1gpz26RWFHoDKYqrGd9/NmM=; b=y4kXHLPhxa+hIb6HKXFkEWTa5Rt9hqdoJiEDvR7464iM7wwnSfp4rlk83iOLN9ew8kHL9pYYVuzHqBp0nT2uR1PqtylJOwACvTwjFIFUUkhcXuKHX+w3wLtOvfFcU1drG75KXjjThDeHya8CzUA7SE7LltSzeZhsxwlxw4Wkjqs= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB1955.namprd11.prod.outlook.com (2603:10b6:404:100::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Fri, 10 Jul 2020 00:50:27 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::dd04:b759:2ef1:e86a]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::dd04:b759:2ef1:e86a%7]) with mapi id 15.20.3153.032; Fri, 10 Jul 2020 00:50:27 +0000 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Topic: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Index: AQHWVM9bZUG9RYw4fESc7hTO7Ljd/6j+srhQgABGxkCAAQT04A== Date: Fri, 10 Jul 2020 00:50:26 +0000 Message-ID: References: <20200708022722.27024-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ec7d758-707e-4189-9445-08d8246b3cc5 x-ms-traffictypediagnostic: BN6PR11MB1955: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Era6CYPmFCBvbyuuJ9rHXUHARpeLV/HvtaL3oDR1wv6SgBLhRrCO158n9BJ2uB+AdX9u4onKWJ+v4A+j+wrMHW0m56I/BBsHxJ8o/Xxsz9VsGwz63BC7uRidE338f3yWVsO9psF8jJSH4/lK6YYw/DuvXQKAsPsueVRvuvVq57q5veHGrIWuPlWarXL3PXnhV5A7RRDZSndq4Etmjsp72BB8eTLnWZAx0Bd59NJ48W3JiO4eQpCfz3xDuZJPFkAmoN/NHWOTFl8g77lI/Hrqjf7oNM/WmMrfxu7oz3yANhBRG0eniKzVLJ1CwHCrK8I5qOqORnokroAKWTTfj300tvu3MmECQBOVmt+7LuzYoxUeDiN8NcjnbnrZ1FjWdofabRaCbX7GREMIM2Wv+dgYRA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(8936002)(66446008)(66556008)(186003)(66476007)(26005)(64756008)(966005)(54906003)(316002)(66946007)(33656002)(110136005)(83380400001)(2906002)(55016002)(86362001)(9686003)(52536014)(53546011)(6506007)(478600001)(71200400001)(4326008)(7696005)(76116006)(5660300002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: qM7oNiDz2VqJCFFh7gphI69Cqxor5vB9NqoHP+0XGinRIhVSleAZD8s7CLOeZSyzs61OknAWWco+TK5L1RfMW9G5eYY3qggre8Jbe4wNf3Wp+sKSFgWMFBeF1BVeauBpV7pttDp0V5As1402QXqLbIibjMx5kJGSn/YmM/Kjog8TghTup4O65mJop1PN1bhmFku4IcRys1msbH9wQ7rnjXFd/UeGMHKFtaYZia64SLQhCfN1yhWRFIia9ju993efBJCAIR8oKEM3G17K1sG3CCY8moIUvCLZQ6DliqWq+qh9qYl0YA63lTarlAYzlUuCNVGk95U5Kd1NqXlDAAYg4Mk/E2EoGKY8S8wfRpaQRW3hjBsFLO7W9EkyruJemBSvGUuWYTY/fba929D87OBgVkY9VU8cjEQ7lFQaPEB4B4EAr2UIYVDDvdUmq7wvjpGrGMkp52IglLEXIAWl/YQH/pUzH8YisWHPxM195R4a6CRsMXDZ/sHguduapxyibb0f MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec7d758-707e-4189-9445-08d8246b3cc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 00:50:27.0178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8G/QodsnsxkN3oJfizrlCJHlfQZ5o0ovdKiwppYxT/6lMOHI1WBRcNFx+Cxp9NC6ENKdPmv14k4JSSQNwFIhRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1955 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, July 10, 2020 8:41 AM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition > check issue >=20 > I have tested on the OVMF with linux iso image like Ubuntu, Fedora and > RedHat. >=20 > It can enumerate under the shell and load the grub efi application. Thanks Zhichao, For the series, Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Thursday, July 9, 2020 1:04 PM > > To: Gao, Zhichao ; devel@edk2.groups.io > > Cc: Ni, Ray ; Laszlo Ersek > > Subject: RE: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the > > partition check issue > > > > > -----Original Message----- > > > From: Gao, Zhichao > > > Sent: Wednesday, July 8, 2020 10:27 AM > > > To: devel@edk2.groups.io > > > Cc: Wu, Hao A ; Ni, Ray ; > > > Laszlo Ersek > > > Subject: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition > > > check issue > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > > > V1: > > > Separate the UDF from the partition rountine array and do the check > > > for every media. > > > > > > V2: > > > Drop V1 because it is a bug: there should not be two partition types > > > in one media. > > > 1. Correct the LastBlock value in MBR handler. It should be the > > > number of sectors (512 bytes). > > > 2. Skip the MBR check if the MBR is added for the Windows > > > comaptiblity. We treat such media as ElTorito and do the check. > > > 3. Fix the partition check bug: One partition type returns already > > > started should be treated as success to avoid multi partition type > > > be installed into same media. > > > > > > Hello Zhichao, > > > > The changes look good to me. > > May I know what tests have been done for the series? Thanks. > > > > Best Regards, > > Hao Wu > > > > > > > > > > Cc: Hao A Wu > > > Cc: Ray Ni > > > Cc: Laszlo Ersek > > > Signed-off-by: Zhichao Gao > > > > > > Zhichao Gao (3): > > > MdeModulePkg/PartitionDxe: Correct the MBR last block value > > > MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM > > > MdeModulePkg/PartitionDxe: Add already start check for child > > > hanldes > > > > > > .../Universal/Disk/PartitionDxe/Mbr.c | 42 +++++++++++++++--= -- > > > .../Universal/Disk/PartitionDxe/Partition.c | 9 ++++ > > > 2 files changed, 44 insertions(+), 7 deletions(-) > > > > > > -- > > > 2.21.0.windows.1