* Re: [edk2-devel] 回复: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data
2021-04-23 0:53 ` 回复: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data gaoliming
@ 2021-04-23 3:17 ` Wu, Hao A
0 siblings, 0 replies; 2+ messages in thread
From: Wu, Hao A @ 2021-04-23 3:17 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
'zhoucheng'
Cc: Kinney, Michael D
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Friday, April 23, 2021 8:53 AM
> To: 'zhoucheng' <zhoucheng@phytium.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] 回复: [PATCH v1 1/2] MdePkg:Update
> IndustryStandard/Nvme.h with Nvme amdin controller data
>
> Cheng Zhou:
> Please update the commit message to highlight this change based on
> NVME1.3 spec.
>
> With this update, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: zhoucheng <zhoucheng@phytium.com.cn>
> > 发送时间: 2021年4月22日 10:11
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>
> > 主题: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with
> Nvme
> > amdin controller data
> >
> > Add definition that describes the structure of Nvme admin controller data.
> >
> > Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> > MdePkg/Include/IndustryStandard/Nvme.h | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Nvme.h
> > b/MdePkg/Include/IndustryStandard/Nvme.h
> > index 9b19a2074b0d..61bf0fadc05c 100644
> > --- a/MdePkg/Include/IndustryStandard/Nvme.h
> > +++ b/MdePkg/Include/IndustryStandard/Nvme.h
> > @@ -353,7 +353,13 @@ typedef struct {
> > UINT8 Npss; /* Number of Power States Support */
> > UINT8 Avscc; /* Admin Vendor Specific Command
> > Configuration */
> > UINT8 Apsta; /* Autonomous Power State Transition
> > Attributes */
> > - UINT8 Rsvd2[246]; /* Reserved as of Nvm Express 1.1 Spec
> > */
> > + UINT16 Wctemp; /* Warning Composite Temperature
> > Threshold */
> > + UINT16 Cctemp; /* Critical Composite Temperature
> > Threshold */
> > + UINT16 Mtfa; /* Maximum Time for Firmware
> > Activation */
> > + UINT8 Hmpre[4]; /* Host Memory Buffer Preferred Size
> > */
> > + UINT8 Hmmin[4]; /* Host Memory Buffer Minimum Size
> > */
I did not see the origin patch was delivered to the mailing list. (Not sure if there is something wrong with the mail client on my side.)
One minor comment:
Do you think we can use UINT32 for definition 'Hmpre' & 'Hmmin'?
Best Regards,
Hao Wu
> > + UINT8 Tnvmcap[16]; /* Total NVM Capacity */
> > + UINT8 Rsvd2[216]; /* Reserved as of Nvm Express 1.3 Spec
> > */
> > //
> > // NVM Command Set Attributes
> > //
> > --
> > 1.9.1
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread