From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.6430.1620695980498394621 for ; Mon, 10 May 2021 18:19:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DGyNUA8p; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) IronPort-SDR: nJWuzNKJVIoxxN38ItqFPs1I2Gl3BlvMY5sxtc2w3GAoyScMKKdEp1RawTcL33PoSxBCs3Dy0d LhcYRx6OcDxw== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="263258091" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="263258091" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 18:19:38 -0700 IronPort-SDR: AA/cU7xU5oQSaKhdGn6LXTfMqm+JU/awuKY3SJDvjgWXkiO1ASrCOcLo7Pjzu6KuBGzz+Wyu8r rAS+DHVfCUlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="461620741" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 10 May 2021 18:19:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 18:19:38 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 18:19:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 10 May 2021 18:19:38 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 10 May 2021 18:19:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C595biswAD83tTrutUXGjqv3X1s86EEnXypbJhb3/CfhcB42yZ8YmwL8GgPVuSYkouVw+8DCMpmlV124tXjlZVzI6KAX1hgXixxj1dnD9lizpe7PA4Z5Ads8ZDKPH2JnztcwRlsK3GuCJV6Dr48QIKhQrgC7MJc1OewU8VC/ON+Ixjyk5JoDvZdCQ+jYul2dm6ruH8cc/0glrn1TImnnl64mBJ12ZRpxZQ61MAFQWAbNOfJdPjwHvfMpb6/owi02xju6+XdX/rJDsKAI0PTjmXtpjLIV0b2xQFCQFIENnFsX2usDO1/qnrBa++u79aT37acfuke1p9Oacll5/KwhGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yii5iiDtAGuIH68kVF973i6gL6bPxml0hKL36wGzBCw=; b=Je8SGSKC+HzzgpSxazO/x6xstYEDMMwraO33Qfa+jgyQkHj9bhqVchGvW6n50LLSBWeDdLf6B1f0gvgs6ZaNa7wVBnb6wNLDbBy7z8jtgO5ozDjIupHmhiKqeb+2/J05IR6W5PenyTxHPKT8Bur5NbwEa0Hr/TUPxnJWnP8RawhY/Tz6P3lGbl0v+0Fu7FQi9U4VRS5lHA0YN7qNMFW7P9CIb1v6wHweU/hd5iRsjdCHoWy+X9/6Ni+xc2TfMvIvRpevynb7jUXlZgBQpB0ZUA8gLdn0mg92Ci/8Ps6ngKf0i12dTi2TaGrbkN76WlcCcqE+uZx6LO+nyJtCb1Fo3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yii5iiDtAGuIH68kVF973i6gL6bPxml0hKL36wGzBCw=; b=DGyNUA8pyMy6ucakPeF/0NE6hZpjPsAx14x0YJUl83heWuPQcFXu8nw7rrJm2IILvqc829Uz1EtwabpRZm19BeMVamAlrtcMzWq3zuA4H4y+tjtdZ1roLBwPuIlJ2jl4U4nWYIK07FNOH7mY31QNOw8ZEg4mDYyuqvaNfugNMvw= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB1474.namprd11.prod.outlook.com (2603:10b6:405:c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 01:19:36 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::b9d0:5694:1b70:c031]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::b9d0:5694:1b70:c031%4]) with mapi id 15.20.4108.032; Tue, 11 May 2021 01:19:36 +0000 From: "Wu, Hao A" To: "Liu, Zhiguang" , "Gao, Zhichao" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Index: AQHXRXS/kW9BjvMMxEmaXgJ1MrggL6rcZEEAgAADQDCAARG/MA== Date: Tue, 11 May 2021 01:19:36 +0000 Message-ID: References: <20210510081532.1073-1-zhiguang.liu@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bcff2d9a-2886-4b45-ef85-08d9141ad760 x-ms-traffictypediagnostic: BN6PR11MB1474: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j8KYBWNdO1UR3Zp+DFdaF3e96DV02uSr/AH3bs+YnAzayr8RLSbQMz+43J1qvTMoKMfZVt+zCZl61/KYaQYlh6P0eCF22tIjD+kDidJwuWxhKnw+AWCMepuZ3gHUaLyr2mnIYY6dSwxhkUpe0trofgq9rGunuP/IL0Gk03AyepLEIq+bZQfkg6EcE3rMevKwOOlmvIw36gVczfXqau+HbZg2ivZg7V4uKLXDG+IPqU0wIeK0r4eSY7WWbvSUbVjLzrAOqWjC5T+91GEfE/8KuCUlgKlM4U1jDQnjhhUBzv0nd/kKZW6k5sH7hNfR9GppUgqRkzZ/2bZMJWAXO5UdSMua5yA/hbmSElvNo75g6W7TZq8Nx1fYP3JESQJpFF8PksZ+6egE6O9SR4baNO69vBkMJ/SxjdN4CuzbuQQRPIQ4jnPV3SuoGdHN+mo9AqvOyBmAEXuZRXRwIl3vvlMgCcj2QUkzFCYZ5SRSI45MLxnd751wj5y+IeGx2MPaPJXHn9JetspHeWMO0M10EsTqIjGi1DHD8raKqfPY1vooIadF/DDNoZw3KDKxRg9lrA/JLev0CTWZwtnsAvel4eu1O1rdZoCq9DIhRCphktRikSyPC9TiLwXy2FEq7RqKheVnB76eA7XcyU8OoeoQNqUia+q5xab5qh8vQGZI778RuxjNzAvKe2VsJ1adzuYZ2cFetLx0rROOptjwxz7NLQWcCj9y9X8M8Y9GBr9GzOrdLKw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39860400002)(396003)(346002)(366004)(2906002)(83380400001)(110136005)(966005)(186003)(53546011)(6506007)(5660300002)(8936002)(4326008)(52536014)(33656002)(9686003)(55016002)(478600001)(26005)(64756008)(66446008)(86362001)(8676002)(38100700002)(66556008)(66946007)(66476007)(76116006)(71200400001)(107886003)(316002)(7696005)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?GbwMAbv2M96SuiQ1rc/w5sChngnLUIPaBwwQJrkkHVazTATYk5o/kMORrSqd?= =?us-ascii?Q?4cBnfvdnCurWCDYyK3P69vslUqQZUN2hNH1I0hItkEWHDhgKy1VnQVdVxt6+?= =?us-ascii?Q?Zp9SyV0roV/othd/BVlUvE9rhFXQqPTRc8P3h/qSDNoFBW0+fU/nHw+CK3M7?= =?us-ascii?Q?DSuupiDpQQQFD0XceLIhurBFv/lHV3MIz37YaM8d8T3XKoMnw8UQ23+ozFyO?= =?us-ascii?Q?3q27pdYITA6uFNReyXltHAkfU1EBmpGe9fbiFaMstUc9F7GhX+VvpEG4eRIK?= =?us-ascii?Q?Giq/XeP8tZQ8aYMWfJ3DcaweRkJbmw+dJEfl2pUPCqU1sgjJQ1afCrjKEaBy?= =?us-ascii?Q?L7dvUF8NOA0PoboNtMOAOnfnx4SPCR0UnpIX1iNEeVTMICtF4z1p4huJzUZT?= =?us-ascii?Q?RpixYoApp7oJZ8zy//XrWVU1cWN5YB+L25NaVyuUnBNvRhjB8iX65doxDI52?= =?us-ascii?Q?dAm9dvZ12HmtoLapSQdBb9rd1O882QX2T4SObjZhmDjZ93eSgSJm+vHf2KMx?= =?us-ascii?Q?TAgf7R9/JYUdZRzY3cGvVNMi0TgGYxpoUi7HQZIVHPLGJu5WZDoFLa5pBK0t?= =?us-ascii?Q?xY7r/NcJvuPbPp6Zbyc0ER+stoeFjCPMvXl+p5P7A9HhqyUttLarIL0YAhcl?= =?us-ascii?Q?hEY4nZ/+0HY45tnU+rKhhLS4mpkaGxxynlRDZF4EoAftLyMN1fGZKlk0+Xj7?= =?us-ascii?Q?4bXK/ElzKSZgUxaBxo/O6bPF5w2EpOpKM5/CAE2O/g24hXnJ9uX27fsdLChk?= =?us-ascii?Q?J3axs+KJPLccS/EHIm0wpk9n+SSjcShYpiO686vS5UC/6O1mRNSY52EpUl/y?= =?us-ascii?Q?6ynAKyu9x+due9ba7j0C+bzF07tiekKL6q4DwFLMQA9ktzk6Zvz1qdvaZ69v?= =?us-ascii?Q?FNwMx3cWxWwatRrlBr3K38CG2qr+YWQudy9VTDlx/vxVlXc7lDT/ocPwjoeZ?= =?us-ascii?Q?ealdK/q2WSGSrz9GuETPNrgqXMKebW21MA30CXMQ09U53HFJLRuTKNHtpL0k?= =?us-ascii?Q?99uXAjl+hYnTOntrS55GLpUEWl1FNZuz0fvpWtBeR+NDwR0pQTr1NV1leTwx?= =?us-ascii?Q?HON3eLVCfS/gMiBLQXS0SIN+M+9z08hMWt1gOB4vdmMdsHJfqOx7O4vi3vNt?= =?us-ascii?Q?rZEWknvecW4javK+gHcO6Mhbz+uzvsRcE6TlQ+o25Ksw+2b+GkWdQqDbW+z5?= =?us-ascii?Q?G4AzavRqrYkVxRsWNXIRYPBV5lRJ0W4HViYT1EkM+V9IucWbi+3oPFJSfGyc?= =?us-ascii?Q?yhYzbpR9MEG8g7oLF/WH4D2B2iPKHgNg14W1CjQ6ody7YZynRNSsi5I2yIat?= =?us-ascii?Q?ICZ4RG61fQIxFCrw5FYHHaOf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcff2d9a-2886-4b45-ef85-08d9141ad760 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 01:19:36.2436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cqlGrk/rJTt7zgKdFQls7rZJRITT2x6ATsnPnnwjSmg7JxMWWj0p5ccu7rYAcDpVdOt7Khx4kMGR8G48E3GFdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1474 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Liu, Zhiguang > Sent: Monday, May 10, 2021 5:00 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Zhichao > ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu > from any fv >=20 > Hi Hao, >=20 > I don't have the data about the boot performance. > However, I think it has little impact for the originally working platform= s. > In function GetSectionFromAnyFv, It will first search section in current = FV. > If it finds the section, it will return succuss. > Only if it can't find the section, it will take extra time to search in o= ther FV. This > case won't happen in originally working platforms Thanks Zhiguang. The implementation of GetSectionFromAnyFv() will try searching the caller's= FFS first, so there should be no impact to currently working platforms. Could you help to update the function comments for BmRegisterBootManagerMen= u() to reflect this change (first searching the same FV, if fails then all = FVs). With this handled: Reviewed-by: Hao A Wu Hello Zhichao and Ray, do you have comments for this patch? Thanks in advan= ce. Best Regards, Hao Wu >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Monday, May 10, 2021 4:42 PM > > To: devel@edk2.groups.io; Liu, Zhiguang > > Cc: Wang, Jian J ; Gao, Zhichao > > ; Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > > menu from any fv > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Zhiguang Liu > > > Sent: Monday, May 10, 2021 4:16 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Wu, Hao A > > > ; Gao, Zhichao ; Ni, Ray > > > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > > menu > > > from any fv > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3384 > > > > > > Currently, UefiBootManagerLib has the below assumption: > > > Assume the BootManagerMenuFile is in the same FV as the module > > > links to this library. > > > It has some limitation now, so remove the assumption. > > > > > > Hello Zhiguang, > > > > Sorry for a question. Do you know what is the boot performance impact > > if 'GetSectionFromAnyFv()' is being used? > > Any data on the impact for originally working platforms? > > > > Best Regards, > > Hao Wu > > > > > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Zhichao Gao > > > Cc: Ray Ni > > > Signed-off-by: Zhiguang Liu > > > --- > > > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 7 +++---- > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > index 6cc34d29c0..b8df4d590f 100644 > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > @@ -2,7 +2,7 @@ > > > Library functions which relates with booting. Copyright (c) > > > 2019, NVIDIA CORPORATION. All rights reserved.-Copyright (c) 2011 - > > > 2020, Intel Corporation. All rights reserved.
+Copyright (c) 2011 > > > - 2021, Intel Corporation. All rights reserved.
(C) Copyright > > > 2015-2021 Hewlett Packard Enterprise Development LP
SPDX-License- > Identifier: > > > BSD-2- Clause-Patent @@ -2385,7 +2385,6 @@ > > > EfiBootManagerRefreshAllBootOption ( > > > This function is called to get or create the boot option for the > > > Boot > > Manager > > > Menu. The Boot Manager Menu is shown after successfully booting a > > boot > > > option.- Assume the BootManagerMenuFile is in the same FV as the > > module > > > links to this library. @param BootOption Return the boot optio= n of the > > > Boot Manager Menu @@ -2437,7 +2436,7 @@ > > BmRegisterBootManagerMenu ( > > > if (DevicePath =3D=3D NULL) { Data =3D NULL;- Status =3D G= etSectionFromFv (+ > > > Status =3D GetSectionFromAnyFv ( PcdGetPtr > > > (PcdBootManagerMenuFile), EFI_SECTION_PE32, = 0,@@ - > > > 2455,7 +2454,7 @@ BmRegisterBootManagerMenu ( > > > // // Get BootManagerMenu application's description from EFI= User > > > Interface Section. //- Status =3D GetSectionFromFv (+ Statu= s =3D > > > GetSectionFromAnyFv ( PcdGetPtr (PcdBootManagerMenuFil= e), > > > EFI_SECTION_USER_INTERFACE, 0,-- > > > 2.30.0.windows.2 > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > Groups.io Links: You receive all messages sent to this group. > > > View/Reply Online (#74859): > > > https://edk2.groups.io/g/devel/message/74859 > > > Mute This Topic: https://groups.io/mt/82714887/1768737 > > > Group Owner: devel+owner@edk2.groups.io > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > [hao.a.wu@intel.com] > > > - =3D-=3D-=3D-=3D-=3D-=3D > > >