Re: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Wednesday, July 8, 2020 10:27 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check
> issue
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
> 
> V1:
> Separate the UDF from the partition rountine array and do the check for
> every media.
> 
> V2:
> Drop V1 because it is a bug: there should not be two partition types in one
> media.
> 1. Correct the LastBlock value in MBR handler. It should be the number of
> sectors (512 bytes).
> 2. Skip the MBR check if the MBR is added for the Windows comaptiblity. We
> treat such media as ElTorito and do the check.
> 3. Fix the partition check bug: One partition type returns already started
> should be treated as success to avoid multi partition type be installed into
> same media.


Hello Zhichao,

The changes look good to me.
May I know what tests have been done for the series? Thanks.

Best Regards,
Hao Wu


> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Zhichao Gao (3):
>   MdeModulePkg/PartitionDxe: Correct the MBR last block value
>   MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM
>   MdeModulePkg/PartitionDxe: Add already start check for child hanldes
> 
>  .../Universal/Disk/PartitionDxe/Mbr.c         | 42 +++++++++++++++----
>  .../Universal/Disk/PartitionDxe/Partition.c   |  9 ++++
>  2 files changed, 44 insertions(+), 7 deletions(-)
> 
> --
> 2.21.0.windows.1