From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.453.1594271030264046273 for ; Wed, 08 Jul 2020 22:03:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tiX7pn1+; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) IronPort-SDR: bi1vVUxaHF5qkzg2ngNs4Pnew8JNCA42pzb6cAfdyX7hUz4QvgSa6HY0yZjRIR6fAk0cOXUA8r 2Bc8CscGpSoA== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="146030020" X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="146030020" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 22:03:49 -0700 IronPort-SDR: pJ2fzb1U5+kt2dxohDBT1BV5N1llfrar1mU6e6hu3sYMXTiLzX+8l/BQTLor9D1bo3RDw6A1W1 gfbZDH6OOMBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="284020147" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2020 22:03:49 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jul 2020 22:03:49 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX153.amr.corp.intel.com (10.22.226.247) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jul 2020 22:03:48 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jul 2020 22:03:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWxihi5V8FFCx/dH7MHb6pOC+lWETTnwXy0p79jygw+xFdRTTTHU8+dhsaplwfBLd+7L0diO5cBkVLoIq18R+foibzG3Difd6fYD0ktW69gl+oyAJpZIzZt3bPvcq0vaF/447zZvGw1dkODFcTMUDK0VAWr6dqkbnJECj54/+hRyu/lLO5fi/V050D08Lukp7ntLRxVA7zGr3wMukmALKmy8nONId0oHzOI6VjPk2bHCyTgjdMrr1u/cQjdhaisK+d/QMgHAyZBQ5tMzpo/EvhE3ubdrr019tfqnEgAQ3qvpwvvz5LhT6lvJkFLIvUKEA5HxzGPIQfY1lIucttNpPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUaTvVqM0wkhwggZuZPUNEsgfRi0pXb4HcZUKp3epis=; b=I2gAD2lTWAmzOyNY1MGdzTMVLfrj1kNaZTZ2vlxBSBzWk7TK/F4Y/7xQeNxKnflpnV91ox4/c7HVeZy2iV6soYB0oBehSsMd39Hri3LTFQ2O5Q7HYtiqbiqLtfyl34f9QRkqFKS/vW7EnoEcHU92U0PwdosizNTO7ir3MGQaIc/Reuy3jkMft1ReGJ8//qkJuqM2fp6QFC3/9Lf+vgM9U/Gjc6bnMPXu8wOj0xMxWmt2yd8H9kLCalQfOWYMBdoYUCqHDLY5MHhsGrJk+rcN7kOdtcFH18CIdMveIvGtAJLpHjPjmQqlXa+FqPW9UpO+o3mIhaqk8b1IieUpY815Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUaTvVqM0wkhwggZuZPUNEsgfRi0pXb4HcZUKp3epis=; b=tiX7pn1+Y04pWCRHUtMa7YiIuqGPi+p6VfXFyvM094NbKdh6jwIf3+JYu0a+Ut96IU27PhoJwAd64vwB125PNiB2UlCCa6XGyhA284QWwwddTph0MN5/fmZrkPhH3Dqg5kQV/25neLIBcEnyHlhhlVENIW08CMcZ2ut9nGuyDVw= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB3986.namprd11.prod.outlook.com (2603:10b6:405:77::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Thu, 9 Jul 2020 05:03:47 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::dd04:b759:2ef1:e86a]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::dd04:b759:2ef1:e86a%7]) with mapi id 15.20.3153.029; Thu, 9 Jul 2020 05:03:46 +0000 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Topic: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Index: AQHWVM9bZUG9RYw4fESc7hTO7Ljd/6j+srhQ Date: Thu, 9 Jul 2020 05:03:46 +0000 Message-ID: References: <20200708022722.27024-1-zhichao.gao@intel.com> In-Reply-To: <20200708022722.27024-1-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb511863-cf56-40f3-0027-08d823c57607 x-ms-traffictypediagnostic: BN6PR11MB3986: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QPDqkP9qMNhlnE0Ete9Ex/Qz5mkAWBm5WEqkew/41a2JoT4x9alRIgisyq1tTSVRWPgfWRbO5Exzn8qcjpmMS4CSqBvlBLX8bfvgqCfOmEWAeNeCJ/OuKvaDFuhBNpu41PHaDAj5wOzX8owHg3FexsmvHxPzglpk+Zht2ekvXsqwQlHlnHDQCUXMAOxlE7qalsefRldPLHcrq/hNYgblJhAQ1mKzhvvegCx0FMNBjzgJ1EeNK1Tw/MGASw4VjCyFcUJkdMoa3AJb6t+nmOYwQHnIvHJJ/bX7617Fheti4c4953pxPAi6PfPfqtWSqBLLfQGr2qLrdskAVnekLZc4jxKQDqjLJwm1RsOAITv6mzY53zDyvSivSnEAX3S45Okd/1MPin7DK+9EeZSB9KAFtQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(83380400001)(8936002)(52536014)(7696005)(2906002)(316002)(110136005)(54906003)(4326008)(55016002)(9686003)(71200400001)(66946007)(86362001)(66446008)(66556008)(8676002)(33656002)(66476007)(64756008)(76116006)(966005)(26005)(478600001)(5660300002)(53546011)(6506007)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 25EGUbSYmFhGMVlC31M1z0bxkdH5uqcnzrBWgBQTC3Xzp0SR6SkYfAOW18Q0DcxYwu4UTA1Ba0OCpYklxr68oAFN9X6rBmIdsLulvkaqeilgBzMgchAnXwOFhb5DGDq+YEMZv+nbDpHuBao1PYwESN4fcGjE8mzJi+/ygoPii4XqE2A+UCioRh25Ldrk+4FheiyMDqz0N5It4x1d6FZmYpSLqDSZMekNOLRYh6noHFY8FDN70t/UdUw+T3KZvO1CkgzO27vtq2x+oU7Jg3UtIIllSB86x/gec8NXQOArgslaJKFKfVRcWLU7HDLHhFyG7pge9EAd1NnXJvRMGOI5ox+4IbBM1oWd+aCIegmpT7eeK8BrNTAkDGS5X2EaThfiLZbxzQPmzXdkBiI+AXdV1wlHg/OcHTnWLPdhCOH+AKJcvqZrU6LHdLDF3gnLif5cP3xJmqWoaP0IcuFc8Hcm50qxaQv+UvgxiASthdVyNOWaDics7Z9S5QyYZ+w7doTr MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb511863-cf56-40f3-0027-08d823c57607 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 05:03:46.6965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wqkn7yhMerrkM4NaEy/3HpOTKC09MeJFLkKqZ8lTxDqrfWY7/ihSPQx40JiF/VkEkzWgHXNA6V4yTniEPepUOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3986 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, July 8, 2020 10:27 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition chec= k > issue >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 >=20 > V1: > Separate the UDF from the partition rountine array and do the check for > every media. >=20 > V2: > Drop V1 because it is a bug: there should not be two partition types in o= ne > media. > 1. Correct the LastBlock value in MBR handler. It should be the number of > sectors (512 bytes). > 2. Skip the MBR check if the MBR is added for the Windows comaptiblity. W= e > treat such media as ElTorito and do the check. > 3. Fix the partition check bug: One partition type returns already starte= d > should be treated as success to avoid multi partition type be installed i= nto > same media. Hello Zhichao, The changes look good to me. May I know what tests have been done for the series? Thanks. Best Regards, Hao Wu >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (3): > MdeModulePkg/PartitionDxe: Correct the MBR last block value > MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM > MdeModulePkg/PartitionDxe: Add already start check for child hanldes >=20 > .../Universal/Disk/PartitionDxe/Mbr.c | 42 +++++++++++++++---- > .../Universal/Disk/PartitionDxe/Partition.c | 9 ++++ > 2 files changed, 44 insertions(+), 7 deletions(-) >=20 > -- > 2.21.0.windows.1