From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Kun Qin <kun.q@outlook.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH v3 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance
Date: Mon, 1 Mar 2021 02:05:13 +0000 [thread overview]
Message-ID: <BN8PR11MB3666417998B6C4A47CA93D49CA9A9@BN8PR11MB3666.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR06MB310207A5A6244937633ABE03F39D9@MWHPR06MB3102.namprd06.prod.outlook.com>
> -----Original Message-----
> From: Kun Qin <kun.q@outlook.com>
> Sent: Saturday, February 27, 2021 6:52 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Wu,
> Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v3 1/7] MdePkg: MmUnblockMemoryLib: Added definition
> and null instance
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168
>
> This interface definition provides an abstraction layer for applicable drivers to
> request certain memory blocks to be mapped/unblocked for accessibility
> inside MM environment.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Signed-off-by: Kun Qin <kun.q@outlook.com>
> ---
>
> Notes:
> v3:
> - Move interface to MdePkg [Hao, Liming, Jiewen]
> - Remove Dxe prefix [Jiewen]
>
> v2:
> - Resend with practical usage. No change [Hao]
>
> MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c | 40
> ++++++++++++++++++++
> MdePkg/Include/Library/MmUnblockMemoryLib.h | 40
> ++++++++++++++++++++
> MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf |
> 29 ++++++++++++++
Hello Kun,
Could you help to add a UNI file for this library instance?
Best Regards,
Hao Wu
> MdePkg/MdePkg.dec | 5 +++
> MdePkg/MdePkg.dsc | 1 +
> 5 files changed, 115 insertions(+)
>
> diff --git
> a/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c
> b/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c
> new file mode 100644
> index 000000000000..ed9a45587b64
> --- /dev/null
> +++
> b/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c
> @@ -0,0 +1,40 @@
> +/** @file
> + Null instance of MM Unblock Page Library.
> +
> + This library provides an abstraction layer of requesting certain page
> + access to be unblocked by MM environment if applicable.
> +
> + Copyright (c) Microsoft Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Uefi.h>
> +
> +/**
> + This API provides a way to unblock certain data pages to be accessible
> inside MM environment.
> +
> + @param UnblockAddress The address of buffer caller requests to
> unblock, the address
> + has to be page aligned.
> + @param NumberOfPages The number of pages requested to be
> unblocked from MM
> + environment.
> +
> + @return EFI_SUCCESS The request goes through successfully.
> + @return EFI_NOT_AVAILABLE_YET The requested functionality is not
> produced yet.
> + @return EFI_UNSUPPORTED The requested functionality is not
> supported on current platform.
> + @return EFI_SECURITY_VIOLATION The requested address failed to pass
> security check for
> + unblocking.
> + @return EFI_INVALID_PARAMETER Input address either NULL pointer or
> not page aligned.
> + @return EFI_ACCESS_DENIED The request is rejected due to system
> has passed certain boot
> + phase.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +MmUnblockMemoryRequest (
> + IN EFI_PHYSICAL_ADDRESS UnblockAddress,
> + IN UINT64 NumberOfPages
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> diff --git a/MdePkg/Include/Library/MmUnblockMemoryLib.h
> b/MdePkg/Include/Library/MmUnblockMemoryLib.h
> new file mode 100644
> index 000000000000..adff8ddc8063
> --- /dev/null
> +++ b/MdePkg/Include/Library/MmUnblockMemoryLib.h
> @@ -0,0 +1,40 @@
> +/** @file
> + MM Unblock Memory Library Interface.
> +
> + This library provides an abstraction layer of requesting certain page
> + access to be unblocked by MM environment if applicable.
> +
> + Copyright (c) Microsoft Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef MM_UNBLOCK_MEMORY_LIB_H_
> +#define MM_UNBLOCK_MEMORY_LIB_H_
> +
> +/**
> + This API provides a way to unblock certain data pages to be accessible
> inside MM environment.
> +
> + @param UnblockAddress The address of buffer caller requests to
> unblock, the address
> + has to be page aligned.
> + @param NumberOfPages The number of pages requested to be
> unblocked from MM
> + environment.
> +
> + @return EFI_SUCCESS The request goes through successfully.
> + @return EFI_NOT_AVAILABLE_YET The requested functionality is not
> produced yet.
> + @return EFI_UNSUPPORTED The requested functionality is not
> supported on current platform.
> + @return EFI_SECURITY_VIOLATION The requested address failed to pass
> security check for
> + unblocking.
> + @return EFI_INVALID_PARAMETER Input address either NULL pointer or
> not page aligned.
> + @return EFI_ACCESS_DENIED The request is rejected due to system
> has passed certain boot
> + phase.
> +
> +**/
> +EFI_STATUS
> +EFIAPI
> +MmUnblockMemoryRequest (
> + IN EFI_PHYSICAL_ADDRESS UnblockAddress,
> + IN UINT64 NumberOfPages
> +);
> +
> +#endif // MM_UNBLOCK_MEMORY_LIB_H_
> diff --git
> a/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> b/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> new file mode 100644
> index 000000000000..4c1f3d1c8e87
> --- /dev/null
> +++
> b/MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> @@ -0,0 +1,29 @@
> +## @file
> +# Null instance of MM Unblock Page Library.
> +#
> +# This library provides an abstraction layer of requesting certain
> +page access to be unblocked # by MM environment if applicable.
> +#
> +# Copyright (c) Microsoft Corporation.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent # # ##
> +
> +[Defines]
> + INF_VERSION = 0x0001001B
> + BASE_NAME = MmUnblockMemoryLibNull
> + FILE_GUID = 9E890F68-5C95-4C31-95DD-59E6286F85EA
> + MODULE_TYPE = BASE
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = MmUnblockMemoryLib
> +
> +#
> +# VALID_ARCHITECTURES = IA32 X64
> +#
> +
> +[Sources]
> + MmUnblockMemoryLibNull.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> 3928db65d188..32a9e009c813 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -257,6 +257,11 @@ [LibraryClasses]
> #
> UnitTestHostBaseLib|Test/UnitTest/Include/Library/UnitTestHostBaseLib.h
>
> + ## @libraryclass This library provides an interface for DXE drivers to
> request MM environment
> + # to map/unblock a memory region for accessibility inside MM.
> + #
> + MmUnblockMemoryLib|Include/Library/MmUnblockMemoryLib.h
> +
> [LibraryClasses.IA32, LibraryClasses.X64]
> ## @libraryclass Abstracts both S/W SMI generation and detection.
> ##
> diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
> ce009086815f..79629e3f93ba 100644
> --- a/MdePkg/MdePkg.dsc
> +++ b/MdePkg/MdePkg.dsc
> @@ -168,6 +168,7 @@ [Components.IA32, Components.X64]
> MdePkg/Library/SmmPciExpressLib/SmmPciExpressLib.inf
> MdePkg/Library/SmiHandlerProfileLibNull/SmiHandlerProfileLibNull.inf
> MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf
> + MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>
> [Components.EBC]
> MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> --
> 2.30.0.windows.1
next prev parent reply other threads:[~2021-03-01 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210226225158.1378-1-kun.q@outlook.com>
2021-02-26 22:51 ` [PATCH v3 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance Kun Qin
2021-03-01 2:05 ` Wu, Hao A [this message]
2021-03-01 8:58 ` Kun Qin
2021-03-01 16:40 ` [edk2-devel] " Laszlo Ersek
2021-03-01 19:03 ` Kun Qin
2021-03-02 8:39 ` Laszlo Ersek
2021-02-26 22:51 ` [PATCH v3 2/7] MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface Kun Qin
2021-03-01 2:03 ` Wu, Hao A
2021-02-26 22:51 ` [PATCH v3 3/7] OvmfPkg: CI Build: Added new library for VariableSmmRuntimeDxe Kun Qin
2021-03-01 16:46 ` [edk2-devel] " Laszlo Ersek
2021-03-01 19:31 ` Laszlo Ersek
2021-03-01 19:35 ` Kun Qin
2021-02-26 22:51 ` [PATCH v3 4/7] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst Kun Qin
2021-02-26 22:51 ` [PATCH v3 5/7] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules Kun Qin
2021-02-26 22:51 ` [PATCH v3 6/7] SecurityPkg: Tcg2Smm: Added support for Standalone Mm Kun Qin
2021-02-26 22:51 ` [PATCH v3 7/7] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB3666417998B6C4A47CA93D49CA9A9@BN8PR11MB3666.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox