From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Ni, Ray" <ray.ni@intel.com>, "Bi, Dandan" <dandan.bi@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH V3] Maintainers.txt: Add reviewer for serial and disk
Date: Tue, 4 Aug 2020 01:01:43 +0000 [thread overview]
Message-ID: <BN8PR11MB3666447B1FF136353DE57908CA4A0@BN8PR11MB3666.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200803060528.23836-1-zhichao.gao@intel.com>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Monday, August 3, 2020 2:05 PM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH V3] Maintainers.txt: Add reviewer for serial and disk
Sorry, forgot to mention that please keep the newly added fields in
alphabetical order.
Also, please help to reflect the SMBIOS change in the subject as well.
With them handled,
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
There is no need to send out a new version of the patch if there is no comment
from others.
Best Regards,
Hao Wu
>
> From: "Gao, Zhichao" <zhichao.gao@intel.com>
>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> V2:
> Forget to remove the *SerailPort*.h from the common device section in V1.
> Fix it in V2.
>
> V3:
> Add the missing ':' in V2 for Disk mdoules.
> Add one more module reviewer for SMBIOS.
>
> Maintainers.txt | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt index 5504bb3d17..fe7f04831f
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -286,16 +286,27 @@ F:
> MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> R: Dandan Bi <dandan.bi@intel.com>
> R: Liming Gao <liming.gao@intel.com>
>
> +MdeModulePkg: Serial modules
> +F: MdeModulePkg/*Serial*/
> +F: MdeModulePkg/Include/*SerialPort*.h
> +R: Hao A Wu <hao.a.wu@intel.com>
> +R: Ray Ni <ray.ni@intel.com>
> +R: Zhichao Gao <zhichao.gao@intel.com>
> +
> +MdeModulePkg: Disk modules
> +F: MdeModulePkg/Universal/Disk/
> +R: Hao A Wu <hao.a.wu@intel.com>
> +R: Ray Ni <ray.ni@intel.com>
> +R: Zhichao Gao <zhichao.gao@intel.com>
> +
> MdeModulePkg: Device and Peripheral modules
> F: MdeModulePkg/*PciHostBridge*/
> -F: MdeModulePkg/*Serial*/
> F: MdeModulePkg/Bus/
> F: MdeModulePkg/Include/*Ata*.h
> F: MdeModulePkg/Include/*IoMmu*.h
> F: MdeModulePkg/Include/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*NvmExpress*.h
> F: MdeModulePkg/Include/*SdMmc*.h
> -F: MdeModulePkg/Include/*SerialPort*.h
> F: MdeModulePkg/Include/*Ufs*.h
> F: MdeModulePkg/Include/*Usb*.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> @@ -304,7 +315,6 @@ F:
> MdeModulePkg/Include/Library/PciHostBridgeLib.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> -F: MdeModulePkg/Universal/Disk/
> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
> R: Hao A Wu <hao.a.wu@intel.com>
> R: Ray Ni <ray.ni@intel.com>
> @@ -365,6 +375,7 @@ MdeModulePkg: SMBIOS modules
> F: MdeModulePkg/Universal/Smbios*/
> R: Dandan Bi <dandan.bi@intel.com>
> R: Star Zeng <star.zeng@intel.com>
> +R: Zhichao Gao <zhichao.gao@intel.com>
>
> MdeModulePkg: UEFI Variable modules
> F: MdeModulePkg/*Var*/
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2020-08-04 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:05 [PATCH V3] Maintainers.txt: Add reviewer for serial and disk Gao, Zhichao
2020-08-03 6:37 ` [edk2-devel] " Zeng, Star
2020-08-06 0:38 ` Ni, Ray
2020-08-04 1:01 ` Wu, Hao A [this message]
2020-08-04 1:16 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB3666447B1FF136353DE57908CA4A0@BN8PR11MB3666.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox