From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg BrotliCustomDecompressLib: Remove the duplicated functions
Date: Wed, 30 Dec 2020 07:15:46 +0000 [thread overview]
Message-ID: <BN8PR11MB36664CF369ACCAFF6774EEFECAD70@BN8PR11MB3666.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201230063022.1378-1-gaoliming@byosoft.com.cn>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Wednesday, December 30, 2020 2:30 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg BrotliCustomDecompressLib:
> Remove the duplicated functions
>
> The same functions have been defined in BrotliDecUefiSupport.c.
>
> Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> ---
> .../BrotliDecompress.c | 23 -------------------
> 1 file changed, 23 deletions(-)
>
> diff --git
> a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliDecompress.c
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliDecompress.c
> index 512518699e4c..53e2255f5ffd 100644
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliDecompress.c
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliDecompress.c
> @@ -7,29 +7,6 @@
> **/
> #include <BrotliDecompressLibInternal.h>
>
> -/**
> - Dummy malloc function for compiler.
> -**/
> -VOID *
> -BrDummyMalloc (
> - IN size_t Size
> - )
> -{
> - ASSERT (FALSE);
> - return NULL;
> -}
> -
> -/**
> - Dummy free function for compiler.
> -**/
> -VOID
> -BrDummyFree (
> - IN VOID * Ptr
> - )
> -{
> - ASSERT (FALSE);
> -}
> -
> /**
> Allocation routine used by BROTLI decompression.
>
> --
> 2.27.0.windows.1
>
>
>
>
>
>
prev parent reply other threads:[~2020-12-30 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 6:30 [PATCH 1/1] MdeModulePkg BrotliCustomDecompressLib: Remove the duplicated functions gaoliming
2020-12-30 7:15 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB36664CF369ACCAFF6774EEFECAD70@BN8PR11MB3666.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox