From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Liming Gao (Byosoft address)" <gaoliming@byosoft.com.cn>
Cc: "ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>
Subject: Re: [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables
Date: Mon, 19 Oct 2020 01:59:04 +0000 [thread overview]
Message-ID: <BN8PR11MB36665235C59191C7DD5FF563CA1E0@BN8PR11MB3666.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BN8PR11MB36664A985E22B1A24CECF0A2CA1E0@BN8PR11MB3666.namprd11.prod.outlook.com>
Just realized that the right mail address was used for Liming.
Please ignore the previous mail, really sorry for the noise.
Best Regards,
Hao Wu
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao A
> Sent: Monday, October 19, 2020 9:28 AM
> To: Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn>
> Cc: devel@edk2.groups.io; ard.biesheuvel@arm.com
> Subject: [edk2-devel] FW: [PATCH 0/3] MdeModulePkg: use pool allocations for
> ACPI tables
>
> Forward to Liming's latest mail address.
>
> Best Regards,
> Hao Wu
>
> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Sent: Friday, October 16, 2020 11:49 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Bi, Dandan
> <dandan.bi@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Wang, Jian
> J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Sami Mujawar
> <sami.mujawar@arm.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables
>
> Currently, the AcpiTableDxe memory allocator uses page based allocations, for
> which the only reason seems to be that it permits the use of a memory limit,
> which is necessary for ACPI 1.0 tables that need to reside in the first 4 GB of
> memory.
>
> That requirement does not exist on AArch64, and since page based allocations
> are rounded up to 64 KB multiples, this wastes some memory in a way that can
> easily be avoided. So let's use the existing 'mAcpiTableAllocType'
> policy variable, and switch to pool allocations if it is set to 'AllocateAnyPages'
>
> Example output from Linux booting on ArmVirtQemu:
>
> Before:
> ACPI: RSDP 0x0000000078510000 000024 (v02 BOCHS )
> ACPI: XSDT 0x0000000078500000 00004C (v01 BOCHS BXPCFACP 00000001
> 01000013)
> ACPI: FACP 0x00000000784C0000 00010C (v05 BOCHS BXPCFACP 00000001
> BXPC 00000001)
> ACPI: DSDT 0x00000000784D0000 0014BB (v02 BOCHS BXPCDSDT 00000001
> BXPC 00000001)
> ACPI: APIC 0x00000000784B0000 0000A8 (v03 BOCHS BXPCAPIC 00000001
> BXPC 00000001)
> ACPI: GTDT 0x00000000784A0000 000060 (v02 BOCHS BXPCGTDT 00000001
> BXPC 00000001)
> ACPI: MCFG 0x0000000078490000 00003C (v01 BOCHS BXPCMCFG 00000001
> BXPC 00000001)
> ACPI: SPCR 0x0000000078480000 000050 (v02 BOCHS BXPCSPCR 00000001
> BXPC 00000001)
>
> After:
> ACPI: RSDP 0x000000007C030018 000024 (v02 BOCHS )
> ACPI: XSDT 0x000000007C03FE98 00004C (v01 BOCHS BXPCFACP 00000001
> 01000013)
> ACPI: FACP 0x000000007C03FA98 00010C (v05 BOCHS BXPCFACP 00000001
> BXPC 00000001)
> ACPI: DSDT 0x000000007C037518 0014BB (v02 BOCHS BXPCDSDT 00000001
> BXPC 00000001)
> ACPI: APIC 0x000000007C03FC18 0000A8 (v03 BOCHS BXPCAPIC 00000001
> BXPC 00000001)
> ACPI: GTDT 0x000000007C03FD18 000060 (v02 BOCHS BXPCGTDT 00000001
> BXPC 00000001)
> ACPI: MCFG 0x000000007C03FE18 00003C (v01 BOCHS BXPCMCFG 00000001
> BXPC 00000001)
> ACPI: SPCR 0x000000007C03FF98 000050 (v02 BOCHS BXPCSPCR 00000001
> BXPC 00000001)
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
>
> Ard Biesheuvel (3):
> MdeModulePkg/AcpiTableDxe: use pool allocations when possible
> MdeModulePkg/AcpiTableDxe: use pool allocation for RSDT/XSDT if
> possible
> MdeModulePkg/AcpiTableDxe: use pool allocation for RSDP if possible
>
> .../Universal/Acpi/AcpiTableDxe/AcpiTable.h | 4 +-
> .../Universal/Acpi/AcpiTableDxe/AcpiSdt.c | 4 +-
> .../Acpi/AcpiTableDxe/AcpiTableProtocol.c | 216 +++++++++++-------
> 3 files changed, 143 insertions(+), 81 deletions(-)
>
> --
> 2.17.1
>
>
>
>
>
prev parent reply other threads:[~2020-10-19 1:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:49 [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables Ard Biesheuvel
2020-10-16 15:49 ` [PATCH 1/3] MdeModulePkg/AcpiTableDxe: use pool allocations when possible Ard Biesheuvel
2020-10-19 19:47 ` [edk2-devel] " Laszlo Ersek
2020-10-22 2:01 ` 回复: " gaoliming
2020-10-22 12:55 ` Ard Biesheuvel
2020-10-26 1:35 ` 回复: " gaoliming
2020-10-26 6:25 ` Laszlo Ersek
2020-10-26 7:42 ` Ard Biesheuvel
2020-10-27 8:45 ` 回复: " gaoliming
2020-10-27 9:05 ` Ard Biesheuvel
2020-10-27 11:07 ` Laszlo Ersek
2020-10-16 15:49 ` [PATCH 2/3] MdeModulePkg/AcpiTableDxe: use pool allocation for RSDT/XSDT if possible Ard Biesheuvel
2020-10-19 20:06 ` [edk2-devel] " Laszlo Ersek
2020-10-19 20:11 ` Laszlo Ersek
2020-10-16 15:49 ` [PATCH 3/3] MdeModulePkg/AcpiTableDxe: use pool allocation for RSDP " Ard Biesheuvel
2020-10-19 20:13 ` [edk2-devel] " Laszlo Ersek
2020-10-19 1:28 ` FW: [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables Wu, Hao A
2020-10-19 1:59 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB36665235C59191C7DD5FF563CA1E0@BN8PR11MB3666.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox