Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Tuesday, December 15, 2020 9:45 AM
> To: devel@edk2.groups.io; cheptsov@ispras.ru
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Albecki, Mateusz <mateusz.albecki@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:
> Add support for drives in RAID mode
> 
> DuetPkg was removed from edk2.
> If the change is specially for DUET use case, I am afraid we cannot accept this
> change.
> 
> Hao,
> Can this change benefit a general use case?


Hello Ray,

My understanding to the proposed PCD is that drives behind a RAID mode SATA controller can be configured to working in non-RAID mode (acting like individual drives).

As for the DuetPkg, below is a previous comment from Vitaly:
"there is no firmware preference for that (Hao: configure the controller to non-RAID mode). The firmware does not support UEFI, and we are running through DuetPkg."

Best Regards,
Hao Wu


> 
> Thanks,
> Ray
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly
> > Cheptsov
> > Sent: Friday, December 11, 2020 5:25 PM
> > To: devel@edk2.groups.io
> > Cc: Vitaly Cheptsov <cheptsov@ispras.ru>; Wang, Jian J
> > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Albecki,
> > Mateusz <mateusz.albecki@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:
> Add
> > support for drives in RAID mode
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3118
> >
> > This resolves the problem of using drivers connected to Intel G33
> > builtin SATA controller when run from DuetPkg when it can only be
> > configured in RAID mode through the firmware settings.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Mateusz Albecki <mateusz.albecki@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Vitaly Cheptsov <cheptsov@ispras.ru>
> > ---
> >  MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c
> > b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c
> > index ab06e2833c..301335c967 100644
> > --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c
> > +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c
> > @@ -324,7 +324,7 @@ SataControllerSupported (
> >      return EFI_UNSUPPORTED;
> >    }
> >
> > -  if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) {
> > +  if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) ||
> > + IS_PCI_RAID (&PciData)) {
> >      return EFI_SUCCESS;
> >    }
> >
> > @@ -465,7 +465,7 @@ SataControllerStart (
> >    if (IS_PCI_IDE (&PciData)) {
> >      Private->IdeInit.ChannelCount = IDE_MAX_CHANNEL;
> >      Private->DeviceCount          = IDE_MAX_DEVICES;
> > -  } else if (IS_PCI_SATADPA (&PciData)) {
> > +  } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) {
> >      //
> >      // Read Ports Implemented(PI) to calculate max port number (0 based).
> >      //
> > --
> > 2.24.3 (Apple Git-128)
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#68707):
> > https://edk2.groups.io/g/devel/message/68707
> > Mute This Topic: https://groups.io/mt/78875596/1712937
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> > -=-=-=-=-=-=
> >