From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.4586.1607997177309139810 for ; Mon, 14 Dec 2020 17:52:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Vc0sfdtW; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) IronPort-SDR: 9ILzw9gr5g+Hbqdl4OtnCUQSfSA6hWZAK2WQrvwHmUkgEFWeqYtZ1sWb4HQxxce47XrbET0wiV Jqe7/pE+MkMw== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="238912596" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="238912596" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 17:52:56 -0800 IronPort-SDR: s48tgDQs7Cfctz8YM4rBvIs5YT7C+/LL3J+RC774kFPElkfrqNz+aNSuUVLPES6JYO3pOAN1iF 3LHBubzZTqYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="331868524" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 14 Dec 2020 17:52:56 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 17:52:56 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 17:52:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Dec 2020 17:52:55 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Dec 2020 17:52:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eol1fcHCRNaZ619TqJM/oMK6xaAdeKlJJoBtcBWEBH9byp16S2+CT67OXDxnvcXhP68fwQIrHyIgiDXA0i/PPnqvLrerWJcHsHaynLEyNiU8t8VHCtySkW5ptgpdgqKIxwE7S4yK1PqB1f5SDJ1Tfn5VDIflrPuC5JfJmlZAwSTou5w50Y2blQYxIQrpmk68aBKF1XFnbmY7p/09cw2+zVduiymoW7cOujPzyeIiVQBZhdonCKSvzl1umHBcbiExouSsTF/pc+bFcFetTTcijcMw0LdgNMyMdk0RTtuxu56CKgjzY+ICsUMHFuGyV0SzM7sTgMklO5HClclqntlZGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P9TRVArJQq8yIm/kYUL+7UtmxtivlGeLf7yU3uPB8EA=; b=hcuO4IfZ66FZ69ConrHkVoDzkRsLpjepYFjEsoxF7om/m70InPL10hxwY7IQdlaYIvIbAigpVSXkwCnm9pyAwTBFU4+df3wbM3bIAdN82r7T+S8wqtuECoglT4lTmiuR5qundSUx+jL5ZpaH1oDofd59EeX0oUbYn1shEeDp8V1xBXy/lCwzWYb1xIwDB5Ja7QrXJcVQCiFdfLGvFP1JxxuPleb2FExiHr0euE+Asf88kPqK3jsTZx4a8Ht4KfFcJbTFo4zW0a7riZgyN/SgnjLV9OT7c2ei7ppCn/Mzb9XQYU6CjHgDNUYTYs5L0PAIBBX8HJsfvSuwrS6CM+4LKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P9TRVArJQq8yIm/kYUL+7UtmxtivlGeLf7yU3uPB8EA=; b=Vc0sfdtWopdqiHGdbOFoB0MqzXK3nhxcGaTD5jr+JnChwY6iZiiAJvtKzlaAM5FTWvBfZQ24G0hgIZ8/VqUOpBRaWvGT7qrlGgxdJAnVgYw+uu+dj139N/VCG1gQOb6KPK0darCbyt0ByyNjc77mEICi1155szmLIKK8J1rp0Z4= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN7PR11MB2660.namprd11.prod.outlook.com (2603:10b6:406:b2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.31; Tue, 15 Dec 2020 01:52:54 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::4cda:993f:ffc1:f169]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::4cda:993f:ffc1:f169%6]) with mapi id 15.20.3654.024; Tue, 15 Dec 2020 01:52:54 +0000 From: "Wu, Hao A" To: "Ni, Ray" , "devel@edk2.groups.io" , "cheptsov@ispras.ru" CC: "Wang, Jian J" , "Albecki, Mateusz" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Index: AQHWz5+xKroIEV71V06Yg+/i73UOVKn3aHAAgAAAbsA= Date: Tue, 15 Dec 2020 01:52:54 +0000 Message-ID: References: <20201211092502.21763-1-cheptsov@ispras.ru> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d739c8c9-3dcd-4f44-fd29-08d8a09c2380 x-ms-traffictypediagnostic: BN7PR11MB2660: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W5uxognMlo31YLieXZTWeGAYRE0ur7a45zAx9hQbNdLDNRfskwuaaH8a6hRIuArXkwDA1UTRVcHtjVJE66k8UeRs1BwAOLvg9NbrxrtbvPb/SdUB03UAjbHOumGbDHfLC1OseTLdYi0Y0fTAmdzkPCOPWR1NCWVY6EQJpgOaOvif9NKaSrv7E4MBvdU3JIDYnzLpCaJa73yFBckmso30fCwL8YSpVriU/Aa00le3aCbD5XO1WhEwBvIbxUAc7O6tYanPwWTY+/eTAmB8b7dD5om5lUJCxUvB39kCekVLohPG2TDOwcdxfiZwUkRragjBQLm/DGr96Hp+Uz8ucJZeKdVC7r7dYW7i3KYVOuONiOB0hxDLhz3vKIYm1yRPmqRDMfO2Vk++AV1c5wlAiiyXAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(346002)(136003)(4326008)(66476007)(53546011)(7696005)(5660300002)(33656002)(52536014)(86362001)(66946007)(66446008)(83380400001)(2906002)(8676002)(508600001)(76116006)(64756008)(71200400001)(110136005)(54906003)(8936002)(26005)(9686003)(66556008)(55016002)(186003)(6506007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?H4YMGwr+M/tnaylSgTI+nYQCuWwJVGRjob8Arg7ceBa4d/h5bj8pYlwcVRAd?= =?us-ascii?Q?aj9R8Bqp8i9amwuv7VMYsdkHgd9UI9FyriDy49zKjsMGKPu+arNWxCNMmQUb?= =?us-ascii?Q?gxsskq0+Att/mbYqAi7d+QSt3Yckga33hA9bWv71A3TMLsvkt/VjL42T9eFd?= =?us-ascii?Q?t+s2jJkHXHek3G7QMEE5wjGNfAsvPhfdJQdOZ0GsEaf9YPn2nyk86vzXo07k?= =?us-ascii?Q?QouxBT3N7vIUG3U8eBnyjKS7/7VISCa7WpakD6yzbKVe4DfBMGvgAo1+0Pjp?= =?us-ascii?Q?IWJ543SIq4O7rFpnwO5ab+gqmRE3ptXkJe1HxMYhZjHVdZayG7PYzEjTVKg+?= =?us-ascii?Q?t8zBk50Wf+v48jW/6qU5RXM002BRV0C8zTq10O5HGmln8WP85aZtOeco1Q67?= =?us-ascii?Q?UVAJ9XiAaNbZeFFadzon52WnwMY4QXvVIMCGGR2zG1/ZjKOmPdgJykNe7psV?= =?us-ascii?Q?V1FzesZjaYA1usxOGHpwFgwgn4K7hgJCjCmgXyUTTr2pVCh2SrT/J0XkSnfs?= =?us-ascii?Q?CO8vHoUSdKzDUgU8JTpwhVAnTYrBZWnMZ3bNEM80pICNFLCYkGIAwF/nZKvm?= =?us-ascii?Q?zTlZOnpSEk2ngqrR6r8fFAB9ft6XaC+XjRTRfi8vOIWRVEV4hEH3qg5kWNXo?= =?us-ascii?Q?sVqkStA6XdWPhxWj7SOYOsnfUprPgQEThEueAlfqImB0bqRGxVzRK7MWYtDi?= =?us-ascii?Q?mMZpB/zzc0Xe49OKNvJ8YBGZx47Rddm3MPoVksF1BgIH+e8ZM5V59fKihy/E?= =?us-ascii?Q?a80yBlOT4PghX9xcsrjlj4RJaRvdvSn6i62wkwltN2cHMVbJWDChO8pMs6td?= =?us-ascii?Q?UZfAVzFWFxFljJft+G1K3KClMm/gBpLAZetv/zLUI/OWg4T6JNwqjWXw5MT+?= =?us-ascii?Q?ZOgomI/5kUw8+IGPoryDzmSvcM4eRzobkMv7SQ20ErA+urEqHWXuEanABelZ?= =?us-ascii?Q?++papyWXGlflBBWypjaxeFvbLOLQMjwwaL39x2pSdVw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d739c8c9-3dcd-4f44-fd29-08d8a09c2380 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 01:52:54.2594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y5xVLt6fO6djJyXSJqT3DBRfXr8ssLTFCjFux0gIJvmmCfv5SosaAR3WGJ5e9rvCU/OoCkzf71ijevSmBNoXWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2660 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, December 15, 2020 9:45 AM > To: devel@edk2.groups.io; cheptsov@ispras.ru > Cc: Wang, Jian J ; Wu, Hao A ; > Albecki, Mateusz ; Laszlo Ersek > > Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: > Add support for drives in RAID mode >=20 > DuetPkg was removed from edk2. > If the change is specially for DUET use case, I am afraid we cannot accep= t this > change. >=20 > Hao, > Can this change benefit a general use case? Hello Ray, My understanding to the proposed PCD is that drives behind a RAID mode SATA= controller can be configured to working in non-RAID mode (acting like indi= vidual drives). As for the DuetPkg, below is a previous comment from Vitaly: "there is no firmware preference for that (Hao: configure the controller to= non-RAID mode). The firmware does not support UEFI, and we are running thr= ough DuetPkg." Best Regards, Hao Wu >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Vitaly > > Cheptsov > > Sent: Friday, December 11, 2020 5:25 PM > > To: devel@edk2.groups.io > > Cc: Vitaly Cheptsov ; Wang, Jian J > > ; Wu, Hao A ; Albecki, > > Mateusz ; Laszlo Ersek > > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: > Add > > support for drives in RAID mode > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3118 > > > > This resolves the problem of using drivers connected to Intel G33 > > builtin SATA controller when run from DuetPkg when it can only be > > configured in RAID mode through the firmware settings. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Mateusz Albecki > > Cc: Laszlo Ersek > > Signed-off-by: Vitaly Cheptsov > > --- > > MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > > b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > > index ab06e2833c..301335c967 100644 > > --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > > +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > > @@ -324,7 +324,7 @@ SataControllerSupported ( > > return EFI_UNSUPPORTED; > > } > > > > - if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) { > > + if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) || > > + IS_PCI_RAID (&PciData)) { > > return EFI_SUCCESS; > > } > > > > @@ -465,7 +465,7 @@ SataControllerStart ( > > if (IS_PCI_IDE (&PciData)) { > > Private->IdeInit.ChannelCount =3D IDE_MAX_CHANNEL; > > Private->DeviceCount =3D IDE_MAX_DEVICES; > > - } else if (IS_PCI_SATADPA (&PciData)) { > > + } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) { > > // > > // Read Ports Implemented(PI) to calculate max port number (0 base= d). > > // > > -- > > 2.24.3 (Apple Git-128) > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#68707): > > https://edk2.groups.io/g/devel/message/68707 > > Mute This Topic: https://groups.io/mt/78875596/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > >