* [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display
@ 2021-08-19 7:30 zhoucheng
2021-08-19 7:30 ` [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data zhoucheng
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: zhoucheng @ 2021-08-19 7:30 UTC (permalink / raw)
To: devel
MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data
Add the definition of Nvme total capacity in Nvme structure.
zhoucheng (2):
MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data
MdeModulePkg:Increase Nvme capacity display
MdePkg/Include/IndustryStandard/Nvme.h | 11 ++++++++++-
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 ++
2 files changed, 12 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data 2021-08-19 7:30 [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display zhoucheng @ 2021-08-19 7:30 ` zhoucheng 2021-08-20 5:32 ` [edk2-devel] " Wu, Hao A 2021-08-19 7:30 ` [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display zhoucheng 2021-08-30 3:46 ` [edk2-devel] [PATCH v1 0/2] " Wu, Hao A 2 siblings, 1 reply; 6+ messages in thread From: zhoucheng @ 2021-08-19 7:30 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu Update Nvme data structure Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> --- MdePkg/Include/IndustryStandard/Nvme.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Nvme.h b/MdePkg/Include/IndustryStandard/Nvme.h index 9b19a2074b0d..f7a1a9f6ca32 100644 --- a/MdePkg/Include/IndustryStandard/Nvme.h +++ b/MdePkg/Include/IndustryStandard/Nvme.h @@ -353,7 +353,16 @@ typedef struct { UINT8 Npss; /* Number of Power States Support */ UINT8 Avscc; /* Admin Vendor Specific Command Configuration */ UINT8 Apsta; /* Autonomous Power State Transition Attributes */ - UINT8 Rsvd2[246]; /* Reserved as of Nvm Express 1.1 Spec */ + // + // Below fields before Rsvd2 are defined in NVM Express 1.3 Spec + // + UINT16 Wctemp; /* Warning Composite Temperature Threshold */ + UINT16 Cctemp; /* Critical Composite Temperature Threshold */ + UINT16 Mtfa; /* Maximum Time for Firmware Activation */ + UINT32 Hmpre; /* Host Memory Buffer Preferred Size */ + UINT32 Hmmin; /* Host Memory Buffer Minimum Size */ + UINT8 Tnvmcap[16]; /* Total NVM Capacity */ + UINT8 Rsvd2[216]; /* Reserved as of NVM Express */ // // NVM Command Set Attributes // -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data 2021-08-19 7:30 ` [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data zhoucheng @ 2021-08-20 5:32 ` Wu, Hao A 0 siblings, 0 replies; 6+ messages in thread From: Wu, Hao A @ 2021-08-20 5:32 UTC (permalink / raw) To: devel@edk2.groups.io, zhoucheng@phytium.com.cn Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > zhoucheng > Sent: Thursday, August 19, 2021 3:31 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> > Subject: [edk2-devel] [PATCH v1 1/2] MdePkg:Update > IndustryStandard/Nvme.h with Nvme amdin controller data > > Update Nvme data structure > > Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdePkg/Include/IndustryStandard/Nvme.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Nvme.h > b/MdePkg/Include/IndustryStandard/Nvme.h > index 9b19a2074b0d..f7a1a9f6ca32 100644 > --- a/MdePkg/Include/IndustryStandard/Nvme.h > +++ b/MdePkg/Include/IndustryStandard/Nvme.h > @@ -353,7 +353,16 @@ typedef struct { > UINT8 Npss; /* Number of Power States Support */ > UINT8 Avscc; /* Admin Vendor Specific Command Configuration */ > UINT8 Apsta; /* Autonomous Power State Transition Attributes */ > - UINT8 Rsvd2[246]; /* Reserved as of Nvm Express 1.1 Spec */ > + // > + // Below fields before Rsvd2 are defined in NVM Express 1.3 Spec // > + UINT16 Wctemp; /* Warning Composite Temperature Threshold */ > + UINT16 Cctemp; /* Critical Composite Temperature Threshold */ > + UINT16 Mtfa; /* Maximum Time for Firmware Activation */ > + UINT32 Hmpre; /* Host Memory Buffer Preferred Size */ > + UINT32 Hmmin; /* Host Memory Buffer Minimum Size */ > + UINT8 Tnvmcap[16]; /* Total NVM Capacity */ > + UINT8 Rsvd2[216]; /* Reserved as of NVM Express */ Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > // > // NVM Command Set Attributes > // > -- > 2.17.1 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display 2021-08-19 7:30 [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display zhoucheng 2021-08-19 7:30 ` [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data zhoucheng @ 2021-08-19 7:30 ` zhoucheng 2021-08-20 5:32 ` Wu, Hao A 2021-08-30 3:46 ` [edk2-devel] [PATCH v1 0/2] " Wu, Hao A 2 siblings, 1 reply; 6+ messages in thread From: zhoucheng @ 2021-08-19 7:30 UTC (permalink / raw) To: devel; +Cc: Ray Ni, Hao A Wu, Liming Gao Displays the Nvme total capacity. Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> --- MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c index 95f8b18bc4f8..450d372b2faa 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c @@ -931,6 +931,8 @@ NvmeControllerInit ( DEBUG ((EFI_D_INFO, " SN : %a\n", Sn)); DEBUG ((EFI_D_INFO, " MN : %a\n", Mn)); DEBUG ((EFI_D_INFO, " FR : 0x%x\n", *((UINT64*)Private->ControllerData->Fr))); + DEBUG ((DEBUG_INFO, " TNVMCAP (high 8-byte) : 0x%lx\n", *((UINT64*)(Private->ControllerData->Tnvmcap + 8)))); + DEBUG ((DEBUG_INFO, " TNVMCAP (low 8-byte) : 0x%lx\n", *((UINT64*)Private->ControllerData->Tnvmcap))); DEBUG ((EFI_D_INFO, " RAB : 0x%x\n", Private->ControllerData->Rab)); DEBUG ((EFI_D_INFO, " IEEE : 0x%x\n", *(UINT32*)Private->ControllerData->Ieee_oui)); DEBUG ((EFI_D_INFO, " AERL : 0x%x\n", Private->ControllerData->Aerl)); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display 2021-08-19 7:30 ` [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display zhoucheng @ 2021-08-20 5:32 ` Wu, Hao A 0 siblings, 0 replies; 6+ messages in thread From: Wu, Hao A @ 2021-08-20 5:32 UTC (permalink / raw) To: zhoucheng, devel@edk2.groups.io; +Cc: Ni, Ray, Liming Gao > -----Original Message----- > From: zhoucheng <zhoucheng@phytium.com.cn> > Sent: Thursday, August 19, 2021 3:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Liming > Gao <gaoliming@byosoft.com.cn> > Subject: [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display > > Displays the Nvme total capacity. > > Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn> > Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > index 95f8b18bc4f8..450d372b2faa 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > @@ -931,6 +931,8 @@ NvmeControllerInit ( > DEBUG ((EFI_D_INFO, " SN : %a\n", Sn)); > DEBUG ((EFI_D_INFO, " MN : %a\n", Mn)); > DEBUG ((EFI_D_INFO, " FR : 0x%x\n", *((UINT64*)Private- > >ControllerData->Fr))); > + DEBUG ((DEBUG_INFO, " TNVMCAP (high 8-byte) : 0x%lx\n", > *((UINT64*)(Private->ControllerData->Tnvmcap + 8)))); > + DEBUG ((DEBUG_INFO, " TNVMCAP (low 8-byte) : 0x%lx\n", > *((UINT64*)Private->ControllerData->Tnvmcap))); Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > DEBUG ((EFI_D_INFO, " RAB : 0x%x\n", Private->ControllerData->Rab)); > DEBUG ((EFI_D_INFO, " IEEE : 0x%x\n", *(UINT32*)Private- > >ControllerData->Ieee_oui)); > DEBUG ((EFI_D_INFO, " AERL : 0x%x\n", Private->ControllerData- > >Aerl)); > -- > 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display 2021-08-19 7:30 [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display zhoucheng 2021-08-19 7:30 ` [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data zhoucheng 2021-08-19 7:30 ` [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display zhoucheng @ 2021-08-30 3:46 ` Wu, Hao A 2 siblings, 0 replies; 6+ messages in thread From: Wu, Hao A @ 2021-08-30 3:46 UTC (permalink / raw) To: devel@edk2.groups.io, zhoucheng@phytium.com.cn Series pushed via: PR - https://github.com/tianocore/edk2/pull/1930 Commit: https://github.com/tianocore/edk2/commit/443300be467d75efa749463e4f2e591cb3e25729 https://github.com/tianocore/edk2/commit/0f11537548e4500f11487c13f24d79c9f6b6499b Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > zhoucheng > Sent: Thursday, August 19, 2021 3:31 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 0/2] MdeModulePkg:Increase Nvme > capacity display > > MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data > > Add the definition of Nvme total capacity in Nvme structure. > > zhoucheng (2): > MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller > data > MdeModulePkg:Increase Nvme capacity display > > MdePkg/Include/IndustryStandard/Nvme.h | 11 ++++++++++- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 ++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > -- > 2.17.1 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-30 3:46 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-08-19 7:30 [PATCH v1 0/2] MdeModulePkg:Increase Nvme capacity display zhoucheng 2021-08-19 7:30 ` [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data zhoucheng 2021-08-20 5:32 ` [edk2-devel] " Wu, Hao A 2021-08-19 7:30 ` [PATCH v1 2/2] MdeModulePkg:Increase Nvme capacity display zhoucheng 2021-08-20 5:32 ` Wu, Hao A 2021-08-30 3:46 ` [edk2-devel] [PATCH v1 0/2] " Wu, Hao A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox