Re: [PATCH v2 3/3] PeiCore: Remove assertion when failing to load PE image

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, June 3, 2021 2:23 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Bi, Dandan <dandan.bi@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [PATCH v2 3/3] PeiCore: Remove assertion when failing to load PE
> image
> 
> EFI_PEI_LOAD_FILE_PPI is invoked by DxeIpl for loading DxeCore.
> It's possible that the instance produced by PeiCore fails to load but
> other instances of EFI_PEI_LOAD_FILE_PPI can load.


Acked-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Core/Pei/Image/Image.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/Image/Image.c
> b/MdeModulePkg/Core/Pei/Image/Image.c
> index 1d15774527..5af3895191 100644
> --- a/MdeModulePkg/Core/Pei/Image/Image.c
> +++ b/MdeModulePkg/Core/Pei/Image/Image.c
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    Pei Core Load Image Support
> 
> 
> 
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> 
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>  **/
> 
> @@ -661,9 +661,6 @@ PeiLoadImageLoadImage (
>      &ImageEntryPoint
> 
>    );
> 
> 
> 
> -  ASSERT_EFI_ERROR (Status);
> 
> -
> 
> -
> 
>    if (EFI_ERROR (Status)) {
> 
>      return Status;
> 
>    }
> 
> --
> 2.31.1.windows.1