* Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
2021-01-04 9:48 Zhong, Zarcd
@ 2021-01-06 14:27 ` Laszlo Ersek
2021-01-13 7:01 ` Ni, Ray
1 sibling, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2021-01-06 14:27 UTC (permalink / raw)
To: devel, zarcd.zhong; +Cc: Ni, Ray, Wu, Hao A
On 01/04/21 10:48, Zhong, Zarcd wrote:
> From 7518212a85269e486d06dcea927a3d34e23372c2 Mon Sep 17 00:00:00 2001
>
> From: Zarcd Zhong <zarcd.zhong@intel.com>
>
> Date: Mon, 4 Jan 2021 17:32:54 +0800
>
> Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail
> in high 32bit of MEM64.
>
> Â
>
> Â Â Â REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
>
> Â
>
> Â Â Â Clear length and alignment for low 32bit of MEM64 BAR if sizing fail
> in high 32bit.
>
> Â
>
> Â Â Â Cc: Ray Ni <ray.ni@intel.com>
>
> Â Â Â Cc: Hao A Wu <hao.a.wu@intel.com>
>
>
Please post the patch with git-send-email.
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
2021-01-14 18:13 ` Kim, Andrew
@ 2021-01-15 9:00 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2021-01-15 9:00 UTC (permalink / raw)
To: devel, andrew.kim, Zhong, Zarcd; +Cc: Wu, Hao A, Kinney, Michael D, Ni, Ray
Andrew, Zarcd,
if you plan to exchange messages through the list repeatedly and/or over
the longer term, then:
- welcome to the list!
- please do accept the invites that I sent to you guys, and join the
list as actual subscribers. Having to approve your messages one by one
gets old *real fast*.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
[not found] <3149>
@ 2021-01-15 9:34 ` nmd5434
2021-01-15 9:39 ` Zhong, Zarcd
2021-01-18 1:12 ` [edk2-devel] " Wu, Hao A
0 siblings, 2 replies; 6+ messages in thread
From: nmd5434 @ 2021-01-15 9:34 UTC (permalink / raw)
To: devel; +Cc: Zarcd Zhong
From: Zarcd Zhong <zarcd.zhong@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
Address MEM64 BAR in type unknown if sizing fail in high 32bit.
L: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 1b64924b7b..a24065e8ba 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -1686,6 +1686,7 @@ PciIovParseVfBar (
);
if (EFI_ERROR (Status)) {
+ PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
return Offset + 4;
}
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
2021-01-15 9:34 ` [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64 nmd5434
@ 2021-01-15 9:39 ` Zhong, Zarcd
2021-01-18 1:12 ` [edk2-devel] " Wu, Hao A
1 sibling, 0 replies; 6+ messages in thread
From: Zhong, Zarcd @ 2021-01-15 9:39 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Ni, Ray, Wu, Hao A
Hi All,
Below mail is sent by GIT send-email. Please help to push it to EDKII. Thanks.
-----Original Message-----
From: nmd5434 <nmd114@sina.com>
Sent: Friday, January 15, 2021 5:34 PM
To: devel@edk2.groups.io
Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
From: Zarcd Zhong <zarcd.zhong@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
Address MEM64 BAR in type unknown if sizing fail in high 32bit.
L: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 1b64924b7b..a24065e8ba 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -1686,6 +1686,7 @@ PciIovParseVfBar (
);
if (EFI_ERROR (Status)) {
+ PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
return Offset + 4;
}
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
2021-01-15 9:34 ` [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64 nmd5434
2021-01-15 9:39 ` Zhong, Zarcd
@ 2021-01-18 1:12 ` Wu, Hao A
2021-01-18 1:44 ` Wu, Hao A
1 sibling, 1 reply; 6+ messages in thread
From: Wu, Hao A @ 2021-01-18 1:12 UTC (permalink / raw)
To: devel@edk2.groups.io, nmd114@sina.com; +Cc: Zhong, Zarcd
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> nmd5434
> Sent: Friday, January 15, 2021 5:34 PM
> To: devel@edk2.groups.io
> Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle
> BAR sizing fail in high 32bit of MEM64.
>
> From: Zarcd Zhong <zarcd.zhong@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
>
> Address MEM64 BAR in type unknown if sizing fail in high 32bit.
>
> L: devel@edk2.groups.io
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
Found that there is no "Signed-off-by:" tag.
Will add the tag when pushing this change.
Best Regards,
Hao Wu
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 1b64924b7b..a24065e8ba 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -1686,6 +1686,7 @@ PciIovParseVfBar (
> );
>
> if (EFI_ERROR (Status)) {
> + PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
> return Offset + 4;
> }
>
> --
> 2.16.2.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64.
2021-01-18 1:12 ` [edk2-devel] " Wu, Hao A
@ 2021-01-18 1:44 ` Wu, Hao A
0 siblings, 0 replies; 6+ messages in thread
From: Wu, Hao A @ 2021-01-18 1:44 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A, nmd114@sina.com
Cc: Zhong, Zarcd, Ni, Ray, Laszlo Ersek
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Monday, January 18, 2021 9:12 AM
> To: devel@edk2.groups.io; nmd114@sina.com
> Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe:
> Handle BAR sizing fail in high 32bit of MEM64.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > nmd5434
> > Sent: Friday, January 15, 2021 5:34 PM
> > To: devel@edk2.groups.io
> > Cc: Zhong, Zarcd <zarcd.zhong@intel.com>
> > Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle
> > BAR sizing fail in high 32bit of MEM64.
> >
> > From: Zarcd Zhong <zarcd.zhong@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3149
> >
> > Address MEM64 BAR in type unknown if sizing fail in high 32bit.
> >
> > L: devel@edk2.groups.io
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>
> Found that there is no "Signed-off-by:" tag.
> Will add the tag when pushing this change.
Patch pushed via:
PR - https://github.com/tianocore/edk2/pull/1360
Commit - https://github.com/tianocore/edk2/commit/a7ef2a03b96c464c776a139c104471fb2b84e39b
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> > ---
> > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > index 1b64924b7b..a24065e8ba 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > @@ -1686,6 +1686,7 @@ PciIovParseVfBar (
> > );
> >
> > if (EFI_ERROR (Status)) {
> > + PciIoDevice->VfPciBar[BarIndex].BarType = PciBarTypeUnknown;
> > return Offset + 4;
> > }
> >
> > --
> > 2.16.2.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-18 1:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <3149>
2021-01-15 9:34 ` [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Handle BAR sizing fail in high 32bit of MEM64 nmd5434
2021-01-15 9:39 ` Zhong, Zarcd
2021-01-18 1:12 ` [edk2-devel] " Wu, Hao A
2021-01-18 1:44 ` Wu, Hao A
2021-01-04 9:48 Zhong, Zarcd
2021-01-06 14:27 ` [edk2-devel] " Laszlo Ersek
2021-01-13 7:01 ` Ni, Ray
2021-01-14 2:47 ` Zhong, Zarcd
2021-01-14 5:58 ` Ni, Ray
2021-01-14 6:31 ` Zhong, Zarcd
2021-01-14 17:37 ` Kim, Andrew
2021-01-14 18:13 ` Kim, Andrew
2021-01-15 9:00 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox