Re: [edk2-devel] [PATCH v13 01/46] MdeModulePkg: Create PCDs to be used in support of SEV-ES

["Wu, Hao A" <hao.a.wu@intel.com>]

Really sorry for the late response.
Two minor inline comments below. With them addressed,
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Lendacky, Thomas
> Sent: Friday, July 31, 2020 2:43 AM
> To: devel@edk2.groups.io
> Cc: Brijesh Singh <brijesh.singh@amd.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>; Dong, Eric <eric.dong@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2-devel] [PATCH v13 01/46] MdeModulePkg: Create PCDs to be
> used in support of SEV-ES
> 
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> 
> Two new dynamic MdeModulePkg PCDs are needed to support SEV-ES under
> OVMF:
>   - PcdGhcbBase:       UINT64 value that is the base address of the GHCB
>                        allocation.
>   - PcdGhcbSize:       UINT64 value that is the size, in bytes, of the
>                        GHCB allocation (size is dependent on the number of
>                        APs).
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 9 +++++++++
> MdeModulePkg/MdeModulePkg.uni | 8 ++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index d7572eedd18c..882f3fb28506
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2063,6 +2063,15 @@ [PcdsDynamic, PcdsDynamicEx]
>    # @Prompt If there is any test key used by the platform.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE|BOOLEAN|0x00
> 030003
> 
> +  ## This dynamic PCD holds the base address of the GHCB pool allocation.


Could you help to use the full name 'Guest-Hypervisor Communication Block' for
GHCB in the above description for PcdGhcbBase? For PcdGhcbSize, similar comment
applies.


> +  # @Prompt GHCB Pool Base Address
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0|UINT64|0x00030007
> +
> +  ## This dynamic PCD holds the total size of the GHCB pool allocation.
> +  #  The amount of memory allocated for GHCBs is dependent on the
> number of APs.
> +  # @Prompt GHCB Pool Size
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0|UINT64|0x00030008
> +
>  [PcdsDynamicEx]
>    ## This dynamic PCD enables the default variable setting.
>    #  Its value is the default store ID value. The default value is zero as
> Standard default.
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni index 5235dee561ad..1d2a50e23623
> 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1303,3 +1303,11 @@
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_P
> ROMPT #language en-US "TCG Platform Firmware Profile revision"
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_
> HELP #language en-US "Indicates which TCG Platform Firmware Profile
> revision the EDKII firmware follows."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_PROMPT
> #language en-US "GHCB Pool Base Address"


Similarly, could you help to use the full name for GHCB for the above
description for PcdGhcbBase in UNI file? Same applies for PcdGhcbSize as well.

Best Regards,
Hao Wu


> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_HELP
> #language en-US "Used with SEV-ES support to identify an address range that
> is not to be encrypted."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT
> #language en-US "GHCB Pool Base Size"
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP
> #language en-US "Used with SEV-ES support to identify the size of the
> address range that is not to be encrypted."
> --
> 2.27.0
> 
> 
>