From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.5279.1596433001090555521 for ; Sun, 02 Aug 2020 22:36:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s1ELnZ6a; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) IronPort-SDR: 9squTAC4neJbitDrOBhyYutlSNsgTWEprmJjD01TSMGTVJPfhBh3OuygQECKJ7NT/A9fpkTeZH 72El1HU6D/bw== X-IronPort-AV: E=McAfee;i="6000,8403,9701"; a="139999301" X-IronPort-AV: E=Sophos;i="5.75,429,1589266800"; d="scan'208";a="139999301" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 22:36:39 -0700 IronPort-SDR: nWMgamP4SA5B5Z129qylrnsTXFggljgUWDsX0ggqJH8xdERIcaUsTjFIo+GcmIE5g2wMWcwvCd EHjJMkhRCmZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,429,1589266800"; d="scan'208";a="466360257" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 02 Aug 2020 22:36:39 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 2 Aug 2020 22:36:38 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 2 Aug 2020 22:36:38 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 2 Aug 2020 22:36:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ah7/h71cPvJKrkruu4zv7wL9B3ovyl91EFcyzK04TwCPak2BStbGlvK9AnX4Ns/olNMJ3YPrdhZumcM+hqCyNQPKXnxxpSBTXPbU2qUOR6zjx02uJ60VTlnFESUZDh5mxr4JMrBSzg6eXlujkoaRuGjry5EDnD7Ll6qirAJ/rrXLoDbPyE503AFIaQOAaH9zxL+K5eBP4LzC4w3BKUNHjjWdOl1JSdg0PhIJ448o1o+AtcOta+7u5g9hQAPUTwqFhOcTs5Ox3tGpEFTrnvHidtmhj0aVnY6mPRx43p0z4gb7TfjHKvojsu7SeGuDpqS6m9xF6F2ePYrpYhlnc0HiFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZpcagZQcuGvgMSL+wJdBA2y1b4RqAVC5tyZZzYH2Kz4=; b=HKcA9fdJqET/jKRRpO9FZmTXIyLGkdoXLlLALnfgYCZQGEfW9bLdzg1ziPSUKLRffIp8v1dQctNP7C8KA80FfWiE0YH7L1c/IAHkbOZs5yipJjI1sHkcTx6JgvSof+p1JL+aB9xXsSEUKJpxSL1j3GO6aR2ERnmo6gCKY0GMNT2BgaGC0WlUkNJN4C2nx3dNOOmCB2Ut0kjSIO1AuKfXoO9qZ+sOZnrVOh+UEsH54/zY8fZxVc8cScesBppNHpDxcM87PXHP+X8l5nvztoaMMBJy8xrENfLzv0NHWlh+JI0iJvNRSHvrqWP99TtOy15YhXVFgYxcus+vjCwMNld8Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZpcagZQcuGvgMSL+wJdBA2y1b4RqAVC5tyZZzYH2Kz4=; b=s1ELnZ6a6GC3srv07PxwWLO2wpBVJwTeX+sW6fyuwoPY6YgleLKBV6/A3m4SIngzsHPYMzXwdSlKOa8c2BVYRrLRptcwBkKIHy/DzPA1ZMIeN8lw/6jNRJZiSj3P5/s3bfuQX+JnbqrOyuIeMEO8aEvSAZLVn6AlYBKnxMpyKOw= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN8PR11MB3617.namprd11.prod.outlook.com (2603:10b6:408:82::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16; Mon, 3 Aug 2020 05:36:33 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::78b6:7108:8852:7536]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::78b6:7108:8852:7536%7]) with mapi id 15.20.3239.021; Mon, 3 Aug 2020 05:36:33 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "thomas.lendacky@amd.com" CC: Brijesh Singh , Ard Biesheuvel , "Dong, Eric" , "Justen, Jordan L" , Laszlo Ersek , "Gao, Liming" , "Kinney, Michael D" , "Ni, Ray" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v13 01/46] MdeModulePkg: Create PCDs to be used in support of SEV-ES Thread-Topic: [edk2-devel] [PATCH v13 01/46] MdeModulePkg: Create PCDs to be used in support of SEV-ES Thread-Index: AQHWZqF5c0zEow1JW0ybldPlMdhFMqklqmcg Date: Mon, 3 Aug 2020 05:36:32 +0000 Message-ID: References: <5165cd142314eb080a7250733cf66b045eb9bf24.1596134638.git.thomas.lendacky@amd.com> In-Reply-To: <5165cd142314eb080a7250733cf66b045eb9bf24.1596134638.git.thomas.lendacky@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47be4cb7-1ff1-400f-abea-08d8376f2e46 x-ms-traffictypediagnostic: BN8PR11MB3617: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9fPmCpj8SvDXi9gYv4t8QnSUONj10dd0ZH0E3rQFz0locNlNDnFrZ6VodaQDgo13W8ITU3pOG46Jb3SowZkLxr2sxXa9AFEmIgF0+QE6r/jllwxK+p2pqpupVCtUtzggW8xUXjY7X4EqztAMZAUJQX/sDLBWI5Ks5d7WI0sgriZJw5w1eFw87kkER3XjBKdmEZowglr2RgI1ZHV74CfNTXS5Spi03A9qTZWvUVUzDlHf7HvqD6r3I49A60WRKLFx5VRfbKRxobPO+2M56aDg/CGuZUzNhSuU8gpknfR+4Bcb9I3cRMNsM1uIFrLfgV4FWrijLhofcjetLTMNoNKrToLyrM+zpHMg5t1o7QfvQwBYq1WzbzzcQ9WAA7R/qDV4R+xyrXM4h/rtd/r15NW0Kg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(366004)(346002)(39860400002)(396003)(5660300002)(52536014)(55016002)(66446008)(9686003)(66946007)(86362001)(76116006)(66476007)(83380400001)(66556008)(64756008)(53546011)(54906003)(2906002)(316002)(110136005)(71200400001)(478600001)(107886003)(8936002)(26005)(7696005)(8676002)(186003)(33656002)(4326008)(6506007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: whiP/HziULYK3vgNAesm42WV9ut1pTnTXBk6oNK5Mh+x35VoqMWBF4msbKi/fc2RHhWVbDRyiBsYnfxOyfkzJY355Hge4kQhNUiWGz6NdKQlltNtgr15AOAFTxtuvK9ZQBhc2MJUuQsXU4luvojQ+aI3JXTgnqZ7Trv2oFwFp2cjh0fkHB1Rfcf1kG61Z6iA3Ls8HS9kpxGoJ1U2xNO0Se+JIq07M25Pu/+myLX/6Rns2hxudsAB5vz+WyFlowKWRsRkP2BqFKMjMh94uxtuHTr8lAxwYCTeM5OHzwGKViYcig4uUrdb+XxWIp78Gka62N2+2K8X9BSO7DvGPc+K2DJNFqESTScM+2UGJC9KKlWafz158gJ/SQaSbzg20yAjsCsvydVkkdCNRuiN2wTg2g2+fX5LHDtG+VLwVGWMTQ5acyT/nsRIVUgjM7TX1pg+SCHm3pg6AKo5p+R9/6YiF84AtmX4Ljs8NDtV8HUFQndgv8KqlawlEwQpM1U4hkMnn4TeCUXGMSDOgLLGgbx/XnXgiu9VpIsajHgtSZnGgFG4CPCpDXFkG7NlQkEDb/ZNTeb0jphncX/piZBeBKJMil/x6MIyJcl627KXEKmI1Pf6UPz0sm7pcZyz36lwHVn0O66KM9K3u3OuzRGTShvebQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47be4cb7-1ff1-400f-abea-08d8376f2e46 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2020 05:36:32.9726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gz1AbFXWiAsSlSF0HoVmZrm1qfDKsmBulraM0KZt2so0py2nrOeTzr1USMp9C/F1tqvT5G6FReK6PA3wIOAJTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3617 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Really sorry for the late response. Two minor inline comments below. With them addressed, Reviewed-by: Hao A Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Friday, July 31, 2020 2:43 AM > To: devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Dong, Eric ; Justen, > Jordan L ; Laszlo Ersek ; > Gao, Liming ; Kinney, Michael D > ; Ni, Ray ; Wang, Jian J > ; Wu, Hao A > Subject: [edk2-devel] [PATCH v13 01/46] MdeModulePkg: Create PCDs to be > used in support of SEV-ES >=20 > From: Tom Lendacky >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 >=20 > Two new dynamic MdeModulePkg PCDs are needed to support SEV-ES under > OVMF: > - PcdGhcbBase: UINT64 value that is the base address of the GHCB > allocation. > - PcdGhcbSize: UINT64 value that is the size, in bytes, of the > GHCB allocation (size is dependent on the number = of > APs). >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Tom Lendacky > --- > MdeModulePkg/MdeModulePkg.dec | 9 +++++++++ > MdeModulePkg/MdeModulePkg.uni | 8 ++++++++ > 2 files changed, 17 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index d7572eedd18c..882f3fb28506 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2063,6 +2063,15 @@ [PcdsDynamic, PcdsDynamicEx] > # @Prompt If there is any test key used by the platform. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE|BOOLEAN|0x00 > 030003 >=20 > + ## This dynamic PCD holds the base address of the GHCB pool allocatio= n. Could you help to use the full name 'Guest-Hypervisor Communication Block'= for GHCB in the above description for PcdGhcbBase? For PcdGhcbSize, similar co= mment applies. > + # @Prompt GHCB Pool Base Address > + gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0|UINT64|0x00030007 > + > + ## This dynamic PCD holds the total size of the GHCB pool allocation. > + # The amount of memory allocated for GHCBs is dependent on the > number of APs. > + # @Prompt GHCB Pool Size > + gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0|UINT64|0x00030008 > + > [PcdsDynamicEx] > ## This dynamic PCD enables the default variable setting. > # Its value is the default store ID value. The default value is zero= as > Standard default. > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni index 5235dee561ad..1d2a50e23623 > 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1303,3 +1303,11 @@ > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_P > ROMPT #language en-US "TCG Platform Firmware Profile revision" >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_ > HELP #language en-US "Indicates which TCG Platform Firmware Profile > revision the EDKII firmware follows." > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_PROMPT > #language en-US "GHCB Pool Base Address" Similarly, could you help to use the full name for GHCB for the above description for PcdGhcbBase in UNI file? Same applies for PcdGhcbSize as w= ell. Best Regards, Hao Wu > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_HELP > #language en-US "Used with SEV-ES support to identify an address range t= hat > is not to be encrypted." > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT > #language en-US "GHCB Pool Base Size" > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP > #language en-US "Used with SEV-ES support to identify the size of the > address range that is not to be encrypted." > -- > 2.27.0 >=20 >=20 >=20