From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.7121.1604455058844954822 for ; Tue, 03 Nov 2020 17:57:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LW2KNPUq; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) IronPort-SDR: 6yoPeWjnFj+s+5IUhAyi0w9er2ls9CSyhzYZqUXQF8mhUwIXK7FFDgjeKPa1dqz+SJLpXqEZWi 98s+2Cl3vooA== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="149005263" X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="149005263" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 17:57:37 -0800 IronPort-SDR: M0nhPZKsLiGaHCbybyUTVBz3Lm1U1zI/SJEIaio20UdR+jF1cBCkklboi+dfn2HihDIWTjS4ox qW4ajo4dfVJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="352514376" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 03 Nov 2020 17:57:37 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 17:57:37 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Nov 2020 17:57:37 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 3 Nov 2020 17:57:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fj385CPijBMXprBpfGzBMftphzILGMVbXBpFcnCc0pjS0/QDHCfys0KzGr5s6l+R8na25WeJ/Aok64aK3umQFFH/nK8M6a8DMSIpCi9H0ogIxv3+TflhK56bPg3M1cD1MI1nq0j1AKMl/KF+wUwyNBXfyxfY0mBPbbYTEMt1rMo1NHdpzstUXRQd1tb7D1+e2s4g8wwsf10MBNxMfiKw5XlxKOk5t9xD9tRLafbX6+K2NILMNyPm7WJ2pRWuUX0F5HYM8cqpipgnFBf+MmNeclEfBh3erCwuDy6SoyLDLCjuPi4GivklnoAjREg4hD3GkWAHMkDZD54yRN+kTh+wgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MWXsmeW3KesRJpH0+T0HyvsYeeTE3BNDoLKL5ineJLo=; b=YT5JRcAosupxpAk8aI0FbY5CQMrZQ3Gwclvn9/62fOMcoyMLYu5tYa4qBhg09cIDm1zkKFkqH4XPiaCQSaNBP/d+HNQxEgTbr4Ci/84LRt+ThBLIyRcQ5Te/QBM6YRm4orteNRjekWH32PFQEyWvaoy7L+QtnWA9Yb5vnSMdiaz8Xwh9b6fyjbOBxxq9zKK1OOG7qU0kjxNyFwyhArz1IG/wvOhko1ftU420dgLMNV1DcanqRqXda26Ro9T16Iluoa/4+WxhFubOjsyTSzdUQIVai2CebU4tUXlBfG48zQoiPOfvgvOnmmx4mW1cc01+ziQOTw8OEMSECcpygea2zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MWXsmeW3KesRJpH0+T0HyvsYeeTE3BNDoLKL5ineJLo=; b=LW2KNPUqtvhMoLWzmXFFd9E+PxoigllSFs2qmljQfwc7JOLIocv711EnWits3uuiRraY5BboWBfsJvL3yC7vzCac5/NWnze5CRBSjB30peBSd87GHZ2Xsp/AhGEDnZQxz71VuLV4UC7HDBhVSRS8TGMNc9e5OV6YJd0hZRMSQYQ= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR1101MB2241.namprd11.prod.outlook.com (2603:10b6:405:51::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 4 Nov 2020 01:57:35 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::c123:faac:1da3:f807]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::c123:faac:1da3:f807%5]) with mapi id 15.20.3499.032; Wed, 4 Nov 2020 01:57:35 +0000 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery Thread-Topic: [PATCH 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery Thread-Index: AQHWseSYM5HBybNeFk2UOgDXlcxmiam3Nw9g Date: Wed, 4 Nov 2020 01:57:34 +0000 Message-ID: References: <20201103132348.2916-1-mateusz.albecki@intel.com> In-Reply-To: <20201103132348.2916-1-mateusz.albecki@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1f5b68a-272d-42e2-afc1-08d88064ffe3 x-ms-traffictypediagnostic: BN6PR1101MB2241: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:207; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +5FWojqtPj14BaDDCCGwEBgu+y1IKw44pAoldQBj+PHTMln3WOxp8V38EvlBlBJafQsyy4gL2KntkxF6yDc2IUY27D7qpc/5rrgHPitVX4AYe3gh27QrtDcI2SL7GiaYgf7PB3bgOnd6al3YVyd+ma4soIrk0azX65nEHUquptuCplNQp4ISBCwckygqGguiT7/lZHPxSk3P1MnSepySSyUEMyJpsX3EAfnVIUHTRlM3vnXCitfXJD4mMfkYC7FY5FguP7wJaaXZWjQzPNyJb8zA1dZwrQBdBovnXwCXdxQ5+0/J3DK7MwBObU8PYH7gMZNt/u5BMHNBCxgcVx7k85OhtPR9kkdTfhs7/HsHFHOKfWhUR5yLbEyXAQA4czJSe/+6ed0veojqOLRzZoWbew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(110136005)(33656002)(26005)(186003)(55016002)(316002)(83380400001)(966005)(71200400001)(8676002)(86362001)(9686003)(8936002)(6506007)(66946007)(66556008)(52536014)(2906002)(107886003)(5660300002)(53546011)(66446008)(66476007)(64756008)(478600001)(76116006)(4326008)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: kkZGAqgw3wVXU+7VJ+oLJDx+dW14A7Mn7WjT7GtXSO097T2wYKrCZOXvedcJJXMk8ior/F6YeOshVQsUCpT2pCAC4LyOw15FdONot8dsrkp1NXe3/TIrY4krM6t1IfYcQSQUfR3WAeXPelARUVAZea9YWQFzdH2r0VMA+QQwrg0viHrg5OZ9G1b6uYBNTmVUuB2vcWsybY1I+M4Pqv89iO4PikhHtk6iYZ0VqBqttVRrt1q03Va+N3DCSfKqTERo5G5yfYm+Ss5Od52zlwufI0joIT9E1xZNn8pOSDAj1iGsZMtvTJNEEwI2GP1Nb5AY/rxAeBx2Cxb8iiNrbcHjII9t6FOQZ34EepHuqPzqrZSo4x7vgXibTptw/DiT04t8qMWDIXjqUGe7EWjDkvWH6oA62arzVwCJDCRnVEFcvT7JH11yq9ao+EgZyZ07sthtUtszg17XjeUHQCtXM4OpUijDr2ovFcwIbatIEBMu0Ubsmozwzs514T4s7a9+TYFCcQDbkpKYfm+C2FdL8IKB7NqsgA2Y4DFfDmzYCmqsYz/XV3mfpLRJlWZHUgYquAdmxmdMYXFl2n+llxwsf8yKpS0IwylvhTrEByyk8VTZSkyMH53/5x0I/JP9/MXTrw3Lw3WRSMyxmKYXUN3nfKSHrQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1f5b68a-272d-42e2-afc1-08d88064ffe3 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2020 01:57:35.0092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tsdnMW/LFUb2vr47GHx6FgINo4DW7VWvJOfYsizRULiY9c5c2N8qkIiw4UxYMwgbx1wUMS/NXtPqGi8hiMex6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2241 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Tuesday, November 3, 2020 9:24 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Ni, Ray > ; Wu, Hao A > Subject: [PATCH 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error > recovery >=20 > To increase boot stability when booting from SATA drives SATA driver shou= ld > implement the AHCI spec defined port error recovery. This will allow the > driver to handle random fails on SATA link. >=20 > Performed tests on 2 setups. One with AHCI controller booting OS > successfully without error recovery(control setup) and other which fails = 1 in 5 > times(fail setup). >=20 > Tests performed: > 1. Booted control setup to OS successfully. > 2. Checked if during normal boot none of the packets is repeated(this cam= e > up after previous code version had a bug which repeated each DMA packet 5 > times). Some more information: For the bug mentioned above in point 2, the discussion can be referred here= : https://github.com/malbecki/edk2/commit/9ea81cadf38725e194ec01e0b0c556fd133= f3ced#r43226067 For the other discussion we did before this patch, please refer to: https://github.com/malbecki/edk2/commits/sata_recovery Best Regards, Hao Wu > 3. Booted control setup to OS with simulated errors appearing on first pa= cket > of every DMA transaction. > 4. Performed extensive tests on fail setup. Fail rate decreased from 20% > failure to ~1% failure. 1% failure is observed during OS execution, not B= IOS so > in a way boot is 100% stable). >=20 > Change pushed to github: > This series: > https://github.com/malbecki/edk2/commits/sata_recovery2 > Simulated errors: > https://github.com/malbecki/edk2/commits/sata_recovery_simulated_erro > r >=20 > Signed-off-by: Mateusz Albecki >=20 > Cc: Ray Ni > Cc: Hao A Wu >=20 > Albecki (4): > MdeModulePkg/AtaAtapiPassThru: Check IS to check for command > completion > MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery flow > MdeModulePkg/AtaAtapiPassThru: Restart failed packets > MdeModulePkg/AtaAtapiPassThru: Trace ATA packets >=20 > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 801 +++++++++++------- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 16 +- > 2 files changed, 532 insertions(+), 285 deletions(-) >=20 > -- > 2.28.0.windows.1