From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.26713.1618194227044375408 for ; Sun, 11 Apr 2021 19:23:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wjBfA7Bg; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) IronPort-SDR: a/K7ehW1qvKEqXpg7vhBh1UtxuOVhKABFfs6VZOVMx4IRolNhn7UXHNSUkHC8hNcISYHEx11Pw /YpdUdivFWDg== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="255418637" X-IronPort-AV: E=Sophos;i="5.82,214,1613462400"; d="scan'208";a="255418637" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2021 19:23:46 -0700 IronPort-SDR: tX5QaaEVtS059U9C2u3DNeNP4Zdum4Yt9jhm2wZsfeTQaq/JJb8NFchIZ+aiE4a/BhScq2ilFc hfcoCFaEoQLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,214,1613462400"; d="scan'208";a="417169645" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 11 Apr 2021 19:23:45 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 11 Apr 2021 19:23:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 11 Apr 2021 19:23:45 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 11 Apr 2021 19:23:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+a8BU7Ct3v31b6u9ihR6HkcIhdybq/qElOITTpXx/KldxWy2N+fVpR13Vim9dfM1FnQ43OnYNd+ZG1xIK0AChqF5xhNkaCceRQ+QjgyPWTeSv7gRRj+Xamdxj3Mrs4t2eAtluqFzV/+IEA24AOhflEHtBVohXqEHUPRYVgddKwKeXolnTn6P9pTMH5gkMJw86NGu/YHO8TUXOZDKx+19D3kxFz9sgn5RBz018t7JVBGD3ewz6sUmjImyvPi0jN3OWuVjDWaR1ExNcB4YKvWD4rJyUdunMwYil5P+UT0BpfRwlVLZSfN+ZUTx0SKRoHLcg67l96fzis4wS01M8t0Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IoyA7D63EgYPKsFKcyoycuLCERg9FdPsDYDwWOBpB8s=; b=AJyVmbBYMGVtIMhE8ghp+kSJCGhDOb7uiuPYnWHp506Fo/2qDAPQZHFpo2ssnmXSLo4/IFy8HoSMslUihkw13dR0Ee3I2V8GMAcaLoe4n3tSssFMdRn21bxEULWdl7JMLH/XP8vxOsEQC6+PiRdPVXibzkXFG9f/yCmFCtOVeG6Z0TZO+vCW/7uHqo325lWdqO36nP3asrkYVSNAGd/w+FvYrMLRUGOXp9aAsfVq1WoxCAFROcn/Dw7LvtTi956pHDKRu5/WWvSHDAJ0aB6pw+mhDOB0EPFlhn4t0bP6Nx/uBwrT8K8EoauN/+xN13eAHd+1ZmvP3jKzA3u5yUu5jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IoyA7D63EgYPKsFKcyoycuLCERg9FdPsDYDwWOBpB8s=; b=wjBfA7BgUhksqRBCHrHinHtLda3xdyiswyx5cBKdRVh2kIuaol7F0S/RSKOmqEH3KUdN9v75PU6W1aeycMc0C6TjX6AEvOQQnySNZIqTI7z6pRah9oLwn8SFd74/1tLXF//0v0SNhes1Ua9mYJwLgjQus4eHKSgaxKm2evg9DYE= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN8PR11MB3537.namprd11.prod.outlook.com (2603:10b6:408:87::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.20; Mon, 12 Apr 2021 02:23:40 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::9d91:6348:53a9:cb20]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::9d91:6348:53a9:cb20%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 02:23:40 +0000 From: "Wu, Hao A" To: Bret Barkelew , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib Thread-Topic: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib Thread-Index: AQHXLW2+ptpdU03r5kSvnXojk8mVlKqwKr2w Date: Mon, 12 Apr 2021 02:23:40 +0000 Message-ID: References: <20210409182511.620-1-bret.barkelew@microsoft.com> In-Reply-To: <20210409182511.620-1-bret.barkelew@microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: corthon.com; dkim=none (message not signed) header.d=none;corthon.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b08109d-e26c-4a77-32da-08d8fd59fc67 x-ms-traffictypediagnostic: BN8PR11MB3537: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vkmz3voIGxMef7EqcF+0FTkgJnQApPI1SQE3hzMB71oQM4GoUIy2t1riK6tZyhZJPnyDEPnemqv1sCggpGa7WnNQchp6LhRuxbr0AIfhzIrBFttrFLmDoTjtHNNoqAOC8PLJ1bZVVIYJIFhD61P4WjNRiBE5XJLi4VhQmch0lYG22EYAz+nv7swOmnP11mIMujIPK6lFD/u9KI3JnBgXffdqNoWYuph7tVF+T0UZFToC3vmVVw8b7GBh/HbxDSYkNc90dYHdxvdWUvk5FUJnelj7o+U8RQa2YQVOIVTqKiupB370k7w7e1A3JPLWL63flX0OWmbvJV4lCDafJKxCTp6X+PEU0DvjcuX3ndrDTWio8fyYW3oqv2mzS2Hb2UA8YD7SUCfK1yzLo24kJU0ev/RdgkatzhazGUVKb3hKhMP3kza9KxmXiy3yfP0aFVEcG+AvXItOltpPchZOwcVYuuqS4AkbiRdfXjlNUNj6wMwz2a0EHpVPzUzcpe33DWM/H0NDh42fQr9IExL8qLT+AXPfJxrFVVbO1gRAohifWkujfjeAWeGSJBt86YWXHNjYtPjBcmXQA+3yVJXo+lg0EKg6m4jmBscqYs7F3C5GsD4yFJvYlgE0Z2PeYoKRwxYMWzXSRWzgFBgl1D8BcOH1So/TgUH9WgNMfExPblbK4vaRAgVFDe+VvVhQN+uhff7o x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(39860400002)(396003)(366004)(76116006)(66946007)(6506007)(66476007)(107886003)(53546011)(66556008)(83380400001)(33656002)(86362001)(966005)(7696005)(5660300002)(9686003)(110136005)(64756008)(52536014)(55016002)(66446008)(2906002)(478600001)(38100700002)(316002)(71200400001)(8676002)(26005)(186003)(4326008)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Oh+4m4jus0gk3Fhe3ndiWe8n22xCvW1LWTp2KRRkjKv53aL+jtc8uwDfaa+w?= =?us-ascii?Q?zCE4jrKaRB70Cszr+ynd+gRR5p5uxeyjqJ4mrigQqoJFuXfmeO9Je6doGXNA?= =?us-ascii?Q?iutGt2oukGcJpZlSFejvFhz3q9wW2wZgreAG7SREEuUxFsFiTskpowUx9qUy?= =?us-ascii?Q?0U3QgnxbRtOnfbikkGNdQWOVjjg/iSG+84bYovetTEfKHjR/b/jDqTki8TOl?= =?us-ascii?Q?qBOSqVb1ok1achHaeZqf41b0UYxV0pgOM+95EOtbt57Iv/LK24ayLR7lVa2J?= =?us-ascii?Q?Z/J24at7uiL5glEDSH4+jtLZw5ptmYDOc7MeuH7HBKfNcfrQNSlOLxJDFdfC?= =?us-ascii?Q?i1nlfxnrQXKZLJYaZUlsCpE3/4f0X0UiqCkxOj+IBZFObQvhcf3PGVFRqk/Z?= =?us-ascii?Q?poIfQpjUx8XxGH8bGLQm2en8Xhis28D0iyUKFBCZTuNZ8livk9KnFW1f2qsC?= =?us-ascii?Q?62kEOVkubtRme44m64gUMQlrgOwjDFZlKrcyAtO5vW+GluSdCVG8zhiNRuOd?= =?us-ascii?Q?rgdhx9f5y8z1jKBDmY1aIMOPQy70ygOw/0LuEpYwvBUo6F1SLCN+sNemG+9q?= =?us-ascii?Q?uRsIGacALnUkfxOwS8zJhsYk4wJZZo0UXnFtznH7E5/1P5+3FW3/8NvUaPk+?= =?us-ascii?Q?yRdApSSu0yHn2FQqJ63qbZdPQ0f45D7naSvAj7OwQ05MQ83LBAfU/wG3pybT?= =?us-ascii?Q?ju+248ZhY4+T/3ln/3jOfUDguu36R6Un9/XtEXlt9XPAy+1ypgtB86w6s9/p?= =?us-ascii?Q?+nHbO5djG+JGkRDtM7aIUlcht424Y/zrzMA0Emejous1qKRlfLE46c6UV5Px?= =?us-ascii?Q?7akvzF7YAggw7fi6l1EccRP1dg2UYuuBDO/H61aDT/A6/71UAeVwr0EcSBsG?= =?us-ascii?Q?XkhAu6z2KXKzgkI4T+KpMZOOs3N01Nl/VapLY1lopclZoRKc0kL/YLIBuJbr?= =?us-ascii?Q?1PhaYoGAJfp9OX2jRMQLouM0QfhGI4+/Dxu07agUjIHNaUJKKKSk2g2fKL6W?= =?us-ascii?Q?p7ul5VMPeii80uEiUSwL41iI+4Xjq6g61J8j8aZQN7d874gT7vBd6htlSOUH?= =?us-ascii?Q?xV4K4n/JAB4QCDcgSmpLxpgm4O6KJBlQqQHs3xMhPbR365joQABV26+ki0hE?= =?us-ascii?Q?VmA8czPQn6ymxODHN6NkGHRKS4Jo2SULQkAj0hYwOQU5CM/LMwHwWKGq6xiy?= =?us-ascii?Q?tJ2+VKGfpZTEE+cwXQbVcfdGltoO53O62aowvkNssPtmRd8mpcPyNoHC70Sz?= =?us-ascii?Q?iYe/bAXaA6tx9ibhpwoDmGyB91qVzzC5qjQiHp3kA0I6mwnLRdxt5EufMiw8?= =?us-ascii?Q?fuT9RLqR2jaPn8etw1+9ZDCu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b08109d-e26c-4a77-32da-08d8fd59fc67 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 02:23:40.0224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sRwc8hKI8T3W7Y+B85rpkGQnMAbEanHsUZj8xZy0UVAs9SEYWJxGl0bv62g2SF2ByzusB7FhM0u3+ud5wd9lPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3537 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Bret Barkelew > Sent: Saturday, April 10, 2021 2:25 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in > VarCheckPolicyLib >=20 > DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer > pointer is NULL and the indirect Size is anything but 0. Since this TempS= ize > was not being initialized it is very likely that this sequence would not = return > the total buffer size as expected. >=20 > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3310 >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Bret Barkelew > --- > MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > index 14e1904e96d3..e50edb4ffc5a 100644 > --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler ( > DumpParamsOut->TotalSize =3D 0; > DumpParamsOut->PageSize =3D 0; > DumpParamsOut->HasMore =3D FALSE; > + TempSize =3D 0; > SubCommandStatus =3D DumpVariablePolicy (NULL, &TempSize); Reviewed-by: Hao A Wu Best Regards, Hao Wu > if (SubCommandStatus =3D=3D EFI_BUFFER_TOO_SMALL && TempSize > 0= ) { > mCurrentPaginationCommand =3D > VAR_CHECK_POLICY_COMMAND_DUMP; > -- > 2.28.0.windows.1