From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.1215.1627967527583790432 for ; Mon, 02 Aug 2021 22:12:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=I05iZQ1a; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10064"; a="210482251" X-IronPort-AV: E=Sophos;i="5.84,290,1620716400"; d="scan'208";a="210482251" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2021 22:12:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,290,1620716400"; d="scan'208";a="636473131" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 02 Aug 2021 22:12:05 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 2 Aug 2021 22:12:05 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 2 Aug 2021 22:12:05 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 2 Aug 2021 22:12:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLf0NsR5LfMczzMk7mvHaBivesWaOi6ZsuRR/kF8pjdnYBjpzl4GVL100l7CnZ5nAZEZCwMYQw5YT3eHHczqMU/fO83neP2SsdmFSNe6PeWn9YqfttUAgq22fL4GoIzNQVfi7VL5CDGDOQjmeHrIBKctc3rqwbibIMrO2ocIYaqTH7h/WbZEXo1i0BX0qJugIuPDlULGJZ+3AaWMr4q0yUZOoAn9Dran2yYprbdTtoZuizjpYQ1pTunf1lMYkLkwA5/Kr+AzpHDSRv2Yy+Q+5/8aPBOcbeglybWY2yT6MvU37HArK7f1TZHQubjNLrbEumTlLBz6wWUsNPsRdqBKvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SXJikRlAnCeioiC1Z8EseTIKLD+Oxn3rRlhYptVhNfE=; b=CeVWHxPpcgC461LiCPxCo/do15OaGPuXfqgdqyrtgDZTXe5St1RGhJXBFi4Um3I0ExS5Qmp4XwrMbemiM+Lcmlb4zaK+HhjWeShHPil9gD0qr0mKI4OVAOqvBeLAqtFqIkC5L2Rt/2Ed0NeGqH5nLMTpFmyfCcfeVtVCNMW3JWgEFa0DSs3vslvkOUhJqrbdW/lqkmgVsIEANLLjP6n0rSRd2ws3eAE701LMqH4vq6OUrwiF9HqlYDvc2H16BLUTv8L1ylugac9DHC2z/ZxD2DVI2ov67n5HKHVSe1qemAWLHxRVI0k6nUTcgjPhYDrn0xOofkNR0IZ5AIHx475dqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SXJikRlAnCeioiC1Z8EseTIKLD+Oxn3rRlhYptVhNfE=; b=I05iZQ1aY6b/KD0aiDJRqNR86X9I9jgSrmWla2Ra4NSrSDCpNbg9gIIsqxQNa3jDYcJ11mmaAfQM+hOKPJvW4DAmsXaW5idFZCrq0i5et8vXYGuMT2aPZSeM7/mmzaDp+HQoYm/8+Nf2Mi04m6O92w1tMEruiUvDkIL6ZLP9q3M= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR1101MB2242.namprd11.prod.outlook.com (2603:10b6:405:58::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Tue, 3 Aug 2021 05:11:59 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d%5]) with mapi id 15.20.4373.026; Tue, 3 Aug 2021 05:11:59 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Sunny.Wang@arm.com" , "Gao, Zhichao" , "gjb@semihalf.com" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Samer El-Haj-Mahmoud , "mw@semihalf.com" , "upstream@semihalf.com" , "pete@akeo.ie" , "Wang, Jian J" , "Bi, Dandan" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib. Thread-Topic: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib. Thread-Index: AQHXh5iX1MKuxKMPS0+4eHjOFZaBiatg4aGggAAsoICAAAqhAIAAILnw Date: Tue, 3 Aug 2021 05:11:58 +0000 Message-ID: References: <20210802121837.2913575-1-gjb@semihalf.com> <20210802121837.2913575-2-gjb@semihalf.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8727d148-8ae5-4c97-7fa3-08d9563d3888 x-ms-traffictypediagnostic: BN6PR1101MB2242: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kImqbbjn34aC5rrHJAtiKRIOf1orgBdeZ33GEHYHxDzRZkml4g/GGjBi2J3ecTLBsSLYTiS81v5fJWLmYMyMvqaMCgwgkLOwj/gNkQWEOELuLMEPzLnBFlOAzR/68xjpYmtJbfdeyMA8/3jROy+uw9iExwzuUv7qeKZ65AMS0hTDFEHGjJ1DqsYhloOmLDrw1h74ZU3kcnAh5AiiRavIDzw0VlNWTtWJ12UuB2HGFWN4RplX2rOAyuih/vz5EAD9UQ0PdNqUyq35My/y1tvJNbq/3k1Lt1GClaH2vOvmjXA9mEnRCNmY6h6MGv1MTa1ZD+DbfsPF+dPRE+S17tj7iXrKw4EIfqlycmD65bO1xptULJmKAPPZ/fM0frylgFx5OEl8XX/sBcvKEWglkLCymq0SxpMmc2Slvjlm+dvaM4f0AXDG4z3VKAwyybKUrNY/hKY2I74Ep9nKvsoOv5nZ/gqegK2jL5rAzt9298xsY8cvlWLZ4R+uDfolUxE+qpi7ejDLwm5OhRnViuh6bBlbTz6dsMYnkC5Uq+Nz8H7o4fH2uKhJkowrhQKhq48AbVIXA5P1pKOOkyGyF7Bg+U8rNIhxe2ZtOxd8fzpV+ThoZsPSF+LerKsUpKeK4u0Y7/9m9MwgsUYqzSBnTRzbEqVcF9weH6Nra79lUR+/1tOnXHLmToDyL543Nn+IostU0KT4vCyhzbMIvNqGjQFV0bqr5xgLnhnU9gIKVkxp6FHOyhilWwjrkZMhFbaMPyw+iMgDRVXIC1fI6JQyTZhqJs/1ivGts6BCAx12vOH6ncm4lE5fcT8itFC639BRnvjtGTXFo6sCX7xtQZvgEw9o6NhPHESqq8W5dzdGDzNHrdbAges= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(4326008)(5660300002)(478600001)(966005)(86362001)(54906003)(30864003)(71200400001)(7696005)(53546011)(55016002)(9686003)(2906002)(8676002)(122000001)(8936002)(33656002)(6506007)(38070700005)(38100700002)(110136005)(107886003)(52536014)(186003)(26005)(316002)(66446008)(66946007)(66476007)(64756008)(83380400001)(66556008)(76116006)(579004)(44824005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2HMKBtwm/g/IV2/eMqqZy6IztD6BCZ7taqmo5lccF5C5UOXRTk1gySE8XGyj?= =?us-ascii?Q?/0saQ9pwmQVTOfJwW2IpbBOvs22/LWef1f55VgAryoG5JJREzbaPDiz869p8?= =?us-ascii?Q?tvyUxy8BM2Vu8VMJbQ46sw7vVlbA7ZcLkSS5nl6WnbX4SRoL85uVWQeqHYGY?= =?us-ascii?Q?AuBaQWM3Z5ZY3oVdCLZOixv8GoHXFiCPTGAGrURsPEyfxAPzsf6cPamixDBs?= =?us-ascii?Q?jaTvmyiOJ+EzthOigK/Qap6lsXN51SeVEkYhRTl5e9x7yi+kc65IjSvXwxT2?= =?us-ascii?Q?oYxiZ0ei0It8zLfEDrFZabNQzmnKcsUs4/TqJJa6prN/7XeSC27x19k3GYe5?= =?us-ascii?Q?uVoknv9IiPtDcPObsSPGWLvFzbLjc0qbGH++HlL/G3S9E36sQJp2pfuboiie?= =?us-ascii?Q?510R5bW/XWXMxEg4SML5+o0+AzvXnYHJTaO8vwvplrASvLcnmBaLLyuOe0xD?= =?us-ascii?Q?4r8yTKqbmky2OgxcN3CBIIKXct1UbAZPUS3s3SEf9uH6jV8v0fuF4a90oTdh?= =?us-ascii?Q?1yHcvWIVYrlpTF8kcpYNHSVd99FXHARRWSeluGcNVUWZAE0JM06P3m1k+y+C?= =?us-ascii?Q?98qyjab/9AYsIjml1qoa7KFn6gp4UqSEPCbCnj+LIvKYY2rnbIEiS0KOQm1V?= =?us-ascii?Q?HXMtZpQB1IdU6SGyrFpFta1qVtejd3t7Y5trO4cOTtA+aDsKy1qypeknXyY2?= =?us-ascii?Q?Yup34pzESGkcTtfUK0MWDfLdwanMv37Y8hSUqn9N79psDAkr9tm8wpMjFAVR?= =?us-ascii?Q?JFu9+bbkZWG0MsDYwO1vEFGL1SyU1yw+2SaYWzm/wIDJT++pyZ/eu04W9BJ6?= =?us-ascii?Q?G4NOTZQhtnXR1XZUhgs5T42d5l92+SflpIF/EiLvYN1q2a+f7/HVmV8Bf87D?= =?us-ascii?Q?MbieeGrdpH8J9EvuTe3TYuqtnllOXd5PdC+8hs2RmUJQrLWW8xJBigHjkZMG?= =?us-ascii?Q?dnG44zZZuUeVPlCBztasoQ4+kg6yf9t1WHeYPNPj0lDGlIXxYKQX55dY95wg?= =?us-ascii?Q?MsKkiIeD9/KWB2KyGIvf2nWgOTUKyFia6LsAicSXVL0h0I7Q+3yHUuBZbJ+3?= =?us-ascii?Q?u32Lszgby3xai5a2bF64XwBL1Hc1T9Kv9xoQouoaOF/tG6F4bvzuOAf6kFcf?= =?us-ascii?Q?nxNGjoqCHCUXATsEaiSqBvWNsCEqbfx7NIghp3B+koLEJhsdn8KEn8SGnSnV?= =?us-ascii?Q?oXFSbaFwWE0amismK5cyZQ6Mv7xsflVU24aGXOcawKpZKNTc+Ncl5K7mexv3?= =?us-ascii?Q?zSKbL0CWvwcrLtc5SV+9uoiFn/Yt9MpeTj+m+v6ign0a+Ykq+6fsFzVpNYYl?= =?us-ascii?Q?8SCkAHNbpWWt28poQx9ArJNv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8727d148-8ae5-4c97-7fa3-08d9563d3888 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2021 05:11:58.9390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VmwmtFn7LXQjdg+aDRTWppFxAKUQM66lN3N5bl2WMnsQWzeZ+mkcw2VKD664akevgSo8V7cg+Otoz9RZN2ODsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2242 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks all, Patch merged via: PR - https://github.com/tianocore/edk2/pull/1858 Commit - https://github.com/tianocore/edk2/commit/2b47aaecef38b9440a65809c= bdaf9d97029f4eeb Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sunny > Wang > Sent: Tuesday, August 3, 2021 11:03 AM > To: Gao, Zhichao ; Wu, Hao A > ; devel@edk2.groups.io; gjb@semihalf.com > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; mw@semihalf.com; > upstream@semihalf.com; pete@akeo.ie; Wang, Jian J > ; Bi, Dandan ; Dong, Eric > ; Sunny Wang > Subject: Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add > BootDiscoveryPolicyUiLib. >=20 > Ditto. v5 looks good to me as well, so keep my 'R-b' for v5. > Thanks for helping on this, Hao. :) >=20 > Best Regards, > Sunny Wang >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, August 3, 2021 10:25 AM > To: Wu, Hao A ; devel@edk2.groups.io; > gjb@semihalf.com; Sunny Wang > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; mw@semihalf.com; > upstream@semihalf.com; pete@akeo.ie; Wang, Jian J > ; Bi, Dandan ; Dong, Eric > > Subject: RE: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add > BootDiscoveryPolicyUiLib. >=20 > No. Please keep my 'R-b' for v5. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, August 3, 2021 8:01 AM > > To: devel@edk2.groups.io; gjb@semihalf.com; Gao, Zhichao > > ; sunny.Wang@arm.com > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > > Mahmoud@arm.com; mw@semihalf.com; upstream@semihalf.com; > pete@akeo.ie; > > Wang, Jian J ; Bi, Dandan > > ; Dong, Eric > > Subject: RE: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add > > BootDiscoveryPolicyUiLib. > > > > Thanks Greg, the new patch pass all the merging tests: > > https://github.com/tianocore/edk2/pull/1858. > > > > Hello Zhichao and Sunny Wang, > > Do you have comments for this new version of the patch? If not, I will > > keep your 'R-b' tags from V4. Thanks in advance. > > > > Best Regards, > > Hao Wu > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Grzegorz Bernacki > > > Sent: Monday, August 2, 2021 8:19 PM > > > To: devel@edk2.groups.io > > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > > > Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com; > > > upstream@semihalf.com; pete@akeo.ie; Wang, Jian J > > > ; Wu, Hao A ; Bi, Dandan > > > ; Dong, Eric ; Grzegorz > > > Bernacki ; Gao, Zhichao > > > Subject: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add > > > BootDiscoveryPolicyUiLib. > > > > > > This library extends Boot Maintenance Menu and allows to select Boot > > > Discovery Policy. When choice is made BootDiscoveryPolicy variable i= s set. > > > Platform code can use this variable to decide which class of device > > > shall be connected. > > > > > > Signed-off-by: Grzegorz Bernacki > > > Reviewed-by: Zhichao Gao > > > --- > > > MdeModulePkg/MdeModulePkg.dec = | 9 ++ > > > MdeModulePkg/MdeModulePkg.dsc = | 2 + > > > > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .inf > > > | 52 +++++++ > > > MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h = | > > 22 > > > +++ > > > > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .c > > > | 160 ++++++++++++++++++++ > > > > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .uni > > > | 18 +++ > > > > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > Stri > > > ngs.uni | 29 ++++ > > > > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > Vfr. > > > Vfr | 44 ++++++ > > > 8 files changed, 336 insertions(+) > > > create mode 100644 > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .inf create mode 100644 > > > MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h > > > create mode 100644 > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .c > > > create mode 100644 > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > .uni > > > create mode 100644 > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > > Stri > > > ngs.uni > > > create mode 100644 > > > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib > > Vfr. > > > Vfr > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > > b/MdeModulePkg/MdeModulePkg.dec index ad84421cf3..133e04ee86 > > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dec > > > +++ b/MdeModulePkg/MdeModulePkg.dec > > > @@ -425,6 +425,9 @@ > > > ## Include/UniversalPayload/SerialPortInfo.h > > > gUniversalPayloadSerialPortInfoGuid =3D { 0xaa7e190d, 0xbe21, > > > 0x4409, { 0x8e, 0x67, 0xa2, 0xcd, 0xf, 0x61, 0xe1, 0x70 } } > > > > > > + ## GUID used for Boot Discovery Policy FormSet guid and related > > variables. > > > + gBootDiscoveryPolicyMgrFormsetGuid =3D { 0x5b6f7107, 0xbb3c, > > > + 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } > > > + > > > [Ppis] > > > ## Include/Ppi/AtaController.h > > > gPeiAtaControllerPpiGuid =3D { 0xa45e60d1, 0xc719, 0x44aa, = { 0xb0, > 0x7a, > > > 0xaa, 0x77, 0x7f, 0x85, 0x90, 0x6d }} @@ -1600,6 +1603,12 @@ > > > # @Prompt Console Output Row of Text Setup > > > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40 > > 000 > > > 00e > > > > > > + ## Specify the Boot Discovery Policy settings # To support > > > + configuring from setup page, this PCD should be overridden in > > > + DynamicHii type > > > in its platform .dsc: > > > + # > > > + > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy|L"BootDiscove > > ryP > > > + olicy"|gBootDiscoveryPolicyMgrFormsetGuid|0 > > > + # @Prompt Boot Discovery Policy > > > + > > > + > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy|2|UINT32|0x4 > > 000 > > > 0 > > > + 00f > > > + > > > [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > > > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UI > > NT3 > > > 2|0x0001004c > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > > b/MdeModulePkg/MdeModulePkg.dsc index 132fb36d95..b1d8346186 > > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dsc > > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > > @@ -220,6 +220,7 @@ > > > MdeModulePkg/Logo/Logo.inf > > > MdeModulePkg/Logo/LogoDxe.inf > > > MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > + > > > + > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > + ib > > > + .inf > > > > > > > > > MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance > > Man > > > agerUiLib.inf > > > MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > > > > MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > > > @@ -341,6 +342,7 @@ > > > MdeModulePkg/Application/UiApp/UiApp.inf{ > > > > > > > > > > > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > > > + > > > + > > > NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPoli > > > + NULL|cy > > > + UiLib.inf > > > > > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > > > > > > > > > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMainte > > nan > > > ceManagerUiLib.inf > > > } > > > diff --git > > > > > > a/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ib.i > > > nf > > > > > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ib.i > > > nf > > > new file mode 100644 > > > index 0000000000..1fb4d43caa > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolic > > > +++ yU > > > +++ iLib.inf > > > @@ -0,0 +1,52 @@ > > > +## @file > > > +# Library for BDS phase to use Boot Discovery Policy # # Copyrigh= t > > > +(c) 2021, ARM Ltd. All rights reserved.
# Copyright (c) 2021, > > > +Semihalf All rights reserved.
# SPDX-License-Identifier: > > > +BSD-2-Clause-Patent # ## > > > + > > > +[Defines] > > > + INF_VERSION =3D 0x00010005 > > > + BASE_NAME =3D BootDiscoveryPolicyUiLib > > > + MODULE_UNI_FILE =3D BootDiscoveryPolicyUiLib.uni > > > + FILE_GUID =3D BE73105A-B13D-4B57-A41A-463DBD= 15FE10 > > > + MODULE_TYPE =3D DXE_DRIVER > > > + VERSION_STRING =3D 1.0 > > > + LIBRARY_CLASS =3D NULL|DXE_DRIVER UEFI_APPLICATI= ON > > > + CONSTRUCTOR =3D BootDiscoveryPolicyUiLibConstr= uctor > > > + DESTRUCTOR =3D BootDiscoveryPolicyUiLibDestru= ctor > > > +# > > > +# The following information is for reference only and not required = by > > > +the build > > > tools. > > > +# > > > +# VALID_ARCHITECTURES =3D IA32 X64 AARCH64 > > > +# > > > + > > > +[Sources] > > > + BootDiscoveryPolicyUiLib.c > > > + BootDiscoveryPolicyUiLibStrings.uni > > > + BootDiscoveryPolicyUiLibVfr.Vfr > > > + > > > +[Packages] > > > + MdePkg/MdePkg.dec > > > + MdeModulePkg/MdeModulePkg.dec > > > + > > > +[LibraryClasses] > > > + DevicePathLib > > > + BaseLib > > > + UefiRuntimeServicesTableLib > > > + UefiBootServicesTableLib > > > + DebugLib > > > + HiiLib > > > + UefiLib > > > + BaseMemoryLib > > > + > > > +[Guids] > > > + gBootDiscoveryPolicyMgrFormsetGuid > > > + > > > +[Pcd] > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy ## > > PRODUCES > > > + > > > +[Depex] > > > + gEfiHiiDatabaseProtocolGuid AND gPcdProtocolGuid > > > diff --git a/MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h > > > b/MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h > > > new file mode 100644 > > > index 0000000000..06e38921a0 > > > --- /dev/null > > > +++ b/MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h > > > @@ -0,0 +1,22 @@ > > > +/** @file > > > + Definition for structure & defines exported by Boot Discovery > > > +Policy UI > > > + > > > + Copyright (c) 2021, ARM Ltd. All rights reserved.
Copyright > > > + (c) 2021, Semihalf All rights reserved.
> > > + > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > + > > > +**/ > > > + > > > +#ifndef BOOT_DISCOVERY_POLICY_UI_LIB_H_ #define > > > +BOOT_DISCOVERY_POLICY_UI_LIB_H_ > > > + > > > +#define BDP_CONNECT_MINIMAL 0 /* Do not connect any additional > > > +devices > > > */ > > > +#define BDP_CONNECT_NET 1 > > > +#define BDP_CONNECT_ALL 2 > > > + > > > +#define BOOT_DISCOVERY_POLICY_MGR_FORMSET_GUID > { 0x5b6f7107, > > > 0xbb3c, > > > +0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } > > > + > > > +#define BOOT_DISCOVERY_POLICY_VAR L"BootDiscoveryPolicy" > > > + > > > +#endif > > > diff --git > > > > > > a/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLi > > b. > > > c > > > > > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLi > > b. > > > c > > > new file mode 100644 > > > index 0000000000..615958799c > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolic > > > +++ yU > > > +++ iLib.c > > > @@ -0,0 +1,160 @@ > > > +/** @file > > > + Boot Discovery Policy UI for Boot Maintenance menu. > > > + > > > + Copyright (c) 2021, ARM Ltd. All rights reserved.
Copyright > > > + (c) 2021, Semihalf All rights reserved.
> > > + > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > + > > > +**/ > > > + > > > +#include #include > > > + #include > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/// > > > +/// HII specific Vendor Device Path definition. > > > +/// > > > +typedef struct { > > > + VENDOR_DEVICE_PATH VendorDevicePath; > > > + EFI_DEVICE_PATH_PROTOCOL End; > > > +} HII_VENDOR_DEVICE_PATH; > > > + > > > +extern UINT8 BootDiscoveryPolicyUiLibVfrBin[]; > > > + > > > +EFI_HII_HANDLE mBPHiiHandle =3D NULL; > > > +EFI_HANDLE mBPDriverHandle =3D NULL; > > > + > > > +STATIC HII_VENDOR_DEVICE_PATH mVendorDevicePath =3D { > > > + { > > > + { > > > + HARDWARE_DEVICE_PATH, > > > + HW_VENDOR_DP, > > > + { > > > + (UINT8)(sizeof (VENDOR_DEVICE_PATH)), > > > + (UINT8)((sizeof (VENDOR_DEVICE_PATH)) >> 8) > > > + } > > > + }, > > > + BOOT_DISCOVERY_POLICY_MGR_FORMSET_GUID > > > + }, > > > + { > > > + END_DEVICE_PATH_TYPE, > > > + END_ENTIRE_DEVICE_PATH_SUBTYPE, > > > + { > > > + (UINT8)(END_DEVICE_PATH_LENGTH), > > > + (UINT8)((END_DEVICE_PATH_LENGTH) >> 8) > > > + } > > > + } > > > +}; > > > + > > > +/** > > > + > > > + Initialize Boot Maintenance Menu library. > > > + > > > + @param ImageHandle The image handle. > > > + @param SystemTable The system table. > > > + > > > + @retval EFI_SUCCESS Install Boot manager menu success. > > > + @retval Other Return error status.gBPDisplayLibGuid > > > + > > > +**/ > > > +EFI_STATUS > > > +EFIAPI > > > +BootDiscoveryPolicyUiLibConstructor ( > > > + IN EFI_HANDLE ImageHandle, > > > + IN EFI_SYSTEM_TABLE *SystemTable > > > + ) > > > +{ > > > + EFI_STATUS Status; > > > + UINTN Size; > > > + UINT32 BootDiscoveryPolicy; > > > + > > > + Size =3D sizeof (UINT32); > > > + Status =3D gRT->GetVariable ( > > > + BOOT_DISCOVERY_POLICY_VAR, > > > + &gBootDiscoveryPolicyMgrFormsetGuid, > > > + NULL, > > > + &Size, > > > + &BootDiscoveryPolicy > > > + ); > > > + if (EFI_ERROR (Status)) { > > > + Status =3D PcdSet32S (PcdBootDiscoveryPolicy, PcdGet32 > > > (PcdBootDiscoveryPolicy)); > > > + ASSERT_EFI_ERROR (Status); > > > + } > > > + > > > + Status =3D gBS->InstallMultipleProtocolInterfaces ( > > > + &mBPDriverHandle, > > > + &gEfiDevicePathProtocolGuid, > > > + &mVendorDevicePath, > > > + NULL > > > + ); > > > + if (EFI_ERROR (Status)) { > > > + return Status; > > > + } > > > + > > > + // > > > + // Publish our HII data > > > + // > > > + mBPHiiHandle =3D HiiAddPackages ( > > > + &gBootDiscoveryPolicyMgrFormsetGuid, > > > + mBPDriverHandle, > > > + BootDiscoveryPolicyUiLibVfrBin, > > > + BootDiscoveryPolicyUiLibStrings, > > > + NULL > > > + ); > > > + if (mBPHiiHandle =3D=3D NULL) { > > > + gBS->UninstallMultipleProtocolInterfaces ( > > > + mBPDriverHandle, > > > + &gEfiDevicePathProtocolGuid, > > > + &mVendorDevicePath, > > > + NULL > > > + ); > > > + > > > + return EFI_OUT_OF_RESOURCES; > > > + } > > > + > > > + return EFI_SUCCESS; > > > +} > > > + > > > +/** > > > + Destructor of Boot Maintenance menu library. > > > + > > > + @param ImageHandle The firmware allocated handle for the EFI > image. > > > + @param SystemTable A pointer to the EFI System Table. > > > + > > > + @retval EFI_SUCCESS The destructor completed successfully. > > > + @retval Other value The destructor did not complete successfull= y. > > > + > > > +**/ > > > +EFI_STATUS > > > +EFIAPI > > > +BootDiscoveryPolicyUiLibDestructor ( > > > + IN EFI_HANDLE ImageHandle, > > > + IN EFI_SYSTEM_TABLE *SystemTable > > > + ) > > > +{ > > > + > > > + if (mBPDriverHandle !=3D NULL) { > > > + gBS->UninstallProtocolInterface ( > > > + mBPDriverHandle, > > > + &gEfiDevicePathProtocolGuid, > > > + &mVendorDevicePath > > > + ); > > > + mBPDriverHandle =3D NULL; > > > + } > > > + > > > + if (mBPHiiHandle !=3D NULL) { > > > + HiiRemovePackages (mBPHiiHandle); > > > + mBPHiiHandle =3D NULL; > > > + } > > > + > > > + return EFI_SUCCESS; > > > +} > > > diff --git > > > > > > a/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLi > > b. > > > uni > > > > > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLi > > b. > > > uni > > > new file mode 100644 > > > index 0000000000..eea3ca6c8d > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolic > > > +++ yU > > > +++ iLib.uni > > > @@ -0,0 +1,18 @@ > > > +// /** @file > > > +// Boot Discovery Policy UI module. > > > +// > > > +// Copyright (c) 2021, ARM Ltd. All rights reserved.
// Copyrig= ht > > > +(c) 2021, Semihalf All rights reserved.
// // > > > +SPDX-License-Identifier: BSD-2-Clause-Patent // // **/ > > > + > > > + > > > +#string STR_MODULE_ABSTRACT > > > +#language en-US "Boot Discovery Policy UI module." > > > + > > > +#string STR_MODULE_DESCRIPTION > > > +#language en-US "Boot Discovery Policy UI module." > > > + > > > + > > > diff --git > > > > > > a/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ibS > > > trings.uni > > > > > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ibS > > > trings.uni > > > new file mode 100644 > > > index 0000000000..736011c9bb > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolic > > > +++ yU > > > +++ iLibStrings.uni > > > @@ -0,0 +1,29 @@ > > > +// *++ > > > +// > > > +// Copyright (c) 2021, ARM Ltd. All rights reserved.
// > > > +Copyright > > > +(c) 2021, Semihalf All rights reserved.
// > > > +SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > > +// > > > +// BootDiscoveryPolicyUiLibStrings.uni > > > +// > > > +// Abstract: > > > +// > > > +// String definitions for Boot Discovery Policy UI. > > > +// > > > +// --*/ > > > + > > > +/=3D# > > > + > > > + > > > +#langdef en-US "English" > > > + > > > +#string STR_FORM_BDP_MAIN_TITLE #language en-US "Boot > > Discovery > > > Policy" > > > + > > > +#string STR_FORM_BDP_CONN_MIN #language en-US "Minimal" > > > + > > > +#string STR_FORM_BDP_CONN_NET #language en-US "Connect > > Network > > > Devices" > > > + > > > +#string STR_FORM_BDP_CONN_ALL #language en-US "Connect Al= l > > > Devices" > > > + > > > diff --git > > > > > > a/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ibV > > > fr.Vfr > > > > > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiL > > > ibV > > > fr.Vfr > > > new file mode 100644 > > > index 0000000000..0de87ec34f > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolic > > > +++ yU > > > +++ iLibVfr.Vfr > > > @@ -0,0 +1,44 @@ > > > +///** @file > > > +// > > > +// Formset for Boot Discovery Policy UI // // Copyright (c) 2021, > > > +ARM Ltd. All rights reserved.
// Copyright (c) 2021, Semihalf > > > +All rights reserved.
// // SPDX-License-Identifier: > > > +BSD-2-Clause-Patent // //**/ > > > + > > > +#include > > > +#include "Guid/BootDiscoveryPolicy.h" > > > +#include > > > + > > > +typedef struct { > > > + UINT32 BootDiscoveryPolicy; > > > +} BOOT_DISCOVERY_POLICY_VARSTORE_DATA; > > > + > > > +formset > > > + guid =3D BOOT_DISCOVERY_POLICY_MGR_FORMSET_GUID, > > > + title =3D STRING_TOKEN(STR_FORM_BDP_MAIN_TITLE), > > > + help =3D STRING_TOKEN(STR_FORM_BDP_MAIN_TITLE), > > > + classguid =3D EFI_IFR_BOOT_MAINTENANCE_GUID, > > > + > > > + efivarstore BOOT_DISCOVERY_POLICY_VARSTORE_DATA, > > > + attribute =3D EFI_VARIABLE_BOOTSERVICE_ACCESS | > > > EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_NON_VOLATILE, > > > + name =3D BootDiscoveryPolicy, > > > + guid =3D BOOT_DISCOVERY_POLICY_MGR_FORMSET_GUID; > > > + > > > + form formid =3D 0x0001, > > > + title =3D STRING_TOKEN(STR_FORM_BDP_MAIN_TITLE); > > > + > > > + oneof varid =3D BootDiscoveryPolicy.BootDiscoveryPolicy, > > > + prompt =3D STRING_TOKEN(STR_FORM_BDP_MAIN_TITLE), > > > + help =3D STRING_TOKEN(STR_FORM_BDP_MAIN_TITLE), > > > + flags =3D NUMERIC_SIZE_4 | INTERACTIVE | RESET_REQUIRED, > > > + option text =3D STRING_TOKEN(STR_FORM_BDP_CONN_MIN), value =3D > > > BDP_CONNECT_MINIMAL, flags =3D DEFAULT; > > > + option text =3D STRING_TOKEN(STR_FORM_BDP_CONN_NET), value =3D > > > BDP_CONNECT_NET, flags =3D 0; > > > + option text =3D STRING_TOKEN(STR_FORM_BDP_CONN_ALL), value =3D > > > + BDP_CONNECT_ALL, flags =3D 0; endoneof; > > > + > > > + endform; > > > +endformset; > > > -- > > > 2.25.1 > > > > > > > > > > > > > > > >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended rec= ipient, > please notify the sender immediately and do not disclose the contents to= any > other person, use it for any purpose, or store or copy the information i= n any > medium. Thank you. >=20 >=20 >=20 >=20