public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Kun Qin <kun.q@outlook.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface
Date: Fri, 5 Feb 2021 07:11:11 +0000	[thread overview]
Message-ID: <BN8PR11MB36669A6B4D5498DB3D3F7F27CAB29@BN8PR11MB3666.namprd11.prod.outlook.com> (raw)
In-Reply-To: <32563.1612494656588537457@groups.io>

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Thanks Kun,

If my understanding is correct, this proposed library will not have any consumer until the implementation of blocking the access of unregistered memory access in MM is made.
If this is the case, my take for this sent patch is that it is a RFC to the SMM drivers owners on the library API interface.
And the actual patch for adding this library will come together will the implementation to block unregistered memory access within MM.

Best Regards,
Hao Wu

From: Kun Qin <kun.q@outlook.com>
Sent: Friday, February 5, 2021 11:11 AM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hi Hao,

As mentioned in the cover letter and in BZ-3168, VariableStandaloneMm and Tcg2Smm would need this capability to unblock certain regions in order to access either variable runtime cache or NVS region patched into ACPI table, if non-MMRAM region is blocked for access.

Just as a preview (error handling needs better polishing), the example usages for the 2 drivers above could be found here:
1. Variable DXE SMM change that unblocks runtime cache regions is posted here: https://github.com/kuqin12/mu_basecore/commit/189f90318d1256c2e72a1a67d31e3176588d8e5b
2. Tcg2Smm change example, which breaks one module into 2 and then unblock NVS region, is posted here: https://github.com/kuqin12/mu_basecore/commit/c0784f95ffe31d4d65f6230657adfc63294a693d

The change should be relatively minor but critical for the standalone Mm model.

Thanks,
Kun

[-- Attachment #2: Type: text/html, Size: 4342 bytes --]

  reply	other threads:[~2021-02-05  7:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 22:16 [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface Kun Qin
2021-02-05  2:17 ` [edk2-devel] " Wu, Hao A
2021-02-05  2:37   ` Sean
2021-02-05  2:52     ` Wu, Hao A
2021-02-05  3:10       ` Kun Qin
2021-02-05  7:11         ` Wu, Hao A [this message]
2021-02-06  2:48           ` Kun Qin
2021-02-07  0:44             ` Wu, Hao A
2021-02-08 18:15               ` Kun Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB36669A6B4D5498DB3D3F7F27CAB29@BN8PR11MB3666.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox