From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.3119.1615255828117275248 for ; Mon, 08 Mar 2021 18:10:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SjyqVcfs; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) IronPort-SDR: dbzW66dDEZXwatCUKp5ZhDjLTxhAUL3QQ8SpBuONerrYYlOofY2BxlkONEROVFg0ewKl6B2WS0 /kRV+CVvtMxg== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="252170379" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="252170379" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 18:10:09 -0800 IronPort-SDR: HrmFTVPoksrebb7o2RSXzpT9strbHEKc4xZ/4J/Z7i3Bmfbehp3bsnGd1WLmEnNcf+RZEBYwzy GBf1QnriUZdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="509124650" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2021 18:10:09 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 8 Mar 2021 18:10:09 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 8 Mar 2021 18:10:09 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 8 Mar 2021 18:10:09 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 8 Mar 2021 18:10:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zpl/Ja3ka6rQUOvqdrIKA7gut8RRrshTgI/7SWwfRGbKg8JnbRaetdT4PNOZCNJPkX00kNRSuoZNi8aLkKZhfA1Rm9kYP9SW3uraY+S3VSbL7sGmpFe9Fx6v6m6PDeQ9WbJ2JlkmTzwSQy46dkvWOdM8ukEdLdynwH5hfEvVwWK8KsroF4fC+1+XvTyiNKzF2cHJpvQLodRf8fUteGHckHCpoY5vncx9F98HrYu/hUg19R8FtNu1PsMmDElBn0RWtJ+w6XwplTQe5IXyhIXxEqJYxIBINscmYXC7WTolvqwHFSUzk8xKcGXWyV4KwE7i4PUUZAR2zKzQZatd8iWc3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+/SiY+kNZj5G+xVgjPob19ZpvfIiRtElbLCPK70nhY=; b=lLAuw7DBs/yyLcVDHOZ1qjiZudPxztmkNSU9Nktmy7g5eQxa0dwUI9Cx9Up6jZ73xMiz4JBh2vPrUCeH6ujtZ/xqrWeSdXfd5HNLtIcUXv1r5V8ntIAbu+o/KWQgiqHgcv+szzh6UA8kPWm1A812TEXSZbbNDbb255bR0sNij78TYy8M1akM/fSwbefP4l+lsQHi2xIRzVV8FDb/cGhMlQA9VNxhKCV+gq2gXMBuJu5zbSLlC6jC8hNZnIkWKDOmcwtViT7Ne08+ipMapQWsB5b+zyOc2M+uTwLOuZ5tfzT/d8V+Npdceu7d+6GVUDxW0ebUwZgr8qwx9EmFIpH34g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+/SiY+kNZj5G+xVgjPob19ZpvfIiRtElbLCPK70nhY=; b=SjyqVcfsvcwIlmEw96BT8bFBUnHZsdjikYAMhuO162I3R7o+bIhWWi2qWCiWlwkWNilHLae6ywmaWvV9HB4jM05LVh4lELLVpgvADg1mFsNdwivxOv7UeSH4w8XjR+HSumn4p8Phz50pEKXfl8gTEIF1+AMicHPj7piQWTsIagA= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN7PR11MB2657.namprd11.prod.outlook.com (2603:10b6:406:b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Tue, 9 Mar 2021 02:10:07 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::9d91:6348:53a9:cb20]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::9d91:6348:53a9:cb20%7]) with mapi id 15.20.3912.027; Tue, 9 Mar 2021 02:10:07 +0000 From: "Wu, Hao A" To: Liming Gao , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] MdeModulePkg: Initialize local variable value before they are used Thread-Topic: [PATCH] MdeModulePkg: Initialize local variable value before they are used Thread-Index: AQHXFIMAscAj9MIBVEuroby4k97I0qp66M3A Date: Tue, 9 Mar 2021 02:10:07 +0000 Message-ID: References: <20210309012416.1981-1-gaoliming@byosoft.com.cn> In-Reply-To: <20210309012416.1981-1-gaoliming@byosoft.com.cn> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1e70ba4-cf33-4aa5-d22d-08d8e2a07613 x-ms-traffictypediagnostic: BN7PR11MB2657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:489; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NeHx8ErAHqm3pTWY3XsAXO6Cvup1dywb2atwyNG2knG8x8jo16EJhSotd9ai6ouWkFoC2GbwvPecXLmQzI5xV9+wGcgCLT99/eaAV/NDytcXYGKsqhyLLyCrccaXP+8GoRUv8F3ribQGwvzHAHdu9AbP+jFheYUQbtrKAFAVuBM+9CtUcM6srRGWXgZ2YvG27upi50oXhjRoUZaXHahglANOHo+NWXIWLL0151DYL0xzU+RXG8mxf8sH77n0fC32mNmWDNNuUgqJ1vWZCB0Our4CgzH64d5StU0jkDQExuW0Ufko49eO5j/k9z6Rc26+truV86qKtP7XgFYeT6ENPq/NV1aAYbTRNUPu4uZi6wTe+ezKCAhHiNgjNs9J9I+CJ94CdMgfcilEDQYXiZKtZeOYGhJfa3ewCPL5A8uBRkTiQC2TAqAB5cXq18jT9wkadN+JnBEnlOn9hfPbIYaXPv0PoaH7tfmT0V6y0/GdwiB7xYTxf09LGwtUu2nzYPRO4hQxZlcUjtLV2YvAUD+2Sw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(396003)(376002)(366004)(39860400002)(26005)(2906002)(83380400001)(5660300002)(8936002)(8676002)(186003)(86362001)(55016002)(71200400001)(316002)(107886003)(66476007)(9686003)(6506007)(66556008)(66446008)(478600001)(110136005)(64756008)(52536014)(4326008)(7696005)(76116006)(53546011)(66946007)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6QBWVEW46QYYlyAfyhb1c+1wP/kenQV5vPT3BX1Hj5VcrE+1EN+RGGiq8SVE?= =?us-ascii?Q?ysCrnuUMe/i7Vb/s5dzfiLEpuYkU0nZYRZJA9LDiIDDNRmYJvK9B/O2pUJe/?= =?us-ascii?Q?TBwHaGM6BzxLrBiKmZJIU+URm2ZFzXUgRR+CFX/IkGNazXlhKY9l1736WbMo?= =?us-ascii?Q?69msYG5H9T9az/XA6gUH5O7suyUNgfyOnj4H8H2mVcZbtFbSBickPN8RosO6?= =?us-ascii?Q?5ULOWg2UvTPNVeQIi9pbEuGekRrA8BPqOVI38vPbwLAWZj61e80HIZd7M7OQ?= =?us-ascii?Q?6w8y7cHjsYdF9kqTicN3X4RRbAiebGqE2bMy1DmQirqp6HFJJ36jLRtozaSt?= =?us-ascii?Q?HjWVV1KctAGaurUYH8uWSQWOEQFm7eooVaURhE10xUqoG920vyaiyqd5NYjA?= =?us-ascii?Q?xSR/E8pVkbYCMXk6V/VtjeahTNQJ6KAOOHPtwBe1Rhhm3Ia9A0R+qfCeBmKx?= =?us-ascii?Q?+QBkPGqC3ne92EGdPr49VgyxBbG1/i+0zwADBJrMVQ9IOxSo8v7jGHNgBnr2?= =?us-ascii?Q?GHmrXq6qQ/HP/HaDnYDx2n33x5twvF0H8izP3kIuZQ7VvupV0NY1dSryGs8O?= =?us-ascii?Q?vFRUeBC+QZg6HJMSNp+PV4EJGow8QR1YpGblin+DgWm0GQCqYVKiC0OOyRdw?= =?us-ascii?Q?tY7ZW8y+YzXkSwMpjlzMQHW4ow32TohCRZ/g1/vROeG7mR7D0YP6aHjQg8LA?= =?us-ascii?Q?2r+anQmtcPe/rl0SJv7IP5++q+fNgHgEsHo+cnjIEr+OlgPyy/BCPM71vJIT?= =?us-ascii?Q?BDo0BQXeqyTJrTzh3pYa6oM0ojrXHO497Mr/g+57qqUhIQMbzNmT/3BaFKxn?= =?us-ascii?Q?eL+hyPyuIx1TaWhYZWz3BhAgjdMU68+OajybAegmEW4y6ylai0yX56ASPTSU?= =?us-ascii?Q?XqesUl0ZJ5clo+IwOsyUHMb7izh4gVviPtW+m5QoGtj2zf1P27kgR0FBg5IC?= =?us-ascii?Q?WvuyNUy+fynCJ7+gZPr8RIG7ZlF1ke05w2Gc5p5aKS4S6avsLG7vN3gKpmb4?= =?us-ascii?Q?g4n4aNnp9lpW6OgkXVH7Cfl0/+Torqo6KWquuO4xz8dSaeEd0LIk4vOqfRtN?= =?us-ascii?Q?k2HAUAikaM91t7xBULYPkSxt+8RMGz9AiKpMiyGA4CZYeQlgZfdyQZFFAPEn?= =?us-ascii?Q?ipQCnkuRE/b7vhyaJ6uYFOhHd/YC2A/aVqKf/Q+IPKG2r6bx6viz3J2TJaiW?= =?us-ascii?Q?dP8fMPU5Sb1HVUskeW3hW+4oIPRDVEtozQyUEgXeJcPg374qvCp4lo1C1zFs?= =?us-ascii?Q?MqbBfeH6BHbN7/VzUcj9R+d5IuZXxWjdo/6rSApOUs5uHRDrTzab2LfSv9mY?= =?us-ascii?Q?e7O+Yf9MzlfTp1laQ+JccgrF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1e70ba4-cf33-4aa5-d22d-08d8e2a07613 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 02:10:07.5471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oHwD4r3Q9/3U7tORQuxY6N0kiMDLqMRvvdIbK1t1UUR7RcIuJEkHWvyZ5kN4rgCnr6ywILsAa3JQn+nIL4JdSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2657 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Liming Gao > Sent: Tuesday, March 9, 2021 9:24 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [PATCH] MdeModulePkg: Initialize local variable value before the= y are > used >=20 > This change is to fix the compiler error on GCC49 release build. Thanks Liming. The patch looks good to me: Reviewed-by: Hao A Wu I have one question that I think both the reports are false positives. Do you think it will be better to add this information in the commit messag= e? Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Liming Gao > --- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 1 + > .../Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > index e99a812a44..0779f94f9e 100644 > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > @@ -1122,6 +1122,7 @@ AhciDmaTransfer ( >=20 > Map =3D NULL; > PciIo =3D Instance->PciIo; > + Status =3D EFI_SUCCESS; >=20 > if (PciIo =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > diff --git > a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > index 0c9299c8b0..7822cbf4bb 100644 > --- > a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > +++ > b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > @@ -117,6 +117,7 @@ CreateBasicVariablePolicy ( >=20 > // Now we've gotta determine the total size of the buffer required for > // the VariablePolicy structure. > + NameSize =3D 0; > TotalSize =3D sizeof( VARIABLE_POLICY_ENTRY ); > if (Name !=3D NULL) { > NameSize =3D StrnSizeS( Name, MAX_UINT16 ); > -- > 2.27.0.windows.1 >=20