From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.773.1626398863713719100 for ; Thu, 15 Jul 2021 18:27:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LouaVB1+; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="210703221" X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="210703221" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 18:27:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="506283978" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2021 18:27:40 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 15 Jul 2021 18:27:40 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 15 Jul 2021 18:27:39 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 15 Jul 2021 18:27:39 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 15 Jul 2021 18:27:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FeRZW8gsuZ7Mcvd7lUweUFD3kh5f+Haj8KtlWcKVJzqRYhfhVQSkKLUxekMoe+zBxTYuUxZq1t09eVGtoDE/kovA3cX4AwaVRJq8IW6xbaLdkSXOtUcmpJY/PlqhAOi4p+76pEuC5HhYDywexk8UiySXN9JdfessgFlR7y5tG8PX1+UQil3QJmDblgiwVOk9awoCgSQU4ef7BTneJCtfF83KXTZKApr/NUBJhStNcZuQ38kjaebN7xsGBcjbJWeM4ONeOUvKqGM1QghK92Qp+sVDmjp+CchSl6BF/fup6lCKq/0O5mJPGRun531+T82Xg6Jy44DG+HK6B6vFnno48g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NiZyuy4p+iXgMkKnKlSp6QRcwB65EEUY8abQ7M6Gy4M=; b=Ij+ro71nPEQ0RT0faZBVwwbfbkC54RiCEjmzfEzROt48KFmUXdIm4xaMqLobC+C60MnaMpMAHu04/GIfi9SVHhspTd2S/GH8bIsBX7Xzmf6R8TWzqXmKJNjSYqMBDKNFS03/hFTQy7WLqf4Gr+yw70jwUnP1QEiFVRgdnL1e4YXc+ebwUp4J6gE2hY0PEQ+s8w4JIIPh1XAJoag3RsEwYFNSba0/TEQBVV16G943jaDkiaZexCB1AbOfIaSgULkx7wB/anJ+6fFLIz9HdEPN80bNgAqK1/SVtkyxA9uO6AO19EBMzBk26X+CCP1o3OJd7s0PGuQSWDxSWdFEZNJKdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NiZyuy4p+iXgMkKnKlSp6QRcwB65EEUY8abQ7M6Gy4M=; b=LouaVB1+9ebmfqelLNY14T2BDk5oJOrfif3k8RcxSSRaoUKVwHh/xRbytKgv278e4dznVdAF5k/vVv0WsYY61waxwVDjtFbV21wA2la4hZUEHSwCqzWjKPNMiw0SvlOu/eoO+PqG5krNW0mMTvoouWaZnUox8NI8yb6NQ2v4xtE= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (20.178.221.19) by BN8PR11MB3619.namprd11.prod.outlook.com (20.178.219.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Fri, 16 Jul 2021 01:27:35 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d%5]) with mapi id 15.20.4331.024; Fri, 16 Jul 2021 01:27:35 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "xiewenyi2@huawei.com" , "Wang, Jian J" , "Ni, Ray" CC: "songdongkuang@huawei.com" , "wanghuiqiang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value Thread-Topic: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value Thread-Index: AQHXeXUcHRYm+BJOVEGc+0qzAKoyWatEzUJg Date: Fri, 16 Jul 2021 01:27:35 +0000 Message-ID: References: <1626351895-21064-1-git-send-email-xiewenyi2@huawei.com> <1626351895-21064-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1626351895-21064-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0bc9e091-bb90-4816-c5a7-08d947f8e453 x-ms-traffictypediagnostic: BN8PR11MB3619: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G/D5fKUwRw6eN0BF9VVY3qK/yCQpMk6fTdvoKdwl619bxFxXASaNpTNuH4oPECI11btlFCa2m7Xfc/JeWxbu9UJ/rlGB0a9gdWZXvbX7DBVyhaFNEMFvBDRjYWJfBymFeJStkRklRJKPs0OoxFTfa99apNV/oZ/bPtkUileWih6gNRhnTdLubM1dp8gzUDhVxMrUR0otTTfP/t4XVXI1/6xSmYhwuLAW9PizWQV0aO7M9lMICZHPSk/Jgbazu1zJrstEwg9xh86kQSQ3KDNHDNfJ3OMYq9bPZrwVtN9SfZzmfF7fTrd7613X2QS4sPMWwAUxwcarFM6oV+q1Z5+rOETIl63Ub391ElNR3HqS4szsZRSX8pEDdbFhsqJ1RGzsdwI7AQ4chkSbhPNnMZqos+YaIsmriMk/oph6bIt74jf9sdS5LIArkM0H4grysuUnPWEsypr/Dykw1E1488Oe3oLyuIKfB6tEZcrNNBU5OAXp5V10QxZk7pkXjoOH6SUPTh/77nzO8kPd3D4vED67t8G6GvPnK7zFofafNgM3AwOH7kE87ZIWCW7jGRwC0V4WirVQWchPqbUlsIhqJg8khSYEnfPgm9SPC7Np1O/seHsNl1tnsTPJ1bIiPDU44ilW9CSWCzhxWTjNUaUOkRe6jRZFRdebBw7AUd1G18Hq53Si+Nj+XkGTnzuBbwaeBQhBp4iOmA+Ks/3x5iECIWeSKMTyyN5P3IOeomiIYxf8TKdhx5LaEATZS/VFN4dvGBetERGAYRJxjyuqj2SUPLd6Dq/fszOg8NQJLvMn+PgZNtqqXAQzxdS2IepbGNbllxtLmi7oOFCDPI2FOYf8IZTHYg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(71200400001)(54906003)(186003)(7696005)(26005)(316002)(110136005)(5660300002)(66556008)(86362001)(66476007)(6636002)(66946007)(2906002)(64756008)(76116006)(66446008)(6506007)(53546011)(52536014)(83380400001)(38100700002)(9686003)(966005)(4326008)(8676002)(478600001)(122000001)(8936002)(33656002)(55016002)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rls+LuMYruPHYHb2Zo62wjk3Ek60waPT5X6lNkz5Xg96EGq6MAssiR9QvLP2?= =?us-ascii?Q?t98m0Zp222Q1Ycu+JmC3LH79QQSbPB4wePm5SAP/O6kwzbJbsAsn2AuiOCNB?= =?us-ascii?Q?n8ex+/kM8mfn/8gwRtDP9ONhOAYKTyVDJzOrWK+BQhe165I5c+wLBHGkV60H?= =?us-ascii?Q?0QwXkfQN1wFj/W5r33WYIrZYMYKkHPu0K77BiXxpehzeoP4SjwtR4bW8s8I9?= =?us-ascii?Q?kDigPdq4lF8Gz9Of5BSUKGOXcWqcCmxPqvAVwhIqdAV6VsXa1qCpPpLuIdRP?= =?us-ascii?Q?kkbxnmxPQstvH79KkvOYbRoOi1pDIrbVqSFRQiguzNDA38GNFES1bS35tTpC?= =?us-ascii?Q?1LhZX7q5tjuBtBp0gQs59S23rBM3vLH0mEyRAJ0Z/5lYpMxXUVvRhk0w6d0z?= =?us-ascii?Q?aLrT6UNooGd7wlI9DtO2kVgGRXsJQxrNXj8MctCuHiOS7XIugLnA4oA9aG1a?= =?us-ascii?Q?Nj+26AaXHWgTcUwQJQZJ79PSNOhMR/B11g7RO1Hhwf3Z6T3aW03xhvJfHZBp?= =?us-ascii?Q?XdfS3g26qS6/8IsCHbEsrkiJx4srwrUT2MbSP8r5d9fhYd7SF9MCWT6F8Yfw?= =?us-ascii?Q?rel8jE3mKOhKBnrKS7HC41l5C6FLjVw8qOZeiHELiI23Xk9JwkS+jQSla5n+?= =?us-ascii?Q?dDZUScMEQVO90a+erRaFacvbCJ0Um+sTtldn2mVeRuF33O5C9iKggeydMUyj?= =?us-ascii?Q?NyO0GLXC78rzFv2bSA0p/Np5X0afarzP1N7iu2hm9nkPbknFU+g6RTeDpset?= =?us-ascii?Q?gqafxfLmsMEAfyjIQptU3BB9tQQNJ0UK2criUKpaPohqqynanjVUHIaEwvG0?= =?us-ascii?Q?VrovRmzWzHgrSDhDHE9h8Ebn6Ivx++B8E3p0eJB0eJ9unNTWB33w604ed6mh?= =?us-ascii?Q?Jb+w8WDpuGqN2duHy4PiykmECzbEeAkoiWvwqAvl1qWkADcFj9hvAvii+4e4?= =?us-ascii?Q?dTtlJk/l5tSRC3V3Qo3j0dp0Uqtaq9nGQ70rIkYlxtrplKHEZ733bq6XkUHC?= =?us-ascii?Q?nEwWgbZ9dZ4vfcXNGuRLttuz0eC1GBg1DKKsgjCQ/hfCUCv2hkgfcUfq2607?= =?us-ascii?Q?yjmA1R4TzGZuO/Lbe89gDmxlKRLdsURQfUNh58psidQkLF6eKu0QTIYiuTn8?= =?us-ascii?Q?j3yW6OCIGq+ZLjVyiiBdr6KaDCGZf7S0mepwN694/FNfU5MNV1MIURu5PSZf?= =?us-ascii?Q?QqH8E3Bv9oMuUfnAfJmg/JhBYD6TiYhcOAv9pepQqLKBAI9n/B3P36xPM32B?= =?us-ascii?Q?jIPi4xZrrEcS7c98UZ6KTmubHMy2k5t81d3uc225a+dnLPLXr0uOZzfdcnVI?= =?us-ascii?Q?TnMFEfgjT+/R1R3bHxazhnNB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc9e091-bb90-4816-c5a7-08d947f8e453 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 01:27:35.6823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cPmSKciEd7lXM0UACkTPF4BOEkKumzfPtK3Lfs8gjKKXw1/SGGDLbReDoyg9PE1pZwfptQ5K8qCA9xQG9o5RVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3619 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable (Add Ray) Hello Ray, do you have comments on changing the default value of PcdSrIovS= ystemPageSize from 0x1 to 0x10? I am not quite sure if there will be compatibility issue for this change. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > wenyi,xie via groups.io > Sent: Thursday, July 15, 2021 8:25 PM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao = A > > Cc: songdongkuang@huawei.com; wanghuiqiang@huawei.com; > xiewenyi2@huawei.com > Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD > default value >=20 > From: "wenyi.xie" >=20 > The default value of PcdSrIovSystemPageSize is 0x1, it means the memory > BAR is 4KB alignment. When page size of OS is set to 64KB, as the resour= ce > partitions are different between OS and BIOS, it will cause pcie failtur= e. And if > 52 bit physical address need to be supported, page size should also be s= et to > 64KB alignment. > So modify the default vaule of PcdSrIovSystemPageSize to 0x10 can meet t= he > requirement above. And even if the OS is 4KB alignment, new value of PCD= is > compatible for this situation. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Wenyi Xie > --- > MdeModulePkg/MdeModulePkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index ad84421cf3..426ea1b6cc > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1853,7 +1853,7 @@ > # BIT0 set indicates 4KB alignment
> # BIT1 set indicates 8KB alignment
> # @Prompt SRIOV system page size. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1|UINT32| > 0x10000047 > + > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x10|UINT32 > |0x10 > + 000047 >=20 > ## SMBIOS version. > # @Prompt SMBIOS version. > -- > 2.20.1.windows.1 >=20 >=20 >=20 >=20 >=20