* [edk2 PATCH] MdeModulePkg: Fix typo in error message
@ 2021-07-29 1:01 Seonghyun Park
2021-07-30 8:51 ` [edk2-devel] " Wu, Hao A
0 siblings, 1 reply; 3+ messages in thread
From: Seonghyun Park @ 2021-07-29 1:01 UTC (permalink / raw)
To: devel; +Cc: chen.a.chen, Seonghyun Park
Fix typo in error message in CapsuleApp.
Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
---
MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
index dba50b3202..712cf2e1f7 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
@@ -509,7 +509,7 @@ GetUpdateFileSystem (
DevicePath = DuplicateDevicePath (MappedDevicePath);
Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath, Fs);
if (EFI_ERROR (Status)) {
- Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map, Status);
+ Print (L"Error: Cannot get EFI system partition from '%s' - %r\n", Map, Status);
return EFI_NOT_FOUND;
}
Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message
2021-07-29 1:01 [edk2 PATCH] MdeModulePkg: Fix typo in error message Seonghyun Park
@ 2021-07-30 8:51 ` Wu, Hao A
2021-08-02 1:58 ` Wu, Hao A
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Hao A @ 2021-07-30 8:51 UTC (permalink / raw)
To: devel@edk2.groups.io, shpark.zilla@gmail.com; +Cc: Chen, Chen A, Seonghyun Park
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Seonghyun Park
> Sent: Thursday, July 29, 2021 9:01 AM
> To: devel@edk2.groups.io
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> <shpark1@protonmail.com>
> Subject: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> message
>
> Fix typo in error message in CapsuleApp.
>
> Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
> ---
> MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> index dba50b3202..712cf2e1f7 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> @@ -509,7 +509,7 @@ GetUpdateFileSystem (
> DevicePath = DuplicateDevicePath (MappedDevicePath);
>
> Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath, Fs);
>
> if (EFI_ERROR (Status)) {
>
> - Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map,
> Status);
>
> + Print (L"Error: Cannot get EFI system partition from '%s' - %r\n", Map,
> Status);
Thanks for the patch.
I will change the commit title a little bit when merging:
MdeModulePkg/CapsuleApp: Fix typo in error message
The change itself is good to me:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> return EFI_NOT_FOUND;
>
> }
>
> Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
>
> --
> 2.32.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#78376): https://edk2.groups.io/g/devel/message/78376
> Mute This Topic: https://groups.io/mt/84528989/1768737
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message
2021-07-30 8:51 ` [edk2-devel] " Wu, Hao A
@ 2021-08-02 1:58 ` Wu, Hao A
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Hao A @ 2021-08-02 1:58 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A, shpark.zilla@gmail.com
Cc: Chen, Chen A, Seonghyun Park
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Friday, July 30, 2021 4:51 PM
> To: devel@edk2.groups.io; shpark.zilla@gmail.com
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> <shpark1@protonmail.com>
> Subject: Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> message
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Seonghyun Park
> > Sent: Thursday, July 29, 2021 9:01 AM
> > To: devel@edk2.groups.io
> > Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> > <shpark1@protonmail.com>
> > Subject: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> > message
> >
> > Fix typo in error message in CapsuleApp.
> >
> > Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
> > ---
> > MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > index dba50b3202..712cf2e1f7 100644
> > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > @@ -509,7 +509,7 @@ GetUpdateFileSystem (
> > DevicePath = DuplicateDevicePath (MappedDevicePath);
> >
> > Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath,
> > Fs);
> >
> > if (EFI_ERROR (Status)) {
> >
> > - Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map,
> > Status);
> >
> > + Print (L"Error: Cannot get EFI system partition from '%s' -
> > + %r\n", Map,
> > Status);
>
>
> Thanks for the patch.
>
> I will change the commit title a little bit when merging:
> MdeModulePkg/CapsuleApp: Fix typo in error message
>
> The change itself is good to me:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via:
PR - https://github.com/tianocore/edk2/pull/1852
Commit - https://github.com/tianocore/edk2/commit/3445058aea4f64a994e4ec040135258a135d36ce
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> >
> > return EFI_NOT_FOUND;
> >
> > }
> >
> > Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
> >
> > --
> > 2.32.0
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#78376):
> > https://edk2.groups.io/g/devel/message/78376
> > Mute This Topic: https://groups.io/mt/84528989/1768737
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-02 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-29 1:01 [edk2 PATCH] MdeModulePkg: Fix typo in error message Seonghyun Park
2021-07-30 8:51 ` [edk2-devel] " Wu, Hao A
2021-08-02 1:58 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox