From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.1474.1610700791984934622 for ; Fri, 15 Jan 2021 00:53:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rFYAX8ya; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) IronPort-SDR: 67Mn1+3iDj/yHvgD8Gbf3hWWaB56T8xzKgw7Kt4wW+c0U+0fmUxtskgdd2wS3EmIM64x5tT2A0 bGpwudHJADMA== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="157700573" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="157700573" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 00:53:09 -0800 IronPort-SDR: 5zMfwFdz49R6Vtu96x5NqdATXcLQygSHM00N2qxmWYZJzEeVr0OihsE3yXzRU32us74qU785IY 1GbwqrA8dNpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="382592169" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 15 Jan 2021 00:53:08 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 Jan 2021 00:53:08 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 Jan 2021 00:53:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 15 Jan 2021 00:53:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtUD1Nafm8LIVn7aQxiTRJJCW29/lv9aYXsdk/jk68s37Dwf4IaAGN54KO4q0qlMywhidoCpbJQyMplHoYhwgdKBvtW/UKv7w+oIjAgjwBS/jKqezn23p1YYcYYZsq+7kRFO2lwcMABxzlfznBgsC24UQesVSs2zbR1MsXcVAKDMCemSIuBaDdVoVq+WTh7HzrdJCLJYMSwH1GeQGacidKZtrw1p6BVi5nz4WijkOD0iza0s8JybrIWeFxg0YlzdwGXK28w4qad+u/sZ3tCRIZ9YZKBDmO4z32dOe8i1r1kuAZ6jONkbxfQxypiUKrxp41IVvQ8ltqvo+LyLyxY8DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UzmeIqz7MqUOkYLV/QKaVCiuSftnnofgOzJ8ew49Uf8=; b=SMOKaZpE/WQVAGsBNJ8oA7KsQ3pQR5+gRZViruswtdB7TtwOvS3q5R9zS3jozXCP93UasykX4E4QF53vPk0KbcDVSTecDDnK+x+iLvg0DbTWwrCxEyYUcNiwIHpXoUargMrYcdRWcNOtGAhv67sQJg1vGOOLQZTLtMJXASABphXlb+Eszu1aDzVgGLQiXELTY/lUNO3w6a98cPV6J/LQkwMqVPEQo+P2KcukVUrVspfZPGKaAxMVsi48qV5xY2c1LG9/WVFVwsCDczF+5qVdgJUrVEmFyqIkk7a7oE4rDJ509wwkR/JemkFSm5dw24uN/AtCXrgsl0CUENdgVl9xyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UzmeIqz7MqUOkYLV/QKaVCiuSftnnofgOzJ8ew49Uf8=; b=rFYAX8yaiihlIwr9Nj7Ksx3CE0avGhpcPj/PKqYD27E2Ba77jlNBRiEaO6cHl4tR7tJU0J/i1BwdCjCkTMvFpiTC1v8Ga0dKcmVyJRN0gCTW2ctMoYqVTz6rVpJdB+br28jJWa3kRBhZihq497fQKTTmu/xqCClg7RChaox7Q6Y= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN7PR11MB2657.namprd11.prod.outlook.com (2603:10b6:406:b1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Fri, 15 Jan 2021 08:53:07 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::d11e:3b2:e34f:7f0f]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::d11e:3b2:e34f:7f0f%5]) with mapi id 15.20.3763.011; Fri, 15 Jan 2021 08:53:07 +0000 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "gechao@greatwall.com.cn" , "Wang, Jian J" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow. Thread-Index: AQHW6iSOtki2de4wAkWCJ8AqJv/MTaomqRNwgAG4oQCAAAGLgA== Date: Fri, 15 Jan 2021 08:53:07 +0000 Message-ID: References: <165A05B49BF7F07B.12403@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37df75bd-5854-4470-fe2f-08d8b932fa4f x-ms-traffictypediagnostic: BN7PR11MB2657: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fOP7jx7lwStXQxO0DYPpzZYlXxXVHCFDNyXj8Qn9ZazcYik3avA+DEoYviliROm0FFFeeMEV4md5vWjaIn2LVjgaehQUe7waJvxcT7NUidy8cu5SmsMEknzNt1LyBysZ9RHrrWroPLcwqmi2WcL3e7kkqZoqVN3diB6EDapdpGczPGeSkeaVF+X+iiMYRjeaTXLZMwwiKYRWBykZTPXECpvMR4m5+5r9bCQpRBqFxJXf8CbkSXljA/WeohMOuPSThV2qx1NjkBCMnTZ4+CGy5TJrHr7pFnDozVJy+2cDqulzhKpE1tIZf3tb26DJbiwKmkYzAxPICqzJZPBJdCI+iOkFs59xJrdUiVp2k3kZzLAbaLj036FFeAkcI5cS4cQDNOmnSAaoyVtKayAjIZ6NsWkT6Fbq3Bx8lF9q3izJ0X1y212zUEWS4hLE+Hg2Rv/u9YMPse+YqMD7QJszEd3Sng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(9686003)(55016002)(107886003)(478600001)(966005)(66476007)(66446008)(66556008)(5660300002)(64756008)(71200400001)(76116006)(8676002)(66946007)(52536014)(6506007)(2906002)(83380400001)(110136005)(316002)(6636002)(8936002)(4326008)(33656002)(186003)(53546011)(86362001)(26005)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jmMeqPIHJA2VDUSysIDl/Zc/qjgdhwnrEuOOKLl7R0Z93v3TZ6r9kvQK36U/?= =?us-ascii?Q?kVIG6ZzhrBPX0QF0Qejky8m+5+m02jjeTfKtKcWUVG9LXriAU530wqvgBQpC?= =?us-ascii?Q?16flCSixXQ48jH//Y5cA3HL8u4J8dQjLPGlOPuxfDhGRfcwzM7nWU56+80eE?= =?us-ascii?Q?EtMobd0Rv9UuBYFOuWPdT79Q0b0XoQGtTuTZ2Xh5HZzg3dUUUfZktCg88o5/?= =?us-ascii?Q?2oyLoKQlbIjqptjUhotHzApoR6gTEizdACb2zu8970b0czZWQ1pfv8uD3Cyn?= =?us-ascii?Q?TGHRoeapplFjUE3uT+sL9TE5KqwNg+xsF99Dg7fCB6YJdj4F8X9yVH75AvPp?= =?us-ascii?Q?4M1E2ZDvt3jxCkROQ29r0Le+/S5gMmNiuV55gPH+aB9ofGbWmhmRT3iZ9KcB?= =?us-ascii?Q?LkDT8fV3oIxjrkr7/BjNdrK1cdCk+ZUjdXAj+OzvpsN+ASB9Swmj0FXFbYOn?= =?us-ascii?Q?ZLechso4fFB/dZX4GtIKvd5XzamYtfphV1hbtA1hVvP6op3zeMxH7Zs751ql?= =?us-ascii?Q?z7Q44QfWE0ZIgImdQuUC0FbZbdHYY33kLXUYb1U2cEvU4w3ykqVWDG5CohMt?= =?us-ascii?Q?9EtZF81J7I5cB/sdmDU7ERg4nfTNgBNpLTNnaMhUjKEXvNZPq9TrxjNZwToQ?= =?us-ascii?Q?OIqnikfwFjOUYJf8RykwpKXpdY2co4DFSDsClo9mwpc8FpVJp3T9qy0rHJL4?= =?us-ascii?Q?2DQ8g5biCv+1zrxL2SFg9JmfcERscQaafW8umLnztszNrU75rEqE8V4CspWj?= =?us-ascii?Q?2PvIgR8WcErZ0G2ysMdiUPmU7ZOS9SQb0ZEmD2CgcabmeD+xf1bZbDbJvkr1?= =?us-ascii?Q?WkP4vBW2Lzl2zoEUsorELapvrwVZuI1yMcyFM5CbhflzSfY5AkqTmkZhu4+t?= =?us-ascii?Q?KucLBuAfiktFXe96IoZbpMIst8nElYYpsYyt/C8PpdK8aRDntCiSf3ue+C6y?= =?us-ascii?Q?/XrnKSasuKm/EDOoy+m4jC4bbiwDJ6IPWsJU7cwGl+w=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37df75bd-5854-4470-fe2f-08d8b932fa4f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2021 08:53:07.0245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8IicbfQ/nN4tv7kj75QxzjzfKpYUSL/LaeWGG8q0a5PP2eVIKVtjBbDRpl4VTZV2RDj3aRG+3D2So+Z7502QFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2657 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, January 15, 2021 4:49 PM > To: devel@edk2.groups.io; Gao, Zhichao ; > gechao@greatwall.com.cn; Wu, Hao A ; Wang, Jian J > > Cc: Ni, Ray > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: > Terminal fifo buffer overflow. >=20 > Add Hao and Jian, who have the permission to merge the patch. CI result: > https://github.com/tianocore/edk2/pull/1358 Hello Zhichao, I have added the 'push' label for the PR. Best Regards, Hao Wu >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gao, > > Zhichao > > Sent: Thursday, January 14, 2021 2:35 PM > > To: gechao@greatwall.com.cn > > Cc: devel@edk2.groups.io; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: > > Terminal fifo buffer overflow. > > > > There is no need to add [BUG] in the title. I would remove it when I c= reate > the PR. > > If you want to have a record for this bug, you can edit a Bugzilla and > > add the link in the commit message. > > Beside of that, Reviewed-by: Zhichao Gao > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: gechao@greatwall.com.cn > > > Sent: Thursday, January 14, 2021 11:23 AM > > > To: Gao, Zhichao > > > Cc: devel@edk2.groups.io; Ni, Ray ; gechao > > > > > > Subject: [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo > > > buffer overflow. > > > > > > From: gechao > > > > > > Fix the bug of terminal fifo buffer overflow with UINT8 type. > > > > > > typedef struct { > > > UINT8 Head; > > > UINT8 Tail; > > > UINT8 Data[RAW_FIFO_MAX_NUMBER + 1]; } RAW_DATA_FIFO; > > > RAW_FIFO_MAX_NUMBER is 256. > > > the data buffer size is 257 (Index from 0 to 256), but the max value > > > of the index, Head or Tail (UINT8), is 255. That means the last data > > > of the data buffer would be always empty if we use Head/Tail to > > > output/input the data correctly. And because of the incorrect > > > buffer size the FIFO full check "((Tail + 1) % (RAW_FIFO_MAX_NUMBER = + > 1)) =3D=3D Head" > > would never meet. > > > > > > Signed-off-by: gechao > > > --- > > > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > > index 378ace13ce..360e58e847 100644 > > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > > @@ -37,7 +37,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #include -#define RAW_FIFO_MAX_NUMBER > 256+#define > > > RAW_FIFO_MAX_NUMBER 255 #define FIFO_MAX_NUMBER 128 > typedef > > > struct {-- > > > 2.25.1 > > > > > > > >=20 > >