From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.46031.1606182620280384045 for ; Mon, 23 Nov 2020 17:50:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZYXPIM76; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) IronPort-SDR: Wq+iwz9c2gTieEwKKpuPMwhylVdmG5tonstooDcQAtobeQdmLcwTqJrbBDZhQD2e+ksFC8jjei cmsFt3uYC62g== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="151717344" X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="151717344" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 17:50:19 -0800 IronPort-SDR: ot2Q6/KrUQik7/C38UYX31ucsonWhBt1MB9N37/LZ6OoAl3p6oNBRelsMMkFgN6wzS31iSM0Ix hV2ZA170qtkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="332394249" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 23 Nov 2020 17:50:18 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 17:50:18 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 17:50:17 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 23 Nov 2020 17:50:17 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.59) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 23 Nov 2020 17:50:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPTydG6RRmo2yw5LqLbX6Kl1setTle1aDOevzsJAmmSAwD6zmsraCZhdDOgy0WTYNYjv3HI24B9+6x1K6rJxyr4BnKektsnPcrcAvN35uMltYegfMnTX+77FouZc+NKg+5CzoGfOvzPylfCHGcA9vE94SPtZE/rKAVHB5hVHWgIaSv2SoxGc8NZfR9uvVGNx7qAZdgoQfQyu1+8xL76dLWpEOjLdeWPQY+iwn2Q6WaJmaBp2lOeJiZZDTbEfwhqhzYuyB7JfojuJeRCf5SlhwgVlc6/Ay3R1T7vpqdhVNrpyIe4crM9sUG1bon3OSrPIWQk3tJ4rdem+d4pt3K3SYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiYCtVXOifIl2BxLFcFrH/EJ42YbktWQz7N6vLcRJWM=; b=TL56DpJsTqCdzAkTsxBjnwRxsNZA1KEJ623+BquQ5oPAcPedxfx+k11oDeVtYS63xGLPUXA4Hw+Y37b1wq7EWoj7aHljQnFJgORn6HADKpBCl5khceLIoORZf+FWoacIAJU6xUUcwgHDw6n51KcntUwTPx7TG9tJ3/GdCO5iwW2+znf8OlBgBahsu3nsffqspMFgrkSFUpbLb/5lWOXteTM9IDH5m8M8nUzmGCJaEq9N/w02+NJA35S6Jajp+QIdBgyU/eKQNKmSUah0x48iGWuSA0FPuCGDRXbISUcgTlPzWpnqgm6/Zt19ku1+Vs24OUto/Q0CLnFwz0P8xOro+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiYCtVXOifIl2BxLFcFrH/EJ42YbktWQz7N6vLcRJWM=; b=ZYXPIM76cMkb5vbqyiNRpg2we64Gcl7vYZ5a0tNj9ebIWBtOXL7ToYMcDUaOup+JvgfXDSUcoKknwKrYCwMaw/3YWpdkk492MZpaI91C/RPo1ZSX/PrgYRky3XSwj/rSWNg+tA+RIcrCLUUOVHVZ68pCyY8jvX+CVhZevAmDwuU= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB1377.namprd11.prod.outlook.com (2603:10b6:404:49::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Tue, 24 Nov 2020 01:50:15 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::b48e:bb0b:fdb:38a2]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::b48e:bb0b:fdb:38a2%5]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 01:50:15 +0000 From: "Wu, Hao A" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: "Wang, Jian J" , Andrew Fish , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Wang, Nickle (HPS SW)" , "O'Hanley, Peter (EXL)" Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port Thread-Topic: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port Thread-Index: AQHWwaWpgE6CyF0BvkuX9D6Pt2xq3KnWexUwgAADLLCAAAOjAA== Date: Tue, 24 Nov 2020 01:50:15 +0000 Message-ID: References: <20201123134722.15980-1-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 663d22da-28f8-468b-3ee9-08d8901b4a60 x-ms-traffictypediagnostic: BN6PR11MB1377: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:462; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I0w2WMU3HuF2jhOBSiZRMBfw4sUZgQMc9Len1tS7uEOQhvlhwMEBVI2g2+fiXNpI1Ex0VX0nCdnNUHXNaVAyieFmwpl+pdAVkdOOVJ0DL3SZezBHb2VeYMOt/Ueyj9bD74sMRWr9bqywizcXP9nx1TPBTtWnNBVwpbimAevctO6xUBuVa0UHhl7KUYSUIp44WKtOj6g+s26xCgL/xZ1FoERlvURDWix3TzGwr2/8JlDi9oRxVPt1nULNhsWkEzBR6fRDtNxTAe3fB1JWvp+9yHzIRPZ86Poxx/wRghSHMp8yy1eLWSHmXMlDPbbKKXSLotcrBAJcuV7zbDGzUNW28ajiQbHdupDNDj14PZZyel/55sIdYry2oup72gJ86gnme6egcB4dYOjYeoZoJ+5llA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(2906002)(66556008)(71200400001)(53546011)(19627235002)(7696005)(86362001)(64756008)(5660300002)(8676002)(66446008)(66946007)(52536014)(66476007)(76116006)(316002)(110136005)(54906003)(26005)(6506007)(296002)(8936002)(186003)(83380400001)(478600001)(33656002)(9686003)(966005)(4326008)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?78FGPeX20829l61P/3JmSa3b3dOUK2o6shoP4JZGGo+k3RefyMRxqrLxMOcH?= =?us-ascii?Q?FfOHP0SWyrwIHY4F/skmyEpnJiGECzJ9ZiCFnG1g3pATiLKcDobhjwMdOAkv?= =?us-ascii?Q?trh73hk4IsLLDVKuevJhxofiQryYMrTdf9kqfXadFhjIo82AwLqpAlELkj11?= =?us-ascii?Q?UEWTpH0P5d1WFf4eaQd2FBT6pu5Pglyt2oHExJnCHu/3PaaKsAdA2xAoQCpx?= =?us-ascii?Q?OJYF76eZ1JB0R8Tszr+hMeAaHt71H/8Yg7PB3UxicLlvE+jAGAE3S5VI/ahs?= =?us-ascii?Q?sSx3m5TH9eP4p52f2ZD1lS5xz7XRVUQjtcnMujaIfKf6/PYMgFpY4qJVzlmp?= =?us-ascii?Q?HzCoDx0Xru7Q3J14gnk1Ie6XgkQG4YJiGUIZPLj2R7QJJ6KLtIYzuOQSsOs5?= =?us-ascii?Q?pBwgr40K/NOyZG4GOEr2guAaSz9gYysWcR14MjqJGV5e2bBEnLn2lQdTOjJX?= =?us-ascii?Q?xXxRdz9QVI9fhKPLKSoJ4pd2targh9Pw4Pq83a3C1jkBV3EyCiE3cY2F5I34?= =?us-ascii?Q?OOsHj5GoQ+1l4qFew7rAJSnkg9urOrgq32b+cL5cXydE6EH0AcwqLSBTuGp+?= =?us-ascii?Q?fKChjCSFdD8OQRviCf2+a5BQatcnxb5LZx6Cu2O9yz9C6LUgOW3X2SbKEAUU?= =?us-ascii?Q?tGSF1UzCjkjrUuBP2iTC1KbmkrtMw980BAxzlGCTx72FUCqN6uY5j5msyiBK?= =?us-ascii?Q?saKnc2EtdqDlpLg8yt5jn4ZJFzk5Xw2thSUH6Ku3KVr1KHxZmhHYoDVp5OG/?= =?us-ascii?Q?QLlvCPzQpuaF2WKw3YP0KmzzozhXYmUVxd1uvoJzi5O4DZyF+CNqTpJRGe5u?= =?us-ascii?Q?YmZ3vgyO6AwwYr5SCLAuZoABbwsi/HqoFS6YUuF/03+KuPcsczRucnFFQ4TV?= =?us-ascii?Q?xRb0lzb7zot3KWitzjMhtMrNizfuS1ZuoA0p1uoOtVbZimyHqVdvB5s6xfuF?= =?us-ascii?Q?eAdaDWG7+AoE03tZ4/mOXIP8T+6l7RSFZYLGZd66tSM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 663d22da-28f8-468b-3ee9-08d8901b4a60 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 01:50:15.8683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l04ga+6v8kCTsBY5Lo8gG0kaSIdgAUsTLrpq4XNs7hpo1IPKnYq9RqF9RfObCPg8oRNtmNDi0tQpqht5kYNFzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1377 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Tuesday, November 24, 2020 9:31 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Wang, Jian J ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Tuesday, November 24, 2020 9:20 AM > > To: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io > > Cc: Wang, Jian J ; Andrew Fish > > ; Laszlo Ersek ; Leif Lindholm > > ; Kinney, Michael D ; > > Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > -----Original Message----- > > > From: Abner Chang > > > Sent: Monday, November 23, 2020 9:47 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Wu, Hao A > > > ; Andrew Fish ; Laszlo Ersek > > > ; Leif Lindholm ; Kinney, > > > Michael D ; Nickle Wang > > > ; Peter O'Hanley > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > This set of pactehs is sent for the comments on edk2 JSON library. > > > edk2 JSON library is based on jansson open source > > > (https://github.com/akheron/jansson) and wrapped as an edk2 library. > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not > > > contributed yet) > > > > > > Hello, > > > > Sorry for possibly missing previous discussions on the Redfish feature= . > > I am wondering is it more straight-forward to put the JsonLib together > > with the Readfish codes under RedfishPkg? > Hi Hao, > The idea is JSON is not the representation of data payload for Redfish o= nly > and JsonLib could be not only for Redfish neither. Any applications whic= h use > JSON as data payload can leverage JsonLib. Thanks, My concern is for the case of adding a common library/module, MdeModulePkg usually seems to be the destination. But since MdeModulePkg is already a h= uge and complex package, I am not sure if this is the right way to go. I would like to get the inputs on other reviewers for putting the JsonLib = under MdeModulePkg. If this is the right direction, could you help to add an item in the Maintainers.txt for the Json related stuff in MdeModulePkg and list you (and 1 more person will be appreciated) as the reviewer? Thanks in advance. Best Regards, Hao Wu >=20 > Thanks > Abner > > > > Best Regards, > > Hao Wu > > > > > > > and the edk2 port of libredfish library (not contributed yet) based > > > on DMTF GitHub (https://github.com/DMTF/libredfish). > > > > > > You will encounterred the build error with the jansson library > > > pointed in submoudle (v2.13.1) and the fix is already submitted to > > > jansson open source (https://github.com/akheron/jansson/pull/558). > > > > > > Signed-off-by: Abner Chang > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Andrew Fish > > > Cc: Laszlo Ersek > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Nickle Wang > > > Cc: Peter O'Hanley > > > > > > Abner Chang (3): > > > edk2: jansson submodule of JSON library > > > MdeModulePkg/library: EDK2 port jansson library > > > MdeModulePkg: Add EDK2 port jansson library > > > > > > .gitmodules | 3 + > > > MdeModulePkg/Include/Library/JsonLib.h | 596 +++++++++++++ > > > .../Library/JsonLib/JanssonCrtLibSupport.c | 705 +++++++++++++++ > > > .../Library/JsonLib/JanssonCrtLibSupport.h | 198 +++++ > > > MdeModulePkg/Library/JsonLib/JsonLib.c | 805 > > ++++++++++++++++++ > > > MdeModulePkg/Library/JsonLib/JsonLib.inf | 81 ++ > > > MdeModulePkg/Library/JsonLib/JsonUtilities.c | 417 +++++++++ > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h | 69 ++ > > > MdeModulePkg/Library/JsonLib/assert.h | 11 + > > > MdeModulePkg/Library/JsonLib/errno.h | 11 + > > > MdeModulePkg/Library/JsonLib/jansson | 1 + > > > MdeModulePkg/Library/JsonLib/jansson_config.h | 57 > > > ++ .../Library/JsonLib/jansson_private_config.h | 19 + > > > MdeModulePkg/Library/JsonLib/limits.h | 11 + > > > MdeModulePkg/Library/JsonLib/math.h | 11 + > > > MdeModulePkg/Library/JsonLib/stdarg.h | 11 + > > > MdeModulePkg/Library/JsonLib/stddef.h | 11 + > > > MdeModulePkg/Library/JsonLib/stdio.h | 11 + > > > MdeModulePkg/Library/JsonLib/stdlib.h | 11 + > > > MdeModulePkg/Library/JsonLib/string.h | 11 + > > > MdeModulePkg/Library/JsonLib/sys/time.h | 11 + > > > MdeModulePkg/Library/JsonLib/sys/types.h | 10 + > > > MdeModulePkg/Library/JsonLib/time.h | 11 + > > > MdeModulePkg/MdeModulePkg.dec | 7 +- > > > MdeModulePkg/MdeModulePkg.dsc | 4 +- > > > ReadMe.rst | 1 + > > > 26 files changed, 3092 insertions(+), 2 deletions(-) create mode > > > 100644 MdeModulePkg/Include/Library/JsonLib.h > > > create mode 100644 > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c > > > create mode 100644 > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/assert.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/errno.h > > > create mode 160000 MdeModulePkg/Library/JsonLib/jansson > > > create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h > > > create mode 100644 > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/limits.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/math.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/string.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h > > > create mode 100644 MdeModulePkg/Library/JsonLib/time.h > > > > > > -- > > > 2.17.1 > > > > > > > >=20 > > >=20