From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.48594.1612247676460987864 for ; Mon, 01 Feb 2021 22:34:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EwX3aneg; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) IronPort-SDR: BTIsPqqk6bqhm6fDVI0kV//Dqa+Zq249/pFpuXefX7LZlb0MG9vmjORMkVCAiX4pVNL5iJQX0K oL7Y3+n7RxbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="244887872" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="244887872" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 22:34:28 -0800 IronPort-SDR: pKeDS6Gv0KlDFhSE/fAJh9vVP0k2SLb1HNlYHfNmMAaGdkZHZyA8L0TvcDX/7RdpZBO/8cnoyI 9IaznuVsvW8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="479450995" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2021 22:34:28 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 22:34:28 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 22:34:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Feb 2021 22:34:27 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.52) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 1 Feb 2021 22:34:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ca97fBlsylzVRxWuj2/Fp2+4EeZBMZDY28n9zUNaNEqzu4Fh3ZlDdS6pgqlNMtnLrFGbADNjne/MOpmtwbiDIT4bL6uUO9uB1SjgHlm53PdAYkcQKGNqoY1xYuFq5WC1sCS3lImvoxVRR5w2M+uG/kDcmtzMnAkutoOlN4iAR5d1Gr9ORot4ruhu4BMxwoaE1aR+lK1egRFeF2BG5VzTLOFzIjH+oE0NtFK4MCr3oufeSKWM9wUmZKk/moOMokUCJdDSCqBm7773Oivd1TzA6/XeL1l5pJw2rqI7zVlu1rWoE5IAAwWafGrjUb6OZiB17i4AdMB9+LFnylSXT1Wu8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M6XljNm8ZG6bXTn4SQCUlZerrqnLWPZQu1q+Ezm/AG8=; b=T9uJ0PciV9wiAcBdBL6+BxV1xMaVjfQUGzCzjO/5OfFZnl0WiXi9IWcJBktNMCxE6NF44dR6yU6aWb2Nbkzod3MC+9Xr6J9NPN42R+6Uw1aHo8Ak6aI6jSFDLUPDkF2Y/eP9enA3+ndBPXGILapN4c09UcQz+FwN/ZGtg0rnOmDYo9KQ+RbgVO9vCmkwMURqjh+oIb3Nc/mmDTgWQvSuJ298w7lZxbUGHvdLgf6N2OkGqAKBbjuSNoveMq0rE9j0/7Aja+6hiLkCFM5fRtGEF7oLZbraUEejPaVMCvZPxow2UV0WeVtnlv4YRidQSlxsCzgjLQvIJPb8MUqGuxvY+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M6XljNm8ZG6bXTn4SQCUlZerrqnLWPZQu1q+Ezm/AG8=; b=EwX3anegQ2AVfc7Hcm77cKIH/lqXtH7a0lsjsiKqYQ0nhgk+JzYoFvE0AO239gai+MTLl9+GM+DOjjqeBhLxi/XkWftsWoXr7F0SCN4UbpU8WNqy3gpzahUUaYXUV13PNHSit9VG1JEK18RdsPxW6qzbvQ+iocpg0yxXgXpZ718= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB3907.namprd11.prod.outlook.com (2603:10b6:405:83::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.24; Tue, 2 Feb 2021 06:34:25 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::d11e:3b2:e34f:7f0f]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::d11e:3b2:e34f:7f0f%5]) with mapi id 15.20.3805.026; Tue, 2 Feb 2021 06:34:25 +0000 From: "Wu, Hao A" To: "Ni, Ray" , "Park, Aiden" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Dong, Guo" Subject: Re: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Topic: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Index: AQHW6d6BmIsOKkxWRESU7FZ/pi9f1ao979cAgAB244CABiA2sA== Date: Tue, 2 Feb 2021 06:34:25 +0000 Message-ID: References: <20210113190114.19888-1-aiden.park@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2eb901e-ed85-4da8-902a-08d8c7449592 x-ms-traffictypediagnostic: BN6PR11MB3907: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rXdbmFJ/woGp1HmQAJkczqWM2uDCI0DCvY5laLJEAoD/UO7MOlBVZr/xFIygEyHip71c9eFkTmIgAe3TTIuCXXGU+t8qHvEPUt5pWLbkJ9OC/pG+hGoAzdYJJIKz282b3DdIQuLHVQ8IMQ9VseRxqXFPaxW4bPULmo8ZAxCxjLxS2OAUMxN9gSLxMT/gZQvoVVRAfb/JzVZskPKM5jw+35tcHLGOYf3lXumDxLhd0vyBILpQtJwDsjNYncZ9S0f0bQm0fMk2MV8PnRbLBIzeJBqo3jvl97B6Qo5dL/mmerVbJhJPW+26XNiGiew+YLXKe7w8T/iYL40jPtnHRNozhNbzx4L7uJql5hm/jzpXRyF2omg8KtFJQLy4DrN5s+CRzck4+wPbMcFT654AQa4R1oh9hFOpcGh5DZIcVQ6jm9EwVbv23wLaDsI68D0ZDcuXQ4kUBTzZzceoRzovzsK8MVdKaoEOXOD0Fi/XKhwAyAclO2uqUjJ5xn4i1PIvGbJerRU7M/UF7HLy9E9cLi19ifyUrZMV+eV6F7yYPh5D84eYThZiaHAAmDSx+fPZN2h6EcxvpG2zol5LccT/wRqZBcOTlBO2N0kacJb+Tzs9pH4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(76116006)(5660300002)(66556008)(66446008)(4326008)(86362001)(66476007)(64756008)(33656002)(66946007)(316002)(8936002)(966005)(478600001)(2906002)(110136005)(54906003)(52536014)(9686003)(186003)(55016002)(7696005)(6506007)(26005)(53546011)(71200400001)(8676002)(83380400001)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hUchvCdR1dwsKrwidZWdLH+qbKHjVnUVFkV+lt7K5PCHUJSaBbNPTpXKVsEz?= =?us-ascii?Q?dyUOGEI7DohvYLmf5h9YmBt/nt/4eCZakl6mckIxaDewijbp1tsBb2KbFh15?= =?us-ascii?Q?Os/4AnYwAEgQ/1RaWYOrUP2c9r2YO8Tx3HXQ2RxGvxw7OjBOUa8BuyUUWe6G?= =?us-ascii?Q?DP+sVA1R1NKx3gl/CgSsv1dtVihztSzyhe6eKwe9I5CqTTxQLOXv1LDZ/sOP?= =?us-ascii?Q?hbtFq1Ew/A9bEpYYh8I1RCbS+l4/+HuAXkciGv4I5GpsPnWydXm2w7C2glOm?= =?us-ascii?Q?kA9y0XsNzSEQIxm2BZeRcwSNnzaxcDhnVe6taAqn+fHlv74C0H7K3AuH/1X/?= =?us-ascii?Q?SKNXZ5VXdNzDJOTGANh4dpykVxvpZLArwe+gjISne7cVn7Rbp0c/e4dqbC+V?= =?us-ascii?Q?d4ixkOm+RoczH3clq2DxQN6lhZJ22a3rz7XWeP4qAe5YTldTWCxXdLngcDNd?= =?us-ascii?Q?7fuxmgWp45Euh3KMyzcAT5WF2heOv9KURGg7tdfFHEBqaKfubiuIFUSOdDAv?= =?us-ascii?Q?8ckj/N4qtAHj+ytiiTODUfQUvPpW2hrdsR58xjBSj84Vh1thv9Z3CcWdajXB?= =?us-ascii?Q?T1RDJQsf6KEuBVThRD025K51ZOnHvc+wolhPcgl1DDryHhAIXBfxvUudgVmk?= =?us-ascii?Q?qk9vmEsT7SoZBXd4TR8XkAnDRoctaH4HHai89sPkS+5rE2FQhb/d1ArFYrYi?= =?us-ascii?Q?t/ZnwVoiFx4cWLET1Djk+N15gnJsDqWX37tcMcQM28ZcHexg5wspJgnAY+aF?= =?us-ascii?Q?kE4bOp0uOj85kI61ZW8Q4EOIpQe9LMxDJs4gthXhx5yH0h+RwadWs4dWvH7X?= =?us-ascii?Q?km/v/XBRFWvfTtUsKvqGK5HV7opnvOLYOllBRrzlEsfw0+XnopjfJ3HjdAkV?= =?us-ascii?Q?BynYnGiG6KV0STBOHeYQk5HBkav6zR26yJHbdpdzQz9GkWQzDexarLW8+Xji?= =?us-ascii?Q?OTUSIkQFwlVTBYSCRcWsoOFbPfmlDNKhrLHJN5xI/xZq3dynB2NwtNqff5VZ?= =?us-ascii?Q?HKLlQ4bjTxvYNXrkYZ1rGLoNmAfxZuMFXUSY+k5KOzOVSDSGEsy73ultgWBF?= =?us-ascii?Q?SnAUrthy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2eb901e-ed85-4da8-902a-08d8c7449592 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 06:34:25.1450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZckFUjwL+vxxAkApyzhuETPBXO6KWR2Hr/FcjVp9VgqwVPBxE7csZyWh5CI6uz+7fImAzLvHI2pTqxVYUBbjng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3907 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ray > Sent: Friday, January 29, 2021 5:01 PM > To: Park, Aiden ; Wu, Hao A ; > devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > ProcessOptionRomLight >=20 > Reviewed-by: Ray Ni The patch has been pushed via: PR - https://github.com/tianocore/edk2/pull/1400 Commit - https://github.com/tianocore/edk2/commit/3f90ac3ec03512e2374cd2968= c047a7e856a8965 Best Regards, Hao Wu >=20 >=20 > > -----Original Message----- > > From: Park, Aiden > > Sent: Friday, January 29, 2021 9:55 AM > > To: Wu, Hao A ; Ni, Ray ; > > devel@edk2.groups.io > > Cc: Ma, Maurice ; Dong, Guo > > > Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > > ProcessOptionRomLight > > > > Hello, > > > > Can you please review this? > > > > > -----Original Message----- > > > From: Park, Aiden > > > Sent: Wednesday, January 13, 2021 11:01 AM > > > To: Wu, Hao A ; Ni, Ray ; > > > devel@edk2.groups.io > > > Cc: Park, Aiden ; Ma, Maurice > > > ; Dong, Guo > > > Subject: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > > > ProcessOptionRomLight > > > > > > From: Aiden Park > > > > > > The ProcessOptionRomLight() assumes that OpRom has already been > > > processed in the previous full enumeration and updates > > > AllOpRomProcessed flag to TRUE by default. However, this may not be > > > applicable with other pre-stage boot firmwares. > > > > > > This will update AllOpRomProcessed flag properly by checking > > > PciRomGetImageMapping(). > > > > > > Signed-off-by: Aiden Park > > > --- > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------ > > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > > index 1b64924b7b..e8337e865e 100644 > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > > @@ -1168,12 +1168,7 @@ ProcessOptionRomLight ( > > > ProcessOptionRomLight (Temp); > > > } > > > > > > - PciRomGetImageMapping (Temp); > > > - > > > - // > > > - // The OpRom has already been processed in the first round > > > - // > > > - Temp->AllOpRomProcessed =3D TRUE; > > > + Temp->AllOpRomProcessed =3D PciRomGetImageMapping (Temp); > > > > > > CurrentLink =3D CurrentLink->ForwardLink; > > > } > > > -- > > > 2.20.1 > > > > Best Regards, > > Aiden