[PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE
@ 2021-01-12  5:23 Heng Luo
  2021-01-12  5:23 ` [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability Heng Luo
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Heng Luo @ 2021-01-12  5:23 UTC (permalink / raw)
  To: devel; +Cc: Ray Ni, Hao A Wu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138

Change default value of PcdPcieResizableBarSupport to FALSE, avoid it
impacts existing platforms.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Heng Luo <heng.luo@intel.com>
---
 MdeModulePkg/MdeModulePkg.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 9173fdef83..1483955110 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -2047,7 +2047,7 @@
   #   TRUE  - PCIe Resizable BAR Capability is supported.<BR>
   #   FALSE - PCIe Resizable BAR Capability is not supported.<BR>
   # @Prompt Enable PCIe Resizable BAR Capability support.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE|BOOLEAN|0x10000024
+  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEAN|0x10000024
 
 [PcdsPatchableInModule]
   ## Specify memory size with page number for PEI code when
-- 
2.24.0.windows.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability
  2021-01-12  5:23 [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Heng Luo
@ 2021-01-12  5:23 ` Heng Luo
  2021-01-13  5:54   ` Wu, Hao A
  2021-01-12 19:02 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Laszlo Ersek
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Heng Luo @ 2021-01-12  5:23 UTC (permalink / raw)
  To: devel; +Cc: Ray Ni, Hao A Wu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138

PcdPcieResizableBarSupport was added in MdeModulePkg.dec, update
UNI file as the documentation of the PCD.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Heng Luo <heng.luo@intel.com>
---
 MdeModulePkg/MdeModulePkg.uni | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 1b347a75f6..ef9f4d97b9 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -4,7 +4,7 @@
 // It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library classes)
 // and libraries instances, which are used for those modules.
 //
-// Copyright (c) 2007 - 2020, Intel Corporation. All rights reserved.<BR>
+// Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
 //
 // SPDX-License-Identifier: BSD-2-Clause-Patent
 //
@@ -1324,3 +1324,9 @@
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT #language en-US "Guest-Hypervisor Communication Block (GHCB) Pool Base Size"
 
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP #language en-US "Used with SEV-ES support to identify the size of the address range that is not to be encrypted."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_PROMPT #language en-US "Enable PCIe Resizable BAR Capability Supported"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HELP #language en-US "Indicates if the PCIe Resizable BAR Capability Supported.<BR><BR>\n"
+                                                                                            "TRUE  - PCIe Resizable BAR Capability is supported.<BR>\n"
+                                                                                            "FALSE - PCIe Resizable BAR Capability is not supported.<BR>"
-- 
2.24.0.windows.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability
  2021-01-12  5:23 ` [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability Heng Luo
@ 2021-01-13  5:54   ` Wu, Hao A
  2021-01-13  6:06     ` [edk2-devel] " Ni, Ray
  0 siblings, 1 reply; 8+ messages in thread
From: Wu, Hao A @ 2021-01-13  5:54 UTC (permalink / raw)
  To: Luo, Heng, devel@edk2.groups.io; +Cc: Ni, Ray

Acked-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: Luo, Heng <heng.luo@intel.com>
> Sent: Tuesday, January 12, 2021 1:23 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable
> BAR Capability
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138
> 
> PcdPcieResizableBarSupport was added in MdeModulePkg.dec, update UNI
> file as the documentation of the PCD.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.uni | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni index 1b347a75f6..ef9f4d97b9
> 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -4,7 +4,7 @@
>  // It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and
> library classes) // and libraries instances, which are used for those modules.
> //-// Copyright (c) 2007 - 2020, Intel Corporation. All rights reserved.<BR>+//
> Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR> // //
> SPDX-License-Identifier: BSD-2-Clause-Patent //@@ -1324,3 +1324,9 @@
>  #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT
> #language en-US "Guest-Hypervisor Communication Block (GHCB) Pool Base
> Size"  #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP
> #language en-US "Used with SEV-ES support to identify the size of the
> address range that is not to be encrypted."++#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_PRO
> MPT #language en-US "Enable PCIe Resizable BAR Capability
> Supported"++#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HEL
> P #language en-US "Indicates if the PCIe Resizable BAR Capability
> Supported.<BR><BR>\n"+
> "TRUE  - PCIe Resizable BAR Capability is supported.<BR>\n"+
> "FALSE - PCIe Resizable BAR Capability is not supported.<BR>"--
> 2.24.0.windows.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability
  2021-01-13  5:54   ` Wu, Hao A
@ 2021-01-13  6:06     ` Ni, Ray
  0 siblings, 0 replies; 8+ messages in thread
From: Ni, Ray @ 2021-01-13  6:06 UTC (permalink / raw)
  To: Wu, Hao A, devel

[-- Attachment #1: Type: text/plain, Size: 40 bytes --]

Reviewed-by: Ray Ni <ray.ni@intel.com>

[-- Attachment #2: Type: text/html, Size: 99 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE
  2021-01-12  5:23 [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Heng Luo
  2021-01-12  5:23 ` [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability Heng Luo
@ 2021-01-12 19:02 ` Laszlo Ersek
  2021-01-13  3:12 ` Ni, Ray
  2021-01-14  1:47 ` Wu, Hao A
  3 siblings, 0 replies; 8+ messages in thread
From: Laszlo Ersek @ 2021-01-12 19:02 UTC (permalink / raw)
  To: devel, heng.luo; +Cc: Ray Ni, Hao A Wu

On 01/12/21 06:23, Heng Luo wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138
> 
> Change default value of PcdPcieResizableBarSupport to FALSE, avoid it
> impacts existing platforms.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 9173fdef83..1483955110 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2047,7 +2047,7 @@
>    #   TRUE  - PCIe Resizable BAR Capability is supported.<BR>
>    #   FALSE - PCIe Resizable BAR Capability is not supported.<BR>
>    # @Prompt Enable PCIe Resizable BAR Capability support.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE|BOOLEAN|0x10000024
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEAN|0x10000024
>  
>  [PcdsPatchableInModule]
>    ## Specify memory size with page number for PEI code when
> 

series
Acked-by: Laszlo Ersek <lersek@redhat.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE
  2021-01-12  5:23 [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Heng Luo
  2021-01-12  5:23 ` [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability Heng Luo
  2021-01-12 19:02 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Laszlo Ersek
@ 2021-01-13  3:12 ` Ni, Ray
  2021-01-14  1:47 ` Wu, Hao A
  3 siblings, 0 replies; 8+ messages in thread
From: Ni, Ray @ 2021-01-13  3:12 UTC (permalink / raw)
  To: Luo, Heng, devel@edk2.groups.io; +Cc: Wu, Hao A

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Luo, Heng <heng.luo@intel.com>
> Sent: Tuesday, January 12, 2021 1:23 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH 1/2] MdeModulePkg: Change default value of
> PcdPcieResizableBarSupport to FALSE
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138
> 
> Change default value of PcdPcieResizableBarSupport to FALSE, avoid it
> impacts existing platforms.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 9173fdef83..1483955110 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2047,7 +2047,7 @@
>    #   TRUE  - PCIe Resizable BAR Capability is supported.<BR>
> 
>    #   FALSE - PCIe Resizable BAR Capability is not supported.<BR>
> 
>    # @Prompt Enable PCIe Resizable BAR Capability support.
> 
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE|BOOLE
> AN|0x10000024
> 
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOL
> EAN|0x10000024
> 
> 
> 
>  [PcdsPatchableInModule]
> 
>    ## Specify memory size with page number for PEI code when
> 
> --
> 2.24.0.windows.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE
  2021-01-12  5:23 [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Heng Luo
                   ` (2 preceding siblings ...)
  2021-01-13  3:12 ` Ni, Ray
@ 2021-01-14  1:47 ` Wu, Hao A
  2021-01-14 14:25   ` Laszlo Ersek
  3 siblings, 1 reply; 8+ messages in thread
From: Wu, Hao A @ 2021-01-14  1:47 UTC (permalink / raw)
  To: Luo, Heng, Laszlo Ersek, devel@edk2.groups.io; +Cc: Ni, Ray

The series has been merged via commits:
https://github.com/tianocore/edk2/commit/ef23012e5439f14864630630d2e218aeab7df501
https://github.com/tianocore/edk2/commit/da45a3608787d77fc55d915bee3903f5119b3ee6

Best Regards,
Hao Wu

> -----Original Message-----
> From: Luo, Heng <heng.luo@intel.com>
> Sent: Tuesday, January 12, 2021 1:23 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH 1/2] MdeModulePkg: Change default value of
> PcdPcieResizableBarSupport to FALSE
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138
> 
> Change default value of PcdPcieResizableBarSupport to FALSE, avoid it
> impacts existing platforms.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 9173fdef83..1483955110
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2047,7 +2047,7 @@
>    #   TRUE  - PCIe Resizable BAR Capability is supported.<BR>   #   FALSE - PCIe
> Resizable BAR Capability is not supported.<BR>   # @Prompt Enable PCIe
> Resizable BAR Capability support.-
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE|BO
> OLEAN|0x10000024+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BO
> OLEAN|0x10000024  [PcdsPatchableInModule]   ## Specify memory size with
> page number for PEI code when--
> 2.24.0.windows.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE
  2021-01-14  1:47 ` Wu, Hao A
@ 2021-01-14 14:25   ` Laszlo Ersek
  0 siblings, 0 replies; 8+ messages in thread
From: Laszlo Ersek @ 2021-01-14 14:25 UTC (permalink / raw)
  To: Wu, Hao A, Luo, Heng, devel@edk2.groups.io; +Cc: Ni, Ray

On 01/14/21 02:47, Wu, Hao A wrote:
> The series has been merged via commits:
> https://github.com/tianocore/edk2/commit/ef23012e5439f14864630630d2e218aeab7df501
> https://github.com/tianocore/edk2/commit/da45a3608787d77fc55d915bee3903f5119b3ee6

Thank you all for the quick action.
Laszlo

>> -----Original Message-----
>> From: Luo, Heng <heng.luo@intel.com>
>> Sent: Tuesday, January 12, 2021 1:23 PM
>> To: devel@edk2.groups.io
>> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>> Subject: [PATCH 1/2] MdeModulePkg: Change default value of
>> PcdPcieResizableBarSupport to FALSE
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3138
>>
>> Change default value of PcdPcieResizableBarSupport to FALSE, avoid it
>> impacts existing platforms.
>>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Signed-off-by: Heng Luo <heng.luo@intel.com>
>> ---
>>  MdeModulePkg/MdeModulePkg.dec | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>> b/MdeModulePkg/MdeModulePkg.dec index 9173fdef83..1483955110
>> 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -2047,7 +2047,7 @@
>>    #   TRUE  - PCIe Resizable BAR Capability is supported.<BR>   #   FALSE - PCIe
>> Resizable BAR Capability is not supported.<BR>   # @Prompt Enable PCIe
>> Resizable BAR Capability support.-
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE|BO
>> OLEAN|0x10000024+
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BO
>> OLEAN|0x10000024  [PcdsPatchableInModule]   ## Specify memory size with
>> page number for PEI code when--
>> 2.24.0.windows.2
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-01-14 14:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-12  5:23 [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Heng Luo
2021-01-12  5:23 ` [PATCH 2/2] MdeModulePkg: Update UNI file for PCIe Resizable BAR Capability Heng Luo
2021-01-13  5:54   ` Wu, Hao A
2021-01-13  6:06     ` [edk2-devel] " Ni, Ray
2021-01-12 19:02 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Change default value of PcdPcieResizableBarSupport to FALSE Laszlo Ersek
2021-01-13  3:12 ` Ni, Ray
2021-01-14  1:47 ` Wu, Hao A
2021-01-14 14:25   ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox