From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.1763.1605064203215470264 for ; Tue, 10 Nov 2020 19:10:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XLUQr37+; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) IronPort-SDR: xgkaxhcMcKh4oTPuAes66HCle0yuXWDZsas+XuZ0hEp06WXDepH66Tpi0FWniP2p7AVSJlNPmd C2SnDzg6j95A== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="254796039" X-IronPort-AV: E=Sophos;i="5.77,468,1596524400"; d="scan'208";a="254796039" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 19:10:02 -0800 IronPort-SDR: BI7HwI4UgstpsBjjiqa8rpc1Q/x2Lq5rdAzNczZqDE3ZUjd+SjSLfVK9mJFrrr+qqchTbBblF0 YgramHYw4Sag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,468,1596524400"; d="scan'208";a="338944948" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 10 Nov 2020 19:10:02 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Nov 2020 19:10:01 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Nov 2020 19:10:01 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Nov 2020 19:10:01 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 10 Nov 2020 19:10:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wh3bWoSlfiAumfuBD30KoHKj4vG0MjJ50epyFaABJ8wqq+D3m5Jnj6YjVdN8nlN46Lknt43hWceNgdxP/Bbo7LsoTMu/otKBjibo5TD3UrV5idTGo/HB71uRXTEVXCk5nzZCfSIax8U4YTj0htk/GtVpjbSllPzJpp842gqIvVPe8BZFhhSnxZA7469/tfGm1hVtZ7iVAckJ32wWUcRKze35jn6Fqrn9J/RdC8AxsnZ/7U5WBJ1CZcpYAivEGA3lAfgfnyh1r3H4+iGLWUcqcybVU0B/aZyFAOMNznWm73TTUlctZHBMogHu9fm3/5qBqMIshCuH2ylgMEAHAd6RRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pRVchdYC1CTm0/fAQe6VhjMAb6zqdwx9M+d8v4xA3No=; b=TqakYOTXClP2Nz2TwGxl7CfwFGDh29BT+kk+MPHDUwvJ6BKFk47ZQZ8fmw2nxKDOp9uPKF7beXgA/36EoWNrVEEeZPs3RCxLrmScrSLG+tDI5+gr1rIM3BbX9VAw9RkDufDX1uGpVVO7hv4qZYPcABKx4IO+3jh138SB5jTLz7F7DLFiuLOG/6u8vzrIw5EiwB6Ww2QIg65tPQhnnRv6H4+l0XZZpemWNS7BC0kBkcsmLhDrMwGVprvSRSfepICpcppzqjtaOOgrpjE7LJGR6kOGbzUHUzmQhfB74+yo8bhJn6eglxC+oPrBmmurDJ9YCBraGjxjaUCPJeJ1PHDO6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pRVchdYC1CTm0/fAQe6VhjMAb6zqdwx9M+d8v4xA3No=; b=XLUQr37+6kJhxpzwRmirqbhquSmJtphphA97gYmKGHrM4N95W1l7wSsl2IfzEBOAHg1tb7m9NTOmxBOSa/J7e89zeCiZLRcRTWgORMXkdDROMduKioZ023YD/OaUEarxGMo3Tr+WaD2g9ss2wsWKfrgIFuFvGpMUG5tc4th7YCM= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR11MB1714.namprd11.prod.outlook.com (2603:10b6:404:47::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Wed, 11 Nov 2020 03:09:59 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::c123:faac:1da3:f807]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::c123:faac:1da3:f807%5]) with mapi id 15.20.3541.025; Wed, 11 Nov 2020 03:09:59 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Albecki, Mateusz" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery Thread-Topic: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery Thread-Index: AQHWs3D4Cm8Vl5vJQkuncLnB3wdsIKm5fWIwgAWG/cCAA0SI8A== Date: Wed, 11 Nov 2020 03:09:58 +0000 Message-ID: References: <16449D11B4E4D780.24349@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 715d6d60-bdf1-48b6-5df1-08d885ef4607 x-ms-traffictypediagnostic: BN6PR11MB1714: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lz16sJpWZVWTTfcXM/CFfT27cg4MY4awzCNAsLxiQp/T1UvPA8hD5iRtFtKGPnBVAtJrUVRVgeC3wEkVNMtYmau9xaWPCEip1V6/SpVQOJo58r79+VrUHa6SY6CRDQd7ZChnbqcGNxb03N3/UcItA4fDgLH6/+KpP5/Gd2ArJ40o+Ux3C/sZ9I6Axd7Y/HMT7VM5KPP2gmHX+kM3zFms5Kj0ZfoCbErFg3D0I36fzVec2felt5q/NpMe/xUNHCj5EJrUZsJb3h/bs7pcbVfO3wwT+cHKLT48PzVYjyZphNp7NeRsteU9FPHq2wyfFGiPim8TGJp660OdoQV/pnLfrywMJWfMzzAt4Znwdz0ibrHDCjM/VkaDEPXnpR7v/pVKhGqvwwxwE3qKK54sS/3Tzg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(316002)(4326008)(966005)(86362001)(110136005)(83380400001)(66476007)(478600001)(107886003)(64756008)(52536014)(26005)(33656002)(66556008)(5660300002)(66446008)(66946007)(8676002)(7696005)(71200400001)(55016002)(6506007)(9686003)(2906002)(6636002)(76116006)(53546011)(8936002)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 8P3wT+YkUl3HgOmylnC+irVDDrtBDIDwQNaUOUT1/mGS3atrL8swF4WdgavTT8nfc+W9anr57EaMSZPkPnhe0d9oJyQrrg5qKLK5HUp1jdOU+cITpF6ds3BqZRvNaGgqxlurU5ZKTD+hDMjlAbbjuDtwl8wHnrhWStS7vICz30zJf8RoDW6RjPgiQp0gPival2mdRVb5ngVkvDzFRtZbtMnxQxJxXdpAGH3CdCtmM77ZkD3VdOKjdyS4SKywHdfRrd/DPKYafonl5mEykmcLavmiMJjxegs/ocNIjeUMRJdf2CmVuJDNCZlidtV5BAKCBAR/3SHJgYqdRILneDLxizS2DOzcSPtEGbWnybzWxfIIrvf6+xz9qKjJpVhqRd2M9/g+i1VE+BzE1GfNqooco4tWU6IsPvmD8bBTn6xm7RLjN7sqlPpfZ0UfRTOHeHRz7Nnbe7Shap3lUxGplsSCPjycB/qI7XKBZ55wy9Dum5CSVCZmG7n7VcPBiva6Y8eydUO3DbY7HgxWqPE0+WI9fTc7eNr5iPvGp4GS01EJ6j5Ld/A8l7w2S4KRIx8nUU97Kh7tiHdtExxf8zvmgJYookRyIOP2yNEO3Ys4YWi296/TLnoXxInXbvhXIBZaV+luLsob3FeB3yBOBx2npUifySwC7xrpgi3Um8XMQtRl4KMcAknF/wRvkCDCz9R59TUzN7zuW8j8S4jhDUDyEFlEgN1Pgzh2H6Q+5EL1RHtvKIBDEN6n91Qj1YqkSnFK7jZjwy7oItTLinPh6mU844Y+dnnKxhk02py7mNgM3NJBlQvzWqHedyo0W3ogf+0qmqwRztf2q+SflJP+wBSvZKxx6U2NkGRc550eq4cyFDOL95SypkFME+mbIqQe1AVzfYiZqft1kwS6s6uzLt1TdvwZcA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 715d6d60-bdf1-48b6-5df1-08d885ef4607 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 03:09:59.0771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xCkR+WA61o6aLQ9/njU74yfxEaigomABmTme/bbugPxUDDf8DyrZMPwMiLiGcEhAoeenG3kr+6ZgwrgCkoN3NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1714 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Monday, November 9, 2020 9:17 AM > To: Albecki, Mateusz ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/AtaAtapiPassThru: > Add SATA error recovery >=20 > > -----Original Message----- > > From: Albecki, Mateusz > > Sent: Thursday, November 5, 2020 8:51 PM > > To: devel@edk2.groups.io; Albecki, Mateusz > > Cc: Ni, Ray ; Wu, Hao A > > Subject: RE: [edk2-devel] [PATCHv2 0/4] > MdeModulePkg/AtaAtapiPassThru: > > Add SATA error recovery > > > > Forgot to put BZ tracker into v2 commit msg so I have resent the > > series as v3 with proper bz info. >=20 >=20 > (Seems no separate cover-letter sent for V3, replies here) I have given = my 'R- > b' tags for the V3 series: > https://edk2.groups.io/g/devel/topic/78049844#67059 > https://edk2.groups.io/g/devel/topic/78049845#67060 > https://edk2.groups.io/g/devel/topic/78049846#67061 > https://edk2.groups.io/g/devel/topic/78049847#67063 >=20 > Will wait a couple of days to see if there are comments from others. V3 series has been pushed via: PR: https://github.com/tianocore/edk2/pull/1113 Commits: https://github.com/tianocore/edk2/commit/cc28ab7a1d7353ad7ade55d19e58e85c5= 0d8fa4d https://github.com/tianocore/edk2/commit/b465a811006eb1663068380dded041d28= 7ace907 https://github.com/tianocore/edk2/commit/64e25d4b062c907dab2dd30b686de9219= d8e372c https://github.com/tianocore/edk2/commit/91d95113d07aee4a11e9dac02c1a836c7= 360d422 Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Albecki, Mateusz > > > Sent: Thursday, November 5, 2020 1:41 PM > > > To: devel@edk2.groups.io > > > Cc: Albecki, Mateusz ; Ni, Ray > > > ; Wu, Hao A > > > Subject: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/AtaAtapiPassThru: > > > Add SATA error recovery > > > > > > To increase boot stability when booting from SATA drives SATA driver > > > should implement the AHCI spec defined port error recovery. This > > > will allow the driver to handle random fails on SATA link. > > > > > > Performed tests on 2 setups. One with AHCI controller booting OS > > > successfully without error recovery(control setup) and other which > > > fails 1 in 5 times(fail setup). > > > > > > Tests performed: > > > 1. Booted control setup to OS successfully. > > > 2. Checked if during normal boot none of the packets is > > > repeated(this came up after previous code version had a bug which > > > repeated each DMA packet 5 times). > > > 3. Booted control setup to OS with simulated errors appearing on > > > first packet of every DMA transaction. > > > 4. Performed extensive tests on fail setup. Fail rate decreased from > > > 20% failure to ~1% failure. 1% failure is observed during OS > > > execution, not BIOS so in a way boot is 100% stable). > > > > > > Change pushed to github: > > > This series: > > > https://github.com/malbecki/edk2/commits/sata_recovery2 > > > Simulated errors: > > > > > > https://github.com/malbecki/edk2/commits/sata_recovery_simulated_erro > > > r > > > > > > Some more information: > > > For the bug mentioned above in point 2, the discussion can be > > > referred > > here: > > > > > > https://github.com/malbecki/edk2/commit/9ea81cadf38725e194ec01e0b0c5 > > > 56fd133f3ced#r43226067 > > > > > > For the other discussion we did before this patch, please refer to: > > > https://github.com/malbecki/edk2/commits/sata_recovery > > > > > > For logging here is the example of verbose command log(taken from v1 > > > patch): > > > Starting commmand: > > > ATA COMMAND BLOCK: > > > AtaCommand: 37 > > > AtaFeatures: 0 > > > AtaSectorNumber: 0 > > > AtaCylinderLow: 16 > > > AtaCylinderHigh: 16 > > > AtaDeviceHead: 224 > > > AtaSectorNumberExp: 57 > > > AtaCylinderLowExp: 0 > > > AtaCylinderHighExp: 0 > > > AtaFeaturesExp: 0 > > > AtaSectorCount: 64 > > > AtaSectorCountExp: 0 > > > DMA command failed at retry: 0 > > > DMA retry 1 > > > Starting commmand: > > > ATA COMMAND BLOCK: > > > AtaCommand: 37 > > > AtaFeatures: 0 > > > AtaSectorNumber: 0 > > > AtaCylinderLow: 16 > > > AtaCylinderHigh: 16 > > > AtaDeviceHead: 224 > > > AtaSectorNumberExp: 57 > > > AtaCylinderLowExp: 0 > > > AtaCylinderHighExp: 0 > > > AtaFeaturesExp: 0 > > > AtaSectorCount: 64 > > > AtaSectorCountExp: 0 > > > ATA STATUS BLOCK: > > > AtaStatus: 80 > > > AtaError: 0 > > > DMA retry 0 > > > > > > Changes in v2: > > > - Changed logging per review suggestions > > > - Fixed small issues with commit message > > > > > > Signed-off-by: Mateusz Albecki > > > > > > Cc: Ray Ni > > > Cc: Hao A Wu > > > > > > > > > Mateusz Albecki (4): > > > MdeModulePkg/AtaAtapiPassThru: Check IS to check for command > > > completion > > > MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery flow > > > MdeModulePkg/AtaAtapiPassThru: Restart failed packets > > > MdeModulePkg/AtaAtapiPassThru: Trace ATA packets > > > > > > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 799 +++++++++++----= --- > > > .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 18 +- > > > 2 files changed, 532 insertions(+), 285 deletions(-) > > > > > > -- > > > 2.28.0.windows.1 > > > > > > -------------------------------------------------------------------- > > > - > > > Intel Technology Poland sp. z o.o. > > > ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII > > > Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP > > > 957-07-52-316 > > > | Kapita zakadowy 200.000 PLN. > > > Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego > > > adresata i moe zawiera informacje poufne. W razie przypadkowego > > > otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae > > > jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest > zabronione. > > > This e-mail and any attachments may contain confidential material > > > for the sole use of the intended recipient(s). If you are not the > > > intended recipient, please contact the sender and delete all copies; > > > any review or distribution by others is strictly prohibited. > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20