From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.30547.1607926928153678748 for ; Sun, 13 Dec 2020 22:22:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aH6xX9US; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) IronPort-SDR: zmcqtgASlfnab9pY8cRL3xhvUqaBGO4HQM+utnaITQeUVnEviJngfm0dx9aJa6CFvNGzkSzZdb tHLeXGOWaYJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="171152967" X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="171152967" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 22:22:06 -0800 IronPort-SDR: Bs8LFAl5UbZREEi5ZccCA4xxThn0Zga12/aRO7D8qH3JeWZftpep5xCUgFEMAd1X6161z98MFd KXyVMtKUzuqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="387679557" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 13 Dec 2020 22:22:06 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 13 Dec 2020 22:22:06 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 13 Dec 2020 22:22:05 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 13 Dec 2020 22:22:05 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 13 Dec 2020 22:22:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WK1KZfZ4LZOdNObluS8V5OloGg3zp0uTl8Q9oVg5ZQq3X7KmAD0qt7qjvURx8ewe2/UdhbXcx/08l6vWi345hlDjXSMgKIgrELhXeHUwWq3z/cnClx7QB7TXDS68e9TL+vHA4TRZ/Foty+J6zYbOBLbpHisxFMuMwwVzZwgkMizRarqNE5pRhm/cpfaSUn3B7u8Ra8nXxrzq3yZwX2Yv6m/7WSAe4toVpZww/C2STvaKMKM9Y9Hlt3iWdMx6tmi9Q8rkOVlOdUcVXA2blfsRXhvVFOAWr+Aj7N/iglTIixQbeXtpte/xgvJWRKiE876vRvGvqR7k8ue7GPcxg+SrBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecLy8MfT6iIHnCZhV3AihA7wom6/bqFlx+RDI72mPVQ=; b=O/ugcre4f7ieeRIJQzk5aiBAnXK8tBj67eYepzlxkf59b/wk6v1VbTPdapZso++YKHEwO7gTNyEo1z1CmFZgffy9qP61HcSzKDE7Bfbch46ogdsNzA3LmVCu1sc54x4qqymSVwC0iIM+h4StWlQ31ThCslCkHHIgUazMivVoxiRaUzbdiXtJoePrEeVUMmm1Ds7spTwqVGV1+6Yl4QxED5K9Q9QiA8Z8/wSby14gWw7Dep6ouBWKDESJrlZOcwMy7gIC2ECN43MoXd9vY2b1Eo3eWBxtJxRORejdzArhPC6HLSl+kdyasfQsgf8VQrb2QKrhIjlTHhzxBwSHjo3YCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecLy8MfT6iIHnCZhV3AihA7wom6/bqFlx+RDI72mPVQ=; b=aH6xX9USeuoUvnvmGFBT3Fd2IUcCIg4zXI97Tv7qoHuvygpBthcW+P8pd6hUAzB5xP7a1o9hLnHhWWntYxAzjyDccBfDKXs6hJ/vzDrohAvPjfUQ2VkuYPGiF/UFKDMwIC9Nzn9820kDHwFkidTZqnFEV1vVhjkP40ihjfP+TS8= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN6PR1101MB2097.namprd11.prod.outlook.com (2603:10b6:405:50::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Mon, 14 Dec 2020 06:22:03 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::4cda:993f:ffc1:f169]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::4cda:993f:ffc1:f169%6]) with mapi id 15.20.3654.024; Mon, 14 Dec 2020 06:22:03 +0000 From: "Wu, Hao A" To: Vitaly Cheptsov , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Albecki, Mateusz" , Laszlo Ersek Subject: Re: [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Topic: [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Index: AQHWz5+xKroIEV71V06Yg+/i73UOVKn2GUaQ Date: Mon, 14 Dec 2020 06:22:03 +0000 Message-ID: References: <20201211092502.21763-1-cheptsov@ispras.ru> In-Reply-To: <20201211092502.21763-1-cheptsov@ispras.ru> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: ispras.ru; dkim=none (message not signed) header.d=none;ispras.ru; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd70eb03-1705-4fb9-475d-08d89ff892d7 x-ms-traffictypediagnostic: BN6PR1101MB2097: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kxwE/RrOpnYnm0ZKo3uThdNybMUEyXVhucI7wCl05ghjKPa2jkZ7dQttZK0ca9AMbOeN9Eh7WFZ3dfqnxvb/hbotrBbYtoG+e5qRPKxp8Q9CEARM28IMHNUflyIKeZOAiJ6LZ+E1kAkz+JmVoTTPo6C4MuiA4Fn0QMPuMD1q91ywd+mxm4RBfRKVE5vyJ8whIIu40DCk6TDQWYVhhYsHDcnp+G1yxCSAIKYufmGiNyfYGxf070/8uMf1V9f75SrSm/hawNrR4zT6iewLISMTvb1UiOyVYZQuArfvr1cxkfcwC+rygxR9VZ7TAlY68NHZPJiDRVoa8cBlJ3hFFQ7XVgRGUnxTsP8a/PFo/mRnTorwZHSOYEE1or7fCQNW/wvK45N3O52tRWMYnKxsTWDbuQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(366004)(55016002)(71200400001)(66946007)(83380400001)(8676002)(6506007)(64756008)(66476007)(66446008)(52536014)(9686003)(53546011)(4326008)(110136005)(508600001)(86362001)(33656002)(8936002)(66556008)(5660300002)(54906003)(966005)(76116006)(2906002)(186003)(7696005)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/yPv9Fx5zrZKRdJNhq7IC8WqA1zWI5ZKyJk/amNbaaa6JiZEl8xsYKjZs/pW?= =?us-ascii?Q?OWVJqSDuKQ27i121YLgkkkPPrl3RIczPf+IIRlWa6L8KV/eG5utBr2XWc2H1?= =?us-ascii?Q?ZHp5lRtxvVZWUxctqkozG3aTIgmBmInLo5E5p/ht1cb0X2jQ3Ksg1DcKkzW0?= =?us-ascii?Q?D+MyeWHC4E2htAKHBKYf3GrzH4rn2g5xMMInQLEi2kHySNX0S1FNEELwXWhf?= =?us-ascii?Q?5zlojuTEBR9HTS5S2RFHZYkBS2jFOmWgHGqXUH3n8MbxXH8qN+7vsmzbbtG/?= =?us-ascii?Q?1q77BhmprEDQuuNwIG4NE86eneS7yFKXduH+E+CVztAxTTNM/lRd8Wl31fxX?= =?us-ascii?Q?DDIb75qhCK6Q75AGwBSpH70HsR+zVt2Zzf0dsouNKBx03Jrrng8o8oTxhApG?= =?us-ascii?Q?Y+PEEiRrvwFg1muC33iU6aYqFFgafFgsbEa6wrM26ndp4huPCLq0nSDl5BgM?= =?us-ascii?Q?Y2w75MLq7Q+0x3IplE39jxvtPmQ1yqFRERALW2eml7ZXIpZZRb1NBU00tN7M?= =?us-ascii?Q?g/p/pGPSLNpmQ846lCqjv8ZH0Bz/c9b4LebMZyeNpALUPpg0S+CcWuOjb/lK?= =?us-ascii?Q?FXI3VUnl2kpMLrOxqZRnZIBCk6YX3fK4UgRE67JiouapOBKZsy2KsEHT9QWb?= =?us-ascii?Q?nUCT57ZcqVwDGizbakBniw3POuhIRIbb7yHGVD4dRjW2Ue70KpXG2EbBuvyY?= =?us-ascii?Q?MQaWtOu2EbyfAnfp9yEMoQdWOwOMNeyu/wQEpFYf+P9R+YJsuR1Hc0Clt7ju?= =?us-ascii?Q?kMfGvEuBNfkzEe7F/4Wni5XtIZ3nLt8kIg8RoqAQP47yJlN5IxNW/lBsePag?= =?us-ascii?Q?Qa3KKkislWzGKnMm+9q00CPDXSQblVjIgoRkkG/bDcqZV8v0ALoMAV/MOi/4?= =?us-ascii?Q?TIxPoFBPANJrMBqVyjNSHKczvD/GJj/1ZeKGOp3BgvP61HbIUNGeKbR2axfD?= =?us-ascii?Q?XV7Q+T52YxNHMpY5r024HNx8Dm6UEiI2HUZfDAcUZ1c=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd70eb03-1705-4fb9-475d-08d89ff892d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2020 06:22:03.6053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hNeFItuAG8noSw5zQgVIa25/XjFLXA853aaEJRqFg0UIyRpTME6uo0XqYCgyjziZ8VoaqKv581Tx0r+tYu1huA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2097 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Vitaly Cheptsov > Sent: Friday, December 11, 2020 5:25 PM > To: devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Wang, Jian J > ; Wu, Hao A ; Albecki, > Mateusz ; Laszlo Ersek > Subject: [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for > drives in RAID mode >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3118 >=20 > This resolves the problem of using drivers connected to Intel G33 builtin > SATA controller when run from DuetPkg when it can only be configured in > RAID mode through the firmware settings. Hello Vitaly, If my understanding is correct, this driver (SataControllerDxe) and the AtaAtapiPassThru driver are written for non-RAID case only. Both drivers (especially AtaAtapiPassThru) do not distinguish logic/physica= l SCSI channels, which I think only works for the non-RAID case. I am not sur= e if this patch series will have an impact to existing RAID drivers. Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Mateusz Albecki > Cc: Laszlo Ersek > Signed-off-by: Vitaly Cheptsov > --- > MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > index ab06e2833c..301335c967 100644 > --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > @@ -324,7 +324,7 @@ SataControllerSupported ( > return EFI_UNSUPPORTED; > } >=20 > - if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) { > + if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) || IS_PCI_RAID > + (&PciData)) { > return EFI_SUCCESS; > } >=20 > @@ -465,7 +465,7 @@ SataControllerStart ( > if (IS_PCI_IDE (&PciData)) { > Private->IdeInit.ChannelCount =3D IDE_MAX_CHANNEL; > Private->DeviceCount =3D IDE_MAX_DEVICES; > - } else if (IS_PCI_SATADPA (&PciData)) { > + } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) { > // > // Read Ports Implemented(PI) to calculate max port number (0 based)= . > // > -- > 2.24.3 (Apple Git-128)