From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.24145.1626674121154645781 for ; Sun, 18 Jul 2021 22:55:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=p0nrEpR1; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10049"; a="296559337" X-IronPort-AV: E=Sophos;i="5.84,251,1620716400"; d="scan'208";a="296559337" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2021 22:55:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,251,1620716400"; d="scan'208";a="414747660" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 18 Jul 2021 22:55:18 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 18 Jul 2021 22:55:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 18 Jul 2021 22:55:18 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 18 Jul 2021 22:55:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+/t/hdPsFlod2qPzF0xY5oaEx2k1jiL+aMab3FfWbJhQzvF1fj2iWhJRJYwgz+99L2ryUFHlx4iifKFzt5YBBrVc1OHYFQ+GEoO8CRPy8GcLcw5xRMD09lAhzL8Ui3gV2UbQN12Y0EAG+onOU8AM8YwzcMezifcoK1Eo05MHyuqdsJoaczakCr/EKfkmUnX8h1B9IZ0lEnii/cK0HYuXLtySRMwp3lBQfSup2lqW1Ijf52Fy3KpG74ocndoob46aoRMrFhPlq9lh/5IYSpYFnc2eH7LwTBV2Hg5mj1DgLbkhM8h6fchKuqJ2ALqFNReBpS9n11eQTG2IMgDiaJThQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HqjUKToe2MUZBcUOEPIS6wVzMG83IGk5mKER7mLM/Tg=; b=B6nmsn2FQdw0sAoDlLyLTnm4SgX6WSJyAKXt+eA+yYKZwfMeBksqJnsSL+Yz99xOtjLkjs3Gx6XSYaZtLPkCYZNCl73gKRusgLbGXfiYiV3BK0wYOe85D6EOJsOoSk8tA7w5VltypNfSqhXN7L9UXSUfQRw2hIESRiKvlWoQXC7MsVO0I0EAq67DmwKCNepWpQIlcejQqUJ3xtsilLJ3wCmT1t37So3r6tTpNuOvDWXxS8vZXeVSBJBZbjeqASHGGCsRp4/4ODapWQLcYAI31IRPbADdqXqIMZ3WNkNMhoN3htq8GuF0WKMqGJia7JyQC9v15P4sFtsBD2ukUzuv0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HqjUKToe2MUZBcUOEPIS6wVzMG83IGk5mKER7mLM/Tg=; b=p0nrEpR1A+KXCsgEmzcPEMG4d9tZtJxkbIVVgRWJosxQbpg67/XHfkfz6tIBCCPM7cpcymWi3dr6QhBUzhsMSY83saVEpiZTDsffsyelcGBBPiIoZmIh53F6lNhqLBdtDlRNF4C5Fs2w7cVBjQRzliCREpKjXv+hpjIukv8a/U4= Received: from BN8PR11MB3666.namprd11.prod.outlook.com (2603:10b6:408:8c::19) by BN8PR11MB3537.namprd11.prod.outlook.com (2603:10b6:408:87::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Mon, 19 Jul 2021 05:55:13 +0000 Received: from BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d]) by BN8PR11MB3666.namprd11.prod.outlook.com ([fe80::cd58:25ce:5017:619d%5]) with mapi id 15.20.4331.032; Mon, 19 Jul 2021 05:55:13 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "daniel.schaefer@hpe.com" CC: "Wang, Jian J" , "Bi, Dandan" , Liming Gao Subject: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was unable to be found Thread-Topic: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was unable to be found Thread-Index: AQHXeGrVlYk6WBSx+UOeNUCGb4Dx66tJ1Alw Date: Mon, 19 Jul 2021 05:55:13 +0000 Message-ID: References: <20210714044302.549374-1-daniel.schaefer@hpe.com> <20210714044302.549374-2-daniel.schaefer@hpe.com> In-Reply-To: <20210714044302.549374-2-daniel.schaefer@hpe.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bfa537d5-770c-4f98-c665-08d94a79c6c8 x-ms-traffictypediagnostic: BN8PR11MB3537: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pCDSjfX21UHuKLjXO2CfmMwROkXmERvnj8XY1mQks4Pi4oP9r82iV9mEKerERW07zKngU3LYvE5teNeWw3/nM0IjBUI0If8gLAz/cyck3uSOPr2r9BAzvt9wRn4ACfiaxZkpmdealjtW6dV2nZy1/F+c+T7MP1H4b27XFPFZLe3h4/Fk/R+90f4N+pVtTjL08sfyh81zG24++4C0TfY+BBnDE8yFXIYcl+OSlBH9hj+76Rhc2FyV7e7JyMMXPPFALfEBppn8OgIPKZORVRUjz/XgfoNS5Q/8LOodj5K8Vby8DphiUqkKXEVjj3YPM2+FSndd0yRSCvFIBXyL+QOhkv9sX5Jq29BEBsv5/3fuUv7IRe1EzFB6/Dw4h0dc9HjU51pLxEEpLlOAaMbB+l5G2jjZ+fQTXpQZ6NLD1I23ktLKvMo9KJKl2Ec9cZ5dLf3h4wjZGzlIniuLDCky6yJYSfJIdCrdyK5A1WBr9OUrCmG5LlZJ/ywkPD10HSWmQULfdgR0Lp5oqqiGvymjVUhf65FmbOlpu5yX2onPzup3IrbgQW7d1AF9hbo3fNJnAQFwmMgx+3XmT4SNlprf8dnags9xdGxjN3js2s5Nq0Pep4TvmCBM7lqRvf85+qnRk2tFYbvCY2GMeeySJglc3maGmpX/l6eRx7uA7eKMD1GqcIPNgxJecYXl1HpAk+0feQykziw5NQrIHi6T1fjIOFPX0n/dl6+UnlowS6eYu82tXLrzNcWrJzeMZW2XEtubjhNVhD/F+XSC0ss90hlz47eKqmlsj4SPAyYI9eFFauBxegGvSObSADom2grO28Hs7vIi63Va8gNNTiQ/IZ56ll38TQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3666.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(76116006)(55016002)(54906003)(966005)(508600001)(2906002)(8936002)(52536014)(122000001)(316002)(66446008)(110136005)(6506007)(26005)(66556008)(8676002)(64756008)(53546011)(186003)(4326008)(86362001)(5660300002)(38100700002)(7696005)(9686003)(71200400001)(66946007)(66476007)(33656002)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CgU7F67HCdShJgGCvVr4KCBizn9xWCL+ShErlRYG7nzOV0qweb/w6HcJtMdt?= =?us-ascii?Q?A5Hn2UxW+m4miKK3lONPqyWMOxzzvmunuAWK6omeyauYgAIaYArZz9nW5wgU?= =?us-ascii?Q?+3z8faLvaz8aJH9eqNy9JoCSYS1jx04bjV8MNlJHrEDcoGSpyGMNzSA6xG7g?= =?us-ascii?Q?/ZTwGNtbNtrFztEMGGVwu5hshAoV2S5AoZ2wZqGeFIdfwx7ZbYoEUU0XUZMd?= =?us-ascii?Q?KGgFCBhVxJFJUW8ne8wHqLcyEM8GzypQHvTtNVjnbLvvcmjZMPJwgnqmAW+P?= =?us-ascii?Q?2WusrGAB2JupZ3sv6kwzFdEyhCrndxfbeo9dHvdkNbvJyxCsUsmeJjBN/gY3?= =?us-ascii?Q?dwq+yura4JJtVxceOFSeTnx8dRs+WOmWDZiqfYRWxTZukk3mBAZdEYqjaNpT?= =?us-ascii?Q?CqaN+a/iFXkZMNWd/az5swtZsn8NW1CWvH35zu6l8I5zIYtVnRtFLsfs1UI3?= =?us-ascii?Q?tSZHp7pLiMtAf0NFnZGUYx4S7d3anB3o4lcg+bfCcwMy0hbkw0A+shHVysba?= =?us-ascii?Q?bmV75oMUYOpGdrIJ39vndflKTYWcKWMd4lXGV93TCk3102oMmzm7IXY7P2SW?= =?us-ascii?Q?6thgmSDyk3ijHhdWxqqhlhb3/cp6Rua+X1vIdJtiI08Y7qFu9t9QutRGcFT1?= =?us-ascii?Q?03s/JU66CxZ0GcrjUBgmf/qvYDhz120ANHNhhw0t5DQCBDePq3MEB5RB/nAj?= =?us-ascii?Q?kjOfES3X0SOl+MeBjzD5ThFBJfgYGKaGdQ84HVYhmoGyTbC+4iaGDPkeinw6?= =?us-ascii?Q?wXiR4NdG3NJcrV8zdslrzcVEhkWP+Gzyaegz7rkaF3hb4dfPHo5sO+dALCno?= =?us-ascii?Q?Sbztrcx8CXnAkR3mw9A0nBnQHC2QCx3ISlNYRG0qKN+OXf9fTNSIzPRklSLQ?= =?us-ascii?Q?/AM5qsZgoh8a45wLJoGWWmwPZX00gUQZiopMT95Ewai78srWr60/nXzB0Tra?= =?us-ascii?Q?ztKW6oNkKNaK5NCq5rPITT+wY9WkbJuXpdz+VVI3QUPAiyOVMaR1nOeH7jyu?= =?us-ascii?Q?20S/W7jF2MXRaS60NcJM/GGxj16p3Qcne2mvxjMiQPovIvBs/By1RNDrzbeA?= =?us-ascii?Q?luc1Cd8bytpENn0re4CvfXLIDV90tCKNBz/lqb+u7kO4CE9PRK6Arh3rAKBe?= =?us-ascii?Q?3ViHE7EdhQjwWjffD4YAK750OmJF2itmKz7wv1yZKcmGC0hpxtCNFvXVR+1l?= =?us-ascii?Q?jqyFcTiVnkoOb+ZhEY6j9JC/6jjc1fmFTsJilay68BSICxjvvq/ErjK+9Fs8?= =?us-ascii?Q?qVONMKyhEYPUFkkHYNmK1RT4z5hJka/HsACqSxb7FJfYgVCmDKB5rSdb3nQH?= =?us-ascii?Q?n1nmRf/wfYfkNLVnJhqTlAL7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3666.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfa537d5-770c-4f98-c665-08d94a79c6c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 05:55:13.5251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m7Y+saZIL7sH/Jig2Uyzy2SS4DgM3cPk6YgBGUQrtsI7Cc+xpFHSpoLW+Vnt29DZO0DLK86x3pTTlp58GSqwUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3537 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Daniel > Schaefer > Sent: Wednesday, July 14, 2021 12:43 PM > To: devel@edk2.groups.io > Cc: Daniel Schaefer ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan > ; Liming Gao > Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was > unable to be found >=20 > When reaching the assert, it can't be debugged because the PCD is unknow= n. > Therefore the PCD's GUID and token number should be printed. >=20 > Signed-off-by: Daniel Schaefer > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/Universal/PCD/Dxe/Service.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c > b/MdeModulePkg/Universal/PCD/Dxe/Service.c > index ea7edc3cbb1c..badeec8c97f0 100644 > --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c > +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c > @@ -3,7 +3,7 @@ >=20 > Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
> Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> -(C) Copyright 2016 Hewlett Packard Enterprise Development LP
> +(C) Copyright 2016-2021 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -1610,6 +1610,7 @@ GetExPcdTokenNumber ( > } > } >=20 > + DEBUG ((DEBUG_ERROR, "%a: Failed to find PCD with GUID: %g and token > + number: %d\n", __FUNCTION__, Guid, ExTokenNumber)); The change looks good to me. Reviewed-by: Hao A Wu I will wait a couple days before merging to see if there are comments from= the Core services modules reviewers. Best Regards, Hao Wu > ASSERT (FALSE); >=20 > return 0; > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20