From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.4343.1588994443170003401 for ; Fri, 08 May 2020 20:20:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qQ1GjbUg; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: yunhuax.feng@intel.com) IronPort-SDR: P38d1fRMNvxd0MNYPd5k0pn+hKuUz3F6JBW1u/xJAwFwgREidIynXCL/Sa7rBCI3o+I+k86Fee PW+UAVj+eCMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 20:20:42 -0700 IronPort-SDR: W1WdrKpstrVTv2iN8Udvucxo5cbXdMzpFKuuIAxkA72TaXgPgnAY2vbo3QGnAORq7FZZTnx9a/ aBy1XyuY+QWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="435999782" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 08 May 2020 20:20:42 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 20:20:41 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 May 2020 20:20:40 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 8 May 2020 20:20:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 20:20:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3TKZnyvNXuOze9s3LQ1h/ZDwYsVevgp/aLIQdKvUx58zD0wEYNnFSZL2MgUgbLDJOCW/Pl4WTKS8vleuGxOrmoUrL5L9eE4q6BPiCY2JU+saGFh4swQA/80RQoDEeQdRYXn+49XyfZQQdldEEWw/P/QO5xdvP3zGYnjxN5bnu794Znr9VWk2GzDVTIbBz4BtOubMNUuj2M6QeI9XBT2ltEOD0MCsqkAlHzLN/f6lVprg6T2NMC7FMvmg1AGVyBr3K6MY3Fcs8syhyC8Me7Uu99EcjltPUsn7IXOdXK2dEA/JnuFQ1dETH4s3uVeXxiXYUzaLnUb1LZe8GerLNYz9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a76vG2+Djchg6MAKVy1KT9/BgAajgxo3f06mGoZ/jlY=; b=EQhEkbbfxUZIFFg8ye6UmQy39MN0sUVqfeQ+jCJP6pawZXl9XLT/3LwggB5HhEv4lp8Ld5HYlrCEb0xYD9FED5pewEegdfSPBHIKghzvIH9I4nVHMlznIiaVInveZMgFP9uVywlRahLjYJRio2/6496BkNBs10/xctzge5u5gosb97ZD/rAHLScK8yv/60Z6tPSYiS0R1o4BMMNOKQ9Re8w5DgvSsD6oDRheqCwCfs7woRY3hlySkE8LvPhv73jlDqE98U2IGkpKVYPa33iMYDxRKKgLkY186e9VymdRbgQrMy2aLZwUal6w2BKRAlUczpScVCTjnSVMwspMvpxkPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a76vG2+Djchg6MAKVy1KT9/BgAajgxo3f06mGoZ/jlY=; b=qQ1GjbUgjMfwKaoX0ySccWBkovoXPwrggJ9+OEXx6a9oSBCg4gibW9g3QIZ+3iX/k2ljc7IOHQVh8AI4PnsYogVGVGvviN90qhR4wGJ7RwS1M/4BUbav7jjGwPhiI2xbr7ui4h4HdFbM/y1fiHqTI1DVqTfneCNPeXjOM03PUiM= Received: from BN8PR11MB3793.namprd11.prod.outlook.com (2603:10b6:408:86::23) by BN8PR11MB3844.namprd11.prod.outlook.com (2603:10b6:408:91::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Sat, 9 May 2020 03:20:38 +0000 Received: from BN8PR11MB3793.namprd11.prod.outlook.com ([fe80::6455:7f80:a3b2:730b]) by BN8PR11MB3793.namprd11.prod.outlook.com ([fe80::6455:7f80:a3b2:730b%5]) with mapi id 15.20.2979.033; Sat, 9 May 2020 03:20:38 +0000 From: "Feng, YunhuaX" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue Thread-Topic: [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue Thread-Index: AdYlpUzbYGIqiayXSXG6NdcZlBf1zAABoBJAAAAVEAA= Date: Sat, 9 May 2020 03:20:37 +0000 Message-ID: References: <734D49CCEBEEF84792F5B80ED585239D5C530A62@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C530A62@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: caa36d41-4402-4146-8535-08d7f3c7f221 x-ms-traffictypediagnostic: BN8PR11MB3844: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-forefront-prvs: 03982FDC1D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CeTQ8eRXDREyRkUd8t8gNd3K4VmliisuH9y91dPhlE88TTr1kdoPjQ66/Onrd5SthCCMSsWqDITcI8xnTBjTjEaGVCA2ZosRWvyZiiTWvudD6jj/JqN3tE2XootaiRWWXSEqvbtFE4b5hIosrnk7FKmzK2qs+aajpYGJjv5Wx7iL7QS2TxIBc5LkKiwW8l/lbBGlKv2ZQYokNDKKw0uLDRfkRymJnBnQYMLwkcvKT7g5WdCKDKUDgqot7UPSQPsZbVYQMDCno8num6B+4kea/pV/O9yAEdOGlnT40j2FQhVARUNcCkX/FkgQAtH+ahBi8QROfIAqhRw9Ui2VKVwouXOwl1qfUD+h8IvD8IAxVhBS3E5MUWaLqEh2IdDb8pBtnloXg6AlZUW3rN8IbrzbI8UHeji9Ge0mf+vT2ODbZEy8SLgX2DifRM/PsR8k6MzYduXuieRivQlYPxcIkq0xht2R2LU1r5crnYXMMR52SrkaglGLc2CMGjlh8ZiivM/kQ64aVzO2whZkSLbw3DJMMVjPE4fnpIB8S0iE8BwC+f3UKWjTOshc9em7mjVSiK61+zaj3hdq9HGGbI2m5JcAeDW/idMwY1/ZwzFsjc96ECQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR11MB3793.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(376002)(366004)(346002)(396003)(33430700001)(7696005)(2906002)(316002)(64756008)(66946007)(66476007)(33440700001)(71200400001)(6506007)(66556008)(5660300002)(186003)(110136005)(966005)(53546011)(54906003)(66446008)(478600001)(9686003)(8676002)(33656002)(26005)(4326008)(76116006)(8936002)(86362001)(107886003)(55016002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: m4+/ua1U7DbvGlOKIdiEGabl3lsfET8vG9F3VAtl0zh7WnjzhLGp3pXz71lL+je297rOTDdT2kp0gyqzQZeZ9nPn3lvoil1CeFBPENU0nSQGcKer53qxA96ILY62a+hNiEv3x55619qKr8kjcSMNKC7Vzg+LYduCTAQAAX7iTZrg2mOQNgBZNIY4rN4QntJ9hGeochnJwtQKasg94j15NKLvKLSaAGDRWKl3mXcTUlGgRFm26GYNpJUt+PA4RLIQwXdWNvA0sewA+xpIVq2ZeFp6N7DTO7ba1jlhubHgkMgs2N4C5wS5DGnTViZbTeVr1jdiokl9eCEFH51gC6gBv/E5rGWrS6lcu1tIVTO4UrUZh/thlOCx+ZaNzNOCYpz39alKlvo6NZ6rKLHY+c2UjCeEWh1MS94PVrUqGG6PB+jrZRQWoZ71CCaxatffJaHa+uasmu/GEP+xc1zIGDhGhZWRLN3GCHE80sm+Z3fx+tA= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: caa36d41-4402-4146-8535-08d7f3c7f221 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2020 03:20:37.8201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3VOfkYNTXyi7HiSS2nOVg66WXawUyBkLlw81b3K6N6ejDBogXI46dlcmnYU694aNfCE85JpN8SZlWkilF2afxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3844 Return-Path: yunhuax.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, I have checked the EFI_FFS_FILE_HEADER, the Size only 3 bytes, GetFfsF= ileLength only return 0xFFFFFF. I not found existing macro typedef struct { EFI_GUID Name; EFI_FFS_INTEGRITY_CHECK IntegrityCheck; EFI_FV_FILETYPE Type; EFI_FFS_FILE_ATTRIBUTES Attributes; UINT8 Size[3]; EFI_FFS_FILE_STATE State; } EFI_FFS_FILE_HEADER -----Original Message----- From: Ni, Ray =20 Sent: Saturday, May 9, 2020 10:46 AM To: devel@edk2.groups.io; Feng, YunhuaX Cc: Feng, Bob C ; Gao, Liming Subject: RE: [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS = issue Yunhua, Why the comparison is against 0xFFFFFF not 0xFFFFFFFF? Is there any existing macro that you can use? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Feng, Yun= huaX > Sent: Saturday, May 9, 2020 9:59 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [edk2-devel] [edk2-staging][PATCH] BaseTools/Fmmt: Fix found th= e next FFS issue >=20 > if found the next FFS size equal 0xFFFFFF, return NOT_FOUND >=20 > Cc: Bob Feng > Cc: Liming Gao >=20 > Signed-off-by: Yunhua Feng > --- > BaseTools/Source/C/FMMT/FmmtLib.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/BaseTools/Source/C/FMMT/FmmtLib.c b/BaseTools/Source/C/FMMT= /FmmtLib.c > index cdbee3d629..4fb10ecfe6 100644 > --- a/BaseTools/Source/C/FMMT/FmmtLib.c > +++ b/BaseTools/Source/C/FMMT/FmmtLib.c > @@ -1769,10 +1769,13 @@ FvBufFindNextFile ( > (*Key + sizeof (*fhdr)) < fvSize; > *Key =3D (UINTN)ALIGN_POINTER (*Key, 8) > ) { > fhdr =3D (EFI_FFS_FILE_HEADER*) ((UINT8*)hdr + *Key); > fsize =3D GetFfsFileLength (fhdr); > + if (fsize =3D=3D 0xffffff) { > + break; > + } > if (!EFI_TEST_FFS_ATTRIBUTES_BIT( > FvbAttributes, > fhdr->State, > EFI_FILE_HEADER_VALID > ) || > -- > 2.12.2.windows.2 >=20 >=20 >=20