From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web11.47078.1591043605234035702 for ; Mon, 01 Jun 2020 13:33:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OEKh+D0j; spf=pass (domain: nvidia.com, ip: 216.228.121.64, mailfrom: ipark@nvidia.com) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 01 Jun 2020 13:31:58 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 01 Jun 2020 13:33:24 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 01 Jun 2020 13:33:24 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Jun 2020 20:33:20 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 1 Jun 2020 20:33:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ad6e0h0fkkW8AZBBNBV3jgZ2H/BoT6T/x1esy0YxqhXrclmBOWUrrRt6S2VaCr0iESMQloYvhK43n+Bs3Ze0gkbOBRog0TFqQSXtylVi36ha4OcDlFhPXa2KpdR/IS9xugv/6MB/WRFXNOMQJI3UMBQW5v+lXSC4FATn/A39qCAc0pc416K0Thx9cDwDe2NWOJkOpK1ExmiH9Vgsa2BUTJRxoGgVjV4BhKPP5kvFvd3p/1k1qXG6+BRIU6iCfb6BwdHmc/HoUGVilUO5DtnDtyye5m4LIo8F393ZU+saz/1osx1QGgywPN+aVY5xD/UtmsRZtPdATBTqJtGqid5i0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uFgmkxK0ds5zUW1tpY4p5uYlwZJRdmS0nm+VtMQijU8=; b=iE6wsdxadw38Smm6VHk+zKgM5XfeJszwUK3jC/TccALJVURW6ksuoxrdOwPZ8hf7uN2jO7620qaxe7+dekWBZhazV+CChAQyz5TZv9JfWd+qBJFCKYyu5lAJ8JbRm8GF369Zxg7LlFR+SrSM69TfSrIGnZGsvP0aucOc45Er+6wbsEKAFLA7Q/f6uKj9fWKUPI6YQ4wjagI5dXj19El2V8tHzG+PvK2YwaIj9M758uAd39Jh9ZcEOOYuXq3MLWQW2p2PGf2u8by8BOaZhjIt6soxgP4zknZ7d/onIuOwAv6UgZnXzHd8g88gtBkaF+6QGe/X97eXfqI6g42+fN+veg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB3281.namprd12.prod.outlook.com (2603:10b6:408:6e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Mon, 1 Jun 2020 20:33:19 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3045.022; Mon, 1 Jun 2020 20:33:19 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , Irene Park , "eric.jin@intel.com" Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHWNGKuQ1NcfKcKyUinKlvIwTbvvai97gqQgAZQmVA= Date: Mon, 1 Jun 2020 20:33:18 +0000 Message-ID: References: <16134CAE37D4DAC5.10634@groups.io> In-Reply-To: <16134CAE37D4DAC5.10634@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-05-28T20:06:39.6568840Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=e5f65812-950b-44cd-a6f2-718925f50870; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 277f7211-16aa-4ab8-1c7c-08d8066b0540 x-ms-traffictypediagnostic: BN8PR12MB3281: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 0421BF7135 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uadB2RSzkRbeX6vFtWxdQISlgn7mLXdaPlnunWNu821fEnhK7rOMyc9OVE+q9+P0D4cBCMkt3CsmGQflwOfP+OBCEFOg+O0rbzRvwVWRo8N8qGCCz+gFKmxuy2ubb6o39evtfNavka9BsryCLdhgrFWeAtO6nu49oagVAoHHHTOkNvJM1dm8krzv/E20olZgcgYljQRIUcrl3Tnq8jIliuv9Rc9E7HOnwA023Wp+lNc9Y1sHR1P5vhxC+9KWsrpIzY+tO8EMzlSvmk7JuEHceDL5AV+1Y3BH+Y3OEXaEJhaGjOPXnpzAGjmd0mslISkV9RoyteRz47jxY5cps+nXE1qzCeQQ9Fxex9wYbN62jli+9BM4Ops/39aBAiO9qjsXzIGShoOGB+8FJ2PrJQVmdr+zoR0Szu5jO5SWAeJt84yrksc66DF2uqOi9+qmbRcxUK/14f/FBoTNxsLTC+iHagdBJ2FUPzAmP6c7qhddkZQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(396003)(376002)(136003)(346002)(39860400002)(366004)(66574014)(478600001)(52536014)(86362001)(66446008)(19627235002)(33656002)(66476007)(66946007)(966005)(76116006)(55016002)(2906002)(9686003)(66556008)(64756008)(71200400001)(6506007)(53546011)(7696005)(5660300002)(186003)(26005)(83380400001)(8936002)(8676002)(110136005)(316002)(145543001)(145603002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: n1xt18UVjsiaJK1D+67zox0is82JfwAoKa+LBZSq471AC9ZIPaeAwa4XCIM97JWwL0iqOal6VDPpv9Hokez4HiBdk2FDQfPcbCde90v3IQE2vLR8AUvm24nj15HJa3zqNBz5JaLYOBkFLknWncKj99VXJvoEZWaefLGL+IKjysB1d65TtrlmL4wrFK7Vl0q/JICO7FDGy1HIKjEDYWJyUcJCSQNSJkvh6xaR8HvPZAjTMkM1ZGypcEoflX3K/HwGqdJMC/H7zz6UNEMs1p2hvPPcCOL6DxlySO8H25WMP9uLMO5lAWaZFtfYDcBM1ElcPcavU1ucIMRfwBWaFUET4D1g8QAQFS98sqWcxeG1Nf9prOyoeJeJt3NGT0FxnNR+RGAf9YjjEObmuQIs9U3iTwOSQ3tf6zKZ5wqyUiQFwQDIxr0lL7/XSrtyMskHx6gdrWbOM4mdTVuRT0vBcZX+PJondf8+ykIaIgFhM/4AvIk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 277f7211-16aa-4ab8-1c7c-08d8066b0540 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 20:33:19.0451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xI8i6mDfVlgTXU3zGWwNbRkyWVNo5Q9tg36s/mbB3Oi8ev30m7ksGBMy5c3TimUD3XwmJFkSe4jR6MyBHnAetQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3281 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591043518; bh=uFgmkxK0ds5zUW1tpY4p5uYlwZJRdmS0nm+VtMQijU8=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-forefront-prvs: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=OEKh+D0jx+2sQ5mYnaX9JAs1rL0Xke/l3CBsUDU20+sEKuSPHryTds7AgMIpR8Vz/ BhaViRV7JfKCcpjj62rOsnjvqhbHOu/dplFjeocBLXfyOGjEyH+7kfnFK/EgpJEMAl xnGkMFjzaGhhmormytMi9CnU801Z17VeBQE8OMBWQctC7YdcNtMXWEuMQqcUE9F9uH xrpraDTDnUiHgDZYPWhGio116xq1Wuc6I5VDEX+4uqzI/mSvIhOkdxXwrcOeinmDhf moe3UGtrb/HWdDlC0PFMBcapGvnrdawNTR+K/r5yI/uVHd6oNfjG0HLaCxWwlkhaUn ACkoYT7mBDXww== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Eric, Would you please help review this change? SCT build fails with the latest EDK2 due to lack of this change. Thanks, Irene -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Thursday, May 28, 2020 4:07 PM To: devel@edk2.groups.io Cc: eric.jin@intel.com Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid External email: Use caution opening links or attachments -----Original Message----- From: Irene Park Sent: Thursday, May 28, 2020 3:19 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid From: Irene Park REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocol= Guid, remove the unnecessary declaration. Signed-off-by: Irene Park --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4= ++-- .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2= +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandl= er/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/Te= stCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/Sampl= eDriver/DriverSample.c index d495afd..fe973a3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Blac= kBoxTest/Dependency/SampleDriver/DriverSample.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c @@ -1893,7 +1893,7 @@ DriverSampleInit ( EFI_STRING NameRequestHdr; MY_EFI_VARSTORE_DATA *VarStoreConfig; EFI_INPUT_KEY HotKey; - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; #if 1 EFI_STRING Progress; EFI_STRING Results; @@ -2190,7 +2190,7 @@ DriverSampleInit ( // // Example of how to use BrowserEx protocol to register HotKey. // - Status =3D gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (= VOID **) &FormBrowserEx); + Status =3D gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL,= = =20 + (VOID **) &FormBrowserEx); if (!EFI_ERROR (Status)) { // // First unregister the default hot key F9 and F10. diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandl= er/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctP= kg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/= SampleDriver/DriverSampleDxe.inf index cfa049e..75cb6fb 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Blac= kBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf @@ -99,7 +99,7 @@ gEfiFormBrowser2ProtocolGuid ## CONSUMES gEfiHiiDatabaseProtocolGuid ## CONSUMES gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES - gEfiFormBrowserExProtocolGuid ## CONSUMES + gEdkiiFormBrowserExProtocolGuid ## CONSUMES gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES [Depex] -- 2.7.4