From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mx.groups.io with SMTP id smtpd.web12.755.1591135231872785136 for ; Tue, 02 Jun 2020 15:00:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=q3YtnZJa; spf=pass (domain: nvidia.com, ip: 216.228.121.65, mailfrom: ipark@nvidia.com) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 02 Jun 2020 15:00:19 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 02 Jun 2020 15:00:31 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 02 Jun 2020 15:00:31 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Jun 2020 22:00:29 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 2 Jun 2020 22:00:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZ948N3tLJa1xIkYjzT5fWpxPGJkoDiyem9TPm/esA0okMFsSqZL6QbxQHvIPv9szr/szD5l93Ifvap0OPgLsjQL3Ylr5lQOz+Ug8Xra05qEH3r2ZlhEWNw8TmD1pqFrL+k3G128ydVaRXWxt40E4QBAcPAMxvigCf9PUj9uz10QdfPUnEhRaveFx9bmFxzj8K2rU9ZFluk8V6raLt1zWEjV6wbeIrYd0oiR99aHcjbGzFEuPxdkz+5Oemp3K9FbKbY70FsI2HYP+rPL3nDTuzEB5O6YtntNuS9JHpyxW3CRmK8C9C03aoC4wtbkpI1QdN4NFdSw7iFOpezwtT5+Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0mi2sRPirIi+Qp5DZtPxkQPMw76IQtMQ5v54/uuN5xg=; b=cPjiPe3KG+ruVQCKb/g9yXxldsmyDgfLi4wc7WEDMPCH6oNjZ953ebkNbc1eKANtd0PhjQ8WD4G3zB0tUp88Kh/eL9W3Tn0oKFAgW1tdxop2qCCHdftkznWkoMG/rQfH2qkAnUPRpQTFDMNO4zvoKoRLME4BK1cU1xhzVYl257tB+zrUH4mHisZ5xta5x+exsoaGHUxa0x7CAbRk6tYYOAohZDeKo9eRN3kfEdUL4Y3ZCJQoQY3S5Evc8Z1O2s8+rLMl4XJQIsmz8nPayo7DuqyX+/l4H8e9NlHLqlS8dFMgdJhDutfn11zhr56oB26qEAOFcxOtPnj61ZzdbUBbnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB3043.namprd12.prod.outlook.com (2603:10b6:408:65::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 2 Jun 2020 22:00:27 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3045.022; Tue, 2 Jun 2020 22:00:27 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , Irene Park , "bob.c.feng@intel.com" Subject: Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Topic: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred Thread-Index: AQHWOSkR2nmSIUpNtk24FeNAFtbNmajF3/fQ Date: Tue, 2 Jun 2020 22:00:27 +0000 Message-ID: References: <1614D8FC854AA05C.21938@groups.io> In-Reply-To: <1614D8FC854AA05C.21938@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-06-02T22:00:23.8040640Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=83f48b83-368e-4b49-bbf9-f57d2507716a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a5c4b675-687a-4456-a2cc-08d807405c00 x-ms-traffictypediagnostic: BN8PR12MB3043: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0422860ED4 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /VC4t8EGvzDM/44szwe7aXAYXEl9FuXtRDFx/OWLE/6OBamshSQvbvbw3MhEHmCd/M2HIVZqocUfM+hgcUJ4oKy9mwmfAnT0Cu2GDD4ohPuL1Cv7gVl/Va6Ux620xaNt/XGPQ6/doH0EOjsrkx2RY5oUj4GqKmL7mn6L9DaY682FQhBff5WQuq6T+GqpoKoYVyl1jFiWXKQfdi4fnF4+/1ktJKAQFCoA5iYJp7HcGkh31FDvJvz1LyzZquJWesSXB2cKJjnMJdDyIs/lzdd0Y3hSq7Aj7MYipo/4ieprb+p12icqy+MtNPHazHjTZtGG9hPuYXP3IQuMutGgvh7fypSWjaSHmMZRQWYQB++xQHz9JKazNQBbaiWkovw2k+c4OhWmgPLFVpDkdzMbSktuiw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(136003)(396003)(346002)(366004)(39860400002)(52536014)(5660300002)(110136005)(26005)(316002)(53546011)(8936002)(6506007)(86362001)(7696005)(71200400001)(8676002)(66946007)(66476007)(478600001)(33656002)(55016002)(2906002)(966005)(9686003)(66446008)(64756008)(66556008)(186003)(83380400001)(76116006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: Qeh3f3EK9sMfRjb2i0+SettbsDWKVFApTH3dydVGLxGZvV6O4lEquEyEKIUCYWHSAFWe8fE3sW51eSR8n4RanQjx1yrgFfgFXhDbkVdq7gSkbpz9vTfEFRHZHkr5JoiTaZVp1eBAkae7cZRPbwN3RtW4N0BRZ/Vv9RVdGQ6XYehu2BPsEhy2Qq27Dm28HAlUcwU0TJ4Ed9KuRA6SYNVYMhP7CO4ePcFOl5T7yaOw/If62ayUA99hjuHVeqG39ju5jHpMe0hLniRo5Tz7NZhxm0pVCGbI73Pv1RfykCjW8HGR3IMpJjAsupxCX3xKBf+9Jz8EHqSQqpV4jejQyxwsaGMLrPU+TNAdvNXTIpnQrOnPjxVwrnZ7pfqc1T1TPdBteHEshHlyZtrFk26RiXJrqMozqTRcOul8p1iGw3G31n+x4Xxso+4fSncrzKwsoXau3nirvzDK0K5fGnccxvWorgC6BUWEYPNtkK3wGznyZQI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a5c4b675-687a-4456-a2cc-08d807405c00 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2020 22:00:27.3863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X4JECuFK4sCEPJ4+vxfZ+L5e0JmKXu2oTwmux7JvjYbaLc/cWZS6Y2glODELF8ciBgxGeWDQTmOsv0h/a9cQRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3043 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591135219; bh=0mi2sRPirIi+Qp5DZtPxkQPMw76IQtMQ5v54/uuN5xg=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-forefront-prvs: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=q3YtnZJaUsp5fXCv+ajdctXjaJpG9k6wMgagNHD3csjPspoMl/FPpzjuvLSyZLykm sVe5q/cuoh22lDLcL90h1om9WlGmQj0Hnu5EeNnSmqkL7DmmJZqOGQ0zGZAGpkACnG ezQzLpxUIXlcMYdz/8PuG5TA0gDmHz80J3HdKjuz6l5ykn+A3YSRUjh1w8BSnRjSj8 xxmE2Le7vtXpGRhdOyBV88V6ZzpooSbaHx+cZwTvJSib+Gt4y3n8iTJ8Of++qmv2Zx pfslrBsW5NRNxLGcWEhpBoL7dfwBdJWr022TY5Nn6kO+juOiKP6L47ROG9bEhaFMxk C9w4MgpN3Hpvg== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Tuesday, June 2, 2020 5:59 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen= error occurred External email: Use caution opening links or attachments From: Irene Park AutoGen manager/workers halt the progress when an error occurs but doesn't= propagate the error code to main and allows main exit with 0 and gets the = build system unable to catch the occurrence of an error. This change informs main with an error when a progress is halted and helps= main exit with 1. Signed-off-by: Irene Park --- BaseTools/Source/Python/build/build.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyt= hon/build/build.py index ed3a3b9..1ab1e60 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -880,7 +880,10 @@ class Build(): self.AutoGenMgr.join() rt =3D self.AutoGenMgr.Status - return rt, 0 + err =3D 0 + if not rt: + err =3D UNKNOWN_ERROR + return rt, err except FatalError as e: return False, e.args[0] except: @@ -2724,4 +2727,3 @@ if __name__ =3D=3D '__main__': ## 0-127 is a safe return range, and 1 is a standard default error if r < 0 or r > 127: r =3D 1 sys.exit(r) - -- 2.7.4