From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web11.5974.1591342261860547443 for ; Fri, 05 Jun 2020 00:31:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Fz49oS8c; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ipark@nvidia.com) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 05 Jun 2020 15:30:59 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate101.nvidia.com (PGP Universal service); Fri, 05 Jun 2020 00:30:59 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Fri, 05 Jun 2020 00:30:59 -0700 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Jun 2020 07:30:53 +0000 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.53) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 5 Jun 2020 07:30:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N40R9kHItPzJGE7THnvYKjX264OgYOO877Mdx9kThGPXBqJjs3YSaB8pVoBHSh+d9068zWcOxuczEMpRiVcEkijjUMD+e9L7N7ERWy+vTM7Z4K2IoBRFy6uTzIzfeUgPiVD1qzqt+daUzyJuQF+IO8NVpgoSL17N6Lefeu8KbaE/LFgLbhK6OcAyIJMU8y8GbWdU+hv657mF3aXucAql3Gh4PZWaFtumBqC+zcd/G9U5RaXyOb4pFYIByYwUM/OXN1DlawQYknnCW1Wq4XNdJN9UitJFSEpgB+eVeHqt1nKT4rPlUetQszRoS4Ua22GvlImIvQ2WH0axB7Yp4gZEOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rdwhyI3COxWhS1tfAExWzLpWM35jgIPAgTofz8zpBmo=; b=SNqyrtEJ2bW6Jzd28KuOTXq3igseBZfJM7wUY1jsZRWrZodpCy23B0t9Zi65t4WPN2isrtgzD0oYWGRQnuxYdrU1HPWNgRi8PekqN/InCYtfASy+q5jtkD58JgBOlsrxJWP9zlT6M9PrH7uGc+k1Nd6PVBV1S7gLDDK5UEf1gMt/74rL8VELMn0oKkR7aPpNdjnrWHMuhkKrUxL9ffelQSJXDpyti1I5gtPpWD1n5ACiCsoJNp10jq2mjsLKcqoQADiI/ZjOm+Pd8I3zV/lbMJrWh2gT2M7FvasSwWFoOImCsxQfBloGmKzeRWs45MA68OCUa9UER5Q2T5sVy0XHLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB2931.namprd12.prod.outlook.com (2603:10b6:408:6d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Fri, 5 Jun 2020 07:30:50 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3066.019; Fri, 5 Jun 2020 07:30:50 +0000 From: "Irene Park" To: G Edhaya Chandran , "devel@edk2.groups.io" , Samer El-Haj-Mahmoud CC: "eric.jin@intel.com" Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHWNGKuQ1NcfKcKyUinKlvIwTbvvai97gqQgAZQmVCAAAVmgIACRHzAgAAG4QCAAx4hIA== Date: Fri, 5 Jun 2020 07:30:50 +0000 Message-ID: References: <16134CAE37D4DAC5.10634@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-05-28T20:06:39.6568840Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=e5f65812-950b-44cd-a6f2-718925f50870; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c191a8b2-65da-4f12-2a87-08d809225f34 x-ms-traffictypediagnostic: BN8PR12MB2931: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0425A67DEF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vKdXA0BYQKGbAD70DDiMsnO8P7Sw2nUmw7CP0rqQt1MOYJtrZ2gnIj1jCIQvpRVIN3poxOyZwMCepfXvVzEzIY4Krt8m3Yd58mJFGyXndTB+QHslMtJkH7hZChgWqSZ8C04JclGcwcjPGgEoDsa2kMps1qVg9XOu8QT5k42OCI5wUN6/Qad9d8mjCXz6Hr3GDqXUBtTfNLs4IAxQ0u8RbRAbbApWOLjcgkP74JpQABQ/rFOGXmh6YZJlimyhTWqwUYhr7UvCzTzrlCuzUhgKXRbsoiHAjoaliPZj5/ke2vruv0NAkzClY3Nc/MLanzEBJyyf95pwIhNZk5Wg+Z1eYSssUm5dF4+P+UKnEZCG2UQfntjGLBOr8kDFmKjPOuJDfXZQ36NR9BD3bVDlyRARLxSuVuZVRzf46JM4nidQQ5DOTFQ9F9HVdcT87oEkoTOKW25+KLkQkSK3B39ZMqFHPeWPXLkznQDFRgO6Nw0MpZY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(136003)(39860400002)(346002)(376002)(366004)(396003)(53546011)(4326008)(8936002)(76116006)(66556008)(66446008)(66946007)(8676002)(5660300002)(316002)(186003)(52536014)(19627235002)(64756008)(71200400001)(2906002)(66476007)(7696005)(33656002)(6506007)(66574014)(110136005)(83380400001)(966005)(9686003)(26005)(86362001)(478600001)(55016002)(145543001)(145603002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: AjvLd0M0wIwiI1j0VIDvmrVZnuUmfBBh1n0HVtxDbYCysq9N3CaWKVyDafctwPQcREUBoqtfsi2MlnMnL5Qa4wymRyKajv8fcCQhaZxS6NIXn/SLh0DA4TFSnBCSLj1+RKc8WaYGFTKC3nXbgEVVuD9ptXffF57hj5wmDefNvtMb9eRKcWLpPKphR05icPLdK9JKqP3uflOWf5ZlJwzRCH/NKHRhaXYPQSDuJXH7iiAkY6FX9MJIoDkYKBho5m8ueo/lVJVpwyznS8efCKVTSrNnFb+oP5SkKHzI7uEbVpYGs9IrcOtKj6jXj4XQpMg9ls92qF2scqlDSSzULkwlJ8uKdFe93D13DI/85160YToftuY/fgj/ynfr41xVxun5cESqBl1RLo259x+1IRQ3ojUBbtqYvbV/woVz8+w4+pAZCCaDQKOHbM62TS2SVqjxX9lnnnjs0GCQk4Y2s/ebt6IGFQFWysiT+vy5bLLoveg= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c191a8b2-65da-4f12-2a87-08d809225f34 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2020 07:30:50.2088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z8aMQvR5wpp8vbG9A7jKMM/WCOLGACAIZ22ygYQlPLEJlPPaUCqzk8g92Uvjk3PM6YJ6sOnui/ruP0gN4RO7JQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2931 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591342259; bh=rdwhyI3COxWhS1tfAExWzLpWM35jgIPAgTofz8zpBmo=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=Fz49oS8cvLM3R637Dyf1CWgA76eSFdEJ7gEOHiNSxuu6LFrV3soK3xrWxler9NNx0 LTp2zcHVYG/cnJYuA5akTf48kAAnXfFGXGifEXJpF+leK7SK+268WtwZIDDZdkdY60 afpScy2iO4hkGfigZQkshkPtfr4NBFdwtoNjM08c8YjiG8PTiUSF8gRVBOiO376r0g nawJ4Y8+BPJkn4TmdFHoIJugjEc4F9wW+UKsMhefXMPeiWHAVK3fAuLIyH+X4N+vGB 6lIdvNSm45be1RRlzTPFYhXiDsQ/vdQZhGGEIW/GsO3YE91wydAlDXQ/Jj9Em0GbiR FcC4yLwvLDNUg== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Edhaya, Would you please kindly review this change? Thank you, Irene -----Original Message----- From: G Edhaya Chandran =20 Sent: Wednesday, June 3, 2020 3:54 AM To: Irene Park ; devel@edk2.groups.io; Samer El-Haj-Mahm= oud Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid External email: Use caution opening links or attachments Hello Irene, Sure. Will review and send my comments soon. With Warm Regards, Edhay -----Original Message----- From: Irene Park Sent: 03 June 2020 13:00 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud ; G Edhaya Chandran Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io On Behalf Of Samer El-Ha= j-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park ; eric.jin@intel.co= m Cc: G Edhaya Chandran Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SC= T patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene=20 > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park ;=20 > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove=20 > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene=20 > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove=20 > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > > Replace the gEfiFormBrowserExProtocolGuid with=20 > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c |= 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf |= 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi-=20 > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status =3D gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL,= = =20 > (VOID **) &FormBrowserEx); > + Status =3D gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-=20 > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.