From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web12.8664.1591169431583366027 for ; Wed, 03 Jun 2020 00:30:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=eJ0QEcdy; spf=pass (domain: nvidia.com, ip: 216.228.121.64, mailfrom: ipark@nvidia.com) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 03 Jun 2020 00:29:04 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 03 Jun 2020 00:30:31 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 03 Jun 2020 00:30:31 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 3 Jun 2020 07:30:22 +0000 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 3 Jun 2020 07:30:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQS9/3ASSeIAWFZ0Xx1/ZgwNaquPLpYnGsCR4YItYeb1/8J3Am1F7bQmzfogDDko0FagcuJFcCalkKYZ346OHN6MvCVEdTnai4Vp+eRpYxyQI+la1COPFpkTFxHuFtvC1EEUes30EtrTSBdZ9F4zsogMukLXFTSQx2w2T38KjKRGgF4ehiaT0SvUU55GqJ5dlZQbkV1wzyVXvW3S8fNAX7UG0aAjjVJhIK1pCmsEkyF37FHIN7nNkkS2lsezovcKJK5v0M0/5bH8JQIsdbKBAYA6JrvRR6etm2HgoY0TSMip4J8n4U3EzXxGIsMHpt/vGPNqxSDQAqHqdHgkqVYteg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qktKPT2ujO08x09xpTLLb4PNX+Azt1GKulC8Mp6GGM4=; b=bumQQkx1vgN5CU+xNm6CVnrmV4Vci262aeg8KueL8aunuRD3I3sE+/ZGTC3QbnGb/8ZLlXiaX5Ko/IFOd90IAFXNfuhiQTafOTBQE/qEwDdkYnXkrdy+PnR5ATPnsENK73p02RjyBQ6f3OS9gqoBv/EyQz9rh6CRJ8olOs+7YiS0OgnIqsydY9jIauNmrJHtVGsMgHAQb0zEOMPsQza483OSVZf0XhMvsUwfeF+XFUawrZPlOuJXuXXpozHNUTUnJM4G+dV7V77tgecnHQ0Fvlp0/ovcdKZ2rGKt23vdZRS00TdnG941zfTTGwj47YiszQRJWfjdbDcJrVC6b1PtyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB3042.namprd12.prod.outlook.com (2603:10b6:408:63::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Wed, 3 Jun 2020 07:30:20 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3045.022; Wed, 3 Jun 2020 07:30:20 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , "samer.el-haj-mahmoud@arm.com" , "G Edhaya Chandran" CC: "eric.jin@intel.com" Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHWNGKuQ1NcfKcKyUinKlvIwTbvvai97gqQgAZQmVCAAAVmgIACRHzA Date: Wed, 3 Jun 2020 07:30:20 +0000 Message-ID: References: <16134CAE37D4DAC5.10634@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-05-28T20:06:39.6568840Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=e5f65812-950b-44cd-a6f2-718925f50870; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 204a7cd7-7986-4e6e-c736-08d8078ff88e x-ms-traffictypediagnostic: BN8PR12MB3042: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04238CD941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CreA3oIWsjurseb5udLWlNnWLb260V7hzfYbLKGzbWS7mudrZQtvJm9ryxoIN4GT9rXXC0f0ygFSbLBvaIyOPEWunYYJOWeYV+ugiTRsWpnhCTfci8cT6mBvv+GtrKNf6qcM4DDIRVm+OLgUC3goF4LpkpfeGGm3/SnYMgEOeoHXVD/W7sIJV8AFIReX7qU3fzEchj2g8+tUjnMHvwXVJVBThmYhhU8HNejTXZ/KSZ+TKRijUY9N3wnf7+SPseDgZJLq0TccUZC9P1BaMtaPSI0M+w90vO+QUpz7/Qm0YWKkYMT95pfGs1HHMnAVSWxE7Wyu3cX95L2j5TT81i6rHoJ23wTsNsEy8GXj5OY1v0Ol5sh3WSbmwyMlMj2I2GjdXkTQRKs/ArBny8kB8X5iDiInd8nZQtXyk2OgH6Q0Udepq9B3vSc5c+em+0tVoIpgU7N9Wn+jZkxmJrR1XEgfVQGdkWCI24ZF9QdKOQAeKTc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(39860400002)(366004)(376002)(346002)(396003)(136003)(478600001)(19627235002)(966005)(66476007)(6506007)(110136005)(66446008)(64756008)(66946007)(66556008)(76116006)(86362001)(5660300002)(66574014)(52536014)(7696005)(33656002)(53546011)(186003)(83380400001)(2906002)(26005)(316002)(4326008)(8936002)(8676002)(9686003)(55016002)(71200400001)(145543001)(145603002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: fvVaON+bOi+eQx0gb1+aaQGmiAuAFjXUEtk93QsfNbSlQaauk4pk/d2tqyxrSk/bYhV8RTc+XDcA8PENDrl3KLp3Cvnm2GX3Slc7ssxS3143//mK4/jUTUjwD1H6HwP+8ZVIH+Z4IKtHq5C5KK4NOEL63b5c6vweLwKiwpSThJpHbYe5VtFcXtbgoYkDBvMWRckwN+BIzbf675hjCnKnMas2wgVVAwVarNWygvOnXnRopCjAfMFGvDoRltZGW5agsB9kXXGylZxbseO8bKKrilWtaN3hkDReMOK9vG0yzQvOQhTR4u0aHD1U3oIdZA416cEEKC4M087uSPErFGTKMO3kh3bO7tGr7KKBE4lsBob5JbZsTy1Yzb+xa4aHc6zGB/u4J17qXhzs4omQ/9eWBURC5sK+LDATo9RavrVkABp8wM/HjjwA67+DOd9Tj7fOmmhtNSTrXXtxfTAoD/MbBdsoqx7cICK2xSjYTMtyEfs= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 204a7cd7-7986-4e6e-c736-08d8078ff88e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2020 07:30:20.3600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BN2WA5eusjsRWMTOAMH3cMA1j1dpgZP3hpRtAO8K6syyp9CbEtLwPrEcoEdSKlMpk1CFNVT0e/KiTnCwX8LvMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3042 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591169344; bh=qktKPT2ujO08x09xpTLLb4PNX+Azt1GKulC8Mp6GGM4=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=eJ0QEcdybc78k5ep1ICAg6OC5Ih5ZV9fKjE/gGd2HwCLni4RHLpqennuVbWUBwkCf cSfM/wW0VdzPrZB7/X5gzskBgCcflyDkujeieduv0IE5Narx7u+Q3mmFFMydmvkpKb VF7+HBLSpBY3BVv0ePBeiumgLF5Q0ZWuxtc1ClK6WQNcT93nLYRjBKL+vNYgxUZsYf aZ7PBCGbi9SQHYNJdcD1mQo7RE7KXcAaMMLarwArQXvjlgmWmGr/DxMdCvalmrrjP8 KSDM4vqTZfKbx6AeZrxr+pQcfrWX7V61NMYFqOwnhDMs+xWMS/WuJEuVQz66CbVguR YDWwWwfQpEyKw== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io On Behalf Of Samer El-Ha= j-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park ; eric.jin@intel.co= m Cc: G Edhaya Chandran Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SC= T patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene=20 > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park ;=20 > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove=20 > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene=20 > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove=20 > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > > Replace the gEfiFormBrowserExProtocolGuid with=20 > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c |= 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf |= 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi-=20 > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status =3D gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL,= = =20 > (VOID **) &FormBrowserEx); > + Status =3D gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid,=20 > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-=20 > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.