From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web12.47006.1591043476990746009 for ; Mon, 01 Jun 2020 13:31:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Zo9ZgUEu; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ipark@nvidia.com) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 02 Jun 2020 04:31:14 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate102.nvidia.com (PGP Universal service); Mon, 01 Jun 2020 13:31:14 -0700 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Mon, 01 Jun 2020 13:31:14 -0700 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Jun 2020 20:31:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 1 Jun 2020 20:31:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HX4PsaGf5vuB0HS4guxRNucFEby6r9ADh52eP9vzkch1zqwf/BQkN3U/xStaX7TEJDgk8Z71uNds3UbevOla2gUPIPuou/OTGV8J6S+qLzGWbi1QWgRUAF7TVyfFGgD2efkb/aIkRZ4P4/bNco3XVND2aPQvX0ExjGQF3EJA1jwB3whlfzBdf2Swx6i9tjqLpqYzz3SSAzE0Zm0nTa+QXW1NPk8T/kHGcvxmC+AdqFxjBDLzqPV6fCVas494kvKLXTaNPLOxZDWVjOeVzWuua/anSZYDdAv8cgzqDfSHnn5v0GrCcG5I3ULhpGBo4h6Ze7AYSEc3YrL+z1CxfVv7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81kIIeX/RmBxhSqMY5ph8b7xsNDada86D/CS9hLcJ6s=; b=jKlemOZGqueI9+AKA4xJ9rp+wkE9waRKPINGsxRAk5JkgFexvYlX6QcPmuvtwDN3n5XwD5NIPey2LzkRmyyn618+l4Rt6XM/BO6vJDkAn7G03zpxJeILV1/pWWqQGvmza+85yl25py7xaCeGNICkCLdh13b308TyUezS45btCjh5A1yNVqwBbmOKvbOBsUwHaLZ0/InUMG1D+rktCvUPh4Pm0JEOBRcyJEpVFQRu0yg5OQQuGrQQH/8DmY9qNhaibUoDQHWbgxLCSEpKy51lVXNVXjc+Qp4ZnVFMheb4K1bC+ssH91pdBE5Qi5vgDU1vTAg8xI5JmSz58oHPX7iAUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB3281.namprd12.prod.outlook.com (2603:10b6:408:6e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Mon, 1 Jun 2020 20:31:06 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3045.022; Mon, 1 Jun 2020 20:31:06 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , Irene Park CC: "bob.c.feng@intel.com" Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error occurred Thread-Topic: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error occurred Thread-Index: AQHWOFNDZBf1cwkFJUmF4umbBXIFG6jENkLA Date: Mon, 1 Jun 2020 20:31:06 +0000 Message-ID: References: <1614857659D31804.27457@groups.io> In-Reply-To: <1614857659D31804.27457@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-06-01T20:31:04.4244026Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=c4290c9e-da97-435a-a101-94d80a4b18eb; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 478b849a-54ba-4bf2-d095-08d8066ab633 x-ms-traffictypediagnostic: BN8PR12MB3281: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0421BF7135 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /FJGd9D65zxIrY39FpTA/DJxJOFGdT0e2RJ282bIfjBYbxqB0tKJgZ9EmgzOXd4+7bLhPxQxNelF1hXxa5jHjxM00E6eXZh9R3YRuQaaDy/yBiYbaxxYMSHd4VepNT4pci6atNLjgPm4Egjx3GY8KdB3Ht0p/x/xwf7Bi9fVld1z5/kbzmivtNH9S3JLqvBjF7mUQIUg5vb4PAMpCfKOhqH+llhUT/QKsf45swk4ULV+fV+vC9TugVeI1mSA0wybf6YABBQWXI4sSDpl/lDaum6U6lBdJ80/YQxs0U94LMLQYq6ujJgacZz0XS53kmrKtwdX+ddcNa5Wua4crDVLT6KhGP+McbW+v0zD8fnR2QEyPB29SxA0fz8hxQdsavjQL22tA1qaHYek/n1ESNocgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(376002)(136003)(346002)(39860400002)(366004)(478600001)(52536014)(86362001)(66446008)(33656002)(66476007)(66946007)(966005)(76116006)(55016002)(2906002)(9686003)(66556008)(64756008)(71200400001)(6506007)(53546011)(7696005)(5660300002)(186003)(26005)(83380400001)(8936002)(4326008)(8676002)(110136005)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: /VQIaLAMm9yZY2h513ozMLgwev06V/haeslioQ8R+zJJ9quWwKz8+ZDzUkuXgQozgfkYpEgpUuKOZ+k4CWCP+tMqmLfoGzvbRazu52BJCyIjPAIWwhM9StVw2q9qGPuvsTV08sxW8wQijYHORCjYprw8MguDTYxCVEohUiGFu19y1X02bu9jhuVOGNw3rTOhTunh+ArG7qvLZifZA0znaP3GZwFxXr67aTGML+q88n4K5bH4tX2R/VpoWJIrQBWusryDJoexYheU03I+j728997KiQeZvcvA5BPMUeArQReFJuJtw6c9SulD6cENmqVEN7UgGkUongWOMbKo63H0bsZfmxA5DRiSuwxVEzkXl8S8y1FbCzz130K7l9Yb31sCpfJLhBPqJiaSO54gqhLW4e4sVFaEXpmxvRMDJ7XIQDCL37WwwA61dnPKwBLMuYXkNdv98WleSi/iLw1riA/CWm8z+ZsIpJ4pIFNjOhJUNoE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 478b849a-54ba-4bf2-d095-08d8066ab633 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 20:31:06.4615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iIMh7z5triAH733ACS1ZBcjaML3pzs9EVjHtTg/5tm7Z1re/EMgX8XyjFlTY9B2o4Hu5IIsiG+5xD5V/GgWwzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3281 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591043474; bh=81kIIeX/RmBxhSqMY5ph8b7xsNDada86D/CS9hLcJ6s=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-forefront-prvs: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=Zo9ZgUEuPxNpoP9WvT+k++n4eWNYYvhXD5BJ7koSN3qA3onlClvB9SnJFBx8t4E3c mqP/QhuN5HbcjuktNJ0LFqfCxXCGZU3HK2gfd714wRnV6LzKTs+ffNXHjhZX7S0z1L slmbTKTNgmGm4+0WkeQ8IvbwTRhbe66yfh0fwyg8kTSu0jOKEPlMli+D4R8atmAX17 YRiBWt4EeX62sDz1ukwrndQi//Sw7U7l1swur0deQKA1Sy+0QZUijD4zo+WujYH5w+ iOXl8Xkc4ZdmrFjMksreYmhBn9tF9ND5kOQjvgvlPipXAsXULOWMyD5rEDQnoR6p2+ 5z/LnzaWNR86Q== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob, Would you please review this patch again? Thank you, Irene -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Monday, June 1, 2020 4:28 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error = occurred External email: Use caution opening links or attachments From: Irene Park AutoGen manager/workers halt the progress when an error occurs but doesn't= propagate the error code to main and makes main sys.exit(0) and gets the b= uild system unable to catch the occurrence of an error. This change informs main with an error when a progress is halted and helps= main sys.exit(1). Signed-off-by: Irene Park --- BaseTools/Source/Python/build/build.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyt= hon/build/build.py index ed3a3b9..1ab1e60 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -880,7 +880,10 @@ class Build(): self.AutoGenMgr.join() rt =3D self.AutoGenMgr.Status - return rt, 0 + err =3D 0 + if not rt: + err =3D UNKNOWN_ERROR + return rt, err except FatalError as e: return False, e.args[0] except: @@ -2724,4 +2727,3 @@ if __name__ =3D=3D '__main__': ## 0-127 is a safe return range, and 1 is a standard default error if r < 0 or r > 127: r =3D 1 sys.exit(r) - -- 2.7.4