From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mx.groups.io with SMTP id smtpd.web10.4761.1591725642982678064 for ; Tue, 09 Jun 2020 11:00:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=I770SCtW; spf=pass (domain: nvidia.com, ip: 216.228.121.65, mailfrom: ipark@nvidia.com) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 09 Jun 2020 11:00:29 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 09 Jun 2020 11:00:42 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 09 Jun 2020 11:00:42 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 9 Jun 2020 18:00:42 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 9 Jun 2020 18:00:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j+PXOHbfdvQj1oq+zfuupC+2rMOA2NrOZcFn4KyLJgaDuIB7at99RIM8JDvrNEJ/rixAu4w39noR8uBLjIq2s9o7GwVnzfL9Pn1h9Z3mQcmFc6h0/7cYLnVqVnOMw1krfalrYsZ1tXYS9JSMRqV3yOxBmAyXoY6h1/k8AuiGxqO29T5xfDpliPxOnCCtYhRBPajYcd+yYX++k16DjNVZNa71KfVjs4Hc2YtBwgXnYMwnekgv0oft+0Rwusine94BNFGn9RTNJnJVbVqwb692Te1fIXaP/GWmr13TnVdFIR9ugFHx71xsMC+0cMBvsrRyRGctGKYLrKOqmtclGY7jfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3scG6AGElFUY2///+F2S3/lM+Is0NRsGzUf/YsfYMHM=; b=cahlMY2zKbtIxDKpw0TBGOGAFS03WJa6SqAVbpck6TocN7zZX57bgZvmIPTP0BN7loh812XUqLoShPrNAWMoFJreB5n4Xdky+Ouo1irodUPe2z7QbhSMSOUUabHKEgqmUHxIFY3eQ1HfFarCuZSMubNGrck3MZc7JpXZ2cLeJST5HWO8KIztfAoQTrcahDjRpi011Gcam/1rbucZ5xpFy8+2C0qL8HlUJc9YqD4XRA35eSfr+FCbSH164WxDE2xg5Qj/k+w11dPBLSaLBECx0S8z3yqDhvqs0nDxA2tLpeKMGaoIMh1rV0eMicPJNhccR58wG8OeCaI6TsK2bw/I/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN8PR12MB3202.namprd12.prod.outlook.com (2603:10b6:408:9c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Tue, 9 Jun 2020 18:00:40 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 18:00:40 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" Subject: Re: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero Thread-Topic: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero Thread-Index: AQHWPofihRuN9EI8e061AizXQM7Qyw== Date: Tue, 9 Jun 2020 18:00:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-06-09T18:00:38.6890545Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=80f06d79-3e8e-4bd0-9949-95e662a1197e; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [12.22.141.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08fe7fdf-34b6-4e10-644a-08d80c9f0596 x-ms-traffictypediagnostic: BN8PR12MB3202: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Ajlo1aohFHQvYF+MJ4kWGy/qZC0uxnwTbMr60R3dwVGY+90BAbQ/O0QmWWsBYIDTxgdNzHEM4iM5RxICj+yj02FVWY1kwUZnz/BsMn+cqYlwfbVRZKZ02Y97rJknhzOSPlvAi/T4JEvZyf5k9UWjo8sYFXuTqoczdK+xfQbf7M/ZjS67x9sjTckRp7nvd6LkAfslqarKrModErAZCo7Oyo0Z/e7a1EmaK7cD0Lm/SprgFbXbdk8bm2Kw393tErUE1lJplwj1YcAnfD0srtXXZgQ4OskXYU0WQY4FudG9x3PnBUlGGOdjb4AuLZycs3bK7qqqqcsEiSrRiikDLO1rQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(346002)(376002)(366004)(136003)(396003)(39860400002)(71200400001)(66946007)(33656002)(76116006)(19627235002)(316002)(5660300002)(66446008)(66476007)(66556008)(64756008)(52536014)(53546011)(86362001)(7696005)(478600001)(55016002)(2906002)(8676002)(186003)(83380400001)(8936002)(110136005)(9686003)(6506007)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: spa9DBxh47ny9X+pXg7FsJYF5Td4xscPum6ZAnsf9Bhl0hZASAlE44X+9dakjkKSuoV32y51cbCJXmZ72qC3fgmQzd/e6c3jarOXNrqs8G6Pxu2g0lSqtMn1ykreqK3T4TiLvUjhWZtvf9rrdGa17XvOzCAYw6xo3J7ocm7K6GztmiUDj/Uw6rja0ZDVXTiaRatZ1j0v+T9Bd/of1jg4abjNoEbMIMhNWrKHqkksPnUy1CIF2ogH2fhd1m5AsB6sk7/taLdKjv0/x3MhNVbkjT2t3y/6aH3PcoarQuuIQW1HWQMoa3Bm4cvvdzRVqYsFcZkl22lUWBlpfVsmKrVANWuOixrQoNmwlaqwhFim25IuB8ploV6MXp82MwbaACmTSAn8lAgzevCwUjBJ4l1IB0gAeoAPZVOv9QdQd4BdSpMUFMexAKuTjqmXMHi4DlNNBuzplh0JCiV2Wn0LKRuLi66gzCT21TfUDuPhWVciiWQ= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 08fe7fdf-34b6-4e10-644a-08d80c9f0596 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 18:00:40.3532 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eI2QhHRzROlP46fB49ir8W5JtkI1kDd2DqARgRGbzDWOKDlayG9rKYPJx0mCHVG8yfT5BoKF59rLGA/CovoZvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3202 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1591725629; bh=3scG6AGElFUY2///+F2S3/lM+Is0NRsGzUf/YsfYMHM=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=I770SCtWjos+l21K23o0KDRPam8n2/gp8kNfwjtVOpSlcESTTn9s+oTLdNwADPJ9y GT8dUKticV3DfY2W/TIBVHgEvcQAwjJh42yxXPOOpFHD8cy2Y2Bdi4QpzwpooZ/2Xj 3oQ6vyg9RTnmBpgOtBD5iGETuMoPm7JECAxKAaj7639EiUGGBRaXiOvQNzKSXpkT5h eE+sptO6sl0gNyhxDsIMjSiKmQrp8ExIR/Z3KlC/wMsuJWfFf35z+YycOieqXu8e+s 9pEvSI1s6Dlg8j0T8b2SDco4BBqFqWZXFBxDmNNzjrmWxWoBS0w0rEgGDwsWzqfzwq TYaO6YermFkeg== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, Would you please review this patch v2? Thank you, Irene -----Original Message----- From: Irene Park =20 Sent: Tuesday, June 9, 2020 1:59 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is= zero From: Irene Park PL011UartLib determines its FIFO depth based on the PID2 value but the regi= ster PID2 is not mandatory as per the SBSA spec. This change won't check PID2 if PcdUartDefaultReceiveFifoDepth is set to a = value > 0. Signed-off-by: Irene Park --- ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 4 ++++ ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf | 1 + 2 files changed, 5 insertions(+) diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c b/ArmPlatfo= rmPkg/Library/PL011UartLib/PL011UartLib.c index 801990d..05ad1ad 100644 --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c @@ -79,9 +79,13 @@ PL011UartInitializePort ( UINT32 Fractional; UINT32 HardwareFifoDepth; =20 + HardwareFifoDepth =3D FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth);=20 +#if FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) =3D=3D 0 HardwareFifoDepth =3D (PL011_UARTPID2_VER (MmioRead32 (UartBase + UARTPI= D2)) \ > PL011_VER_R1P4) \ ? 32 : 16 ; +#endif + // The PL011 supports a buffer of 1, 16 or 32 chars. Therefore we can ac= cept // 1 char buffer as the minimum FIFO size. Because everything can be rou= nded // down, there is no maximum FIFO size. diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf b/ArmPlat= formPkg/Library/PL011UartLib/PL011UartLib.inf index d99e89f..e3da507 100644 --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf @@ -30,6 +30,7 @@ ArmPlatformPkg/ArmPlatformPkg.dec =20 [FixedPcd] + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate =20 gArmPlatformTokenSpaceGuid.PL011UartInteger -- 2.7.4