From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web12.4451.1593063711319196821 for ; Wed, 24 Jun 2020 22:41:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=rXDwWWBh; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ipark@nvidia.com) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 25 Jun 2020 13:41:48 +0800 Received: from HKMAIL103.nvidia.com ([10.18.16.12]) by hkpgpgate101.nvidia.com (PGP Universal service); Wed, 24 Jun 2020 22:41:48 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Wed, 24 Jun 2020 22:41:48 -0700 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 25 Jun 2020 05:41:43 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 25 Jun 2020 05:41:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vde4rLKii4rTt8FENcfvPKBhoXGUu+/a3NUJ91/bFHRO3yqc8P4inFTdjhDMB1krvBaQtIZ7Hc+BQ5IY1KJ6pAgRYYQVXI5J33HIR8dL2q94sEcnpn2qPuJwBzXvnNv3QZyTBRcqF+KAFbkzEfyuYSq1VYAAwmwZ1mdzdWkpNOz8FpDG2dAP9gwAFGZ3twbnphEpSbrdA30b7pZlgZSdwiGjcs1/cMlUoo4FFbQ5a5drh4gwO3Jdn0cerXha7jObNCfKO91ldTxnQNt+0HKvL6xoJY0oHOtvyzx5TMC5bXLy4pZQF/RJOay+vYmkGEasRGv74p7cjSsVsyFd7hG8uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jIkommLRkA+oxFOhLuWWHryF3LWFHX1i7BAEoZh2ris=; b=gTwK/KRusixorhcrUJy5RU9+2QEzaxIxcKhLc2kr/FKe6d4gTLQjUkumZrXWy+WtNUvFmo8Fe5XNEWqqNbBhMhjlVgGEBnotsWQMiUQP1rgRdO3CT4UKE9UgZHxVG6aWf6kjuUNxD8WMnGKFvfd+iQyHhHhGdPrBY7OXEpPH/lzbJInuwwZvihjw9HZSCZoyHzL3999sQTaGHGxGPpIJZD5q80CjUJxEVtcMTt3knAERJ2/BrH1phvR1U1URFBTmLWkqMZKjfyOls/YSLlTlqXJzwgam/rrDq9YDm0jlZ4DyUK8RWgvVPTdDFiDmvdXhJ33qBYGCkdSy9Nau0KWs/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN8PR12MB3458.namprd12.prod.outlook.com (2603:10b6:408:44::32) by BN6PR12MB1826.namprd12.prod.outlook.com (2603:10b6:404:106::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Thu, 25 Jun 2020 05:41:41 +0000 Received: from BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec]) by BN8PR12MB3458.namprd12.prod.outlook.com ([fe80::3489:4bde:b7b9:3aec%7]) with mapi id 15.20.3131.021; Thu, 25 Jun 2020 05:41:40 +0000 From: "Irene Park" To: "devel@edk2.groups.io" , Ard Biesheuvel CC: Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero Thread-Topic: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero Thread-Index: AQHWSNHD2r2jRm628ECbYabK/HzdqKjlHsGAgAO1+UA= Date: Thu, 25 Jun 2020 05:41:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-06-22T20:14:39.1314960Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=192ae5ab-a83e-4663-94d7-10711a9bba9d; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [173.95.172.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c1a125a-446c-475c-df52-08d818ca6fba x-ms-traffictypediagnostic: BN6PR12MB1826: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0445A82F82 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +acVS26lpmT22Hb29KyoN4k/4Ir+gjt5MLpqJfLoGYcrjeE7dRB/PseZsc2ZuCkqpUHsyO9sd7hRKsbzt+MToY61blIubIFM5fP+fYjm2ozTQsVXF27zaoDlZjP+Z1/hT2QauUxWROCrx7aALhrP0w63L4sfOxVBE5ZXcWUIMsGkvLfQki0Nb4kjgv3zifEsAb3WNJX2uiNnflrzMrkYEvQe3xGaUKIQEnu2zGu4LrcN2g8ijmKGNAjelrCwP3EyFvyttRfSky2YlNGul4Fula4LBNZ5w6z+jADWbZktMjLNyEzrD3SDfL5l6+bELBtBSPIN6SjQCd2vAq8cvVgoMe4h7/3R3ZnZVEAZa7nUPwto10sbCQShnRuq8X8jaE8hgUjy+ybsQnngs3DraybMEA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(366004)(346002)(396003)(376002)(39860400002)(136003)(66556008)(64756008)(66476007)(110136005)(2906002)(4326008)(33656002)(86362001)(186003)(52536014)(19627235002)(83380400001)(66946007)(76116006)(55016002)(316002)(71200400001)(966005)(478600001)(7696005)(66446008)(5660300002)(9686003)(53546011)(6506007)(26005)(8936002)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: rzZp6myVJoGViGxIDvEUE7cfc81H3HEfudw13pFcdAHTAiwL37qQQl83Ocuzs8DElgh6BaHTakZWYJoDDTbdpazvT0xGJW0icTitkFcmKYkMZo8HmLYeoWd/L3yQIOlyb62yYJRXRQ5V9P0ETRelfZgZl3xd9AJo91CkT3uyPCpySTuTBJmMx8eUkcqNzs6Q6YCMqQ+nVn2nyYf53NfcNHXRdzORIZywlr3uxKmHK4db/nEZ1+j058M+CJ0cwM68xloU1mKOYcSzV7xqeFW1qRXghJlBKOMOixIO/pSmceNIAjz9SuKNSISNAqt4RCQQpY1VCnMox4rMOM2BziHNuagDI0MxsxkpTcCpYar4ZmRjMNBlBGsAZgSNkFZurpdExoVt03LdOgsr25fBcJP129ZsLaMx/1IEebj1F9JHUAQqb5cv6X1sWqw/F+3C3k0JPoHoHFzcdzpfkm9mxvGblbbY8Olo6Ffi07laCj9++Zc= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1a125a-446c-475c-df52-08d818ca6fba X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2020 05:41:40.8654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ALkgiGQZrt6SwCcruQRESTjE5rhaflX0D0gbZXupzsI6DSbt/Y5HfKt8vmEVydzhF4xbcrbTy/i7TqtwtCmrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1826 Return-Path: ipark@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1593063708; bh=jIkommLRkA+oxFOhLuWWHryF3LWFHX1i7BAEoZh2ris=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=rXDwWWBhxm/LUJbyiO4up5Fc3MZXbyDG4DdI2yiWr4JPjIEEOGVyzJrRi0ihbzmJx SwleuNVEnMtwZ5mMO+wucYzaBSc1mmfSDqFq5/gMJgu8OHmhzkpz9rr8iPpV0cRQqT jmujiuF8xdkNxC/0jRU3NNtdzUj5gHRGzW8kv3wXaEj4aGnHukjlPqbXEbBlq4XbWg sRCewMoxE3MufnoOjfLhsGw7ew6vpQ0x/Qhs9ATR9/DCZeN5GyZyU6C3cMA1/LJmn+ HJEsXE6ejsc31xD56X6blGPBgzLVEMTcZC2BGuayceR9jjGisbllq8VldCcH+/09oT p9SghYZSR8PvQ== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Ard, Would you please kindly review this change? Thank you, Irene -----Original Message----- From: Samer El-Haj-Mahmoud =20 Sent: Monday, June 22, 2020 5:01 PM To: devel@edk2.groups.io; Irene Park ; Ard Biesheuvel Subject: RE: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PI= D2 if FiFoDepth is zero External email: Use caution opening links or attachments Adding Ard's new Arm e-mail address, and removing the old Linaro e-mail. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene=20 > Park via groups.io > Sent: Monday, June 22, 2020 4:15 PM > To: devel@edk2.groups.io; ard.biesheuvel@linaro.org > Subject: Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib:=20 > Check > PID2 if FiFoDepth is zero > > Hi Ard, > Would you please review this change ? > I also wonder what you think of the following. > > #if FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) =3D=3D 0 VS if > (FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) =3D=3D 0) or if=20 > (HardwareFifoDepth =3D=3D 0) > > Thank you, > Irene > > -----Original Message----- > From: Irene Park > Sent: Tuesday, June 9, 2020 1:59 PM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if=20 > FiFoDepth is zero > > From: Irene Park > > PL011UartLib determines its FIFO depth based on the PID2 value but the= =20 > register PID2 is not mandatory as per the SBSA spec. > This change won't check PID2 if PcdUartDefaultReceiveFifoDepth is set=20 > to a value > 0. > > Signed-off-by: Irene Park > --- > ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 4 ++++ > ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > index 801990d..05ad1ad 100644 > --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > @@ -79,9 +79,13 @@ PL011UartInitializePort ( > UINT32 Fractional; > UINT32 HardwareFifoDepth; > > + HardwareFifoDepth =3D FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth);= = =20 > +#if FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) =3D=3D 0 > HardwareFifoDepth =3D (PL011_UARTPID2_VER (MmioRead32 (UartBase + > UARTPID2)) \ > > PL011_VER_R1P4) \ > ? 32 : 16 ; > +#endif > + > // The PL011 supports a buffer of 1, 16 or 32 chars. Therefore we=20 > can accept > // 1 char buffer as the minimum FIFO size. Because everything can=20 > be rounded > // down, there is no maximum FIFO size. > diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > index d99e89f..e3da507 100644 > --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > @@ -30,6 +30,7 @@ > ArmPlatformPkg/ArmPlatformPkg.dec > > [FixedPcd] > + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate > > gArmPlatformTokenSpaceGuid.PL011UartInteger > -- > 2.7.4 > > >=20 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.