Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

["Gao, Zhichao" <zhichao.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 8546 bytes --]

Yes. The INF file is required. Before we don’t have script to build it, we keep using the one from ShellBinPkg. I think we can add the two INF file generation to the release generation script.
Here is the content of UefiShell.inf
##  @file
#  This is the UEFI Shell application binary file.
#
#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
#
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
##

[Defines]
  INF_VERSION                    = 0x00010006
  BASE_NAME                      = Shell
  FILE_GUID                      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1
  MODULE_TYPE                    = UEFI_APPLICATION
  VERSION_STRING                 = 1.0

[Binaries.Ia32]
  PE32|Ia32/Shell.efi|*

[Binaries.X64]
  PE32|X64/Shell.efi|*

[Binaries.Arm]
  PE32|Arm/Shell.efi|*

[Binaries.AArch64]
  PE32|AArch64/Shell.efi|*
MinUefiShell.inf
##  @file
#  This is the UEFI Shell application binary file.
#
#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
#
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
##

[Defines]
  INF_VERSION                    = 0x00010006
  BASE_NAME                      = Shell
  FILE_GUID                      = 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1
  MODULE_TYPE                    = UEFI_APPLICATION
  VERSION_STRING                 = 1.0

[Binaries.Ia32]
  PE32|Ia32/Shell.efi|*

[Binaries.X64]
  PE32|X64/Shell.efi|*

[Binaries.Arm]
  PE32|Arm/Shell.efi|*

[Binaries.AArch64]
  PE32|AArch64/Shell.efi|*
==== End ====

For the extended shell, we can make a binary release. But that is not required, because the extended command is not record in the shell spec. The behavior is not documented. That means there is no expected result. But if there are benefits to release them, we should release them.

Thanks,
Zhichao

From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Monday, December 6, 2021 1:30 PM
To: Gao, Zhichao <zhichao.gao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; rebecca@bsdio.com; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Teng, Lynn L <lynn.l.teng@intel.com>; afish@apple.com; leif@nuviainc.com
Subject: RE: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

The previous release also provide an “As Built” INF file to allow the shell to be easily integrated into platform DSC files.

Do you think this is required?  How was that generated?

The ShellPkg also contains a number of command extensions.  Should those be build and included in a binary release?

Thanks,

Mike

From: Gao, Zhichao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
Sent: Sunday, December 5, 2021 9:16 PM
To: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; rebecca@bsdio.com<mailto:rebecca@bsdio.com>
Cc: Teng, Lynn L <lynn.l.teng@intel.com<mailto:lynn.l.teng@intel.com>>; afish@apple.com<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Subject: RE: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

To generate Full Shell, execute:
  "build -a IA32 -a X64 -p ShellPkg\ShellPkg.dsc -b RELEASE"
To generate Minimal Shell, execute:
  "build -a IA32 -a X64 -p ShellPkg\ShellPkg.dsc -b RELEASE -D NO_SHELL_PROFILES"

The binary with name “Shell_7C04A583-9E3E-4f1c-AD65-E05268D0B4D1.efi" Is the one for ShellBinPkg release.

Thanks,
Zhichao

From: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Sent: Friday, December 3, 2021 10:08 AM
To: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; rebecca@bsdio.com<mailto:rebecca@bsdio.com>; Gao, Zhichao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
Cc: Teng, Lynn L <lynn.l.teng@intel.com<mailto:lynn.l.teng@intel.com>>; afish@apple.com<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Subject: 回复: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Mike:
 Previously, ShellPkg maintainer Zhichao Gao helps to generate the binary ShellPkg.

Zhichao:
 Can you give the build step to generate the binary ShellPkg with Shell and MinShell?

Thanks
Liming
发件人: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
发送时间: 2021年12月1日 11:16
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>; rebecca@bsdio.com<mailto:rebecca@bsdio.com>; Gao, Zhichao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
抄送: Teng, Lynn L <lynn.l.teng@intel.com<mailto:lynn.l.teng@intel.com>>; afish@apple.com<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
主题: RE: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Hi Liming,

I agree it would be better to have a CI agent create this shell ZIP file.

What was the process used to create the previous ZIP files?  When I do a shell build I see some different named files.  MinShell is very small.  What flags were used.  There are also some shell commands in the shell package.  Should we add those to the ZIP file?

If you give me the recipe, I can work on a CI task.  We can also add RISCV64 if that is of interest as well.

Thanks,

Mike

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of gaoliming
Sent: Thursday, November 11, 2021 5:02 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; rebecca@bsdio.com<mailto:rebecca@bsdio.com>; Gao, Zhichao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Teng, Lynn L <lynn.l.teng@intel.com<mailto:lynn.l.teng@intel.com>>; afish@apple.com<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Subject: 回复: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Rebecca:
 Thanks for your reminder. Now, we have open CI. I think we can create the binary ShellPkg based on CI build result.

Mike:
 Can open CI upload the generated EFI image as the artifacts? If so, the binary ShellPkg can be created from CI build result.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Rebecca Cran
发送时间: 2021年11月12日 7:44
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>
抄送: 'Kinney, Michael D' <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Teng, Lynn L' <lynn.l.teng@intel.com<mailto:lynn.l.teng@intel.com>>; afish@apple.com<mailto:afish@apple.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>
主题: Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111


Do we have a task or reminder to generate the UEFI Shell binaries for this release, and to upload ShellBinPkg.zip to Github?

https://bugzilla.tianocore.org/show_bug.cgi?id=3178 was opened but apparently never resolved, and the latest ShellBinPkg.zip is still from the edk2-stable202002 release.



--
Rebecca Cran


On 11/4/21 11:53 PM, gaoliming wrote:
Hi, all
We will enter into Soft Feature Freeze phase on 2021-11-08. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged.

The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable tag, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag, please add edk2-stable202111 key words in the patch title and BZ, so the community know this patch target and give the feedback.

Below is edk2-stable202111 tag planning https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning Proposed Schedule
Date (00:00:00 UTC-8) Description
2021-08-30  Beginning of development
2021-11-08  Soft Feature Freeze
2021-11-12  Hard Feature Freeze
2021-11-26  Release

Thanks
Liming



[-- Attachment #2: Type: text/html, Size: 29977 bytes --]