From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B4E1C7803D9 for ; Thu, 9 Nov 2023 11:44:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GnHOflOmO7pXq368I7M4Ow5yb4EtcdosEOybFCSJKeU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699530281; v=1; b=PYtOtmm4xq5FLwN+NIQSU0g5nipWR3wZrj1Na4VijPBDQZQlntUtarsQNklx6KVunTJxqg/q ivfFfLgo63g7++kRv9ai2yhmKLI172yoVdiNMV7Qd0vT2hY4fxYHCmn8+3vJx1by71ieo/jBZW6 mbJXPsLtFFzUxn7WzblWNqsQ= X-Received: by 127.0.0.2 with SMTP id nQHlYY7687511x5HQb15xdmE; Thu, 09 Nov 2023 03:44:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.119699.1699530280226311251 for ; Thu, 09 Nov 2023 03:44:40 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="380360952" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="380360952" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 03:44:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="792512492" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="792512492" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 03:44:39 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 03:44:38 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 03:44:38 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 03:44:38 -0800 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 03:44:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iWW2p4LgsgZiLFMHEWXGOZV4zY0x8JMwWxAYAUBRO/ZsDd/kgZzx5uPEEM/x70FlCCXG8uDXrWmxXQWlZkgjcA9KQIjSMjyF+yyjlP1hFfGXmx8kfsOjhBknR90RJlMjAkEl0VTKK8nbzSncPIZlFOP3tZNfvZ25BDS/twfEo+LpKHdCxgsUaudcpK50w6tX5ythtT7DFZYGCaYQH1mOWKB9+Nz2b2esz2DHbVWsEnBcTEY2h1xRWiOtj+kiaWwuTnerQw0azSolQ5qfdPU/QhKptE1Qkf9Cl2B7VtXyCDnztnaoXDYSJztOrmr9LkBZpkl4vs8F16X6b1pwP1ExQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ee9ZKd45GCmWin82EuQLYRvotKGF22mXlC4dz4mzUuc=; b=F87oRhfLhoThCOfrX3J5z+tJnJBxJhZl4OYF7IbMDiLbRdLcyWDJ85VR/z9fclQ8I77Ol4uw+y8xjnem8XyDpp78Cui7BOepqSvotRZfp51cbPrJYshbelg3nIOrnUwVl5ovhlRTOiUlV547BKiLtuoUsUb5wa7se52Tlo9fxN9zIwZHjDDztRUFqtKcjSfjltCsk+SDx9k+es3ZODD3wuFfo3+CfFNVFrwR3yyYESs2R3hnltmKusE6TgGvStTOMAUW1op6NAE91Wp12MDyszNKeac0LBzJfw7GqV5dUjHRWpNnIMuTm7uLeCNfaaGSc89uK4Zu7EMJK4M/Ih2ffw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5275.namprd11.prod.outlook.com (2603:10b6:408:134::24) by DM4PR11MB5246.namprd11.prod.outlook.com (2603:10b6:5:389::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Thu, 9 Nov 2023 11:44:31 +0000 X-Received: from BN9PR11MB5275.namprd11.prod.outlook.com ([fe80::c112:9cb2:ff33:b512]) by BN9PR11MB5275.namprd11.prod.outlook.com ([fe80::c112:9cb2:ff33:b512%3]) with mapi id 15.20.6954.029; Thu, 9 Nov 2023 11:44:31 +0000 From: "Ashraf Ali S" To: "Chen, Gang C" , "Guo, Gua" , "Hsu, JasonX" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Chiu, Chasel" , "Duggapu, Chinni B" , "Kuo, Ted" , "Mohapatra, Susovan" , "Lu, James" Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization Thread-Topic: [PATCH] IntelFsp2WrapperPkg: Add variable initialization Thread-Index: AQHaEvOuFEvkBMwwtUqRmn87yvFSzrBxwxuAgAABdQCAABmPgA== Date: Thu, 9 Nov 2023 11:44:31 +0000 Message-ID: References: <45e974f7a6fdb497e243b8c61ea50b60e63bb501.1699523871.git.jasonx.hsu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5275:EE_|DM4PR11MB5246:EE_ x-ms-office365-filtering-correlation-id: 6aeb1573-ded9-4954-0df1-08dbe1193ca5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: NO7mVE1g50wTGVPiIo0tzyDBZgoT1nqtR9gMdYk8FaPkRP4pRwT8JqhRvbo8yG2sjO3IaU+kIf17AdZ0H5XrGJzoEtykf830g7KA876M2c6gApp16uKIHv8OIYkZaVcYj2F3Td4hXO7T5C5ISqpJi+vY+8eMpYTXl4+tl7ifqv2NQU4WzswUiMz6a4wSotv2su2Pl9FfY34jqWbHepq44yqzHTNNVKuk4flIRl80HaSE2Y646oKWRPF4/rSo7jow5Q2vamXzZY+SHencuMkFWxIUYADhgd31pZjvQQDclHTkuIifqGJkui0K+7Hi+wPdOWII7k/40oBWa/h0w+W2Zuafhj5WX/o6edc/71AHFo0vzh+/9N3sd1RUdRh2Kn874gn5PsxVExFj1CkIVdEeKfw9Pb9+5ZJI1YNfPCZ91tnwIkNBEikVs0XRRCMW9Kgj5DegXFW6pJaPl4Sp66hsxN5UKrcVJfWh4Npgg4CwYTi+t0kxBH4sHWC4iVXmAuN22BTMGKPXhGF564whk52j5cPSodvEQiRDMCrzJmse5kYUsk6IfFQkhrztEvd1gTrJqqfYcYpVnCptgizGR9ayJ5xCPUhnEG97oUsW+iX0zVM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FBzag6u6lvvB4mo+HM4ZXh5KRcjGJM8JFx6ikLj3qV1cIVH4TdvIUgDVXUtL?= =?us-ascii?Q?j+5fn2OZzdFQLFk2eCsIpvt0Z8q8KeXG/iERt7xKtlbA9LwG/yddOdDN7rci?= =?us-ascii?Q?Bb1JNanA5tkFknC/NyPHzK5gsIJxa3y1pB9Gi/tPR1f6+uOzwh/cdYMnn4GQ?= =?us-ascii?Q?e+HkndePSq8WQLF7vlBZhRhey5HIL/e+m5HDMSLda6yVJcZM1fPp63Xiy+4K?= =?us-ascii?Q?vUhTSb/hCIaeLy4JGwkwLe+bauF5JOsvFOxbUMDIrd0SikFofqGnNz93dtbO?= =?us-ascii?Q?fID7LQjrMrLmtozceNyK1h2XbhltThaLdKuhwY0Qs0suFQyfAGUBq3LGDU6x?= =?us-ascii?Q?/WqExmWZx37i6QdXvtVdaBIk0Q3xD1abcqzIVDiX2nsKebZBMOqfBgdtQbA/?= =?us-ascii?Q?hajcR2CU4DYOxRFepff7SX4EV/CqzEVUT99geMakPZMQqBXqWeSTI6MUdysg?= =?us-ascii?Q?WiRb6H+8qeqpgRIXk2Hir8FJuxblEMxMwo7lMlh3nTvnpP4PMSj79tAIEF4h?= =?us-ascii?Q?c3JPdNE09aV6aCRFkYtjZPd9FbkubX29OJQ7nOsfUqOcAEy2VERgRPDuf7Ls?= =?us-ascii?Q?+c3TSJuMaG4Lg1KREb5SxQeiYZt8rxy9wWezOiooFTyvZmcJhswpKpOxnfe3?= =?us-ascii?Q?iv5OX4qwhEqnFySEd+mTlQOGylazw52J7b3x7/XmIB/MQzcbJaKevj49YpV8?= =?us-ascii?Q?hO6wMr4Qy363Tp7k9wZoKVt0gGLmKlr3EgGgzdAJe3Ni8VfX6WS9E0eMHSKp?= =?us-ascii?Q?WG8W7Pfke3oPSCRxVPHtcJz6uuGjfkxmWbT0arsasq1T6NGl2veF3ApZ4NwM?= =?us-ascii?Q?p4Lw/s3SXIbIuumARHjyjmJoB1YChCNWtW0ksM3v3sSrvzi6hsR2zbBFrYGg?= =?us-ascii?Q?27ykgEAEotEdVv+qa2kUv907C2E84ONPY9iH2j45qsh04KmEPIHnSbxMIhGD?= =?us-ascii?Q?owtG1fi4di1GY5UVI0Ipsqc2C/KmDQlksR9gpqIY1Nni94SQP6WKjCKXUra4?= =?us-ascii?Q?SdkXjBIKE+PV/67g5L0RBNknXrvBNcZvzHnR+zuEnAErabq/sIlm/LUvQBbY?= =?us-ascii?Q?OhF+qu1Mxd5AKnHnTOLgS8zxel0HtWGG8QuZuVqA9oonxPKw4Tlb7nkhpO7E?= =?us-ascii?Q?pBDkN/jEplEa8vhhSm07Wqx4BoRvgUYP6NonNCbhAiNuuQJ2+fG3obxi/BlV?= =?us-ascii?Q?uc86WcrdEE4EHQvKIXlwuG3SFS+ZbCFRsiJBNuXlgJof/Q1jnDxH0Xe2tj7u?= =?us-ascii?Q?jEHTgDPRZAmx62oqP16ftrMGMW9OVW553UBNdR+h2U3NUp4Eo06dFjDrISL2?= =?us-ascii?Q?49iZE6PUgCG/TO1IrEtggN4JrP0H/tCOvnP2TNdDzb6ZXcnSWFGywhkRhccN?= =?us-ascii?Q?8NyakImCTGYF9aC82eQDIXPUfvnzpxisNHrC6Yyi0WuCet7S1iGjfaWBkUId?= =?us-ascii?Q?83ODE3w4uGEHG27c46n20fxO2nxSiwKsFNT6dK8EYGoH6Y235XFEEMoT6FI1?= =?us-ascii?Q?7zaGZE92HzPtMZtAK9GhRBylqaWCHfeCB+2wgzcnudU7a2UnmkU/Q5ug7OxU?= =?us-ascii?Q?7U5ZRC4BLLAQ/2lIQoR678HRAxHwcghB3lb+wQVK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5275.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aeb1573-ded9-4954-0df1-08dbe1193ca5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 11:44:31.0665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IPCh9mGlVoQ3iaNluoqn7/ieN8odw1QFd6m0cl/Du7iJAskD4yEiftZ1tR3FmPAmKEPwjdU8eqML4+TfUFkOvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5246 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8oIXWuepX54wtY1dWZ7z9ywTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PYtOtmm4; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -----Original Message----- From: Chen, Gang C =20 Sent: Thursday, November 9, 2023 3:42 PM To: Guo, Gua ; Hsu, JasonX ; devel= @edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Duggapu, Chinni B = ; Kuo, Ted ; S, Ashraf Ali <= ashraf.ali.s@intel.com>; Mohapatra, Susovan ; = Lu, James Subject: RE: [PATCH] IntelFsp2WrapperPkg: Add variable initialization Reviewed-by: Chen Gang C BR Gang -----Original Message----- From: Guo, Gua =20 Sent: Thursday, November 9, 2023 6:07 PM To: Hsu, JasonX ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Kuo, Te= d ; S, Ashraf Ali ; Mohapatra, S= usovan ; Lu, James Subject: RE: [PATCH] IntelFsp2WrapperPkg: Add variable initialization Reviewed-by: Gua Guo -----Original Message----- From: Hsu, JasonX =20 Sent: Thursday, November 9, 2023 6:01 PM To: devel@edk2.groups.io Cc: Hsu, JasonX ; Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B <= chinni.b.duggapu@intel.com>; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susovan ; L= u, James ; Guo, Gua Subject: [PATCH] IntelFsp2WrapperPkg: Add variable initialization From: "JasonX.Hsu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4595 Fix build error when remove "-Wno-sometimes-uninitialized" option, Add vari= able "FspMultiPhaseApiOffset" initialization. Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Cc: Chen Gang C Cc: Duggapu Chinni B Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Cc: James Lu Cc: Gua Guo Signed-off-by: Jason Hsu --- .../PeiFspWrapperMultiPhaseProcessLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/Pei= FspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMu= ltiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 834dca07a9..224c24881d 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspW +++ rapperMultiPhaseProcessLib.c @@ -80,6 +80,7 @@ CallFspMultiPhaseEntry ( BOOLEAN IsVariableServiceRequest; FSP_MULTI_PHASE_PARA= MS *FspMultiPhaseParamsPtr; + FspMultiPhaseApiOffset =3D 0; FspMultiP= haseParamsPtr =3D (FSP_MULTI_PHASE_PARAMS *)FspMultiPhaseParams; IsVari= ableServiceRequest =3D FALSE; if ((FspMultiPhaseParamsPtr->MultiPhaseActi= on =3D=3D EnumMultiPhaseGetVariableRequestInfo) ||--=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110967): https://edk2.groups.io/g/devel/message/110967 Mute This Topic: https://groups.io/mt/102482693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-